108966 2013-02-05 12:03:41 -0800 [chromium] Remove "config.h" header from WebUnitTests.cpp 2013-02-06 13:37:26 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dcheng dcheng fishd oldest_to_newest 825688 0 dcheng 2013-02-05 12:03:41 -0800 WebUnitTests.cpp is an intentional layering violation and includes some headers from base/ in the Chromium code. "config.h" is largely unneeded (it was used for ASSERT, and attempting to run a null test suite isn't going to get very far anyway) and conflicted with base/logging.h, so it'd be nice to remove it rather than teach certain files not to #include base/logging.h. 825689 1 186671 dcheng 2013-02-05 12:07:12 -0800 Created attachment 186671 Patch 826706 2 186671 tony 2013-02-06 13:24:25 -0800 Comment on attachment 186671 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186671&action=review > Source/WebKit/chromium/tests/WebUnitTests.cpp:33 > #include <base/test/test_suite.h> Please add a FIXME about this include since it's a layering violation. 826717 3 dcheng 2013-02-06 13:37:26 -0800 Committed r142027: <http://trac.webkit.org/changeset/142027> 186671 2013-02-05 12:07:12 -0800 2013-02-06 13:24:24 -0800 Patch bug-108966-20130205120350.patch text/plain 1727 dcheng U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNTk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDBhNDU0MGMyNTMzNzFjMTMzOGNhNjM4OGZiNTVjODAzZDNiZWZhMzIuLmYyZDE1OGFiZmZlZTM5 YjdjZjcyOGRlODY1OGI3M2VmYWNlYWJmMmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTMtMDItMDUgIERhbmllbCBDaGVuZyAgPGRjaGVuZ0Bnb29nbGUu Y29tPgorCisgICAgICAgIFtjaHJvbWl1bV0gUmVtb3ZlICJjb25maWcuaCIgaGVhZGVyIGZyb20g V2ViVW5pdFRlc3RzLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTA4OTY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhpcyBmaWxlIGluY2x1ZGVzIGhlYWRlcnMgZnJvbSBiYXNlLyBpbiBDaHJvbWl1 bSwgYW5kIGNvbmZpZy5oCisgICAgICAgIGNvbmZsaWN0cyB3aXRoIGJhc2UvbG9nZ2luZy5oLiBS YXRoZXIgdGhhbiB0ZWFjaGluZyBjZXJ0YWluIGZpbGVzIGluCisgICAgICAgIGJhc2UvIG5vdCB0 byAjaW5jbHVkZSBiYXNlL2xvZ2dpbmcuaCwgcmVtb3ZlIHRoZSBjb25maWcuaCBpbmNsdWRlCisg ICAgICAgIGhlcmUuIFRoZSBBU1NFUlQgaXNuJ3QgcmVhbGx5IG5lY2Vzc2FyeSwgYXMgYXR0ZW1w dGluZyB0byBydW4gYSBudWxsCisgICAgICAgIHRlc3Qgc3VpdGUgd29uJ3QgZ28gdmVyeSBmYXIg YW55d2F5LgorCisgICAgICAgICogdGVzdHMvV2ViVW5pdFRlc3RzLmNwcDoKKyAgICAgICAgKFdl YktpdDo6UnVuQWxsVW5pdFRlc3RzKToKKwogMjAxMy0wMi0wMSAgU2hlcmlmZiBCb3QgIDx3ZWJr aXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gIFJvbGxlZCBD aHJvbWl1bSBERVBTIHRvIHIxODAxMzEuICBSZXF1ZXN0ZWQgYnkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViVW5pdFRlc3RzLmNwcCBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vdGVzdHMvV2ViVW5pdFRlc3RzLmNwcAppbmRleCA5MmQ5OTBiYjY1NTI1ODNiNTg5 YmNhNGY0MjkxYTMyNzdhNDRjNDFmLi44YzNmNjZhZWYyNjRjMzI4YjEyOWE0NzQxN2YzNWM4OTRi YmNhNGVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYlVuaXRU ZXN0cy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9XZWJVbml0VGVzdHMu Y3BwCkBAIC0yOCw3ICsyOCw2IEBACiAgKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklT RUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICovCiAKLSNpbmNsdWRlICJj b25maWcuaCIKICNpbmNsdWRlICJXZWJVbml0VGVzdHMuaCIKIAogI2luY2x1ZGUgPGJhc2UvdGVz dC90ZXN0X3N1aXRlLmg+CkBAIC00Niw4ICs0NSw2IEBAIHZvaWQgSW5pdFRlc3RTdWl0ZShpbnQg YXJnYywgY2hhcioqIGFyZ3YpCiAKIGludCBSdW5BbGxVbml0VGVzdHMoKQogewotICAgIEFTU0VS VCh0ZXN0U3VpdGUpOwotCiAgICAgaW50IHJlc3VsdCA9IHRlc3RTdWl0ZS0+UnVuKCk7CiAKICAg ICByZXR1cm4gcmVzdWx0Owo=