108962 2013-02-05 11:21:29 -0800 Add null check to editable in moveCaretSelectionTowardsWindowPoint 2013-02-07 04:19:52 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dtrainor webkit-unassigned cjhopman eric esprehn lforschler webkit.review.bot oldest_to_newest 825662 0 dtrainor 2013-02-05 11:21:29 -0800 Add null check to editable in moveCaretSelectionTowardsWindowPoint 825663 1 186665 dtrainor 2013-02-05 11:22:20 -0800 Created attachment 186665 Patch 825714 2 186665 buildbot 2013-02-05 12:37:14 -0800 Comment on attachment 186665 Patch Attachment 186665 did not pass win-ews (win): Output: http://queues.webkit.org/results/16366916 825779 3 186665 buildbot 2013-02-05 13:43:39 -0800 Comment on attachment 186665 Patch Attachment 186665 did not pass win-ews (win): Output: http://queues.webkit.org/results/16368837 826840 4 eric 2013-02-06 16:11:05 -0800 The Win-EWS failure seems unrelated: 1>..\cg\ImageDiffCG.cpp(37) : fatal error C1083: Cannot open include file: 'wtf/Platform.h': No such file or directory 826842 5 186665 eric 2013-02-06 16:11:17 -0800 Comment on attachment 186665 Patch Can we test this? 826845 6 dtrainor 2013-02-06 16:15:30 -0800 Good point. I can put in a simple check that tries calling this when there's no selection and just makes sure it doesn't crash. 826914 7 186955 dtrainor 2013-02-06 17:26:47 -0800 Created attachment 186955 Patch 826917 8 esprehn 2013-02-06 17:36:03 -0800 Were there cases where we'd actually do this right now? 826937 9 dtrainor 2013-02-06 17:57:57 -0800 We're seeing this happen because we're trying to clear the selection state then handling a different touch event that moves the caret. We're not getting the actual state change back from webkit fast enough to update the front end before we get the touch event which tries to move the caret. That needs to be fixed there as well but I don't think we should crash here either way. 826944 10 esprehn 2013-02-06 18:03:22 -0800 (In reply to comment #9) > We're seeing this happen because we're trying to clear the selection state then handling a different touch event that moves the caret. We're not getting the actual state change back from webkit fast enough to update the front end before we get the touch event which tries to move the caret. That needs to be fixed there as well but I don't think we should crash here either way. Seems reasonable. 826955 11 186955 eric 2013-02-06 18:13:00 -0800 Comment on attachment 186955 Patch LGTM. 827302 12 186955 webkit.review.bot 2013-02-07 04:19:48 -0800 Comment on attachment 186955 Patch Clearing flags on attachment: 186955 Committed r142093: <http://trac.webkit.org/changeset/142093> 827304 13 webkit.review.bot 2013-02-07 04:19:52 -0800 All reviewed patches have been landed. Closing bug. 186665 2013-02-05 11:22:20 -0800 2013-02-06 17:26:44 -0800 Patch bug-108962-20130205111858.patch text/plain 1599 dtrainor U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNzM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDgxNTRlZTEyOGRkOWY1NTU1YjcyMDc1ZGQ3NTY1NDNiMWRmZmQ3NmMuLjY1YzQ2OGE5NWEwZTFh NzI4Zjk0MmVhZWYyNGUyNjQzYzQ5NmMxNzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTMtMDItMDUgIERhdmlkIFRyYWlub3IgIDxkdHJhaW5vckBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgQWRkIG51bGwgY2hlY2sgdG8gZWRpdGFibGUgaW4gbW92ZUNh cmV0U2VsZWN0aW9uVG93YXJkc1dpbmRvd1BvaW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg5NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJGcmFtZUltcGw6Om1vdmVDYXJldFNlbGVjdGlvblRvd2FyZHNXaW5kb3dQb2lu dCk6CisKIDIwMTMtMDItMDMgIERhdmlkIERvcndpbiAgPGRkb3J3aW5AY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFtjaHJvbWl1bV0gRG8gbm90IGNhbGwgbV93aWRnZXRDbGllbnQtPnNob3coKSBm b3IgV2ViSGVscGVyUGx1Z2luLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViRnJhbWVJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1l SW1wbC5jcHAKaW5kZXggMTE3MDUxZGNhYzk4OWEzMjM0MDg2NzY1MGM2YWZlNGEzODA3N2Q0OC4u NGRlZGYwZTM2ZjgxNjYzMzE5MGYxNWRiZjFjMWMyZGJjMjdjNDc5NyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCkBAIC0xNDEyLDYgKzE0MTIsOSBAQCB2 b2lkIFdlYkZyYW1lSW1wbDo6bW92ZUNhcmV0U2VsZWN0aW9uVG93YXJkc1dpbmRvd1BvaW50KGNv bnN0IFdlYlBvaW50JiBwb2ludCkKICAgICAgICAgdW5zY2FsZWRQb2ludC5zY2FsZSgxIC8gdmll dygpLT5wYWdlU2NhbGVGYWN0b3IoKSwgMSAvIHZpZXcoKS0+cGFnZVNjYWxlRmFjdG9yKCkpOwog CiAgICAgRWxlbWVudCogZWRpdGFibGUgPSBmcmFtZSgpLT5zZWxlY3Rpb24oKS0+cm9vdEVkaXRh YmxlRWxlbWVudCgpOworICAgIGlmICghZWRpdGFibGUpCisgICAgICAgIHJldHVybjsKKwogICAg IEludFBvaW50IGNvbnRlbnRzUG9pbnQgPSBmcmFtZSgpLT52aWV3KCktPndpbmRvd1RvQ29udGVu dHModW5zY2FsZWRQb2ludCk7CiAgICAgTGF5b3V0UG9pbnQgbG9jYWxQb2ludChlZGl0YWJsZS0+ Y29udmVydEZyb21QYWdlKGNvbnRlbnRzUG9pbnQpKTsKICAgICBWaXNpYmxlUG9zaXRpb24gcG9z aXRpb24gPSBlZGl0YWJsZS0+cmVuZGVyZXIoKS0+cG9zaXRpb25Gb3JQb2ludChsb2NhbFBvaW50 KTsK 186955 2013-02-06 17:26:47 -0800 2013-02-07 04:19:48 -0800 Patch bug-108962-20130206172323.patch text/plain 2425 dtrainor U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNzM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDgxNTRlZTEyOGRkOWY1NTU1YjcyMDc1ZGQ3NTY1NDNiMWRmZmQ3NmMuLmNkYzk0ZjFlNzhjOTM4 OGI4NzZmYzdhYzRmMWZiM2E1N2RhNjQyYjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTMtMDItMDYgIERhdmlkIFRyYWlub3IgIDxkdHJhaW5vckBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgQWRkIG51bGwgY2hlY2sgdG8gZWRpdGFibGUgaW4gbW92ZUNh cmV0U2VsZWN0aW9uVG93YXJkc1dpbmRvd1BvaW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg5NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJGcmFtZUltcGw6Om1vdmVDYXJldFNlbGVjdGlvblRvd2FyZHNXaW5kb3dQb2lu dCk6CisgICAgICAgICogdGVzdHMvV2ViRnJhbWVUZXN0LmNwcDoKKwogMjAxMy0wMi0wMyAgRGF2 aWQgRG9yd2luICA8ZGRvcndpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBE byBub3QgY2FsbCBtX3dpZGdldENsaWVudC0+c2hvdygpIGZvciBXZWJIZWxwZXJQbHVnaW4uCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAppbmRleCAxMTcwNTFk Y2FjOTg5YTMyMzQwODY3NjUwYzZhZmU0YTM4MDc3ZDQ4Li40ZGVkZjBlMzZmODE2NjMzMTkwZjE1 ZGJmMWMxYzJkYmMyN2M0Nzk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJGcmFtZUltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZy YW1lSW1wbC5jcHAKQEAgLTE0MTIsNiArMTQxMiw5IEBAIHZvaWQgV2ViRnJhbWVJbXBsOjptb3Zl Q2FyZXRTZWxlY3Rpb25Ub3dhcmRzV2luZG93UG9pbnQoY29uc3QgV2ViUG9pbnQmIHBvaW50KQog ICAgICAgICB1bnNjYWxlZFBvaW50LnNjYWxlKDEgLyB2aWV3KCktPnBhZ2VTY2FsZUZhY3Rvcigp LCAxIC8gdmlldygpLT5wYWdlU2NhbGVGYWN0b3IoKSk7CiAKICAgICBFbGVtZW50KiBlZGl0YWJs ZSA9IGZyYW1lKCktPnNlbGVjdGlvbigpLT5yb290RWRpdGFibGVFbGVtZW50KCk7CisgICAgaWYg KCFlZGl0YWJsZSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgSW50UG9pbnQgY29udGVudHNQb2lu dCA9IGZyYW1lKCktPnZpZXcoKS0+d2luZG93VG9Db250ZW50cyh1bnNjYWxlZFBvaW50KTsKICAg ICBMYXlvdXRQb2ludCBsb2NhbFBvaW50KGVkaXRhYmxlLT5jb252ZXJ0RnJvbVBhZ2UoY29udGVu dHNQb2ludCkpOwogICAgIFZpc2libGVQb3NpdGlvbiBwb3NpdGlvbiA9IGVkaXRhYmxlLT5yZW5k ZXJlcigpLT5wb3NpdGlvbkZvclBvaW50KGxvY2FsUG9pbnQpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS90ZXN0cy9XZWJGcmFtZVRlc3QuY3BwIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS90ZXN0cy9XZWJGcmFtZVRlc3QuY3BwCmluZGV4IGQ3ZThiMGRmOGE2Mzg2YWMzMDcx ZmIxZWI4MDdlZGZkMzdjODVkMjQuLmQxNjMxMDY1MDYxZDdhMzM2OTc1NDVhZWI5Zjc2YmY1ZjUz N2MzMjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViRnJhbWVU ZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYkZyYW1lVGVzdC5j cHAKQEAgLTIwNDMsNCArMjA0MywxMyBAQCBURVNUX0YoV2ViRnJhbWVUZXN0LCBSZXBsYWNlTmF2 aWdhdGlvbkFmdGVySGlzdG9yeU5hdmlnYXRpb24pCiAgICAgRVhQRUNUX1RSVUUod2ViRnJhbWVD bGllbnQuY29tbWl0Q2FsbGVkKCkpOwogfQogCitURVNUX0YoV2ViRnJhbWVUZXN0LCBNb3ZlQ2Fy ZXRTZWxlY3Rpb25Ub3dhcmRzV2luZG93UG9pbnRXaXRoTm9TZWxlY3Rpb24pCit7CisgICAgV2Vi Vmlldyogd2ViVmlldyA9IEZyYW1lVGVzdEhlbHBlcnM6OmNyZWF0ZVdlYlZpZXdBbmRMb2FkKCJh Ym91dDpibGFuayIsIHRydWUpOworICAgIFdlYkZyYW1lKiBmcmFtZSA9IHdlYlZpZXctPm1haW5G cmFtZSgpOworCisgICAgLy8gVGhpcyB0ZXN0IHBhc3NlcyBpZiB0aGlzIGRvZXNuJ3QgY3Jhc2gu CisgICAgZnJhbWUtPm1vdmVDYXJldFNlbGVjdGlvblRvd2FyZHNXaW5kb3dQb2ludChXZWJQb2lu dCgwLCAwKSk7Cit9CisKIH0gLy8gbmFtZXNwYWNlCg==