108919 2013-02-05 00:43:23 -0800 [V8] Remove deprecatedV8String() and deprecatedV8Integer() 2013-02-05 16:30:13 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 825229 0 haraken 2013-02-05 00:43:23 -0800 Now we've removed all call sites. 825230 1 186566 haraken 2013-02-05 00:44:31 -0800 Created attachment 186566 Patch 825231 2 186566 haraken 2013-02-05 00:47:30 -0800 Comment on attachment 186566 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186566&action=review > Source/WebCore/bindings/v8/custom/V8CustomXPathNSResolver.h:45 > class V8CustomXPathNSResolver : public XPathNSResolver { BTW, the implementation of V8CustomXPathNSResolver looks weird. The class exists just for keeping m_resolver. Alternately, we might want to store m_resolver to a ScriptState and pass the ScriptState around WebCore and JSC/V8 bindings. Then we can remove V8CustomXPathNSResolver and JSCustomXPathNSResolver. 825557 3 186566 abarth 2013-02-05 09:33:26 -0800 Comment on attachment 186566 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186566&action=review >> Source/WebCore/bindings/v8/custom/V8CustomXPathNSResolver.h:45 >> class V8CustomXPathNSResolver : public XPathNSResolver { > > BTW, the implementation of V8CustomXPathNSResolver looks weird. The class exists just for keeping m_resolver. Alternately, we might want to store m_resolver to a ScriptState and pass the ScriptState around WebCore and JSC/V8 bindings. Then we can remove V8CustomXPathNSResolver and JSCustomXPathNSResolver. Yes, I suspect that we have more modern tools for handling this case these days. 825904 4 186566 webkit.review.bot 2013-02-05 15:56:35 -0800 Comment on attachment 186566 Patch Rejecting attachment 186566 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: ue>&, const WTF::String&, v8::Handle<v8::Value>&)': ../../Source/WebCore/bindings/v8/IDBBindingUtilities.cpp:143: error: 'deprecatedV8String' was not declared in this scope ../../Source/WebCore/bindings/v8/IDBBindingUtilities.cpp: In function 'bool WebCore::set(v8::Handle<v8::Value>&, const WTF::String&, const v8::Handle<v8::Value>&)': ../../Source/WebCore/bindings/v8/IDBBindingUtilities.cpp:153: error: 'deprecatedV8String' was not declared in this scope ninja: build stopped: subcommand failed. Full output: http://queues.webkit.org/results/16370939 825928 5 186566 webkit.review.bot 2013-02-05 16:30:10 -0800 Comment on attachment 186566 Patch Clearing flags on attachment: 186566 Committed r141948: <http://trac.webkit.org/changeset/141948> 825929 6 webkit.review.bot 2013-02-05 16:30:13 -0800 All reviewed patches have been landed. Closing bug. 186566 2013-02-05 00:44:31 -0800 2013-02-05 16:30:10 -0800 Patch bug-108919-20130205174109.patch text/plain 5978 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxODY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmExODM1NGYzMGNiY2Q5 ZGZlZjVjMDc0MDU5ZTNlNmJlYTJhNWZkMC4uNGJjZmNmNTZiMjFjMzBlNDI3YzM5YjAzNTc1NDVl NWEwY2QwYTVkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEzLTAyLTA1ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIFJlbW92ZSBk ZXByZWNhdGVkVjhTdHJpbmcoKSBhbmQgZGVwcmVjYXRlZFY4SW50ZWdlcigpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg5MTkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdl IGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OnRvWFBhdGhOU1Jlc29sdmVyKToKKyAgICAgICAgKiBiaW5kaW5ncy92 OC9WOEJpbmRpbmcuaDoKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhDdXN0b21YUGF0 aE5TUmVzb2x2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhDdXN0b21YUGF0aE5TUmVzb2x2 ZXI6OmNyZWF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpWOEN1c3RvbVhQYXRoTlNSZXNvbHZlcjo6 VjhDdXN0b21YUGF0aE5TUmVzb2x2ZXIpOgorICAgICAgICAoV2ViQ29yZTo6VjhDdXN0b21YUGF0 aE5TUmVzb2x2ZXI6Omxvb2t1cE5hbWVzcGFjZVVSSSk6CisgICAgICAgICogYmluZGluZ3Mvdjgv Y3VzdG9tL1Y4Q3VzdG9tWFBhdGhOU1Jlc29sdmVyLmg6CisgICAgICAgIChWOEN1c3RvbVhQYXRo TlNSZXNvbHZlcik6CisKKzIwMTMtMDItMDUgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21p dW0ub3JnPgorCiAgICAgICAgIFtWOF0gUmVkdWNlIHVzYWdlIG9mIGRlcHJlY2F0ZWRTdHJpbmco KSBhbmQgZGVwcmVjYXRlZEludGVnZXIoKQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA4OTA5CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4QmluZGluZy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJp bmRpbmcuY3BwCmluZGV4IGRiMzQ4ODVmYTNmZGIwNDU4NWQ3YzdiNDA0MmMxNzFjZWJmNzJhYzAu LjExZTMyYjQyZGE3ODU5Y2RkMzQyMmEyMjE1NDU3NzBmOTcxYTI3ZDQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcApAQCAtMjA4LDcgKzIwOCw3IEBAIFBhc3NSZWZQ dHI8WFBhdGhOU1Jlc29sdmVyPiB0b1hQYXRoTlNSZXNvbHZlcih2ODo6SGFuZGxlPHY4OjpWYWx1 ZT4gdmFsdWUsIHY4OjpJCiAgICAgaWYgKFY4WFBhdGhOU1Jlc29sdmVyOjpIYXNJbnN0YW5jZSh2 YWx1ZSwgaXNvbGF0ZSkpCiAgICAgICAgIHJlc29sdmVyID0gVjhYUGF0aE5TUmVzb2x2ZXI6OnRv TmF0aXZlKHY4OjpIYW5kbGU8djg6Ok9iamVjdD46OkNhc3QodmFsdWUpKTsKICAgICBlbHNlIGlm ICh2YWx1ZS0+SXNPYmplY3QoKSkKLSAgICAgICAgcmVzb2x2ZXIgPSBWOEN1c3RvbVhQYXRoTlNS ZXNvbHZlcjo6Y3JlYXRlKHZhbHVlLT5Ub09iamVjdCgpKTsKKyAgICAgICAgcmVzb2x2ZXIgPSBW OEN1c3RvbVhQYXRoTlNSZXNvbHZlcjo6Y3JlYXRlKHZhbHVlLT5Ub09iamVjdCgpLCBpc29sYXRl KTsKICAgICByZXR1cm4gcmVzb2x2ZXI7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhC aW5kaW5nLmgKaW5kZXggNzQ0Nzg3N2FhMzQzOWI0NTZiMzRmZGQ0YjVjYjgxYjZhMWJhMTUxZC4u MzYzN2EwNmMxM2ZkNjhmYzQxZmUyNTRiMzJjZWI1Nzg3MGRhNmI4NiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKKysrIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKQEAgLTE1MiwxMiArMTUyLDYgQEAgbmFtZXNwYWNlIFdl YkNvcmUgewogICAgICAgICByZXR1cm4gVjhQZXJJc29sYXRlRGF0YTo6ZnJvbShpc29sYXRlKS0+ c3RyaW5nQ2FjaGUoKS0+djhFeHRlcm5hbFN0cmluZyhzdHJpbmcuaW1wbCgpLCBoYW5kbGVUeXBl LCBpc29sYXRlKTsKICAgICB9CiAKLSAgICAvLyBGSVhNRTogQWxsIGNhbGwgc2l0ZXMgb2YgdGhp cyBtZXRob2Qgc2hvdWxkIHVzZSB2OFN0cmluZygpLgotICAgIGlubGluZSB2ODo6SGFuZGxlPHY4 OjpTdHJpbmc+IGRlcHJlY2F0ZWRWOFN0cmluZyhjb25zdCBTdHJpbmcmIHN0cmluZykKLSAgICB7 Ci0gICAgICAgIHJldHVybiB2OFN0cmluZyhzdHJpbmcsIHY4OjpJc29sYXRlOjpHZXRDdXJyZW50 KCkpOwotICAgIH0KLQogICAgIGlubGluZSB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdjhTdHJpbmdP ck51bGwoY29uc3QgU3RyaW5nJiBzdHJpbmcsIHY4OjpJc29sYXRlKiBpc29sYXRlLCBSZXR1cm5I YW5kbGVUeXBlIGhhbmRsZVR5cGUgPSBSZXR1cm5Mb2NhbEhhbmRsZSkKICAgICB7CiAgICAgICAg IEFTU0VSVChpc29sYXRlKTsKQEAgLTE3OSwxMiArMTczLDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUg ewogICAgICAgICByZXR1cm4gVjhQZXJJc29sYXRlRGF0YTo6ZnJvbShpc29sYXRlKS0+aW50ZWdl ckNhY2hlKCktPnY4SW50ZWdlcih2YWx1ZSwgaXNvbGF0ZSk7CiAgICAgfQogCi0gICAgLy8gRklY TUU6IEFsbCBjYWxsIHNpdGVzIG9mIHRoaXMgbWV0aG9kIHNob3VsZCB1c2UgdjhJbnRlZ2VyKCku Ci0gICAgaW5saW5lIHY4OjpIYW5kbGU8djg6OkludGVnZXI+IGRlcHJlY2F0ZWRWOEludGVnZXIo aW50IHZhbHVlKQotICAgIHsKLSAgICAgICAgcmV0dXJuIHY4SW50ZWdlcih2YWx1ZSwgdjg6Oklz b2xhdGU6OkdldEN1cnJlbnQoKSk7Ci0gICAgfQotCiAgICAgaW5saW5lIHY4OjpIYW5kbGU8djg6 OkludGVnZXI+IHY4VW5zaWduZWRJbnRlZ2VyKHVuc2lnbmVkIHZhbHVlLCB2ODo6SXNvbGF0ZSog aXNvbGF0ZSkKICAgICB7CiAgICAgICAgIEFTU0VSVChpc29sYXRlKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEN1c3RvbVhQYXRoTlNSZXNvbHZlci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhDdXN0b21YUGF0aE5TUmVz b2x2ZXIuY3BwCmluZGV4IDg2ZTNjM2Q1OTc5NGQ2NWJiNGZkZTBiNjE2YWFiOWM1OTFhNTJhMGMu LmI5NTRmZmVkMWVkMzY4ZGRlYzcyZmIxMmYzZjJiN2Q4ODFjOTVhMTQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEN1c3RvbVhQYXRoTlNSZXNvbHZlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4Q3VzdG9tWFBhdGhO U1Jlc29sdmVyLmNwcApAQCAtNDEsMTMgKzQxLDE0IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsK IAotUGFzc1JlZlB0cjxWOEN1c3RvbVhQYXRoTlNSZXNvbHZlcj4gVjhDdXN0b21YUGF0aE5TUmVz b2x2ZXI6OmNyZWF0ZSh2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IHJlc29sdmVyKQorUGFzc1JlZlB0 cjxWOEN1c3RvbVhQYXRoTlNSZXNvbHZlcj4gVjhDdXN0b21YUGF0aE5TUmVzb2x2ZXI6OmNyZWF0 ZSh2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IHJlc29sdmVyLCB2ODo6SXNvbGF0ZSogaXNvbGF0ZSkK IHsKLSAgICByZXR1cm4gYWRvcHRSZWYobmV3IFY4Q3VzdG9tWFBhdGhOU1Jlc29sdmVyKHJlc29s dmVyKSk7CisgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBWOEN1c3RvbVhQYXRoTlNSZXNvbHZlcihy ZXNvbHZlciwgaXNvbGF0ZSkpOwogfQogCi1WOEN1c3RvbVhQYXRoTlNSZXNvbHZlcjo6VjhDdXN0 b21YUGF0aE5TUmVzb2x2ZXIodjg6OkhhbmRsZTx2ODo6T2JqZWN0PiByZXNvbHZlcikKK1Y4Q3Vz dG9tWFBhdGhOU1Jlc29sdmVyOjpWOEN1c3RvbVhQYXRoTlNSZXNvbHZlcih2ODo6SGFuZGxlPHY4 OjpPYmplY3Q+IHJlc29sdmVyLCB2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKICAgICA6IG1fcmVzb2x2 ZXIocmVzb2x2ZXIpCisgICAgLCBtX2lzb2xhdGUoaXNvbGF0ZSkKIHsKIH0KIApAQCAtNzcsNyAr NzgsNyBAQCBTdHJpbmcgVjhDdXN0b21YUGF0aE5TUmVzb2x2ZXI6Omxvb2t1cE5hbWVzcGFjZVVS SShjb25zdCBTdHJpbmcmIHByZWZpeCkKICAgICB0cnlDYXRjaC5TZXRWZXJib3NlKHRydWUpOyAv LyBQcmludCBleGNlcHRpb25zIHRvIGNvbnNvbGUuCiAKICAgICBjb25zdCBpbnQgYXJnYyA9IDE7 Ci0gICAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGFyZ3ZbYXJnY10gPSB7IGRlcHJlY2F0ZWRWOFN0 cmluZyhwcmVmaXgpIH07CisgICAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGFyZ3ZbYXJnY10gPSB7 IHY4U3RyaW5nKHByZWZpeCwgbV9pc29sYXRlKSB9OwogICAgIHY4OjpIYW5kbGU8djg6OkZ1bmN0 aW9uPiBmdW5jdGlvbiA9IGxvb2t1cE5hbWVzcGFjZVVSSUZ1bmMuSXNFbXB0eSgpID8gdjg6Okhh bmRsZTx2ODo6RnVuY3Rpb24+OjpDYXN0KG1fcmVzb2x2ZXIpIDogbG9va3VwTmFtZXNwYWNlVVJJ RnVuYzsKIAogICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiByZXR2YWwgPSBTY3JpcHRDb250cm9s bGVyOjpjYWxsRnVuY3Rpb25XaXRoSW5zdHJ1bWVudGF0aW9uKDAsIGZ1bmN0aW9uLCBtX3Jlc29s dmVyLCBhcmdjLCBhcmd2KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L2N1c3RvbS9WOEN1c3RvbVhQYXRoTlNSZXNvbHZlci5oIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvY3VzdG9tL1Y4Q3VzdG9tWFBhdGhOU1Jlc29sdmVyLmgKaW5kZXggMDNmMDdlOTI2ZDlj NTVhOTc2N2E2OTA0NmUwZGRjZjVjZTk4NDMxOC4uMGY0NzE1NzZlOGJhMGU5ZDlmYWUwZGJiNDhi NjcxNDY0OTgzYmIxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3Vz dG9tL1Y4Q3VzdG9tWFBhdGhOU1Jlc29sdmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvY3VzdG9tL1Y4Q3VzdG9tWFBhdGhOU1Jlc29sdmVyLmgKQEAgLTQ0LDE1ICs0NCwxNiBA QCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAvLyBtdXN0IG5vdCBleGNlZWQgdGhlIGxpZmV0aW1lIG9m IHRoZSBwYXNzZWQgaGFuZGxlLgogY2xhc3MgVjhDdXN0b21YUGF0aE5TUmVzb2x2ZXIgOiBwdWJs aWMgWFBhdGhOU1Jlc29sdmVyIHsKIHB1YmxpYzoKLSAgICBzdGF0aWMgUGFzc1JlZlB0cjxWOEN1 c3RvbVhQYXRoTlNSZXNvbHZlcj4gY3JlYXRlKHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gcmVzb2x2 ZXIpOworICAgIHN0YXRpYyBQYXNzUmVmUHRyPFY4Q3VzdG9tWFBhdGhOU1Jlc29sdmVyPiBjcmVh dGUodjg6OkhhbmRsZTx2ODo6T2JqZWN0PiByZXNvbHZlciwgdjg6Oklzb2xhdGUqKTsKIAogICAg IHZpcnR1YWwgflY4Q3VzdG9tWFBhdGhOU1Jlc29sdmVyKCk7CiAgICAgdmlydHVhbCBTdHJpbmcg bG9va3VwTmFtZXNwYWNlVVJJKGNvbnN0IFN0cmluZyYgcHJlZml4KTsKIAogcHJpdmF0ZToKLSAg ICBleHBsaWNpdCBWOEN1c3RvbVhQYXRoTlNSZXNvbHZlcih2ODo6SGFuZGxlPHY4OjpPYmplY3Q+ IHJlc29sdmVyKTsKKyAgICBWOEN1c3RvbVhQYXRoTlNSZXNvbHZlcih2ODo6SGFuZGxlPHY4OjpP YmplY3Q+IHJlc29sdmVyLCB2ODo6SXNvbGF0ZSopOwogCiAgICAgdjg6OkhhbmRsZTx2ODo6T2Jq ZWN0PiBtX3Jlc29sdmVyOyAgLy8gSGFuZGxlIHRvIHJlc29sdmVyIG9iamVjdC4KKyAgICB2ODo6 SXNvbGF0ZSogbV9pc29sYXRlOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=