108910 2013-02-04 23:06:27 -0800 touch-event.html should check touchstartFiredInShadowDOM is true. 2013-02-05 01:07:13 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 107796 1 shinyak shinyak hayato webcomponents-bugzilla webkit.review.bot oldest_to_newest 825160 0 shinyak 2013-02-04 23:06:27 -0800 Maybe I forgot to check touchstartFiredInShadowDOM in touch-event.html. We definitely check it. 825164 1 186554 shinyak 2013-02-04 23:10:26 -0800 Created attachment 186554 Patch 825193 2 hayato 2013-02-05 00:00:46 -0800 Unofficial rs=me on this. Looks okay to me since this fixes a trivial mistake on the layout test committed previously. Note that there are still cases where touch events are not fired on shadow tree. See bug 108908. 825204 3 186554 morrita 2013-02-05 00:16:08 -0800 Comment on attachment 186554 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186554&action=review > LayoutTests/ChangeLog:8 > + We have to check touchstartFiredInShadowDOM is true so that we can assure touch event is in ShadowDOM. This looks like a followup patch. Could you refer the original revision? 825224 4 186564 shinyak 2013-02-05 00:40:10 -0800 Created attachment 186564 Patch for landing 825225 5 shinyak 2013-02-05 00:40:33 -0800 (In reply to comment #3) > (From update of attachment 186554 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=186554&action=review > > > LayoutTests/ChangeLog:8 > > + We have to check touchstartFiredInShadowDOM is true so that we can assure touch event is in ShadowDOM. > > This looks like a followup patch. Could you refer the original revision? Sure. 825245 6 186564 webkit.review.bot 2013-02-05 01:07:08 -0800 Comment on attachment 186564 Patch for landing Clearing flags on attachment: 186564 Committed r141869: <http://trac.webkit.org/changeset/141869> 825246 7 webkit.review.bot 2013-02-05 01:07:13 -0800 All reviewed patches have been landed. Closing bug. 186554 2013-02-04 23:10:26 -0800 2013-02-05 00:40:07 -0800 Patch bug-108910-20130205160704.patch text/plain 2027 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxODU5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTYxM2QyZDI5OTQ1ZDhjODI5YTli YThkNjcxYTQxZjUzZDJjMWQ2OC4uODlkZmQzNmNlOTMzNGU3ZjYwYjFmMzNjODFjNjk1Yzk3MWUz MDkxOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAyLTA0ICBTaGlueWEgS2F3YW5ha2Eg IDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICB0b3VjaC1ldmVudC5odG1sIHNob3Vs ZCBjaGVjayB0b3VjaHN0YXJ0RmlyZWRJblNoYWRvd0RPTSBpcyB0cnVlLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4OTEwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgaGF2ZSB0byBjaGVjayB0b3Vj aHN0YXJ0RmlyZWRJblNoYWRvd0RPTSBpcyB0cnVlIHNvIHRoYXQgd2UgY2FuIGFzc3VyZSB0b3Vj aCBldmVudCBpcyBpbiBTaGFkb3dET00uCisKKyAgICAgICAgKiBmYXN0L2RvbS9zaGFkb3cvdG91 Y2gtZXZlbnQtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvZG9tL3NoYWRvdy90b3VjaC1l dmVudC5odG1sOgorCiAyMDEzLTAyLTA0ICBIYWppbWUgTW9ycml0YSAgPG1vcnJpdGFAZ29vZ2xl LmNvbT4KIAogICAgICAgICBbQ2hyb21pdW1dIFVucmV2aWV3ZWQgcmViYXNlbGluaW5nLgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L3RvdWNoLWV2ZW50LWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy90b3VjaC1ldmVudC1leHBlY3RlZC50 eHQKaW5kZXggM2ZiYjQyZGRlYjI1NmRkZjJhY2FhOGVmYjMxMjIwODIwZGM2YjkyYi4uNzk5OTBj NjM4YWM4M2NiNDZjYTkxYjg4ZmY1NmNkZDEzMmFjNTE1MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvZmFzdC9kb20vc2hhZG93L3RvdWNoLWV2ZW50LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2RvbS9zaGFkb3cvdG91Y2gtZXZlbnQtZXhwZWN0ZWQudHh0CkBAIC0yLDYgKzIs NyBAQCBUb3VjaCBldmVudCBzaG91bGQgYmUgZmlyZWQgaW4gU2hhZG93IERPTS4KIAogRWxlbWVu dHMgaW4gU2hhZG93RE9NIHNob3VsZCBub3QgYmUgcmV2ZWFsZWQgaW4gdG91Y2hUYXJnZXQgaWYg aXQncyBleGFtaW5lZCBpbiBub24gc2hhZG93IHRyZWUuCiAKK1BBU1MgdG91Y2hzdGFydEZpcmVk SW5TaGFkb3dET00gaXMgdHJ1ZQogUEFTUyB0b3VjaFRhcmdldEZvckhvc3QxIGlzIGhvc3QxCiBQ QVNTIHRvdWNoVGFyZ2V0Rm9ySW5wdXQxIGlzIGlucHV0MQogUEFTUyBzdWNjZXNzZnVsbHlQYXJz ZWQgaXMgdHJ1ZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L3RvdWNo LWV2ZW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvdG91Y2gtZXZlbnQuaHRt bAppbmRleCA1OTdjNDM4OTk1OWFhOGY2MDc3NDI5MDlhOTYwNmNjYTZkN2RiYzQxLi5kODYzN2Iz ZWRjMmQyMjlhMTU3NzE2YjBlYmMzNDYxNGRjN2U1ZDU1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9mYXN0L2RvbS9zaGFkb3cvdG91Y2gtZXZlbnQuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0 L2RvbS9zaGFkb3cvdG91Y2gtZXZlbnQuaHRtbApAQCAtNDIsNiArNDIsNyBAQCBldmVudFNlbmRl ci5hZGRUb3VjaFBvaW50KGlucHV0MS5vZmZzZXRMZWZ0ICsgaW5wdXQxLm9mZnNldFdpZHRoIC8g MiwgaW5wdXQxLm9mZgogZXZlbnRTZW5kZXIudG91Y2hTdGFydCgpOwogZXZlbnRTZW5kZXIudG91 Y2hFbmQoKTsKIAorc2hvdWxkQmVUcnVlKCd0b3VjaHN0YXJ0RmlyZWRJblNoYWRvd0RPTScpOwog c2hvdWxkQmUoJ3RvdWNoVGFyZ2V0Rm9ySG9zdDEnLCAnaG9zdDEnKTsKIHNob3VsZEJlKCd0b3Vj aFRhcmdldEZvcklucHV0MScsICdpbnB1dDEnKTsKIAo= 186564 2013-02-05 00:40:10 -0800 2013-02-05 01:07:08 -0800 Patch for landing bug-108910-20130205173648.patch text/plain 2105 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxODU5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTYxM2QyZDI5OTQ1ZDhjODI5YTli YThkNjcxYTQxZjUzZDJjMWQ2OC4uODg1NmJkNzQxZGY2YWY1MGJmYzc4NjE4NGM2YzUwNjdiMjcx Mjc3OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAyLTA1ICBTaGlueWEgS2F3YW5ha2Eg IDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICB0b3VjaC1ldmVudC5odG1sIHNob3Vs ZCBjaGVjayB0b3VjaHN0YXJ0RmlyZWRJblNoYWRvd0RPTSBpcyB0cnVlLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4OTEwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgSGFqaW1lIE1vcml0YS4KKworICAgICAgICBXZSBoYXZlIHRvIGNoZWNrIHRvdWNo c3RhcnRGaXJlZEluU2hhZG93RE9NIGlzIHRydWUgc28gdGhhdCB3ZSBjYW4gYXNzdXJlIHRvdWNo IGV2ZW50IGlzIGluIFNoYWRvd0RPTS4KKyAgICAgICAgVGhpcyBpcyBhIGZvbGxvdy11cCBwYXRj aCBmb3IgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTQxMDU0CisKKyAgICAgICAg KiBmYXN0L2RvbS9zaGFkb3cvdG91Y2gtZXZlbnQtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZh c3QvZG9tL3NoYWRvdy90b3VjaC1ldmVudC5odG1sOgorCiAyMDEzLTAyLTA0ICBIYWppbWUgTW9y cml0YSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KIAogICAgICAgICBbQ2hyb21pdW1dIFVucmV2aWV3 ZWQgcmViYXNlbGluaW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93 L3RvdWNoLWV2ZW50LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy90 b3VjaC1ldmVudC1leHBlY3RlZC50eHQKaW5kZXggM2ZiYjQyZGRlYjI1NmRkZjJhY2FhOGVmYjMx MjIwODIwZGM2YjkyYi4uNzk5OTBjNjM4YWM4M2NiNDZjYTkxYjg4ZmY1NmNkZDEzMmFjNTE1MyAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L3RvdWNoLWV2ZW50LWV4cGVj dGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvdG91Y2gtZXZlbnQtZXhw ZWN0ZWQudHh0CkBAIC0yLDYgKzIsNyBAQCBUb3VjaCBldmVudCBzaG91bGQgYmUgZmlyZWQgaW4g U2hhZG93IERPTS4KIAogRWxlbWVudHMgaW4gU2hhZG93RE9NIHNob3VsZCBub3QgYmUgcmV2ZWFs ZWQgaW4gdG91Y2hUYXJnZXQgaWYgaXQncyBleGFtaW5lZCBpbiBub24gc2hhZG93IHRyZWUuCiAK K1BBU1MgdG91Y2hzdGFydEZpcmVkSW5TaGFkb3dET00gaXMgdHJ1ZQogUEFTUyB0b3VjaFRhcmdl dEZvckhvc3QxIGlzIGhvc3QxCiBQQVNTIHRvdWNoVGFyZ2V0Rm9ySW5wdXQxIGlzIGlucHV0MQog UEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9kb20vc2hhZG93L3RvdWNoLWV2ZW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9z aGFkb3cvdG91Y2gtZXZlbnQuaHRtbAppbmRleCA1OTdjNDM4OTk1OWFhOGY2MDc3NDI5MDlhOTYw NmNjYTZkN2RiYzQxLi5kODYzN2IzZWRjMmQyMjlhMTU3NzE2YjBlYmMzNDYxNGRjN2U1ZDU1IDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvdG91Y2gtZXZlbnQuaHRtbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvdG91Y2gtZXZlbnQuaHRtbApAQCAtNDIs NiArNDIsNyBAQCBldmVudFNlbmRlci5hZGRUb3VjaFBvaW50KGlucHV0MS5vZmZzZXRMZWZ0ICsg aW5wdXQxLm9mZnNldFdpZHRoIC8gMiwgaW5wdXQxLm9mZgogZXZlbnRTZW5kZXIudG91Y2hTdGFy dCgpOwogZXZlbnRTZW5kZXIudG91Y2hFbmQoKTsKIAorc2hvdWxkQmVUcnVlKCd0b3VjaHN0YXJ0 RmlyZWRJblNoYWRvd0RPTScpOwogc2hvdWxkQmUoJ3RvdWNoVGFyZ2V0Rm9ySG9zdDEnLCAnaG9z dDEnKTsKIHNob3VsZEJlKCd0b3VjaFRhcmdldEZvcklucHV0MScsICdpbnB1dDEnKTsKIAo=