108894 2013-02-04 20:24:04 -0800 Make StringBuilder::toAtomicString() consistent with StringBuilder::toString() for strings of null length 2013-02-05 12:51:07 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin ojan.autocc webkit.review.bot oldest_to_newest 825066 0 benjamin 2013-02-04 20:24:04 -0800 Make StringBuilder::toAtomicString() consistent with StringBuilder::toString() for strings of null length 825072 1 186532 benjamin 2013-02-04 20:26:41 -0800 Created attachment 186532 Patch 825365 2 186532 kling 2013-02-05 04:22:18 -0800 Comment on attachment 186532 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186532&action=review > Source/WTF/ChangeLog:3 > + Make StringBuilder::toAtomicString() consistent with StringBuilder::toString() for strings of null length null length -> zero length 825727 3 benjamin 2013-02-05 12:51:07 -0800 Committed r141917: <http://trac.webkit.org/changeset/141917> 186532 2013-02-04 20:26:41 -0800 2013-02-05 04:22:18 -0800 Patch bug-108894-20130204202320.patch text/plain 4998 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxODE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDhkZjMxN2M2ZGIwYjY4MDhkOTRmYTA3 YTkxMWM1YjQ2NjNmNDMwMzYuLmEyYzJjMGVjNmMxMDQ1NWM1ZDVmYzM5ZThiMjEzNWQzZjg2Njhl YzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTMtMDItMDQgIEJlbmphbWluIFBvdWxhaW4gIDxi cG91bGFpbkBhcHBsZS5jb20+CiAKKyAgICAgICAgTWFrZSBTdHJpbmdCdWlsZGVyOjp0b0F0b21p Y1N0cmluZygpIGNvbnNpc3RlbnQgd2l0aCBTdHJpbmdCdWlsZGVyOjp0b1N0cmluZygpIGZvciBz dHJpbmdzIG9mIG51bGwgbGVuZ3RoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDg4OTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHd0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuaDoKKyAgICAgICAgKFdURjo6 U3RyaW5nQnVpbGRlcjo6dG9BdG9taWNTdHJpbmcpOiBUaGUgZnVuY3Rpb24gd2FzIHJldHVybmlu ZyB0aGUgbnVsbEF0b20gZm9yIHN0cmluZ3Mgb2YgbGVuZ3RoIHplcm8uCisgICAgICAgIFRoaXMg aXMgaW5jb25zaXN0ZW50IHdpdGggU3RyaW5nQnVpbGRlcjo6dG9TdHJpbmcoKSB3aGljaCBhbHdh eXMgcmV0dXJuIGFuIGVtcHR5IHN0cmluZy4KKworICAgICAgICBUaGlzIHBhdGNoIHVuaWZpZXMg dGhlIGJlaGF2aW9yLgorCisyMDEzLTAyLTA0ICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5A YXBwbGUuY29tPgorCiAgICAgICAgIFRpZHkgdXAgU3RhY2tCb3VuZHMKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODg4OQogCmRpZmYgLS1naXQgYS9T b3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuaCBiL1NvdXJjZS9XVEYvd3RmL3RleHQv U3RyaW5nQnVpbGRlci5oCmluZGV4IDc1YThmMjVkZGVjNTUyM2FiNDE4NTZiYzVjNTk0ZmU0ZTMy YzY3YTYuLmNmNzdkNjFkMDU3ZWVjNTM3OWE1Yjc1NjBjMDJmMjRjYzFkZWNkNzkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nQnVpbGRlci5oCisrKyBiL1NvdXJjZS9XVEYv d3RmL3RleHQvU3RyaW5nQnVpbGRlci5oCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdo dCAoQykgMjAwOSwgMjAxMCwgMjAxMiBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisg KiBDb3B5cmlnaHQgKEMpIDIwMDksIDIwMTAsIDIwMTIsIDIwMTMgQXBwbGUgSW5jLiBBbGwgcmln aHRzIHJlc2VydmVkLgogICogQ29weXJpZ2h0IChDKSAyMDEyIEdvb2dsZSBJbmMuIEFsbCByaWdo dHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5k IGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CkBAIC0xNzksNyArMTc5LDcgQEAgcHVibGlj OgogICAgIEF0b21pY1N0cmluZyB0b0F0b21pY1N0cmluZygpIGNvbnN0CiAgICAgewogICAgICAg ICBpZiAoIW1fbGVuZ3RoKQotICAgICAgICAgICAgcmV0dXJuIEF0b21pY1N0cmluZygpOworICAg ICAgICAgICAgcmV0dXJuIGVtcHR5QXRvbTsKIAogICAgICAgICAvLyBJZiB0aGUgYnVmZmVyIGlz IHN1ZmZpY2llbnRseSBvdmVyLWFsbG9jYXRlZCwgbWFrZSBhIG5ldyBBdG9taWNTdHJpbmcgZnJv bSBhIGNvcHkgc28gaXRzIGJ1ZmZlciBpcyBub3Qgc28gbGFyZ2UuCiAgICAgICAgIGlmIChjYW5T aHJpbmsoKSkgewpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9n CmluZGV4IGRmZjgwZWEwNDBiZDQ0YmQ2MjJmZWVlNzVlM2VhMDkzYzUxYzcwMmIuLmQ2YmI3OTdk YjM3OTY4MTE2MjIyYWRmYzJjZjA3Y2MzMjZjN2I0YmQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5n ZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0wMi0wNCAg QmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIFN0 cmluZ0J1aWxkZXI6OnRvQXRvbWljU3RyaW5nKCkgY29uc2lzdGVudCB3aXRoIFN0cmluZ0J1aWxk ZXI6OnRvU3RyaW5nKCkgZm9yIHN0cmluZ3Mgb2YgbnVsbCBsZW5ndGgKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODg5NAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9X VEYvU3RyaW5nQnVpbGRlci5jcHA6CisgICAgICAgIEV4dGVuZCB0aGUgdGVzdHMgdG8gY2hlY2sg dG9BdG9taWNTdHJpbmcoKSBvbiBhbiBlbXB0eSBidWlsZGVyLgorCiAyMDEzLTAyLTA0ICBCcnVu byBkZSBPbGl2ZWlyYSBBYmluYWRlciAgPGJydW5vLmFiaW5hZGVyQGJhc3lza29tLmNvbT4KIAog ICAgICAgICBbRUZMXSBBZGQgImZ1bGwgc2NyZWVuIiBwYXJhbWV0ZXIgdG8gTWluaUJyb3dzZXIK ZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1N0cmluZ0J1aWxkZXIu Y3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvU3RyaW5nQnVpbGRlci5jcHAKaW5k ZXggMDNiZTc1OTI1ZjI0ZTRhNGEyNjM5ODI5NDcyOTZiMjZlODdkY2VjZi4uZDFiNWI0M2JkMTlj MjM5ZTA3NDNjNmZjOThmMDVkMzkxYzZmNWZkMiAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XVEYvU3RyaW5nQnVpbGRlci5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XVEYvU3RyaW5nQnVpbGRlci5jcHAKQEAgLTEsNSArMSw2IEBACiAvKgogICogQ29w eXJpZ2h0IChDKSAyMDExIEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5 cmlnaHQgKEMpIDIwMTMgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJl ZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Ig d2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhl IGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQpAQCAtMjg0LDQgKzI4NSw1MSBAQCBURVNUKFN0cmlu Z0J1aWxkZXJUZXN0LCBUb0F0b21pY1N0cmluZykKICAgICBBU1NFUlRfRVEoYXRvbWljU3RyaW5n Mi5pbXBsKCksIHN0cmluZy5pbXBsKCkpOwogfQogCitURVNUKFN0cmluZ0J1aWxkZXJUZXN0LCBU b0F0b21pY1N0cmluZ09uRW1wdHkpCit7CisgICAgeyAvLyBEZWZhdWx0IGNvbnN0cnVjdGVkLgor ICAgICAgICBTdHJpbmdCdWlsZGVyIGJ1aWxkZXI7CisgICAgICAgIEF0b21pY1N0cmluZyBhdG9t aWNTdHJpbmcgPSBidWlsZGVyLnRvQXRvbWljU3RyaW5nKCk7CisgICAgICAgIEFTU0VSVF9FUShl bXB0eUF0b20sIGF0b21pY1N0cmluZyk7CisgICAgfQorICAgIHsgLy8gV2l0aCBjYXBhY2l0eS4K KyAgICAgICAgU3RyaW5nQnVpbGRlciBidWlsZGVyOworICAgICAgICBidWlsZGVyLnJlc2VydmVD YXBhY2l0eSg2NCk7CisgICAgICAgIEF0b21pY1N0cmluZyBhdG9taWNTdHJpbmcgPSBidWlsZGVy LnRvQXRvbWljU3RyaW5nKCk7CisgICAgICAgIEFTU0VSVF9FUShlbXB0eUF0b20sIGF0b21pY1N0 cmluZyk7CisgICAgfQorICAgIHsgLy8gQXRvbWljU3RyaW5nIGNvbnN0cnVjdGVkIGZyb20gYSBu dWxsIHN0cmluZy4KKyAgICAgICAgU3RyaW5nQnVpbGRlciBidWlsZGVyOworICAgICAgICBidWls ZGVyLmFwcGVuZChTdHJpbmcoKSk7CisgICAgICAgIEF0b21pY1N0cmluZyBhdG9taWNTdHJpbmcg PSBidWlsZGVyLnRvQXRvbWljU3RyaW5nKCk7CisgICAgICAgIEFTU0VSVF9FUShlbXB0eUF0b20s IGF0b21pY1N0cmluZyk7CisgICAgfQorICAgIHsgLy8gQXRvbWljU3RyaW5nIGNvbnN0cnVjdGVk IGZyb20gYW4gZW1wdHkgc3RyaW5nLgorICAgICAgICBTdHJpbmdCdWlsZGVyIGJ1aWxkZXI7Cisg ICAgICAgIGJ1aWxkZXIuYXBwZW5kKGVtcHR5U3RyaW5nKCkpOworICAgICAgICBBdG9taWNTdHJp bmcgYXRvbWljU3RyaW5nID0gYnVpbGRlci50b0F0b21pY1N0cmluZygpOworICAgICAgICBBU1NF UlRfRVEoZW1wdHlBdG9tLCBhdG9taWNTdHJpbmcpOworICAgIH0KKyAgICB7IC8vIEF0b21pY1N0 cmluZyBjb25zdHJ1Y3RlZCBmcm9tIGFuIGVtcHR5IFN0cmluZ0J1aWxkZXIuCisgICAgICAgIFN0 cmluZ0J1aWxkZXIgYnVpbGRlcjsKKyAgICAgICAgU3RyaW5nQnVpbGRlciBlbXB0eUJ1aWxkZXI7 CisgICAgICAgIGJ1aWxkZXIuYXBwZW5kKGVtcHR5QnVpbGRlcik7CisgICAgICAgIEF0b21pY1N0 cmluZyBhdG9taWNTdHJpbmcgPSBidWlsZGVyLnRvQXRvbWljU3RyaW5nKCk7CisgICAgICAgIEFT U0VSVF9FUShlbXB0eUF0b20sIGF0b21pY1N0cmluZyk7CisgICAgfQorICAgIHsgLy8gQXRvbWlj U3RyaW5nIGNvbnN0cnVjdGVkIGZyb20gYW4gZW1wdHkgY2hhciogc3RyaW5nLgorICAgICAgICBT dHJpbmdCdWlsZGVyIGJ1aWxkZXI7CisgICAgICAgIGJ1aWxkZXIuYXBwZW5kKCIiLCAwKTsKKyAg ICAgICAgQXRvbWljU3RyaW5nIGF0b21pY1N0cmluZyA9IGJ1aWxkZXIudG9BdG9taWNTdHJpbmco KTsKKyAgICAgICAgQVNTRVJUX0VRKGVtcHR5QXRvbSwgYXRvbWljU3RyaW5nKTsKKyAgICB9Cisg ICAgeyAvLyBDbGVhcmVkIFN0cmluZ0J1aWxkZXIuCisgICAgICAgIFN0cmluZ0J1aWxkZXIgYnVp bGRlcjsKKyAgICAgICAgYnVpbGRlci5hcHBlbmRMaXRlcmFsKCJXZWJLaXQiKTsKKyAgICAgICAg YnVpbGRlci5jbGVhcigpOworICAgICAgICBBdG9taWNTdHJpbmcgYXRvbWljU3RyaW5nID0gYnVp bGRlci50b0F0b21pY1N0cmluZygpOworICAgICAgICBBU1NFUlRfRVEoZW1wdHlBdG9tLCBhdG9t aWNTdHJpbmcpOworICAgIH0KK30KKwogfSAvLyBuYW1lc3BhY2UK