<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>108891</bug_id>
          
          <creation_ts>2013-02-04 19:42:47 -0800</creation_ts>
          <short_desc>EWS bots don&apos;t remove untracked files after processing a patch</short_desc>
          <delta_ts>2013-02-05 00:02:02 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alan Cutter">alancutter</reporter>
          <assigned_to name="Alan Cutter">alancutter</assigned_to>
          <cc>abarth</cc>
    
    <cc>dstockwell</cc>
    
    <cc>eric</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>825042</commentid>
    <comment_count>0</comment_count>
    <who name="Alan Cutter">alancutter</who>
    <bug_when>2013-02-04 19:42:47 -0800</bug_when>
    <thetext>gce-cr-linux-06 and gce-cr-linux-08 were crashing on tests due to the presence of a third_party/WebKit/LayoutTests directory path in the repository. These files and folders were not being cleaned out of the repository automatically and causing the tests to crash.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>825157</commentid>
    <comment_count>1</comment_count>
      <attachid>186552</attachid>
    <who name="Alan Cutter">alancutter</who>
    <bug_when>2013-02-04 22:55:07 -0800</bug_when>
    <thetext>Created attachment 186552
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>825162</commentid>
    <comment_count>2</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2013-02-04 23:08:39 -0800</bug_when>
    <thetext>This will cause the EWS bots to check out a new copy of the chromium dependencies every time they reboot. :)

That&apos;s OK.  But we had intentionally avoided this before.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>825169</commentid>
    <comment_count>3</comment_count>
    <who name="Alan Cutter">alancutter</who>
    <bug_when>2013-02-04 23:16:45 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; This will cause the EWS bots to check out a new copy of the chromium dependencies every time they reboot. :)
&gt; 
&gt; That&apos;s OK.  But we had intentionally avoided this before.

Those files appear to be .gitignored, git clean doesn&apos;t remove ignored files unless -x is given as well. Good consideration though!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>825185</commentid>
    <comment_count>4</comment_count>
      <attachid>186552</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2013-02-04 23:46:55 -0800</bug_when>
    <thetext>Comment on attachment 186552
Patch

Ok.  If this doesn&apos;t blow away the Chromium Turducken, then this sounds like a good change.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>825194</commentid>
    <comment_count>5</comment_count>
      <attachid>186552</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-02-05 00:01:58 -0800</bug_when>
    <thetext>Comment on attachment 186552
Patch

Clearing flags on attachment: 186552

Committed r141863: &lt;http://trac.webkit.org/changeset/141863&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>825195</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-02-05 00:02:02 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>186552</attachid>
            <date>2013-02-04 22:55:07 -0800</date>
            <delta_ts>2013-02-05 00:01:57 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-108891-20130205175145.patch</filename>
            <type>text/plain</type>
            <size>1493</size>
            <attacher name="Alan Cutter">alancutter</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxODU4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTRhMmYxNTA0Y2QzMDA4YTk4Mzg5ODg4OWQ0MDVlNDFm
ZGY5OWZiYi4uYjI0MWUwZTkxZWQ0ZDVkY2M3ODM0ZDQwNTQ1YzgyMmU0YmVlNDg0YiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0
IEBACisyMDEzLTAyLTA0ICBBbGFuIEN1dHRlciAgPGFsYW5jdXR0ZXJAY2hyb21pdW0ub3JnPgor
CisgICAgICAgIEVXUyBib3RzIGRvbid0IHJlbW92ZSB1bnRyYWNrZWQgZmlsZXMgYWZ0ZXIgcHJv
Y2Vzc2luZyBhIHBhdGNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0xMDg4OTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICBBZGRlZCBvcHRpb24gdG8gcmVtb3ZlIHVudHJhY2tlZCBmaWxlcyBpbiB0aGUgYm90
J3MgcmVwby4KKworICAgICAgICAqIEVXU1Rvb2xzL3N0YXJ0LXF1ZXVlLnNoOgorCiAyMDEzLTAy
LTA0ICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCiAgICAgICAgIEtp
bGwgc3VzcGVuZEFuaW1hdGlvbigpLCByZXN1bWVBbmltYXRpb24oKSBhbmQgbnVtYmVyT2ZBY3Rp
dmVBbmltYXRpb25zKCkgZnJvbSBEUlQvV1RSOyB1c2UgSW50ZXJuYWxzCmRpZmYgLS1naXQgYS9U
b29scy9FV1NUb29scy9zdGFydC1xdWV1ZS5zaCBiL1Rvb2xzL0VXU1Rvb2xzL3N0YXJ0LXF1ZXVl
LnNoCmluZGV4IDQ4YWIzMmU1YWJiNDI2OTZkMjNkM2I2MDUzN2VlZGIxM2IxNGZkNzAuLmM3MDA5
NjY0MWI0M2Y1MzBjNGQ4OWRlZGJhNDNmMDg1OGRjZjc4MmYgMTAwNzU1Ci0tLSBhL1Rvb2xzL0VX
U1Rvb2xzL3N0YXJ0LXF1ZXVlLnNoCisrKyBiL1Rvb2xzL0VXU1Rvb2xzL3N0YXJ0LXF1ZXVlLnNo
CkBAIC01MCw3ICs1MCw3IEBAIGRvCiAKICAgICAjIFRoaXMgc29tZXdoYXQgcXVpcmt5IHNlcXVl
bmNlIG9mIHN0ZXBzIHNlZW1zIHRvIGNsZWFyIHVwIGFsbCB0aGUgYnJva2VuCiAgICAgIyBnaXQg
c2l0dWF0aW9ucyB3ZSd2ZSBnb3R0ZW4gb3Vyc2VsZiBpbnRvIGluIHRoZSBwYXN0LgotICAgIGdp
dCBjbGVhbiAtZiAjIFJlbW92ZSBhbnkgbGVmdC1vdmVyIGxheW91dCB0ZXN0IHJlc3VsdHMsIGFk
ZGVkIGZpbGVzLCBldGMuCisgICAgZ2l0IGNsZWFuIC1mIC1kICMgUmVtb3ZlIGFueSBsZWZ0LW92
ZXIgbGF5b3V0IHRlc3QgcmVzdWx0cywgYWRkZWQgZmlsZXMsIGV0Yy4KICAgICBnaXQgcmViYXNl
IC0tYWJvcnQgIyBJZiB3ZSBnb3Qga2lsbGVkIGR1cmluZyBhIGdpdCByZWJhc2UsIHdlIG5lZWQg
dG8gY2xlYW4gdXAuCiAgICAgZ2l0IGZldGNoIG9yaWdpbiAjIEF2b2lkIHVwZGF0aW5nIHRoZSB3
b3JraW5nIGNvcHkgdG8gYSBzdGFsZSByZXZpc2lvbi4KICAgICBnaXQgY2hlY2tvdXQgb3JpZ2lu
L21hc3RlciAtZgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>