108869 2013-02-04 15:19:13 -0800 [EFL] Remove needless local variables in LocalizedStringsEfl.cpp 2013-02-05 15:45:00 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim haraken lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 824815 0 gyuyoung.kim 2013-02-04 15:19:13 -0800 fromUTF8() returns *static String*, so I think we don't need to use local variable. Beside it seems to me the functions which use *static String variable* were just copied from GTK port. If possible, I think it would be better not to use local variable. 824817 1 186475 gyuyoung.kim 2013-02-04 15:20:31 -0800 Created attachment 186475 Patch 824848 2 186475 haraken 2013-02-04 15:54:11 -0800 Comment on attachment 186475 Patch Looks reasonable 824989 3 186475 webkit.review.bot 2013-02-04 18:14:20 -0800 Comment on attachment 186475 Patch Clearing flags on attachment: 186475 Committed r141842: <http://trac.webkit.org/changeset/141842> 824990 4 webkit.review.bot 2013-02-04 18:14:24 -0800 All reviewed patches have been landed. Closing bug. 825521 5 rakuco 2013-02-05 09:07:17 -0800 (In reply to comment #0) > fromUTF8() returns *static String*, so I think we don't need to use local variable. For the record, `static' here is just a modifier that indicates that that method is not per class, but rather per class instance. WTFString::fromUTF8() returns a String, not a "static String". 825875 6 haraken 2013-02-05 15:33:03 -0800 (In reply to comment #5) > (In reply to comment #0) > > fromUTF8() returns *static String*, so I think we don't need to use local variable. > > For the record, `static' here is just a modifier that indicates that that method is not per class, but rather per class instance. WTFString::fromUTF8() returns a String, not a "static String". Good point. You're right... 825895 7 gyuyoung.kim 2013-02-05 15:45:00 -0800 (In reply to comment #5) > (In reply to comment #0) > > fromUTF8() returns *static String*, so I think we don't need to use local variable. > > For the record, `static' here is just a modifier that indicates that that method is not per class, but rather per class instance. WTFString::fromUTF8() returns a String, not a "static String". My mistake. Thank you for your point out. 186475 2013-02-04 15:20:31 -0800 2013-02-04 18:14:19 -0800 Patch bug-108869-20130205081710.patch text/plain 3821 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNzYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjI4MWIwN2RjMGIxNTYz MzYyYzZkYjA3MmM2ODgyOTlhYzQ5MTQyZC4uMjIyMGVmZDUzNDkwNDFkZTJjMGY1ZGIzMTRmNDk0 NGVlYThlMWNhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEzLTAyLTA0ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gUmVt b3ZlIG5lZWRsZXNzIGxvY2FsIHZhcmlhYmxlcyBpbiBMb2NhbGl6ZWRTdHJpbmdzRWZsLmNwcAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4ODY5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZnJvbVVURjgo KSByZXR1cm5zIHN0YXRpYyBTdHJpbmcuIFNvLCB3ZSBkb24ndCBuZWVkIHRvIHVzZSBuZWVkbGVz cyBsb2NhbCB2YXJpYWJsZXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvTG9jYWxpemVkU3Ry aW5nc0VmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjb250ZXh0TWVudUl0ZW1UYWdDb3B5KToK KyAgICAgICAgKFdlYkNvcmU6OmNvbnRleHRNZW51SXRlbVRhZ0RlbGV0ZSk6CisgICAgICAgIChX ZWJDb3JlOjpjb250ZXh0TWVudUl0ZW1UYWdTZWxlY3RBbGwpOgorICAgICAgICAoV2ViQ29yZTo6 Y29udGV4dE1lbnVJdGVtVGFnR29CYWNrKToKKyAgICAgICAgKFdlYkNvcmU6OmNvbnRleHRNZW51 SXRlbVRhZ0dvRm9yd2FyZCk6CisgICAgICAgIChXZWJDb3JlOjpjb250ZXh0TWVudUl0ZW1UYWdT dG9wKToKKyAgICAgICAgKFdlYkNvcmU6OmNvbnRleHRNZW51SXRlbVRhZ0N1dCk6CisgICAgICAg IChXZWJDb3JlOjpjb250ZXh0TWVudUl0ZW1UYWdQYXN0ZSk6CisgICAgICAgIChXZWJDb3JlOjpj b250ZXh0TWVudUl0ZW1UYWdCb2xkKToKKyAgICAgICAgKFdlYkNvcmU6OmNvbnRleHRNZW51SXRl bVRhZ0l0YWxpYyk6CisgICAgICAgIChXZWJDb3JlOjpjb250ZXh0TWVudUl0ZW1UYWdVbmRlcmxp bmUpOgorCiAyMDEzLTAyLTA0ICBEYW4gQ2FybmV5ICA8ZGNhcm5leUBnb29nbGUuY29tPgogCiAg ICAgICAgIFt2OF0gdXNlIHRvVjhGYXN0IGluIGhhbmQgY29kZWQgY2FsbGJhY2tzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTG9jYWxpemVkU3RyaW5nc0VmbC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTG9jYWxpemVkU3RyaW5nc0VmbC5jcHAKaW5k ZXggM2JlODBmNTg2NjQ1NDJjZjZjMDlmMWI4MmIzNjhmNTU1MTgxN2JjNy4uMDYwOWY1OTUzY2Mz NGFjYjg5MzJkZWVmMmJjOWUyNWI0NTFkNTE1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZWZsL0xvY2FsaXplZFN0cmluZ3NFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2VmbC9Mb2NhbGl6ZWRTdHJpbmdzRWZsLmNwcApAQCAtMTc1LDIwICsxNzUsMTcg QEAgU3RyaW5nIGNvbnRleHRNZW51SXRlbVRhZ09wZW5GcmFtZUluTmV3V2luZG93KCkKIAogU3Ry aW5nIGNvbnRleHRNZW51SXRlbVRhZ0NvcHkoKQogewotICAgIHN0YXRpYyBTdHJpbmcgc3RvY2tM YWJlbCA9IFN0cmluZzo6ZnJvbVVURjgoIkNvcHkiKTsKLSAgICByZXR1cm4gc3RvY2tMYWJlbDsK KyAgICByZXR1cm4gU3RyaW5nOjpmcm9tVVRGOCgiQ29weSIpOwogfQogCiBTdHJpbmcgY29udGV4 dE1lbnVJdGVtVGFnRGVsZXRlKCkKIHsKLSAgICBzdGF0aWMgU3RyaW5nIHN0b2NrTGFiZWwgPSBT dHJpbmc6OmZyb21VVEY4KCJEZWxldGUiKTsKLSAgICByZXR1cm4gc3RvY2tMYWJlbDsKKyAgICBy ZXR1cm4gU3RyaW5nOjpmcm9tVVRGOCgiRGVsZXRlIik7CiB9CiAKIFN0cmluZyBjb250ZXh0TWVu dUl0ZW1UYWdTZWxlY3RBbGwoKQogewotICAgIHN0YXRpYyBTdHJpbmcgc3RvY2tMYWJlbCA9IFN0 cmluZzo6ZnJvbVVURjgoIlNlbGVjdCBBbGwiKTsKLSAgICByZXR1cm4gc3RvY2tMYWJlbDsKKyAg ICByZXR1cm4gU3RyaW5nOjpmcm9tVVRGOCgiU2VsZWN0IEFsbCIpOwogfQogCiBTdHJpbmcgY29u dGV4dE1lbnVJdGVtVGFnVW5pY29kZSgpCkBAIC0yMDMsMjAgKzIwMCwxNyBAQCBTdHJpbmcgY29u dGV4dE1lbnVJdGVtVGFnSW5wdXRNZXRob2RzKCkKIAogU3RyaW5nIGNvbnRleHRNZW51SXRlbVRh Z0dvQmFjaygpCiB7Ci0gICAgc3RhdGljIFN0cmluZyBzdG9ja0xhYmVsID0gU3RyaW5nOjpmcm9t VVRGOCgiR28gQmFjayIpOwotICAgIHJldHVybiBzdG9ja0xhYmVsOworICAgIHJldHVybiBTdHJp bmc6OmZyb21VVEY4KCJHbyBCYWNrIik7CiB9CiAKIFN0cmluZyBjb250ZXh0TWVudUl0ZW1UYWdH b0ZvcndhcmQoKQogewotICAgIHN0YXRpYyBTdHJpbmcgc3RvY2tMYWJlbCA9IFN0cmluZzo6ZnJv bVVURjgoIkdvIEZvcndhcmQiKTsKLSAgICByZXR1cm4gc3RvY2tMYWJlbDsKKyAgICByZXR1cm4g U3RyaW5nOjpmcm9tVVRGOCgiR28gRm9yd2FyZCIpOwogfQogCiBTdHJpbmcgY29udGV4dE1lbnVJ dGVtVGFnU3RvcCgpCiB7Ci0gICAgc3RhdGljIFN0cmluZyBzdG9ja0xhYmVsID0gU3RyaW5nOjpm cm9tVVRGOCgiU3RvcCIpOwotICAgIHJldHVybiBzdG9ja0xhYmVsOworICAgIHJldHVybiBTdHJp bmc6OmZyb21VVEY4KCJTdG9wIik7CiB9CiAKIFN0cmluZyBjb250ZXh0TWVudUl0ZW1UYWdSZWxv YWQoKQpAQCAtMjI2LDE0ICsyMjAsMTIgQEAgU3RyaW5nIGNvbnRleHRNZW51SXRlbVRhZ1JlbG9h ZCgpCiAKIFN0cmluZyBjb250ZXh0TWVudUl0ZW1UYWdDdXQoKQogewotICAgIHN0YXRpYyBTdHJp bmcgc3RvY2tMYWJlbCA9IFN0cmluZzo6ZnJvbVVURjgoIkN1dCIpOwotICAgIHJldHVybiBzdG9j a0xhYmVsOworICAgIHJldHVybiBTdHJpbmc6OmZyb21VVEY4KCJDdXQiKTsKIH0KIAogU3RyaW5n IGNvbnRleHRNZW51SXRlbVRhZ1Bhc3RlKCkKIHsKLSAgICBzdGF0aWMgU3RyaW5nIHN0b2NrTGFi ZWwgPSBTdHJpbmc6OmZyb21VVEY4KCJQYXN0ZSIpOwotICAgIHJldHVybiBzdG9ja0xhYmVsOwor ICAgIHJldHVybiBTdHJpbmc6OmZyb21VVEY4KCJQYXN0ZSIpOwogfQogCiBTdHJpbmcgY29udGV4 dE1lbnVJdGVtVGFnTm9HdWVzc2VzRm91bmQoKQpAQCAtMzAzLDIwICsyOTUsMTcgQEAgU3RyaW5n IGNvbnRleHRNZW51SXRlbVRhZ0ZvbnRNZW51KCkKIAogU3RyaW5nIGNvbnRleHRNZW51SXRlbVRh Z0JvbGQoKQogewotICAgIHN0YXRpYyBTdHJpbmcgc3RvY2tMYWJlbCA9IFN0cmluZzo6ZnJvbVVU RjgoIkJvbGQiKTsKLSAgICByZXR1cm4gc3RvY2tMYWJlbDsKKyAgICByZXR1cm4gU3RyaW5nOjpm cm9tVVRGOCgiQm9sZCIpOwogfQogCiBTdHJpbmcgY29udGV4dE1lbnVJdGVtVGFnSXRhbGljKCkK IHsKLSAgICBzdGF0aWMgU3RyaW5nIHN0b2NrTGFiZWwgPSBTdHJpbmc6OmZyb21VVEY4KCJJdGFs aWMiKTsKLSAgICByZXR1cm4gc3RvY2tMYWJlbDsKKyAgICByZXR1cm4gU3RyaW5nOjpmcm9tVVRG OCgiSXRhbGljIik7CiB9CiAKIFN0cmluZyBjb250ZXh0TWVudUl0ZW1UYWdVbmRlcmxpbmUoKQog ewotICAgIHN0YXRpYyBTdHJpbmcgc3RvY2tMYWJlbCA9IFN0cmluZzo6ZnJvbVVURjgoIlVuZGVy bGluZSIpOwotICAgIHJldHVybiBzdG9ja0xhYmVsOworICAgIHJldHVybiBTdHJpbmc6OmZyb21V VEY4KCJVbmRlcmxpbmUiKTsKIH0KIAogU3RyaW5nIGNvbnRleHRNZW51SXRlbVRhZ091dGxpbmUo KQo=