10886 2006-09-16 05:39:43 -0700 REGRESSION (r16387): Reproducible crash when mousing over HTML document 2006-09-16 08:05:06 -0700 1 1 1 Unclassified WebKit WebCore Misc. 420+ Mac OS X 10.4 RESOLVED FIXED Regression P1 Critical --- 1 mitz webkit-unassigned kevin sam oldest_to_newest 55651 0 mitz 2006-09-16 05:39:43 -0700 Safari crashes as soon as you mouse over an HTML document. The reason appears to be that the auto-generated -[DOMNode ownerDocument] calls Node::ownerDocument(), which returns 0 for the document itself. The old version in called Node::document(). You should keep (or generate) that custom behavior. Thread 0 Crashed: 0 WebCore::Document::frame() const + 28 (Document.cpp:773) 1 +[WebCoreFrameBridge bridgeForDOMDocument:] + 76 (WebCoreFrameBridge.mm:459) 2 -[DOMNode(WebDOMNodeOperations) _bridge] + 112 (WebDOMOperations.m:45) 3 -[DOMDocument(WebDOMDocumentOperations) webFrame] + 64 (WebDOMOperations.m:89) 4 -[WebHTMLView(WebDocumentInternalProtocols) elementAtPoint:allowShadowContent:] + 244 (WebHTMLView.m:5835) 5 -[WebHTMLView(WebDocumentInternalProtocols) elementAtPoint:] + 84 (WebHTMLView.m:5826) 6 -[WebHTMLView(WebPrivate) _updateMouseoverWithEvent:] + 1492 (WebHTMLView.m:1192) 7 -[WebHTMLView(WebPrivate) _updateMouseoverWithFakeEvent] + 580 (WebHTMLView.m:800) 8 __NSFireDelayedPerform + 304 9 __CFRunLoopDoTimer + 184 55655 1 10588 sam 2006-09-16 07:27:46 -0700 Created attachment 10588 patch 55656 2 10588 sam 2006-09-16 07:29:15 -0700 Comment on attachment 10588 patch oops, thats not right 55657 3 10589 sam 2006-09-16 07:33:26 -0700 Created attachment 10589 patch without the type 55661 4 mitz 2006-09-16 07:52:49 -0700 *** Bug 10888 has been marked as a duplicate of this bug. *** 55663 5 10589 andersca 2006-09-16 08:00:53 -0700 Comment on attachment 10589 patch without the type Could you file a new bug about the incorrect behavior and reference the url in the FIXME comment? Otherwise r=me 55665 6 sam 2006-09-16 08:05:06 -0700 Landed in r16391. 10588 2006-09-16 07:27:46 -0700 2006-09-16 07:29:15 -0700 patch autoDOMNodeFix.diff text/plain 2389 sam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNjM5MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDYtMDktMTYgIFNhbSBXZWluaWcgIDxzYW0ud2VpbmlnQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXggZm9yIGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4 ODYKKyAgICAgICAgUkVHUkVTU0lPTiAocjE2Mzg3KTogUmVwcm9kdWNpYmxlIGNyYXNoIHdoZW4g bW91c2luZyBvdmVyIEhUTUwgZG9jdW1lbnQKKworICAgICAgICAtIFNwZWNpYWwgY2FzZSBtZXRo b2QgW0RPTU5vZGUgb3duZXJEb2N1bWVudF0gdG8gY2FsbCBkb2N1bWVudCgpIGluc3RlYWQKKyAg ICAgICAgICBvciBvd25lckRvY3VtZW50KCkgdG8gcmV0dXJuIHRvIHRoZSBvbGQgYmVoYXZpb3Iu IAorCisgICAgICAgICogV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOgorICAgICAg ICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvck9iakMucG06CisKIDIwMDYtMDktMTUg IEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFRpbSBIYXRjaGVyCkluZGV4OiBXZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4 cHJvago9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4 cHJvagkocmV2aXNpb24gMTYzOTApCisrKyBXZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3Byb2pl Y3QucGJ4cHJvagkod29ya2luZyBjb3B5KQpAQCAtODQyMSw3ICs4NDIxLDYgQEAKIAkJMDg2N0Q2 OTBGRTg0MDI4RkMwMkFBQzA3IC8qIFByb2plY3Qgb2JqZWN0ICovID0gewogCQkJaXNhID0gUEJY UHJvamVjdDsKIAkJCWJ1aWxkQ29uZmlndXJhdGlvbkxpc3QgPSAxNDlDMjg0MzA4OTAyQjExMDA4 QTlFRkMgLyogQnVpbGQgY29uZmlndXJhdGlvbiBsaXN0IGZvciBQQlhQcm9qZWN0ICJXZWJDb3Jl IiAqLzsKLQkJCWNvbXBhdGliaWxpdHlWZXJzaW9uID0gIlhjb2RlIDIuNCI7CiAJCQloYXNTY2Fu bmVkRm9yRW5jb2RpbmdzID0gMTsKIAkJCWtub3duUmVnaW9ucyA9ICgKIAkJCQlFbmdsaXNoLApA QCAtODQzNiw3ICs4NDM1LDYgQEAKIAkJCXByb2R1Y3RSZWZHcm91cCA9IDAzNDc2OERGRkYzOEE1 MDQxMURCOUM4QiAvKiBQcm9kdWN0cyAqLzsKIAkJCXByb2plY3REaXJQYXRoID0gIiI7CiAJCQlw cm9qZWN0Um9vdCA9ICIiOwotCQkJc2hvdWxkQ2hlY2tDb21wYXRpYmlsaXR5ID0gMTsKIAkJCXRh cmdldHMgPSAoCiAJCQkJOTNGMTk4QTUwODI0NUU1OTAwMUU5QUJDIC8qIFdlYkNvcmUgKi8sCiAJ CQkJREQwNDFGQkUwOUQ5RERCRTAwMTBBRjJBIC8qIERlcml2ZWQgU291cmNlcyAqLywKSW5kZXg6 IFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yT2JqQy5wbQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvck9iakMucG0JKHJldmlz aW9uIDE2MzkwKQorKysgV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JPYmpD LnBtCSh3b3JraW5nIGNvcHkpCkBAIC03NDQsNiArNzQ0LDEwIEBAIHN1YiBHZW5lcmF0ZUltcGxl bWVudGF0aW9uCiAgICAgICAgICAgICB9IGVsc2lmICgkYXR0cmlidXRlTmFtZSBlcSAiZnJhbWUi KSB7CiAgICAgICAgICAgICAgICAgIyBTcGVjaWFsIGNhc2UgYXR0cmlidXRlIGZyYW1lIHRvIGJl IGZyYW1lQm9yZGVycy4KICAgICAgICAgICAgICAgICAkYXR0cmlidXRlSW50ZXJmYWNlTmFtZSAu PSAiQm9yZGVycyI7CisgICAgICAgICAgICB9IGVsc2lmICgkYXR0cmlidXRlTmFtZSBlcSAib3du ZWREb2N1bWVudCIpIHsKKyAgICAgICAgICAgICAgICAjIEZJWE1FOiBmb3Igbm93IHNwZWNpYWwg Y2FzZSBhdHRyaWJ1dGUgb3duZXJEb2N1bWVudCB0byBjYWxsIGRvY3VtZW50LCB0aGlzIGlzIGlu Y29ycmVjdAorICAgICAgICAgICAgICAgICMgbGVnYWN5IGJlaGF2aW9yLgorICAgICAgICAgICAg ICAgICRhdHRyaWJ1dGVOYW1lID0gImRvY3VtZW50IjsKICAgICAgICAgICAgIH0KIAogICAgICAg ICAgICAgJGF0dHJpYnV0ZU5hbWVzeyRhdHRyaWJ1dGVJbnRlcmZhY2VOYW1lfSA9IDE7Cg== 10589 2006-09-16 07:33:26 -0700 2006-09-16 08:00:53 -0700 patch without the type autoDOMNodeFix.diff text/plain 2389 sam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNjM5MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDYtMDktMTYgIFNhbSBXZWluaWcgIDxzYW0ud2VpbmlnQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXggZm9yIGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4 ODYKKyAgICAgICAgUkVHUkVTU0lPTiAocjE2Mzg3KTogUmVwcm9kdWNpYmxlIGNyYXNoIHdoZW4g bW91c2luZyBvdmVyIEhUTUwgZG9jdW1lbnQKKworICAgICAgICAtIFNwZWNpYWwgY2FzZSBtZXRo b2QgW0RPTU5vZGUgb3duZXJEb2N1bWVudF0gdG8gY2FsbCBkb2N1bWVudCgpIGluc3RlYWQKKyAg ICAgICAgICBvciBvd25lckRvY3VtZW50KCkgdG8gcmV0dXJuIHRvIHRoZSBvbGQgYmVoYXZpb3Iu IAorCisgICAgICAgICogV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOgorICAgICAg ICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvck9iakMucG06CisKIDIwMDYtMDktMTUg IEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFRpbSBIYXRjaGVyCkluZGV4OiBXZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4 cHJvago9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4 cHJvagkocmV2aXNpb24gMTYzOTApCisrKyBXZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3Byb2pl Y3QucGJ4cHJvagkod29ya2luZyBjb3B5KQpAQCAtODQyMSw3ICs4NDIxLDYgQEAKIAkJMDg2N0Q2 OTBGRTg0MDI4RkMwMkFBQzA3IC8qIFByb2plY3Qgb2JqZWN0ICovID0gewogCQkJaXNhID0gUEJY UHJvamVjdDsKIAkJCWJ1aWxkQ29uZmlndXJhdGlvbkxpc3QgPSAxNDlDMjg0MzA4OTAyQjExMDA4 QTlFRkMgLyogQnVpbGQgY29uZmlndXJhdGlvbiBsaXN0IGZvciBQQlhQcm9qZWN0ICJXZWJDb3Jl IiAqLzsKLQkJCWNvbXBhdGliaWxpdHlWZXJzaW9uID0gIlhjb2RlIDIuNCI7CiAJCQloYXNTY2Fu bmVkRm9yRW5jb2RpbmdzID0gMTsKIAkJCWtub3duUmVnaW9ucyA9ICgKIAkJCQlFbmdsaXNoLApA QCAtODQzNiw3ICs4NDM1LDYgQEAKIAkJCXByb2R1Y3RSZWZHcm91cCA9IDAzNDc2OERGRkYzOEE1 MDQxMURCOUM4QiAvKiBQcm9kdWN0cyAqLzsKIAkJCXByb2plY3REaXJQYXRoID0gIiI7CiAJCQlw cm9qZWN0Um9vdCA9ICIiOwotCQkJc2hvdWxkQ2hlY2tDb21wYXRpYmlsaXR5ID0gMTsKIAkJCXRh cmdldHMgPSAoCiAJCQkJOTNGMTk4QTUwODI0NUU1OTAwMUU5QUJDIC8qIFdlYkNvcmUgKi8sCiAJ CQkJREQwNDFGQkUwOUQ5RERCRTAwMTBBRjJBIC8qIERlcml2ZWQgU291cmNlcyAqLywKSW5kZXg6 IFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yT2JqQy5wbQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvck9iakMucG0JKHJldmlz aW9uIDE2MzkwKQorKysgV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JPYmpD LnBtCSh3b3JraW5nIGNvcHkpCkBAIC03NDQsNiArNzQ0LDEwIEBAIHN1YiBHZW5lcmF0ZUltcGxl bWVudGF0aW9uCiAgICAgICAgICAgICB9IGVsc2lmICgkYXR0cmlidXRlTmFtZSBlcSAiZnJhbWUi KSB7CiAgICAgICAgICAgICAgICAgIyBTcGVjaWFsIGNhc2UgYXR0cmlidXRlIGZyYW1lIHRvIGJl IGZyYW1lQm9yZGVycy4KICAgICAgICAgICAgICAgICAkYXR0cmlidXRlSW50ZXJmYWNlTmFtZSAu PSAiQm9yZGVycyI7CisgICAgICAgICAgICB9IGVsc2lmICgkYXR0cmlidXRlTmFtZSBlcSAib3du ZXJEb2N1bWVudCIpIHsKKyAgICAgICAgICAgICAgICAjIEZJWE1FOiBmb3Igbm93IHNwZWNpYWwg Y2FzZSBhdHRyaWJ1dGUgb3duZXJEb2N1bWVudCB0byBjYWxsIGRvY3VtZW50LCB0aGlzIGlzIGlu Y29ycmVjdAorICAgICAgICAgICAgICAgICMgbGVnYWN5IGJlaGF2aW9yLgorICAgICAgICAgICAg ICAgICRhdHRyaWJ1dGVOYW1lID0gImRvY3VtZW50IjsKICAgICAgICAgICAgIH0KIAogICAgICAg ICAgICAgJGF0dHJpYnV0ZU5hbWVzeyRhdHRyaWJ1dGVJbnRlcmZhY2VOYW1lfSA9IDE7Cg==