108856 2013-02-04 13:56:32 -0800 Allow TextTracks to be marked as closed captions 2013-02-04 18:03:29 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino eric.carlson ojan.autocc webkit-bug-importer webkit.review.bot oldest_to_newest 824726 0 dino 2013-02-04 13:56:32 -0800 While this isn't exposed directly in markup, some platform media frameworks can provide indication that a caption track is a closed caption. Expose such a flag on TextTrack and platforms can show a different UI if they want to. 824728 1 webkit-bug-importer 2013-02-04 13:56:53 -0800 <rdar://problem/13147063> 824734 2 186455 dino 2013-02-04 14:00:28 -0800 Created attachment 186455 Patch 824753 3 186455 darin 2013-02-04 14:14:44 -0800 Comment on attachment 186455 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186455&action=review A little strange to land just the patch that adds the data, but OK if you will follow up soon. > Source/WebCore/html/track/TextTrack.cpp:110 > + , m_closedCaption(false) Should be named m_isClosedCaption. > Source/WebCore/html/track/TextTrack.h:113 > + void setIsClosedCaption(bool c) { m_closedCaption = c; } I’d name the local variable “isClosedCaption” rather than c. 824978 4 dino 2013-02-04 18:03:29 -0800 Committed r141840: <http://trac.webkit.org/changeset/141840> 186455 2013-02-04 14:00:28 -0800 2013-02-04 14:14:44 -0800 Patch bug-108856-20130205085707.patch text/plain 2535 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNzk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzlkYzBjMTZlMmU4MWVl MTgwN2M4NDNiYzZlZmVkNzI0MDMzMTY0Ni4uMTI1OTcxOTJlYjcyNzg5ZWMwZDMyMmJhNGRiYzE4 MTg0MWVkYzMwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAyLTA0ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBBbGxvdyBUZXh0VHJhY2tzIHRv IGJlIG1hcmtlZCBhcyBjbG9zZWQgY2FwdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODg1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdoaWxlIHRoaXMgaXNuJ3QgZXhwb3NlZCBkaXJlY3RseSBp biBtYXJrdXAsIHNvbWUgcGxhdGZvcm0gbWVkaWEgZnJhbWV3b3JrcyBjYW4KKyAgICAgICAgcHJv dmlkZSBpbmRpY2F0aW9uIHRoYXQgYSBjYXB0aW9uIHRyYWNrIGlzIGEgY2xvc2VkIGNhcHRpb24u IEV4cG9zZSBzdWNoIGEgZmxhZworICAgICAgICBvbiBUZXh0VHJhY2sgYW5kIHBsYXRmb3JtcyBj YW4gc2hvdyBhIGRpZmZlcmVudCBVSSBpZiB0aGV5IHdhbnQgdG8uCisKKyAgICAgICAgTm8gdGVz dHMgLSB0aGlzIGlzbid0IHVzZWQgZWxzZXdoZXJlIHlldCwgbm9yIGV4cG9zZWQgdG8gdGhlIERP TS4KKworICAgICAgICAqIGh0bWwvdHJhY2svVGV4dFRyYWNrLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlRleHRUcmFjazo6VGV4dFRyYWNrKTogSW5pdGlhbGlzZSBuZXcgbWVtYmVyLgorICAgICAg ICAqIGh0bWwvdHJhY2svVGV4dFRyYWNrLmg6CisgICAgICAgIChXZWJDb3JlOjpUZXh0VHJhY2s6 OmlzQ2xvc2VkQ2FwdGlvbik6IE5ldyBtZW1iZXIgdmFyaWFibGUuCisgICAgICAgIChXZWJDb3Jl OjpUZXh0VHJhY2s6OnNldElzQ2xvc2VkQ2FwdGlvbik6CisKIDIwMTMtMDItMDQgIERpbWEgR29y YmlrICA8ZGdvcmJpa0BhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZXQgOmxhbmcoKSBwc2V1 ZG8gY2xhc3Mgc3VwcG9ydCBmb3IgdGhlIFdlYlZUVCA6OmN1ZSBwc2V1ZG8gZWxlbWVudApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9UZXh0VHJhY2suY3BwIGIvU291cmNl L1dlYkNvcmUvaHRtbC90cmFjay9UZXh0VHJhY2suY3BwCmluZGV4IDg5YzE2ZDU3ZDlmNWMxNzlm ZDE1ZThmZjI5OGM3Njc1MTg1NTlhMTUuLjdkNDQzMWMxNmU5MTU5NWQwMWQ5YjQ5YzY2YzhmNzM1 YjA5NTg1ZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svVGV4dFRyYWNr LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1RleHRUcmFjay5jcHAKQEAgLTEw Nyw2ICsxMDcsNyBAQCBUZXh0VHJhY2s6OlRleHRUcmFjayhTY3JpcHRFeGVjdXRpb25Db250ZXh0 KiBjb250ZXh0LCBUZXh0VHJhY2tDbGllbnQqIGNsaWVudCwgYwogICAgICwgbV90cmFja0luZGV4 KGludmFsaWRUcmFja0luZGV4KQogICAgICwgbV9yZW5kZXJlZFRyYWNrSW5kZXgoaW52YWxpZFRy YWNrSW5kZXgpCiAgICAgLCBtX2hhc0JlZW5Db25maWd1cmVkKGZhbHNlKQorICAgICwgbV9jbG9z ZWRDYXB0aW9uKGZhbHNlKQogewogICAgIHNldEtpbmQoa2luZCk7CiB9CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1RleHRUcmFjay5oIGIvU291cmNlL1dlYkNvcmUvaHRt bC90cmFjay9UZXh0VHJhY2suaAppbmRleCAzN2U3NTNjYzhjYTRhMWIyZGZmZGNlNWMwOTY4ZGY1 ODMwMjc5NzdmLi43NTBkMzk2MzBhYWU0NzEwMzk4ZjY5YWIwYTYwMzY1NDMzNjU1M2YwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1RleHRUcmFjay5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvdHJhY2svVGV4dFRyYWNrLmgKQEAgLTEwOSw2ICsxMDksOSBAQCBwdWJs aWM6CiAgICAgZW51bSBUZXh0VHJhY2tUeXBlIHsgVHJhY2tFbGVtZW50LCBBZGRUcmFjaywgSW5C YW5kIH07CiAgICAgVGV4dFRyYWNrVHlwZSB0cmFja1R5cGUoKSBjb25zdCB7IHJldHVybiBtX3Ry YWNrVHlwZTsgfQogCisgICAgYm9vbCBpc0Nsb3NlZENhcHRpb24oKSBjb25zdCB7IHJldHVybiBt X2Nsb3NlZENhcHRpb247IH0KKyAgICB2b2lkIHNldElzQ2xvc2VkQ2FwdGlvbihib29sIGMpIHsg bV9jbG9zZWRDYXB0aW9uID0gYzsgfQorCiAgICAgaW50IHRyYWNrSW5kZXgoKTsKICAgICB2b2lk IGludmFsaWRhdGVUcmFja0luZGV4KCk7CiAKQEAgLTE0MSw2ICsxNDQsNyBAQCBwcml2YXRlOgog ICAgIGludCBtX3RyYWNrSW5kZXg7CiAgICAgaW50IG1fcmVuZGVyZWRUcmFja0luZGV4OwogICAg IGJvb2wgbV9oYXNCZWVuQ29uZmlndXJlZDsKKyAgICBib29sIG1fY2xvc2VkQ2FwdGlvbjsKIH07 CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK