<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>108855</bug_id>
          
          <creation_ts>2013-02-04 13:31:28 -0800</creation_ts>
          <short_desc>[WK2] CoordinatedGraphicsLayerState is a struct, not a class</short_desc>
          <delta_ts>2013-04-25 21:42:35 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Bruno Abinader (history only)">bruno.abinader</reporter>
          <assigned_to name="Bruno Abinader (history only)">bruno.abinader</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>noam</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>zeno</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>824702</commentid>
    <comment_count>0</comment_count>
    <who name="Bruno Abinader (history only)">bruno.abinader</who>
    <bug_when>2013-02-04 13:31:28 -0800</bug_when>
    <thetext>Some forward declarations of CoordinatedLayerInfo were stating it is a class, but in fact it is a struct.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>824707</commentid>
    <comment_count>1</comment_count>
      <attachid>186449</attachid>
    <who name="Bruno Abinader (history only)">bruno.abinader</who>
    <bug_when>2013-02-04 13:34:34 -0800</bug_when>
    <thetext>Created attachment 186449
Patch

Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>824715</commentid>
    <comment_count>2</comment_count>
      <attachid>186449</attachid>
    <who name="Noam Rosenthal">noam</who>
    <bug_when>2013-02-04 13:45:46 -0800</bug_when>
    <thetext>Comment on attachment 186449
Patch

Since this is trivial I take the liberty to r+ it :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>824747</commentid>
    <comment_count>3</comment_count>
      <attachid>186449</attachid>
    <who name="Noam Rosenthal">noam</who>
    <bug_when>2013-02-04 14:07:54 -0800</bug_when>
    <thetext>Comment on attachment 186449
Patch

Clearing r+, since apparently it&apos;s not ok to r+ trivial patches anymore.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>877855</commentid>
    <comment_count>4</comment_count>
      <attachid>186449</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2013-04-18 06:09:13 -0700</bug_when>
    <thetext>Comment on attachment 186449
Patch

rs=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>877860</commentid>
    <comment_count>5</comment_count>
    <who name="Bruno Abinader (history only)">bruno.abinader</who>
    <bug_when>2013-04-18 06:33:07 -0700</bug_when>
    <thetext>CoordinatedLayerInfo has changed to CoordinatedGraphicsLayerState in r144787, but the forward declaration issue is still valid. I&apos;m rebasing the patch for landing atm.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>877865</commentid>
    <comment_count>6</comment_count>
      <attachid>198730</attachid>
    <who name="Bruno Abinader (history only)">bruno.abinader</who>
    <bug_when>2013-04-18 06:37:39 -0700</bug_when>
    <thetext>Created attachment 198730
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>877879</commentid>
    <comment_count>7</comment_count>
      <attachid>198730</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-04-18 07:06:50 -0700</bug_when>
    <thetext>Comment on attachment 198730
Patch for landing

Clearing flags on attachment: 198730

Committed r148674: &lt;http://trac.webkit.org/changeset/148674&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>881677</commentid>
    <comment_count>8</comment_count>
    <who name="Bruno Abinader (history only)">bruno.abinader</who>
    <bug_when>2013-04-25 21:42:35 -0700</bug_when>
    <thetext>All reviewed patches have been landed. Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>186449</attachid>
            <date>2013-02-04 13:34:34 -0800</date>
            <delta_ts>2013-04-18 06:09:13 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-108855-20130204173112.patch</filename>
            <type>text/plain</type>
            <size>2894</size>
            <attacher name="Bruno Abinader (history only)">bruno.abinader</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjhiODg0MGI3MjI4NDM0
YjA3ODUxNTQ3YjQ3YzM3MDc3NjEwOTIxMC4uZDUwYzdhZjM2YjZkYjM4ZjEwNzA1MTJlNjcyMGYz
MjM4MTY3ZDMwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAyLTA0ICBCcnVu
byBkZSBPbGl2ZWlyYSBBYmluYWRlciAgPGJydW5vLmFiaW5hZGVyQGJhc3lza29tLmNvbT4KKwor
ICAgICAgICBbV0syXSBDb29yZGluYXRlZExheWVySW5mbyBpcyBhIHN0cnVjdCwgbm90IGEgY2xh
c3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODg1
NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVz
IHRoZSBmb3J3YXJkIGRlY2xhcmF0aW9ucyB3aGljaCB3ZXJlIG1pc3Rha2VubHkgZGVjbGFyaW5n
CisgICAgICAgIENvb3JkaW5hdGVkTGF5ZXJJbmZvIGFzIGEgY2xhc3MuCisKKyAgICAgICAgKiBw
bGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc1Nj
ZW5lLmg6CisgICAgICAgIChXZWJDb3JlKToKKwogMjAxMy0wMi0wNCAgRGF2aWQgS2lsemVyICA8
ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBkdXBsaWNhdGUgZW50cnkgZnJv
bSBXZWJDb3JlIFhjb2RlIHByb2plY3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA2YjJhNjYxZGUzNTRhNzZkN2Vj
ZWI0NjAzZTkzZjlmY2Q0Zjc0N2JkLi41YjIzMWI0N2RlNGRlOTAyYTE5OGIxM2M0OWRmMmZhOWJh
NjRmOGM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNl
L1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDItMDQgIEJydW5vIGRl
IE9saXZlaXJhIEFiaW5hZGVyICA8YnJ1bm8uYWJpbmFkZXJAYmFzeXNrb20uY29tPgorCisgICAg
ICAgIFtXSzJdIENvb3JkaW5hdGVkTGF5ZXJJbmZvIGlzIGEgc3RydWN0LCBub3QgYSBjbGFzcwor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4ODU1CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXMgdGhl
IGZvcndhcmQgZGVjbGFyYXRpb25zIHdoaWNoIHdlcmUgbWlzdGFrZW5seSBkZWNsYXJpbmcKKyAg
ICAgICAgQ29vcmRpbmF0ZWRMYXllckluZm8gYXMgYSBjbGFzcy4KKworICAgICAgICAqIFVJUHJv
Y2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdFByb3h5Lmg6
CisgICAgICAgIChXZWJDb3JlKToKKwogMjAxMy0wMi0wNCAgRGF2aWQgS2lsemVyICA8ZGRraWx6
ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFNvcnQgV2ViS2l0MiBYY29kZSBwcm9qZWN0IGZpbGUK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29y
ZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzU2NlbmUuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzU2NlbmUu
aAppbmRleCBjZmFiMTY2MmQxYWM1YzQyM2ZkNTAxMGIwMWNkN2U0MDYzNjkzMzgzLi43MjM0N2I0
ZDBiMjdlZmI2YTM5OGJiODcyYTZmNzU5NzQ0ZGY1Zjc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi
Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFw
aGljc1NjZW5lLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFw
L2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZS5oCkBAIC00MSwxMCArNDEsMTAg
QEAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgQ29vcmRpbmF0ZWRCYWNraW5nU3RvcmU7
Ci1jbGFzcyBDb29yZGluYXRlZExheWVySW5mbzsKIGNsYXNzIEN1c3RvbUZpbHRlclByb2dyYW07
CiBjbGFzcyBDdXN0b21GaWx0ZXJQcm9ncmFtSW5mbzsKIGNsYXNzIFRleHR1cmVNYXBwZXJMYXll
cjsKK3N0cnVjdCBDb29yZGluYXRlZExheWVySW5mbzsKIAogY2xhc3MgQ29vcmRpbmF0ZWRHcmFw
aGljc1NjZW5lQ2xpZW50IHsKIHB1YmxpYzoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ
UHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdFByb3h5
LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGlu
YXRlZExheWVyVHJlZUhvc3RQcm94eS5oCmluZGV4IDI0YjM0NzcwYWMwODNjMzVhNTU0MDMwNGUw
OTBhMDUyNThlZjU3YWQuLjk1MDg2NzE1NGE1M2Q1OTY1YmQwYjM2N2JiMzIwYWRmNThmMGUxZDIg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNz
L0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdFByb3h5LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQ
cm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0UHJveHku
aApAQCAtNDEsNyArNDEsNyBAQAogI2luY2x1ZGUgPHd0Zi9WZWN0b3IuaD4KIAogbmFtZXNwYWNl
IFdlYkNvcmUgewotY2xhc3MgQ29vcmRpbmF0ZWRMYXllckluZm87CitzdHJ1Y3QgQ29vcmRpbmF0
ZWRMYXllckluZm87CiBjbGFzcyBTdXJmYWNlVXBkYXRlSW5mbzsKIH0KIAo=
</data>
<flag name="review"
          id="205892"
          type_id="1"
          status="+"
          setter="kling"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>198730</attachid>
            <date>2013-04-18 06:37:39 -0700</date>
            <delta_ts>2013-04-18 07:06:50 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-108855-20130418093708.patch</filename>
            <type>text/plain</type>
            <size>1476</size>
            <attacher name="Bruno Abinader (history only)">bruno.abinader</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NjcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzE0NTBmYjM2ZmJhZjk1
ZmFiYzQ1NjQ4M2I5YmQyZGQwYmRmOTdkNi4uYmNmNjIwZjAwNDM0Zjg4ZGE0MWJmNzdjOGM2MDAy
ODRmMzI4ZjRiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA0LTE4ICBCcnVu
byBkZSBPbGl2ZWlyYSBBYmluYWRlciAgPGJydW5vLmFiaW5hZGVyQGJhc3lza29tLmNvbT4KKwor
ICAgICAgICBbV0syXSBDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXJTdGF0ZSBpcyBhIHN0cnVjdCwg
bm90IGEgY2xhc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTEwODg1NQorCisgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCisKKyAgICAg
ICAgRml4ZXMgdGhlIGZvcndhcmQgZGVjbGFyYXRpb24gd2hpY2ggdGFrZXMgQ29vcmRpbmF0ZWRH
cmFwaGljc0xheWVyU3RhdGUKKyAgICAgICAgYXMgYSBjbGFzcy4KKworICAgICAgICAqIFVJUHJv
Y2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdFByb3h5Lmg6
CisgICAgICAgIChXZWJDb3JlKToKKwogMjAxMy0wNC0xOCAgS3J6eXN6dG9mIFdvbGFuc2tpICA8
ay53b2xhbnNraUBzYW1zdW5nLmNvbT46CiAKICAgICAgICAgW0VGTF1bV0syXSBDaGFuZ2UgaW5h
ZGVxdWF0ZSByZXR1cm4gdmFsdWUgaW4gbWV0aG9kIHNldERvbmUoKS4KZGlmZiAtLWdpdCBhL1Nv
dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5
ZXJUcmVlSG9zdFByb3h5LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRH
cmFwaGljcy9Db29yZGluYXRlZExheWVyVHJlZUhvc3RQcm94eS5oCmluZGV4IDQ0ODZhMGYyZWQ2
ZmEwYWM1YzMyNGI0OTMwZTBlMGEyMzk1YTRmZGEuLjVkZGE1YzQwMzExYmU0ZWE4ZWY0NWYyYzE4
ZTlhZTZhZTI1NmQxZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29y
ZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdFByb3h5LmgKKysrIGIvU291
cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXll
clRyZWVIb3N0UHJveHkuaApAQCAtNDEsNyArNDEsNyBAQAogI2luY2x1ZGUgPHd0Zi9WZWN0b3Iu
aD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewotY2xhc3MgQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVy
U3RhdGU7CitzdHJ1Y3QgQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyU3RhdGU7CiBjbGFzcyBDb29y
ZGluYXRlZEdyYXBoaWNzU3RhdGU7CiBjbGFzcyBTdXJmYWNlVXBkYXRlSW5mbzsKIH0K
</data>

          </attachment>
      

    </bug>

</bugzilla>