108848 2013-02-04 12:26:55 -0800 Disable autoscrolling the main frame if main frame scrolling is disabled 2013-02-04 14:10:01 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton bdakin eric ojan.autocc sam simon.fraser webkit.review.bot oldest_to_newest 824645 0 thorton 2013-02-04 12:26:55 -0800 If main frame scrolling is disabled, you can still cause the main frame to scroll via autoscrolling (drag selection, etc.). This seems wrong. <rdar://problem/13004059> 824646 1 186435 thorton 2013-02-04 12:28:19 -0800 Created attachment 186435 patch 824652 2 thorton 2013-02-04 12:32:17 -0800 http://trac.webkit.org/changeset/141792 824684 3 186435 darin 2013-02-04 13:13:39 -0800 Comment on attachment 186435 patch View in context: https://bugs.webkit.org/attachment.cgi?id=186435&action=review > Source/WebCore/rendering/RenderBox.cpp:755 > + return page && page->mainFrame() == frame && frame->view()->isScrollable(); Can frame->view() ever be null? Can frame->view() every be a view that is currently hosting a different frame? 824749 4 thorton 2013-02-04 14:10:01 -0800 (In reply to comment #3) > (From update of attachment 186435 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=186435&action=review > > > Source/WebCore/rendering/RenderBox.cpp:755 > > + return page && page->mainFrame() == frame && frame->view()->isScrollable(); > > Can frame->view() ever be null? Can frame->view() every be a view that is currently hosting a different frame? I don't think either of those things can be true while we're also dispatching events to the page (I just followed all of the callers and that's the only way we get here), though I could be wrong. That seems scary for other reasons, though. 186435 2013-02-04 12:28:19 -0800 2013-02-04 13:13:39 -0800 patch autoscroll.diff text/plain 1285 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4MWJiZDQ1Li40Nzk1MGIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDItMDQgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgRGlzYWJsZSBhdXRvc2Nyb2xsaW5nIHRoZSBtYWluIGZyYW1lIGlmIG1haW4gZnJh bWUgc2Nyb2xsaW5nIGlzIGRpc2FibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMDg4NDgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEzMDA0MDU5 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuc3Vy ZSB0aGF0IHRoZSBtYWluIGZyYW1lIGNhbiBzY3JvbGwgYXQgYWxsIGJlZm9yZSBhbGxvd2luZyBh biBhdXRvc2Nyb2xsLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJveC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJCb3g6OmNhbkF1dG9zY3JvbGwpOgorCiAyMDEzLTAyLTA0ICBK dWxpZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgogCiAgICAgICAgIFtDU1Mg R3JpZCBMYXlvdXRdIEFkZCBwYXJzaW5nIGZvciBncmlkLWF1dG8tZmxvdwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQm94LmNwcAppbmRleCBmZmJhOTE1Li41ZDI1ZTA4IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcApAQCAtNzUyLDcgKzc1Miw3IEBAIGJvb2wgUmVu ZGVyQm94OjpjYW5BdXRvc2Nyb2xsKCkgY29uc3QKICAgICBpZiAoIWZyYW1lKQogICAgICAgICBy ZXR1cm4gZmFsc2U7CiAgICAgUGFnZSogcGFnZSA9IGZyYW1lLT5wYWdlKCk7Ci0gICAgcmV0dXJu IHBhZ2UgJiYgcGFnZS0+bWFpbkZyYW1lKCkgPT0gZnJhbWU7CisgICAgcmV0dXJuIHBhZ2UgJiYg cGFnZS0+bWFpbkZyYW1lKCkgPT0gZnJhbWUgJiYgZnJhbWUtPnZpZXcoKS0+aXNTY3JvbGxhYmxl KCk7CiB9CiAKIC8vIElmIHNwZWNpZmllZCBwb2ludCBpcyBpbiBib3JkZXIgYmVsdCwgcmV0dXJu ZWQgb2Zmc2V0IGRlbm90ZXMgZGlyZWN0aW9uIG9mCg==