108846 2013-02-04 12:15:42 -0800 Web Inspector: Test bad options to evaluate and ensure the errors are returned 2014-12-13 13:47:50 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED INVALID P2 Normal --- 106811 0 johnjbarton webkit-unassigned apavlov buildbot burg caseq keishi loislo pfeldman pmuellr rniwa vsevik web-inspector-bugs yurys oldest_to_newest 824635 0 johnjbarton 2013-02-04 12:15:42 -0800 The current tests do not test for the case where useContentScriptContext is set true by the developer but there is no security origin matching content script context. When such a test is added, it becomes apparent that the error for option processing are not returned to the client of evaluate(). Patch ready 824637 1 johnjbarton 2013-02-04 12:16:38 -0800 The bad-option test on the patch for bug 106811 cannot pass without a fix to this bug. 824647 2 186436 johnjbarton 2013-02-04 12:28:54 -0800 Created attachment 186436 Patch 824739 3 186436 buildbot 2013-02-04 14:03:03 -0800 Comment on attachment 186436 Patch Attachment 186436 did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16365456 New failing tests: inspector/extensions/extensions-eval-content-script-bad-option.html 824891 4 186436 buildbot 2013-02-04 16:42:23 -0800 Comment on attachment 186436 Patch Attachment 186436 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16366508 New failing tests: inspector/extensions/extensions-eval-content-script-bad-option.html 824894 5 186436 buildbot 2013-02-04 16:47:23 -0800 Comment on attachment 186436 Patch Attachment 186436 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16366511 New failing tests: inspector/extensions/extensions-eval-content-script-bad-option.html 829508 6 186436 caseq 2013-02-11 01:51:07 -0800 Comment on attachment 186436 Patch I don't think we should invoke the callback wrapper passing it the text error message. Besides, returning value from the message handler already results in dispatching the error to the client. See also bug 108640. 829509 7 186436 vsevik 2013-02-11 01:52:51 -0800 Comment on attachment 186436 Patch r- per Andrey's comment. 186436 2013-02-04 12:28:54 -0800 2013-02-11 01:52:51 -0800 Patch bug-108846-20130204122533.patch text/plain 5374 johnjbarton U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2UyMzQxMzljMjY2OGM5 M2U1MWRhZDk1YmRkOGM4ZGI0ZmJkNjAwMy4uZGNiMDVkYzg1MTEwMmI3N2ViNTYyMjMxNjIxYjQw NjhhNmYwNGY2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTA0ICBKb2hu IEouIEJhcnRvbiAgPGpvaG5qYmFydG9uQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBUZXN0IGJhZCBvcHRpb25zIHRvIGV2YWx1YXRlIGFuZCBlbnN1cmUgdGhlIGVycm9y cyBhcmUgcmV0dXJuZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwODg0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFNpbmNlIGV2YWx1YXRlKCkgcmV0dXJuIGVycm9ycyByYXRoZXIgdGhhbiB1c2luZyB0 aGUgY2FsbGJhY2ssIHRoZSBjYWxsZXIKKyAgICAgICAgbXVzdCBjaGVjayB0aGUgc3RhdHVzIG9m IHRoZSByZXR1cm4gdmFsdWUgYW5kIHNlbmQgaXQgYXMgYW4gZXJyb3IgdG8gdGhlCisgICAgICAg IGNhbGxiYWNrLgorCisgICAgICAgIFRlc3Q6IGluc3BlY3Rvci9leHRlbnNpb25zL2V4dGVuc2lv bnMtZXZhbC1jb250ZW50LXNjcmlwdC1iYWQtb3B0aW9uLmh0bWwKKworICAgICAgICAqIGluc3Bl Y3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9uU2VydmVyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9y LkV4dGVuc2lvblNlcnZlci5wcm90b3R5cGUuX29uRXZhbHVhdGVPbkluc3BlY3RlZFBhZ2UpOgor CiAyMDEzLTAyLTA0ICBEb21pbmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRl bC5jb20+CiAKICAgICAgICAgW1NraWFdIEFyZ3VtZW50IHRvIEhhcmZCdXp6U2hhcGVyOjpvZmZz ZXRGb3JQb3NpdGlvbiB1bm5lY2Vzc2FyaWx5IHRydW5jYXRlZApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25TZXJ2ZXIuanMgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvblNlcnZlci5qcwppbmRleCBjMTE2 MWJlMjhkMTY4ZDQ0NjE4M2Y3NTFhNWJjOWU0MjIyOWI5NjRiLi40NTgyMmY1NTViMDcyZDdkZTcx MGEwNWIzMTZlMzQ2ZjMzNTExMDY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL0V4dGVuc2lvblNlcnZlci5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvblNlcnZlci5qcwpAQCAtMzI0LDggKzMyNCw4IEBAIFdl Ykluc3BlY3Rvci5FeHRlbnNpb25TZXJ2ZXIucHJvdG90eXBlID0gewogICAgIHsKICAgICAgICAg LyoqCiAgICAgICAgICAqIEBwYXJhbSB7P1Byb3RvY29sLkVycm9yfSBlcnJvcgotICAgICAgICAg KiBAcGFyYW0ge1J1bnRpbWVBZ2VudC5SZW1vdGVPYmplY3R9IHJlc3VsdFBheWxvYWQKLSAgICAg ICAgICogQHBhcmFtIHtib29sZWFuPX0gd2FzVGhyb3duCisgICAgICAgICAqIEBwYXJhbSB7UnVu dGltZUFnZW50LlJlbW90ZU9iamVjdH0gW3Jlc3VsdFBheWxvYWRdCisgICAgICAgICAqIEBwYXJh bSB7Ym9vbGVhbj19IFt3YXNUaHJvd25dCiAgICAgICAgICAqLwogICAgICAgICBmdW5jdGlvbiBj YWxsYmFjayhlcnJvciwgcmVzdWx0UGF5bG9hZCwgd2FzVGhyb3duKQogICAgICAgICB7CkBAIC0z NDIsNyArMzQyLDEwIEBAIFdlYkluc3BlY3Rvci5FeHRlbnNpb25TZXJ2ZXIucHJvdG90eXBlID0g ewogICAgICAgCiAgICAgICAgICAgICB0aGlzLl9kaXNwYXRjaENhbGxiYWNrKG1lc3NhZ2UucmVx dWVzdElkLCBwb3J0LCByZXN1bHQpOwogICAgICAgICB9Ci0gICAgICAgIHJldHVybiB0aGlzLmV2 YWx1YXRlKG1lc3NhZ2UuZXhwcmVzc2lvbiwgdHJ1ZSwgdHJ1ZSwgbWVzc2FnZS5ldmFsdWF0ZU9w dGlvbnMsIHBvcnQuX2V4dGVuc2lvbk9yaWdpbiwgY2FsbGJhY2suYmluZCh0aGlzKSk7CisgICAg ICAgIHZhciBzdGF0dXMgPSB0aGlzLmV2YWx1YXRlKG1lc3NhZ2UuZXhwcmVzc2lvbiwgdHJ1ZSwg dHJ1ZSwgbWVzc2FnZS5ldmFsdWF0ZU9wdGlvbnMsIHBvcnQuX2V4dGVuc2lvbk9yaWdpbiwgY2Fs bGJhY2suYmluZCh0aGlzKSk7CisgICAgICAgIGlmIChzdGF0dXMpIHsKKyAgICAgICAgICAgIGNh bGxiYWNrLmNhbGwodGhpcywgIkV4dGVuc2lvbiBzZXJ2ZXIgZXJyb3I6ICIgKyBTdHJpbmcudnNw cmludGYoc3RhdHVzLmRlc2NyaXB0aW9uLCBzdGF0dXMuZGV0YWlscykpOworICAgICAgICB9CiAg ICAgfSwKIAogICAgIF9vbkdldENvbnNvbGVNZXNzYWdlczogZnVuY3Rpb24oKQpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDVl MjIzMWU5NmY5MDQzNTlhOGQ3NDc5ZWZhYmQ4MTY1MTc0ZDhkMzAuLjUwZDM4OGRiMDUzZjAwNmE5 ODViNmU4NmY5YjJjZjgwMThiMjBmMTkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0wMi0w NCAgSm9obiBKLiBCYXJ0b24gIDxqb2huamJhcnRvbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAg V2ViIEluc3BlY3RvcjogVGVzdCBiYWQgb3B0aW9ucyB0byBldmFsdWF0ZSBhbmQgZW5zdXJlIHRo ZSBlcnJvcnMgYXJlIHJldHVybmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDg4NDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBIG5ldyB0ZXN0IGZvciBlcnJvciBwcm9wYWdhdGlvbiBmcm9tIEV4dGVu c2lvblNlcnZlciBldmFsdWF0ZSgpCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZXh0ZW5zaW9ucy9l eHRlbnNpb25zLWV2YWwtY29udGVudC1zY3JpcHQtYmFkLW9wdGlvbi1leHBlY3RlZC50eHQ6IEFk ZGVkLgorICAgICAgICAqIGluc3BlY3Rvci9leHRlbnNpb25zL2V4dGVuc2lvbnMtZXZhbC1jb250 ZW50LXNjcmlwdC1iYWQtb3B0aW9uLmh0bWw6IEFkZGVkLgorCiAyMDEzLTAyLTA0ICBWbGFkaXNs YXYgS2F6bmFjaGVldiAgPGthem5hY2hlZXZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IENyZWF0ZSBhIGNvbnRhaW5lciBjbGFzcyBmb3IgU2lkZWJhclBhbmUgaW5zdGFu Y2VzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZXh0ZW5zaW9ucy9leHRlbnNp b25zLWV2YWwtY29udGVudC1zY3JpcHQtYmFkLW9wdGlvbi1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9pbnNwZWN0b3IvZXh0ZW5zaW9ucy9leHRlbnNpb25zLWV2YWwtY29udGVudC1zY3JpcHQt YmFkLW9wdGlvbi1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNzA5N2VlZDFlMWVmNjg0NDgzM2Uz YmVlMWE5ZTg0NmQxZWEyYmY3ZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2luc3Bl Y3Rvci9leHRlbnNpb25zL2V4dGVuc2lvbnMtZXZhbC1jb250ZW50LXNjcmlwdC1iYWQtb3B0aW9u LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDkgQEAKK1Rlc3RzIFdlYkluc3BlY3RvciBleHRlbnNp b24gQVBJCisKK1N0YXJ0ZWQgZXh0ZW5zaW9uLgorbG9nOiBFeHRlbnNpb24gc2VydmVyIGVycm9y OiBPYmplY3Qgbm90IGZvdW5kOiBmaWxlOi8vCitSdW5uaW5nIHRlc3RzLi4uCitSVU5OSU5HIFRF U1Q6IGV4dGVuc2lvbl90ZXN0RXZhbEluQ29udGVudFNjcmlwdENvbnRleHRXaXRoQmFkT3B0aW9u CitFdmFsdWF0ZTogIkV4dGVuc2lvbiBzZXJ2ZXIgZXJyb3I6IE9iamVjdCBub3QgZm91bmQ6IGZp bGU6Ly8iIChleGNlcHRpb246IHRydWUpCitBbGwgdGVzdHMgZG9uZS4KKwpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvaW5zcGVjdG9yL2V4dGVuc2lvbnMvZXh0ZW5zaW9ucy1ldmFsLWNvbnRlbnQt c2NyaXB0LWJhZC1vcHRpb24uaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9leHRlbnNpb25z L2V4dGVuc2lvbnMtZXZhbC1jb250ZW50LXNjcmlwdC1iYWQtb3B0aW9uLmh0bWwKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MC4uODJlNjE0ZTI5NGY4OTBlNTM5MzE1M2I2NWQxNGY2NzJkMWMyZTQ1ZAotLS0gL2Rldi9udWxs CisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9leHRlbnNpb25zL2V4dGVuc2lvbnMtZXZhbC1j b250ZW50LXNjcmlwdC1iYWQtb3B0aW9uLmh0bWwKQEAgLTAsMCArMSwyOSBAQAorPGh0bWw+Cis8 aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9odHRwL3Rlc3RzL2luc3BlY3Rvci9pbnNwZWN0b3It dGVzdC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vaHR0cC90ZXN0cy9pbnNwZWN0 b3IvZXh0ZW5zaW9ucy10ZXN0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgdHlwZT0idGV4dC9qYXZh c2NyaXB0Ij4KKword2luZG93LndoZXJlQW1JID0gIm1haW4gd29ybGQiOworCisvLyBUbyB0ZXN0 IHRoZSBlcnJvci1wYXRoIGluIGV2YWx1YXRlKCkgd2UgZGVsaWJlcmF0ZWx5IGRvIG5vdCBzZXQg dGhlIGlzb2xhdGVkIHdvcmxkCisvL3Rlc3RSdW5uZXIuc2V0SXNvbGF0ZWRXb3JsZFNlY3VyaXR5 T3JpZ2luKDYzMiwgImZpbGU6Ly8vIik7CisvL3Rlc3RSdW5uZXIuZXZhbHVhdGVTY3JpcHRJbklz b2xhdGVkV29ybGQoNjMyLCAid2luZG93LndoZXJlQW1JID0gJ2JyYXZlIG5ldyB3b3JsZCciKTsK KworCitmdW5jdGlvbiBleHRlbnNpb25fdGVzdEV2YWxJbkNvbnRlbnRTY3JpcHRDb250ZXh0V2l0 aEJhZE9wdGlvbihuZXh0VGVzdCkKK3sKKyAgICB3ZWJJbnNwZWN0b3IuaW5zcGVjdGVkV2luZG93 LmV2YWwoIndoZXJlQW1JIiwgeyB1c2VDb250ZW50U2NyaXB0Q29udGV4dDogdHJ1ZSB9LCBjYWxs YmFja0FuZE5leHRUZXN0KGV4dGVuc2lvbl9vbkV2YWwsIG5leHRUZXN0KSk7Cit9CisKK2Z1bmN0 aW9uIGV4dGVuc2lvbl9vbkV2YWwodmFsdWUsIGlzRXhjZXB0aW9uKQoreworICAgIG91dHB1dCgi RXZhbHVhdGU6ICIgKyBKU09OLnN0cmluZ2lmeSh2YWx1ZSkgKyAiIChleGNlcHRpb246ICIgKyBp c0V4Y2VwdGlvbiArICIpIik7Cit9CisKKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2Fk PSJydW5UZXN0KCkiPgorPHA+VGVzdHMgV2ViSW5zcGVjdG9yIGV4dGVuc2lvbiBBUEk8L3A+Cis8 L2JvZHk+Cis8L2h0bWw+Cg==