108825 2013-02-04 07:52:53 -0800 [EFL][WK2] Use C API inside EwkView 2013-02-04 15:59:17 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 107657 1 kenneth kenneth andersca ap benjamin cdumez gyuyoung.kim mikhail.pozdnyakov rakuco sam webkit.review.bot oldest_to_newest 824351 0 kenneth 2013-02-04 07:52:53 -0800 SSIA 824357 1 186374 kenneth 2013-02-04 07:59:27 -0800 Created attachment 186374 Patch 824377 2 186374 mikhail.pozdnyakov 2013-02-04 08:27:06 -0800 Comment on attachment 186374 Patch LGTM 824387 3 186374 cdumez 2013-02-04 08:33:16 -0800 Comment on attachment 186374 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186374&action=review > Source/WebKit2/UIProcess/API/efl/EwkView.cpp:895 > + WKRetainPtr<WKStringRef> wkURLString = wkActiveURL ? adoptWK(WKURLCopyString(wkActiveURL.get())) : adoptWK(WKStringCreateWithUTF8CString("")); WKURLCopyString()? 824408 4 186374 cdumez 2013-02-04 08:55:33 -0800 Comment on attachment 186374 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186374&action=review >> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:895 >> + WKRetainPtr<WKStringRef> wkURLString = wkActiveURL ? adoptWK(WKURLCopyString(wkActiveURL.get())) : adoptWK(WKStringCreateWithUTF8CString("")); > > WKURLCopyString()? Never mind. You are already using it. I did not read properly sorry. 824413 5 cdumez 2013-02-04 09:00:17 -0800 Oh, I forgot: LGTM :) 824857 6 186374 webkit.review.bot 2013-02-04 15:59:12 -0800 Comment on attachment 186374 Patch Clearing flags on attachment: 186374 Committed r141827: <http://trac.webkit.org/changeset/141827> 824858 7 webkit.review.bot 2013-02-04 15:59:17 -0800 All reviewed patches have been landed. Closing bug. 186374 2013-02-04 07:59:27 -0800 2013-02-04 15:59:12 -0800 Patch bug-108825-20130204165551.patch text/plain 6633 kenneth U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNzcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODZmYTExYTE5ZjAxNDZm N2Q1N2RlZTgxNzgyZTI3YzVlYTBhMjE5Zi4uODBkMWMwNzNkMzRhNzZhYjc1ZTkwMGExOTYxYTU2 ZTI3NTk2ZTJiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAyLTA0ICBLZW5u ZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KKworICAgICAgICBb RUZMXVtXSzJdIFVzZSBDIEFQSSBpbnNpZGUgRXdrVmlldworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4ODI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQSBzdHJhaWdodC1mb3J3YXJkIHBvcnQgdG93YXJk cyB0aGUgQyBBUEkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcDoK KyAgICAgICAgKEV3a1ZpZXc6OkV3a1ZpZXcpOiBVc2UgQyBBUEkgZm9yIGNvbW1vbiBkZWZhdWx0 IHByZWZlcmVuY2VzLgorICAgICAgICAoRXdrVmlldzo6d2tQYWdlKTogTWFrZSBpdCBjb25zdCBh bmQgcmVtb3ZlIHVzZWxlc3MgY29tbWVudC4KKyAgICAgICAgKEV3a1ZpZXc6OmRldmljZVNjYWxl RmFjdG9yKToKKyAgICAgICAgKEV3a1ZpZXc6OnRpdGxlKToKKyAgICAgICAgKEV3a1ZpZXc6OmN1 c3RvbVRleHRFbmNvZGluZ05hbWUpOgorICAgICAgICAoRXdrVmlldzo6c2V0Q3VzdG9tVGV4dEVu Y29kaW5nTmFtZSk6CisgICAgICAgIChFd2tWaWV3OjppbmZvcm1VUkxDaGFuZ2UpOgorICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuaDoKKyAgICAgICAgKEV3a1ZpZXcpOgorCiAy MDEzLTAyLTA0ICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwu Y29tPgogCiAgICAgICAgIFtXSzJdW0VGTF0gV2VpcmQgc3RyaXBlIGF0IHRoZSBlbmQgb2YgdGhl IHBhZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1Zp ZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAKaW5k ZXggNzk2MjZlNmZiMGI2NzMwNjUzYmQxZWEwNmI2NTFjMmRhMDBhMWU1NS4uOWM5YWMyMDNhZDli Y2VjNGExYzBiODExZTUwYTg4OWExYzk0OTg4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAKQEAgLTM3LDYgKzM3LDcgQEAKICNpbmNsdWRlICJXS0Rp Y3Rpb25hcnkuaCIKICNpbmNsdWRlICJXS0dlb21ldHJ5LmgiCiAjaW5jbHVkZSAiV0tOdW1iZXIu aCIKKyNpbmNsdWRlICJXS1BhZ2VHcm91cC5oIgogI2luY2x1ZGUgIldLU3RyaW5nLmgiCiAjaW5j bHVkZSAiV2ViQ29udGV4dC5oIgogI2luY2x1ZGUgIldlYkltYWdlLmgiCkBAIC0xNDYsNiArMTQ3 LDE2IEBAIEV3a1ZpZXc6OkV3a1ZpZXcoRXZhc19PYmplY3QqIGV2YXNPYmplY3QsIFBhc3NSZWZQ dHI8RXdrQ29udGV4dD4gY29udGV4dCwgUGFzc1JlCiAgICAgQVNTRVJUKG1fY29udGV4dCk7CiAg ICAgQVNTRVJUKG1fcGFnZVByb3h5KTsKIAorICAgIFdLUGFnZVNldFVzZUZpeGVkTGF5b3V0KHdr UGFnZSgpLCBiZWhhdmlvciA9PSBEZWZhdWx0QmVoYXZpb3IpOworCisgICAgV0tQYWdlR3JvdXBS ZWYgd2tQYWdlR3JvdXAgPSBXS1BhZ2VHZXRQYWdlR3JvdXAod2tQYWdlKCkpOworICAgIFdLUHJl ZmVyZW5jZXNSZWYgd2tQcmVmZXJlbmNlcyA9IFdLUGFnZUdyb3VwR2V0UHJlZmVyZW5jZXMod2tQ YWdlR3JvdXApOworCisgICAgV0tQcmVmZXJlbmNlc1NldFdlYkdMRW5hYmxlZCh3a1ByZWZlcmVu Y2VzLCB0cnVlKTsKKyAgICBXS1ByZWZlcmVuY2VzU2V0RnVsbFNjcmVlbkVuYWJsZWQod2tQcmVm ZXJlbmNlcywgdHJ1ZSk7CisgICAgV0tQcmVmZXJlbmNlc1NldFdlYkF1ZGlvRW5hYmxlZCh3a1By ZWZlcmVuY2VzLCB0cnVlKTsKKyAgICBXS1ByZWZlcmVuY2VzU2V0T2ZmbGluZVdlYkFwcGxpY2F0 aW9uQ2FjaGVFbmFibGVkKHdrUHJlZmVyZW5jZXMsIHRydWUpOworCiAjaWYgVVNFKENPT1JESU5B VEVEX0dSQVBISUNTKQogICAgIG1fcGFnZVByb3h5LT5wYWdlR3JvdXAoKS0+cHJlZmVyZW5jZXMo KS0+c2V0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0VuYWJsZWQodHJ1ZSk7CiAgICAgbV9wYWdlUHJv eHktPnBhZ2VHcm91cCgpLT5wcmVmZXJlbmNlcygpLT5zZXRGb3JjZUNvbXBvc2l0aW5nTW9kZSh0 cnVlKTsKQEAgLTE1MywyNSArMTY0LDE0IEBAIEV3a1ZpZXc6OkV3a1ZpZXcoRXZhc19PYmplY3Qq IGV2YXNPYmplY3QsIFBhc3NSZWZQdHI8RXdrQ29udGV4dD4gY29udGV4dCwgUGFzc1JlCiAgICAg Ym9vbCBzaG93RGVidWdWaXN1YWxzID0gZGVidWdWaXN1YWxzRW52aXJvbm1lbnQgJiYgIXN0cmNt cChkZWJ1Z1Zpc3VhbHNFbnZpcm9ubWVudCwgIjEiKTsKICAgICBtX3BhZ2VQcm94eS0+cGFnZUdy b3VwKCktPnByZWZlcmVuY2VzKCktPnNldENvbXBvc2l0aW5nQm9yZGVyc1Zpc2libGUoc2hvd0Rl YnVnVmlzdWFscyk7CiAgICAgbV9wYWdlUHJveHktPnBhZ2VHcm91cCgpLT5wcmVmZXJlbmNlcygp LT5zZXRDb21wb3NpdGluZ1JlcGFpbnRDb3VudGVyc1Zpc2libGUoc2hvd0RlYnVnVmlzdWFscyk7 Ci0jaWYgRU5BQkxFKFdFQkdMKQotICAgIG1fcGFnZVByb3h5LT5wYWdlR3JvdXAoKS0+cHJlZmVy ZW5jZXMoKS0+c2V0V2ViR0xFbmFibGVkKHRydWUpOwotI2VuZGlmCi0gICAgaWYgKGJlaGF2aW9y ID09IERlZmF1bHRCZWhhdmlvcikKLSAgICAgICAgbV9wYWdlUHJveHktPnNldFVzZUZpeGVkTGF5 b3V0KHRydWUpOwogI2VuZGlmCiAKICAgICBtX3BhZ2VQcm94eS0+aW5pdGlhbGl6ZVdlYlBhZ2Uo KTsKIAogI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKICAgICBtX3BhZ2VQcm94eS0+ZnVsbFNj cmVlbk1hbmFnZXIoKS0+c2V0V2ViVmlldyhtX2V2YXNPYmplY3QpOwotICAgIG1fcGFnZVByb3h5 LT5wYWdlR3JvdXAoKS0+cHJlZmVyZW5jZXMoKS0+c2V0RnVsbFNjcmVlbkVuYWJsZWQodHJ1ZSk7 Ci0jZW5kaWYKLSNpZiBFTkFCTEUoV0VCX0FVRElPKQotICAgIG1fcGFnZVByb3h5LT5wYWdlR3Jv dXAoKS0+cHJlZmVyZW5jZXMoKS0+c2V0V2ViQXVkaW9FbmFibGVkKHRydWUpOwogI2VuZGlmCiAK LSAgICBtX3BhZ2VQcm94eS0+cGFnZUdyb3VwKCktPnByZWZlcmVuY2VzKCktPnNldE9mZmxpbmVX ZWJBcHBsaWNhdGlvbkNhY2hlRW5hYmxlZCh0cnVlKTsKLQogICAgIC8vIEVuYWJsZSBtb3VzZSBl dmVudHMgYnkgZGVmYXVsdAogICAgIHNldE1vdXNlRXZlbnRzRW5hYmxlZCh0cnVlKTsKIApAQCAt MjExLDExICsyMTEsNyBAQCBFd2tWaWV3KiBFd2tWaWV3Ojpmcm9tRXZhc09iamVjdChjb25zdCBF dmFzX09iamVjdCogdmlldykKICAgICByZXR1cm4gc2QtPnByaXY7CiB9CiAKLS8qKgotICogQGlu dGVybmFsCi0gKiBSZXRyaWV2ZXMgdGhlIGludGVybmFsIFdLUGFnZSBmb3IgdGhpcyB2aWV3Lgot ICovCi1XS1BhZ2VSZWYgRXdrVmlldzo6d2tQYWdlKCkKK1dLUGFnZVJlZiBFd2tWaWV3Ojp3a1Bh Z2UoKSBjb25zdAogewogICAgIHJldHVybiB0b0FQSShtX3BhZ2VQcm94eS5nZXQoKSk7CiB9CkBA IC0zMDEsNyArMjk3LDcgQEAgdm9pZCBFd2tWaWV3OjpzZXREZXZpY2VTY2FsZUZhY3RvcihmbG9h dCBzY2FsZSkKIAogZmxvYXQgRXdrVmlldzo6ZGV2aWNlU2NhbGVGYWN0b3IoKSBjb25zdAogewot ICAgIHJldHVybiBtX3BhZ2VQcm94eS0+ZGV2aWNlU2NhbGVGYWN0b3IoKTsKKyAgICByZXR1cm4g V0tQYWdlR2V0QmFja2luZ1NjYWxlRmFjdG9yKHdrUGFnZSgpKTsKIH0KIAogQWZmaW5lVHJhbnNm b3JtIEV3a1ZpZXc6OnRyYW5zZm9ybUZyb21TY2VuZSgpIGNvbnN0CkBAIC01MjcsNyArNTIzLDcg QEAgYm9vbCBFd2tWaWV3Ojppc1Zpc2libGUoKSBjb25zdAogCiBjb25zdCBjaGFyKiBFd2tWaWV3 Ojp0aXRsZSgpIGNvbnN0CiB7Ci0gICAgbV90aXRsZSA9IG1fcGFnZVByb3h5LT5wYWdlVGl0bGUo KS51dGY4KCkuZGF0YSgpOworICAgIG1fdGl0bGUgPSBXS0VpbmFTaGFyZWRTdHJpbmcoQWRvcHRX SywgV0tQYWdlQ29weVRpdGxlKHdrUGFnZSgpKSk7CiAKICAgICByZXR1cm4gbV90aXRsZTsKIH0K QEAgLTU1NiwxOCArNTUyLDE5IEBAIHZvaWQgRXdrVmlldzo6c2V0VGhlbWVQYXRoKGNvbnN0IGNo YXIqIHRoZW1lKQogCiBjb25zdCBjaGFyKiBFd2tWaWV3OjpjdXN0b21UZXh0RW5jb2RpbmdOYW1l KCkgY29uc3QKIHsKLSAgICBTdHJpbmcgY3VzdG9tRW5jb2RpbmcgPSBtX3BhZ2VQcm94eS0+Y3Vz dG9tVGV4dEVuY29kaW5nTmFtZSgpOwotICAgIGlmIChjdXN0b21FbmNvZGluZy5pc0VtcHR5KCkp CisgICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IGN1c3RvbUVuY29kaW5nID0gYWRvcHRXSyhX S1BhZ2VDb3B5Q3VzdG9tVGV4dEVuY29kaW5nTmFtZSh3a1BhZ2UoKSkpOworICAgIGlmIChXS1N0 cmluZ0lzRW1wdHkoY3VzdG9tRW5jb2RpbmcuZ2V0KCkpKQogICAgICAgICByZXR1cm4gMDsKIAot ICAgIG1fY3VzdG9tRW5jb2RpbmcgPSBjdXN0b21FbmNvZGluZy51dGY4KCkuZGF0YSgpOworICAg IG1fY3VzdG9tRW5jb2RpbmcgPSBXS0VpbmFTaGFyZWRTdHJpbmcoY3VzdG9tRW5jb2RpbmcuZ2V0 KCkpOwogCiAgICAgcmV0dXJuIG1fY3VzdG9tRW5jb2Rpbmc7CiB9CiAKIHZvaWQgRXdrVmlldzo6 c2V0Q3VzdG9tVGV4dEVuY29kaW5nTmFtZShjb25zdCBTdHJpbmcmIGVuY29kaW5nKQogewotICAg IG1fcGFnZVByb3h5LT5zZXRDdXN0b21UZXh0RW5jb2RpbmdOYW1lKGVuY29kaW5nKTsKKyAgICBX S1JldGFpblB0cjxXS1N0cmluZ1JlZj4gd2tFbmNvZGluZyA9IGFkb3B0V0sodG9Db3BpZWRBUEko ZW5jb2RpbmcpKTsKKyAgICBXS1BhZ2VTZXRDdXN0b21UZXh0RW5jb2RpbmdOYW1lKHdrUGFnZSgp LCB3a0VuY29kaW5nLmdldCgpKTsKIH0KIAogdm9pZCBFd2tWaWV3OjpzZXRNb3VzZUV2ZW50c0Vu YWJsZWQoYm9vbCBlbmFibGVkKQpAQCAtODk0LDE1ICs4OTEsMTMgQEAgdW5zaWduZWQgbG9uZyBs b25nIEV3a1ZpZXc6OmluZm9ybURhdGFiYXNlUXVvdGFSZWFjaGVkKGNvbnN0IFN0cmluZyYgZGF0 YWJhc2VOYW0KICAqLwogdm9pZCBFd2tWaWV3OjppbmZvcm1VUkxDaGFuZ2UoKQogewotICAgIFN0 cmluZyBhY3RpdmVVUkwgPSBtX3BhZ2VQcm94eS0+YWN0aXZlVVJMKCk7Ci0gICAgaWYgKGFjdGl2 ZVVSTC5pc0VtcHR5KCkpCi0gICAgICAgIHJldHVybjsKKyAgICBXS1JldGFpblB0cjxXS1VSTFJl Zj4gd2tBY3RpdmVVUkwgPSBhZG9wdFdLKFdLUGFnZUNvcHlBY3RpdmVVUkwod2tQYWdlKCkpKTsK KyAgICBXS1JldGFpblB0cjxXS1N0cmluZ1JlZj4gd2tVUkxTdHJpbmcgPSB3a0FjdGl2ZVVSTCA/ IGFkb3B0V0soV0tVUkxDb3B5U3RyaW5nKHdrQWN0aXZlVVJMLmdldCgpKSkgOiBhZG9wdFdLKFdL U3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCIiKSk7CiAKLSAgICBDU3RyaW5nIHJhd0FjdGl2 ZVVSTCA9IGFjdGl2ZVVSTC51dGY4KCk7Ci0gICAgaWYgKG1fdXJsID09IHJhd0FjdGl2ZVVSTC5k YXRhKCkpCisgICAgaWYgKFdLU3RyaW5nSXNFcXVhbFRvVVRGOENTdHJpbmcod2tVUkxTdHJpbmcu Z2V0KCksIG1fdXJsKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgbV91cmwgPSByYXdBY3RpdmVV UkwuZGF0YSgpOworICAgIG1fdXJsID0gV0tFaW5hU2hhcmVkU3RyaW5nKHdrVVJMU3RyaW5nLmdl dCgpKTsKICAgICBzbWFydENhbGxiYWNrPFVSTENoYW5nZWQ+KCkuY2FsbChtX3VybCk7CiAKICAg ICAvLyBVcGRhdGUgdGhlIHZpZXcncyBmYXZpY29uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9lZmwvRXdrVmlldy5oCmluZGV4IDk5Y2U4ZWRiNGIxYTAzZjliYTViMTdkM2I3ODgwZmQ3 NTNmZjg3MjguLmUyMDI1MTAyOGIzYmM3ODkwOGY1YTI0MWUzMDE3NDdmZTJkMDU3OWMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuaAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmgKQEAgLTEwOCw3ICsxMDgs NyBAQCBwdWJsaWM6CiAgICAgc3RhdGljIEV3a1ZpZXcqIGZyb21FdmFzT2JqZWN0KGNvbnN0IEV2 YXNfT2JqZWN0KiB2aWV3KTsKICAgICBFdmFzX09iamVjdCogdmlldygpIHsgcmV0dXJuIG1fZXZh c09iamVjdDsgfQogCi0gICAgV0tQYWdlUmVmIHdrUGFnZSgpOworICAgIFdLUGFnZVJlZiB3a1Bh Z2UoKSBjb25zdDsKICAgICBXZWJLaXQ6OldlYlBhZ2VQcm94eSogcGFnZSgpIHsgcmV0dXJuIG1f cGFnZVByb3h5LmdldCgpOyB9CiAgICAgRXdrQ29udGV4dCogZXdrQ29udGV4dCgpIHsgcmV0dXJu IG1fY29udGV4dC5nZXQoKTsgfQogICAgIEV3a1NldHRpbmdzKiBzZXR0aW5ncygpIHsgcmV0dXJu IG1fc2V0dGluZ3MuZ2V0KCk7IH0K