108816 2013-02-04 04:31:15 -0800 [EFL][WK2] Stop using libsoup in ewk_url_scheme_request 2013-02-04 10:33:45 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 107657 1 cdumez cdumez andersca ap benjamin gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi mikhail.pozdnyakov rakuco sam webkit.review.bot oldest_to_newest 824246 0 cdumez 2013-02-04 04:31:15 -0800 As we are trying to minimize use of external dependencies in our WK2 EFL API implementation, we should stop using libsoup in ewk_url_scheme_request and use the WK2 C API instead. 824248 1 186351 cdumez 2013-02-04 04:34:04 -0800 Created attachment 186351 Patch 824249 2 186351 mikhail.pozdnyakov 2013-02-04 04:38:27 -0800 Comment on attachment 186351 Patch Makes sense. LGTM 824265 3 186351 kenneth 2013-02-04 05:03:54 -0800 Comment on attachment 186351 Patch Looks good to me too 824335 4 186351 buildbot 2013-02-04 07:17:41 -0800 Comment on attachment 186351 Patch Attachment 186351 did not pass win-ews (win): Output: http://queues.webkit.org/results/16372235 824337 5 186351 cdumez 2013-02-04 07:24:07 -0800 Comment on attachment 186351 Patch win-ews is in a bad state. The error looks unrelated. Setting cq? flag again. 824532 6 186351 webkit.review.bot 2013-02-04 10:33:40 -0800 Comment on attachment 186351 Patch Clearing flags on attachment: 186351 Committed r141780: <http://trac.webkit.org/changeset/141780> 824533 7 webkit.review.bot 2013-02-04 10:33:45 -0800 All reviewed patches have been landed. Closing bug. 186351 2013-02-04 04:34:04 -0800 2013-02-04 10:33:40 -0800 Patch 108816_ewkurlscheme_nosoup.patch text/plain 1845 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwNmFiMDRmLi43NzUxMjY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkg QEAKIDIwMTMtMDItMDQgIENocmlzdG9waGUgRHVtZXogIDxkY2hyaXNAZ21haWwuY29tPgogCisg ICAgICAgIFtFRkxdW1dLMl0gU3RvcCB1c2luZyBsaWJzb3VwIGluIGV3a191cmxfc2NoZW1lX3Jl cXVlc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw ODgxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFz IHdlIGFyZSB0cnlpbmcgdG8gbWluaW1pemUgdXNlIG9mIGV4dGVybmFsIGRlcGVuZGVuY2llcyBp biBvdXIgV0syIEVGTAorICAgICAgICBBUEkgaW1wbGVtZW50YXRpb24sIHdlIHNob3VsZCBzdG9w IHVzaW5nIGxpYnNvdXAgaW4KKyAgICAgICAgZXdrX3VybF9zY2hlbWVfcmVxdWVzdCBhbmQgdXNl IHRoZSBXSzIgQyBBUEkgaW5zdGVhZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3 a191cmxfc2NoZW1lX3JlcXVlc3QuY3BwOgorICAgICAgICAoRXdrVXJsU2NoZW1lUmVxdWVzdDo6 RXdrVXJsU2NoZW1lUmVxdWVzdCk6CisKKzIwMTMtMDItMDQgIENocmlzdG9waGUgRHVtZXogIDxk Y2hyaXNAZ21haWwuY29tPgorCiAgICAgICAgIFtFRkxdW1dLMl0gUG9ydCBld2tfcG9wdXBfbWVu dSB0byB0aGUgQyBBUEkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwODc5OAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC9ld2tfdXJsX3NjaGVtZV9yZXF1ZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZWZsL2V3a191cmxfc2NoZW1lX3JlcXVlc3QuY3BwCmluZGV4IDg4OTE3MzAuLjcyOGVl NDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a191cmxf c2NoZW1lX3JlcXVlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZs L2V3a191cmxfc2NoZW1lX3JlcXVlc3QuY3BwCkBAIC0yNiw5ICsyNiw5IEBACiAjaW5jbHVkZSAi Y29uZmlnLmgiCiAjaW5jbHVkZSAiZXdrX3VybF9zY2hlbWVfcmVxdWVzdC5oIgogCi0jaW5jbHVk ZSAiR093blB0clNvdXAuaCIKICNpbmNsdWRlICJXS0RhdGEuaCIKICNpbmNsdWRlICJXS1N0cmlu Zy5oIgorI2luY2x1ZGUgIldLVVJMLmgiCiAjaW5jbHVkZSAiZXdrX3VybF9zY2hlbWVfcmVxdWVz dF9wcml2YXRlLmgiCiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CkBAIC0zNywxMCArMzcsOSBA QCBFd2tVcmxTY2hlbWVSZXF1ZXN0OjpFd2tVcmxTY2hlbWVSZXF1ZXN0KFdLU291cFJlcXVlc3RN YW5hZ2VyUmVmIG1hbmFnZXIsIFdLVVJMUgogICAgIDogbV93a1JlcXVlc3RNYW5hZ2VyKG1hbmFn ZXIpCiAgICAgLCBtX3VybCh1cmwpCiAgICAgLCBtX3JlcXVlc3RJRChyZXF1ZXN0SUQpCisgICAg LCBtX3NjaGVtZShBZG9wdFdLLCBXS1VSTENvcHlTY2hlbWUodXJsKSkKKyAgICAsIG1fcGF0aChB ZG9wdFdLLCBXS1VSTENvcHlQYXRoKHVybCkpCiB7Ci0gICAgR093blB0cjxTb3VwVVJJPiBzb3Vw VVJJKHNvdXBfdXJpX25ldyhtX3VybCkpOwotICAgIG1fc2NoZW1lID0gc291cFVSSS0+c2NoZW1l OwotICAgIG1fcGF0aCA9IHNvdXBVUkktPnBhdGg7CiB9CiAKIHVpbnQ2NF90IEV3a1VybFNjaGVt ZVJlcXVlc3Q6OmlkKCkgY29uc3QK