108808 2013-02-04 03:17:20 -0800 [Qt] Restore URL Scheme Delegates after QtWebProcess crash 2013-02-15 07:35:42 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 milian.wolff milian.wolff abecsi benjamin cmarcelo hausmann menard webkit.review.bot zeno oldest_to_newest 824184 0 milian.wolff 2013-02-04 03:17:20 -0800 When the QtWebProcess crashes, the registered URL Scheme Delegates are not properly restored over IPC in the newly launched process instance. 824189 1 186334 milian.wolff 2013-02-04 03:27:29 -0800 Created attachment 186334 Patch 824254 2 zeno 2013-02-04 04:48:06 -0800 LGTM 824278 3 186334 hausmann 2013-02-04 05:35:22 -0800 Comment on attachment 186334 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186334&action=review > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:790 > + for (int i = 0; i < experimental->schemeDelegates_Count(&schemes); ++i) { Why not call _Count before the loop instead of for each iteration? It cannot be inlined. LGTM otherwise. 824305 4 186364 milian.wolff 2013-02-04 06:17:12 -0800 Created attachment 186364 Patch 824327 5 hausmann 2013-02-04 07:02:05 -0800 LGTM. Perhaps Benjamin can help us with the review :) 833048 6 186364 michael.bruning 2013-02-14 07:11:51 -0800 Comment on attachment 186364 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186364&action=review > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:789 > + QQmlListProperty<QQuickUrlSchemeDelegate> schemes = experimental->schemeDelegates(); I think we have to add this here in order to keep qrc-schemes working: webPageProxy->registerApplicationScheme(ASCIILiteral("qrc")); 833544 7 186364 benjamin 2013-02-14 16:33:13 -0800 Comment on attachment 186364 Patch I have nothing against this. Simon, feel free to review. On a related node: shouldn't you switch to the CustomProtocolManager instead of the custom ApplicationScheme thingy? On a slightly related side note: It would be good to split WebPage and WebPageProxy between the stuff that are core, and the stuff that are platform quirks. This could be done by supplements and/or subclasses. Maybe you want to start something like this to clean custom handling like ApplicationScheme? 833788 8 zeno 2013-02-15 01:10:40 -0800 (In reply to comment #7) > (From update of attachment 186364 [details]) > I have nothing against this. Simon, feel free to review. > > On a related node: shouldn't you switch to the CustomProtocolManager instead of the custom ApplicationScheme thingy? > On a slightly related side note: It would be good to split WebPage and WebPageProxy between the stuff that are core, and the stuff that are platform quirks. This could be done by supplements and/or subclasses. Maybe you want to start something like this to clean custom handling like ApplicationScheme? Hi Benjamin, I am currently working on exactly that issue. I think the CustomProtocolManager will fit relatively well. The only thing that I am aware of, that might be missing is a way to register/unregister schemes at runtime through the C-API. - Or did I overlook anything there? 833790 9 benjamin 2013-02-15 01:17:38 -0800 > The only thing that I am aware of, that might be missing is a way to register/unregister schemes at runtime through the C-API. - Or did I overlook anything there? RegisterScheme/UnregisterScheme? http://trac.webkit.org/browser/trunk/Source/WebKit2/Shared/Network/CustomProtocols/CustomProtocolManager.messages.in :) 833791 10 benjamin 2013-02-15 01:18:34 -0800 Oh, through C API! Yep, it is possible there isn't one. 833799 11 186364 hausmann 2013-02-15 01:39:20 -0800 Comment on attachment 186364 Patch r=me, signed off for WK2 by Benjamin, but Michael's proposed change seems required before landing (cq-) 833967 12 188553 milian.wolff 2013-02-15 06:42:06 -0800 Created attachment 188553 Patch 833968 13 milian.wolff 2013-02-15 06:44:03 -0800 OK, qrc scheme handler gets reregistered now as well. I furthermore created https://bugs.webkit.org/show_bug.cgi?id=109934 to figure out how we can disable the qrc scheme handler if not desired. Anything else? 834012 14 188553 webkit.review.bot 2013-02-15 07:35:37 -0800 Comment on attachment 188553 Patch Clearing flags on attachment: 188553 Committed r142997: <http://trac.webkit.org/changeset/142997> 834013 15 webkit.review.bot 2013-02-15 07:35:42 -0800 All reviewed patches have been landed. Closing bug. 186334 2013-02-04 03:27:29 -0800 2013-02-04 06:17:09 -0800 Patch bug-108808-20130204122408.patch text/plain 2710 milian.wolff U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZWUzYTlhOGY5NjJmOTU4 MTlhNmFjNGFmZjljYzI2NzUxMWNiZmVjYS4uN2Y5MjRjNzU5ZDc5ZGY0OTI4ZDkwOTVlMzU1ZjQ0 NzFhYWJkZjg5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAyLTA0ICBNaWxp YW4gV29sZmYgIDxtaWxpYW4ud29sZmZAa2RhYi5jb20+CisKKyAgICAgICAgW1F0XSBSZXN0b3Jl IFVSTCBTY2hlbWUgRGVsZWdhdGVzIGFmdGVyIFF0V2ViUHJvY2VzcyBjcmFzaAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4ODA4CisKKyAgICAgICAg V2hlbiB0aGUgUXRXZWJQcm9jZXNzIGNyYXNoZXMsIHRoZSByZWdpc3RlcmVkIFVSTCBTY2hlbWUK KyAgICAgICAgRGVsZWdhdGVzIGFyZSBub3QgcHJvcGVybHkgcmVzdG9yZWQgb3ZlciBJUEMgaW4g dGhlIG5ld2x5CisgICAgICAgIGxhdW5jaGVkIHByb2Nlc3MgaW5zdGFuY2UuCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0 L3FxdWlja3dlYnZpZXcuY3BwOgorICAgICAgICAoUVF1aWNrV2ViVmlld1ByaXZhdGU6OmRpZFJl bGF1bmNoUHJvY2Vzcyk6CisgICAgICAgIChRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6dXBkYXRlU2No ZW1lRGVsZWdhdGVzKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdf cF9wLmg6CisgICAgICAgIChRUXVpY2tXZWJWaWV3UHJpdmF0ZSk6CisKIDIwMTMtMDItMDQgIEJh bGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtTb3VwXSBXcmFw IFNvdXBTZXNzaW9uIGJ5IE5ldHdvcmtTdG9yYWdlU2Vzc2lvbgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKaW5kZXggNmY1MzJjMjU4MmE0 MTQzOTFjYTNmNDc4ODg5MDgxNGI4MWU2NDVlNS4uYzM3MTlkM2ZhZDQ1MWIzYTNhOGFjZTI3NmZh ZjNlNDFlNGQ1MTlmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9x dC9xcXVpY2t3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3FxdWlja3dlYnZpZXcuY3BwCkBAIC01MDIsNiArNTAyLDcgQEAgdm9pZCBRUXVpY2tXZWJWaWV3 UHJpdmF0ZTo6ZGlkUmVsYXVuY2hQcm9jZXNzKCkKIAogICAgIHVwZGF0ZVZpZXdwb3J0U2l6ZSgp OwogICAgIHVwZGF0ZVVzZXJTY3JpcHRzKCk7CisgICAgdXBkYXRlU2NoZW1lRGVsZWdhdGVzKCk7 CiB9CiAKIFBhc3NPd25QdHI8RHJhd2luZ0FyZWFQcm94eT4gUVF1aWNrV2ViVmlld1ByaXZhdGU6 OmNyZWF0ZURyYXdpbmdBcmVhUHJveHkoKQpAQCAtNzgzLDYgKzc4NCwxNSBAQCB2b2lkIFFRdWlj a1dlYlZpZXdQcml2YXRlOjp1cGRhdGVVc2VyU2NyaXB0cygpCiAgICAgfQogfQogCit2b2lkIFFR dWlja1dlYlZpZXdQcml2YXRlOjp1cGRhdGVTY2hlbWVEZWxlZ2F0ZXMoKQoreworICAgIFFRbWxM aXN0UHJvcGVydHk8UVF1aWNrVXJsU2NoZW1lRGVsZWdhdGU+IHNjaGVtZXMgPSBleHBlcmltZW50 YWwtPnNjaGVtZURlbGVnYXRlcygpOworICAgIGZvciAoaW50IGkgPSAwOyBpIDwgZXhwZXJpbWVu dGFsLT5zY2hlbWVEZWxlZ2F0ZXNfQ291bnQoJnNjaGVtZXMpOyArK2kpIHsKKyAgICAgICAgUVF1 aWNrVXJsU2NoZW1lRGVsZWdhdGUqIHNjaGVtZSA9IGV4cGVyaW1lbnRhbC0+c2NoZW1lRGVsZWdh dGVzX0F0KCZzY2hlbWVzLCBpKTsKKyAgICAgICAgd2ViUGFnZVByb3h5LT5yZWdpc3RlckFwcGxp Y2F0aW9uU2NoZW1lKHNjaGVtZS0+c2NoZW1lKCkpOworICAgIH0KK30KKwogUVBvaW50RiBRUXVp Y2tXZWJWaWV3UHJpdmF0ZTo6Y29udGVudFBvcygpIGNvbnN0CiB7CiAgICAgUV9RKGNvbnN0IFFR dWlja1dlYlZpZXcpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9x dC9xcXVpY2t3ZWJ2aWV3X3BfcC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9x cXVpY2t3ZWJ2aWV3X3BfcC5oCmluZGV4IGEwY2E2OWFlZmMxYTJmZGYxMjVjMGU3YjQ3NDEwNDI2 OTJjYmFjZmIuLjkzZmE1NGI0ZjI2Yzg0NmU1ZDRlNDYxZjIwNThkNTk3N2UwMjNjMGMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wX3Au aAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcF9w LmgKQEAgLTEyMyw2ICsxMjMsNyBAQCBwdWJsaWM6CiAgICAgYm9vbCB0cmFuc3BhcmVudEJhY2tn cm91bmQoKSBjb25zdDsKICAgICB2b2lkIHNldE5hdmlnYXRvclF0T2JqZWN0RW5hYmxlZChib29s KTsKICAgICB2b2lkIHVwZGF0ZVVzZXJTY3JpcHRzKCk7CisgICAgdm9pZCB1cGRhdGVTY2hlbWVE ZWxlZ2F0ZXMoKTsKIAogICAgIFFQb2ludEYgY29udGVudFBvcygpIGNvbnN0OwogICAgIHZvaWQg c2V0Q29udGVudFBvcyhjb25zdCBRUG9pbnRGJik7Cg== 186364 2013-02-04 06:17:12 -0800 2013-02-15 06:42:02 -0800 Patch bug-108808-20130204151351.patch text/plain 2735 milian.wolff U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZWUzYTlhOGY5NjJmOTU4 MTlhNmFjNGFmZjljYzI2NzUxMWNiZmVjYS4uN2Y5MjRjNzU5ZDc5ZGY0OTI4ZDkwOTVlMzU1ZjQ0 NzFhYWJkZjg5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAyLTA0ICBNaWxp YW4gV29sZmYgIDxtaWxpYW4ud29sZmZAa2RhYi5jb20+CisKKyAgICAgICAgW1F0XSBSZXN0b3Jl IFVSTCBTY2hlbWUgRGVsZWdhdGVzIGFmdGVyIFF0V2ViUHJvY2VzcyBjcmFzaAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4ODA4CisKKyAgICAgICAg V2hlbiB0aGUgUXRXZWJQcm9jZXNzIGNyYXNoZXMsIHRoZSByZWdpc3RlcmVkIFVSTCBTY2hlbWUK KyAgICAgICAgRGVsZWdhdGVzIGFyZSBub3QgcHJvcGVybHkgcmVzdG9yZWQgb3ZlciBJUEMgaW4g dGhlIG5ld2x5CisgICAgICAgIGxhdW5jaGVkIHByb2Nlc3MgaW5zdGFuY2UuCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0 L3FxdWlja3dlYnZpZXcuY3BwOgorICAgICAgICAoUVF1aWNrV2ViVmlld1ByaXZhdGU6OmRpZFJl bGF1bmNoUHJvY2Vzcyk6CisgICAgICAgIChRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6dXBkYXRlU2No ZW1lRGVsZWdhdGVzKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdf cF9wLmg6CisgICAgICAgIChRUXVpY2tXZWJWaWV3UHJpdmF0ZSk6CisKIDIwMTMtMDItMDQgIEJh bGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtTb3VwXSBXcmFw IFNvdXBTZXNzaW9uIGJ5IE5ldHdvcmtTdG9yYWdlU2Vzc2lvbgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKaW5kZXggNmY1MzJjMjU4MmE0 MTQzOTFjYTNmNDc4ODg5MDgxNGI4MWU2NDVlNS4uNmExMmY2M2M3YWM2OGMyNDNjNWEzNjAxNjA5 NjQ1OWMwNDY5Y2IzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9x dC9xcXVpY2t3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3FxdWlja3dlYnZpZXcuY3BwCkBAIC01MDIsNiArNTAyLDcgQEAgdm9pZCBRUXVpY2tXZWJWaWV3 UHJpdmF0ZTo6ZGlkUmVsYXVuY2hQcm9jZXNzKCkKIAogICAgIHVwZGF0ZVZpZXdwb3J0U2l6ZSgp OwogICAgIHVwZGF0ZVVzZXJTY3JpcHRzKCk7CisgICAgdXBkYXRlU2NoZW1lRGVsZWdhdGVzKCk7 CiB9CiAKIFBhc3NPd25QdHI8RHJhd2luZ0FyZWFQcm94eT4gUVF1aWNrV2ViVmlld1ByaXZhdGU6 OmNyZWF0ZURyYXdpbmdBcmVhUHJveHkoKQpAQCAtNzgzLDYgKzc4NCwxNSBAQCB2b2lkIFFRdWlj a1dlYlZpZXdQcml2YXRlOjp1cGRhdGVVc2VyU2NyaXB0cygpCiAgICAgfQogfQogCit2b2lkIFFR dWlja1dlYlZpZXdQcml2YXRlOjp1cGRhdGVTY2hlbWVEZWxlZ2F0ZXMoKQoreworICAgIFFRbWxM aXN0UHJvcGVydHk8UVF1aWNrVXJsU2NoZW1lRGVsZWdhdGU+IHNjaGVtZXMgPSBleHBlcmltZW50 YWwtPnNjaGVtZURlbGVnYXRlcygpOworICAgIGZvciAoaW50IGkgPSAwLCBudW1TY2hlbWVzID0g ZXhwZXJpbWVudGFsLT5zY2hlbWVEZWxlZ2F0ZXNfQ291bnQoJnNjaGVtZXMpOyBpIDwgbnVtU2No ZW1lczsgKytpKSB7CisgICAgICAgIFFRdWlja1VybFNjaGVtZURlbGVnYXRlKiBzY2hlbWUgPSBl eHBlcmltZW50YWwtPnNjaGVtZURlbGVnYXRlc19BdCgmc2NoZW1lcywgaSk7CisgICAgICAgIHdl YlBhZ2VQcm94eS0+cmVnaXN0ZXJBcHBsaWNhdGlvblNjaGVtZShzY2hlbWUtPnNjaGVtZSgpKTsK KyAgICB9Cit9CisKIFFQb2ludEYgUVF1aWNrV2ViVmlld1ByaXZhdGU6OmNvbnRlbnRQb3MoKSBj b25zdAogewogICAgIFFfUShjb25zdCBRUXVpY2tXZWJWaWV3KTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wX3AuaCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wX3AuaAppbmRleCBhMGNhNjlh ZWZjMWEyZmRmMTI1YzBlN2I0NzQxMDQyNjkyY2JhY2ZiLi45M2ZhNTRiNGYyNmM4NDZlNWQ0ZTQ2 MWYyMDU4ZDU5NzdlMDIzYzBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL3F0L3FxdWlja3dlYnZpZXdfcF9wLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3BfcC5oCkBAIC0xMjMsNiArMTIzLDcgQEAgcHVibGljOgog ICAgIGJvb2wgdHJhbnNwYXJlbnRCYWNrZ3JvdW5kKCkgY29uc3Q7CiAgICAgdm9pZCBzZXROYXZp Z2F0b3JRdE9iamVjdEVuYWJsZWQoYm9vbCk7CiAgICAgdm9pZCB1cGRhdGVVc2VyU2NyaXB0cygp OworICAgIHZvaWQgdXBkYXRlU2NoZW1lRGVsZWdhdGVzKCk7CiAKICAgICBRUG9pbnRGIGNvbnRl bnRQb3MoKSBjb25zdDsKICAgICB2b2lkIHNldENvbnRlbnRQb3MoY29uc3QgUVBvaW50RiYpOwo= 188553 2013-02-15 06:42:06 -0800 2013-02-15 07:35:37 -0800 Patch bug-108808-20130215153832.patch text/plain 2804 milian.wolff U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZWUzYTlhOGY5NjJmOTU4 MTlhNmFjNGFmZjljYzI2NzUxMWNiZmVjYS4uZTU4ZWQ4ODcwMTViNzU1ODZhYmExYzI0NmRlZjVh NjNmNWMzMjdlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAyLTE1ICBNaWxp YW4gV29sZmYgIDxtaWxpYW4ud29sZmZAa2RhYi5jb20+CisKKyAgICAgICAgW1F0XSBSZXN0b3Jl IFVSTCBTY2hlbWUgRGVsZWdhdGVzIGFmdGVyIFF0V2ViUHJvY2VzcyBjcmFzaAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4ODA4CisKKyAgICAgICAg V2hlbiB0aGUgUXRXZWJQcm9jZXNzIGNyYXNoZXMsIHRoZSByZWdpc3RlcmVkIFVSTCBTY2hlbWUK KyAgICAgICAgRGVsZWdhdGVzIGFyZSBub3QgcHJvcGVybHkgcmVzdG9yZWQgb3ZlciBJUEMgaW4g dGhlIG5ld2x5CisgICAgICAgIGxhdW5jaGVkIHByb2Nlc3MgaW5zdGFuY2UuCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0 L3FxdWlja3dlYnZpZXcuY3BwOgorICAgICAgICAoUVF1aWNrV2ViVmlld1ByaXZhdGU6OmRpZFJl bGF1bmNoUHJvY2Vzcyk6CisgICAgICAgIChRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6dXBkYXRlU2No ZW1lRGVsZWdhdGVzKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdf cF9wLmg6CisgICAgICAgIChRUXVpY2tXZWJWaWV3UHJpdmF0ZSk6CisKIDIwMTMtMDItMDQgIEJh bGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtTb3VwXSBXcmFw IFNvdXBTZXNzaW9uIGJ5IE5ldHdvcmtTdG9yYWdlU2Vzc2lvbgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKaW5kZXggNmY1MzJjMjU4MmE0 MTQzOTFjYTNmNDc4ODg5MDgxNGI4MWU2NDVlNS4uZmQ3OThhMjdlNjk3OGFiY2M2NGNmZDk3NGU1 MGY0NDRkNWNjMTAzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9x dC9xcXVpY2t3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3FxdWlja3dlYnZpZXcuY3BwCkBAIC01MDIsNiArNTAyLDcgQEAgdm9pZCBRUXVpY2tXZWJWaWV3 UHJpdmF0ZTo6ZGlkUmVsYXVuY2hQcm9jZXNzKCkKIAogICAgIHVwZGF0ZVZpZXdwb3J0U2l6ZSgp OwogICAgIHVwZGF0ZVVzZXJTY3JpcHRzKCk7CisgICAgdXBkYXRlU2NoZW1lRGVsZWdhdGVzKCk7 CiB9CiAKIFBhc3NPd25QdHI8RHJhd2luZ0FyZWFQcm94eT4gUVF1aWNrV2ViVmlld1ByaXZhdGU6 OmNyZWF0ZURyYXdpbmdBcmVhUHJveHkoKQpAQCAtNzgzLDYgKzc4NCwxNyBAQCB2b2lkIFFRdWlj a1dlYlZpZXdQcml2YXRlOjp1cGRhdGVVc2VyU2NyaXB0cygpCiAgICAgfQogfQogCit2b2lkIFFR dWlja1dlYlZpZXdQcml2YXRlOjp1cGRhdGVTY2hlbWVEZWxlZ2F0ZXMoKQoreworICAgIHdlYlBh Z2VQcm94eS0+cmVnaXN0ZXJBcHBsaWNhdGlvblNjaGVtZShBU0NJSUxpdGVyYWwoInFyYyIpKTsK KworICAgIFFRbWxMaXN0UHJvcGVydHk8UVF1aWNrVXJsU2NoZW1lRGVsZWdhdGU+IHNjaGVtZXMg PSBleHBlcmltZW50YWwtPnNjaGVtZURlbGVnYXRlcygpOworICAgIGZvciAoaW50IGkgPSAwLCBu dW1TY2hlbWVzID0gZXhwZXJpbWVudGFsLT5zY2hlbWVEZWxlZ2F0ZXNfQ291bnQoJnNjaGVtZXMp OyBpIDwgbnVtU2NoZW1lczsgKytpKSB7CisgICAgICAgIFFRdWlja1VybFNjaGVtZURlbGVnYXRl KiBzY2hlbWUgPSBleHBlcmltZW50YWwtPnNjaGVtZURlbGVnYXRlc19BdCgmc2NoZW1lcywgaSk7 CisgICAgICAgIHdlYlBhZ2VQcm94eS0+cmVnaXN0ZXJBcHBsaWNhdGlvblNjaGVtZShzY2hlbWUt PnNjaGVtZSgpKTsKKyAgICB9Cit9CisKIFFQb2ludEYgUVF1aWNrV2ViVmlld1ByaXZhdGU6OmNv bnRlbnRQb3MoKSBjb25zdAogewogICAgIFFfUShjb25zdCBRUXVpY2tXZWJWaWV3KTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wX3Au aCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wX3AuaApp bmRleCBhMGNhNjlhZWZjMWEyZmRmMTI1YzBlN2I0NzQxMDQyNjkyY2JhY2ZiLi45M2ZhNTRiNGYy NmM4NDZlNWQ0ZTQ2MWYyMDU4ZDU5NzdlMDIzYzBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcF9wLmgKKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3BfcC5oCkBAIC0xMjMsNiArMTIzLDcg QEAgcHVibGljOgogICAgIGJvb2wgdHJhbnNwYXJlbnRCYWNrZ3JvdW5kKCkgY29uc3Q7CiAgICAg dm9pZCBzZXROYXZpZ2F0b3JRdE9iamVjdEVuYWJsZWQoYm9vbCk7CiAgICAgdm9pZCB1cGRhdGVV c2VyU2NyaXB0cygpOworICAgIHZvaWQgdXBkYXRlU2NoZW1lRGVsZWdhdGVzKCk7CiAKICAgICBR UG9pbnRGIGNvbnRlbnRQb3MoKSBjb25zdDsKICAgICB2b2lkIHNldENvbnRlbnRQb3MoY29uc3Qg UVBvaW50RiYpOwo=