108807 2013-02-04 03:13:45 -0800 Coordinated Graphics : disconnectCustomFilterProgram does not do anything. 2013-02-04 20:46:39 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 yoon webkit-unassigned andersca noam webkit.review.bot zeno oldest_to_newest 824181 0 yoon 2013-02-04 03:13:45 -0800 Coordinated Graphics : disconnectCustomFilterProgram does not do anything. 824182 1 186333 yoon 2013-02-04 03:16:34 -0800 Created attachment 186333 Patch 824784 2 186333 noam 2013-02-04 14:49:08 -0800 Comment on attachment 186333 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186333&action=review LGTM, needs WK2 owner to review. > Source/WebKit2/ChangeLog:9 > + disconnect when CoordinatedLayerTreeHost destructed. destructed -> gets destructed. 824789 3 186465 yoon 2013-02-04 14:51:56 -0800 Created attachment 186465 Patch 824791 4 yoon 2013-02-04 14:53:21 -0800 (In reply to comment #2) > (From update of attachment 186333 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=186333&action=review > > LGTM, needs WK2 owner to review. > > > Source/WebKit2/ChangeLog:9 > > + disconnect when CoordinatedLayerTreeHost destructed. > > destructed -> gets destructed. Thanks. I fixed the sentence. 825080 5 186465 webkit.review.bot 2013-02-04 20:46:36 -0800 Comment on attachment 186465 Patch Clearing flags on attachment: 186465 Committed r141853: <http://trac.webkit.org/changeset/141853> 825081 6 webkit.review.bot 2013-02-04 20:46:39 -0800 All reviewed patches have been landed. Closing bug. 186333 2013-02-04 03:16:34 -0800 2013-02-04 14:51:52 -0800 Patch bug-108807-20130204201313.patch text/plain 1971 yoon U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZWUzYTlhOGY5NjJmOTU4 MTlhNmFjNGFmZjljYzI2NzUxMWNiZmVjYS4uZDFkMWEyMDI0MDcxZGZjNmNjMzA5ZTA1Y2I3NDY3 ZWZiMzU4NjY5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAyLTA0ICBHd2Fu ZyBZb29uIEh3YW5nICA8cnl1bWllbEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBDb29yZGlu YXRlZCBHcmFwaGljcyA6IGRpc2Nvbm5lY3RDdXN0b21GaWx0ZXJQcm9ncmFtIGRvZXMgbm90IGRv IGFueXRoaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA4ODA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2UgbmVlZCB0byBhZGQgbmV3bHkgY3JlYXRlZCBXZWJDdXN0b21GaWx0ZXJQcm9ncmFtUHJv eHkgdG8gYSBoYXNoc2V0IHRvCisgICAgICAgIGRpc2Nvbm5lY3Qgd2hlbiBDb29yZGluYXRlZExh eWVyVHJlZUhvc3QgZGVzdHJ1Y3RlZC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9D b29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHA6CisgICAgICAg IChXZWJLaXQ6OkNvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdDo6Y2hlY2tDdXN0b21GaWx0ZXJQcm9n cmFtUHJveGllcyk6CisKIDIwMTMtMDItMDQgIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJr aXQub3JnPgogCiAgICAgICAgIFtTb3VwXSBXcmFwIFNvdXBTZXNzaW9uIGJ5IE5ldHdvcmtTdG9y YWdlU2Vzc2lvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5h dGVkTGF5ZXJUcmVlSG9zdC5jcHAKaW5kZXggNmU1ZmI1NzIzMWM5Yjg5NWYyZjA2ZWE0MTUxMzAx Njk4ODEwYTQ1Yy4uOWJhYjEwOGE4NDQ3NWI2ZTY4Mzg4MzBjODY5YjQyYjBkNjgxM2QxNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3Jh cGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJl ZUhvc3QuY3BwCkBAIC00MzYsNiArNDM2LDcgQEAgdm9pZCBDb29yZGluYXRlZExheWVyVHJlZUhv c3Q6OmNoZWNrQ3VzdG9tRmlsdGVyUHJvZ3JhbVByb3hpZXMoY29uc3QgRmlsdGVyT3BlcmEKIAog ICAgICAgICBpZiAoIWN1c3RvbUZpbHRlclByb2dyYW1Qcm94eS0+Y2xpZW50KCkpIHsKICAgICAg ICAgICAgIGN1c3RvbUZpbHRlclByb2dyYW1Qcm94eS0+c2V0Q2xpZW50KHRoaXMpOworICAgICAg ICAgICAgbV9jdXN0b21GaWx0ZXJQcm9ncmFtcy5hZGQoY3VzdG9tRmlsdGVyUHJvZ3JhbVByb3h5 LmdldCgpKTsKICAgICAgICAgICAgIG1fd2ViUGFnZS0+c2VuZChNZXNzYWdlczo6Q29vcmRpbmF0 ZWRMYXllclRyZWVIb3N0UHJveHk6OkNyZWF0ZUN1c3RvbUZpbHRlclByb2dyYW0oY3VzdG9tRmls dGVyUHJvZ3JhbVByb3h5LT5pZCgpLCBjdXN0b21PcGVyYXRpb24tPnZhbGlkYXRlZFByb2dyYW0o KS0+dmFsaWRhdGVkUHJvZ3JhbUluZm8oKSkpOwogICAgICAgICB9IGVsc2UgewogICAgICAgICAg ICAgLy8gSWYgdGhlIGNsaWVudCB3YXMgbm90IGRpc2Nvbm5lY3RlZCB0aGVuIHRoaXMgY29vcmRp bmF0b3IgbXVzdCBiZSB0aGUgY2xpZW50IGZvciBpdC4K 186465 2013-02-04 14:51:56 -0800 2013-02-04 20:46:35 -0800 Patch bug-108807-20130205074835.patch text/plain 1976 yoon U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZWUzYTlhOGY5NjJmOTU4 MTlhNmFjNGFmZjljYzI2NzUxMWNiZmVjYS4uOGRlYzljMzE0YWY0NjQ4YzVkOGU3YTc2MmY1YjBm ZDE1Mjc1NjIzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAyLTA0ICBHd2Fu ZyBZb29uIEh3YW5nICA8cnl1bWllbEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBDb29yZGlu YXRlZCBHcmFwaGljcyA6IGRpc2Nvbm5lY3RDdXN0b21GaWx0ZXJQcm9ncmFtIGRvZXMgbm90IGRv IGFueXRoaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA4ODA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2UgbmVlZCB0byBhZGQgbmV3bHkgY3JlYXRlZCBXZWJDdXN0b21GaWx0ZXJQcm9ncmFtUHJv eHkgdG8gYSBoYXNoc2V0IHRvCisgICAgICAgIGRpc2Nvbm5lY3Qgd2hlbiBDb29yZGluYXRlZExh eWVyVHJlZUhvc3QgZ2V0cyBkZXN0cnVjdGVkLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQ YWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcDoKKyAg ICAgICAgKFdlYktpdDo6Q29vcmRpbmF0ZWRMYXllclRyZWVIb3N0OjpjaGVja0N1c3RvbUZpbHRl clByb2dyYW1Qcm94aWVzKToKKwogMjAxMy0wMi0wNCAgQmFsYXpzIEtlbGVtZW4gIDxrYmFsYXpz QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1NvdXBdIFdyYXAgU291cFNlc3Npb24gYnkgTmV0d29y a1N0b3JhZ2VTZXNzaW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJlZUhvc3QuY3BwIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29v cmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcAppbmRleCA2ZTVmYjU3MjMxYzliODk1ZjJmMDZlYTQx NTEzMDE2OTg4MTBhNDVjLi45YmFiMTA4YTg0NDc1YjZlNjgzODgzMGM4NjliNDJiMGQ2ODEzZDE0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0 ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJlZUhvc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5 ZXJUcmVlSG9zdC5jcHAKQEAgLTQzNiw2ICs0MzYsNyBAQCB2b2lkIENvb3JkaW5hdGVkTGF5ZXJU cmVlSG9zdDo6Y2hlY2tDdXN0b21GaWx0ZXJQcm9ncmFtUHJveGllcyhjb25zdCBGaWx0ZXJPcGVy YQogCiAgICAgICAgIGlmICghY3VzdG9tRmlsdGVyUHJvZ3JhbVByb3h5LT5jbGllbnQoKSkgewog ICAgICAgICAgICAgY3VzdG9tRmlsdGVyUHJvZ3JhbVByb3h5LT5zZXRDbGllbnQodGhpcyk7Cisg ICAgICAgICAgICBtX2N1c3RvbUZpbHRlclByb2dyYW1zLmFkZChjdXN0b21GaWx0ZXJQcm9ncmFt UHJveHkuZ2V0KCkpOwogICAgICAgICAgICAgbV93ZWJQYWdlLT5zZW5kKE1lc3NhZ2VzOjpDb29y ZGluYXRlZExheWVyVHJlZUhvc3RQcm94eTo6Q3JlYXRlQ3VzdG9tRmlsdGVyUHJvZ3JhbShjdXN0 b21GaWx0ZXJQcm9ncmFtUHJveHktPmlkKCksIGN1c3RvbU9wZXJhdGlvbi0+dmFsaWRhdGVkUHJv Z3JhbSgpLT52YWxpZGF0ZWRQcm9ncmFtSW5mbygpKSk7CiAgICAgICAgIH0gZWxzZSB7CiAgICAg ICAgICAgICAvLyBJZiB0aGUgY2xpZW50IHdhcyBub3QgZGlzY29ubmVjdGVkIHRoZW4gdGhpcyBj b29yZGluYXRvciBtdXN0IGJlIHRoZSBjbGllbnQgZm9yIGl0Lgo=