10880 2006-09-15 23:25:07 -0700 Do..while loop gains a semicolon each time it is toStringed 2007-05-08 20:33:32 -0700 1 1 1 Unclassified WebKit JavaScriptCore 420+ Mac OS X 10.4 RESOLVED FIXED HasReduction P2 Minor --- 13638 1 jruderman webkit-unassigned gavin.sharp oldest_to_newest 55635 0 jruderman 2006-09-15 23:25:07 -0700 javascript:f=function(){do{}while(0)}; for(i=0;i<4;++i) { alert(f); f=eval("(" + f + ")"); } 10679 1 eric 2007-05-08 02:45:26 -0700 Although no website would ever care about this, this totally breaks jruderman's testing tool since so many of the generated tests seem to contain do {} while 10714 2 14416 kkinnunen 2007-05-08 11:20:04 -0700 Created attachment 14416 Avoid new semicolon when toString()ing function which has do..while EmptyStatement got created after every do..while();, because ';' was not consumed as part of the do..while. 10715 3 14416 darin 2007-05-08 11:53:30 -0700 Comment on attachment 14416 Avoid new semicolon when toString()ing function which has do..while Nice! r=me 10718 4 ddkilzer 2007-05-08 13:46:55 -0700 (In reply to comment #3) > (From update of attachment 14416 [edit]) > Nice! r=me Please avoid using tabs in ChangeLog entries in the future. Thanks! 10662 5 eric 2007-05-08 20:33:32 -0700 Need a changelog for layouttests next time too. Commited as 21320 14416 2007-05-08 11:20:04 -0700 2007-05-08 11:53:30 -0700 Avoid new semicolon when toString()ing function which has do..while do-while-semicolon.diff text/plain 3868 kkinnunen SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzA1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDctMDUtMDggIEtpbW1vIEtp bm51bmVuICA8a2ltbW9rQGlraS5maT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworCQktIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODgw IChEby4ud2hpbGUgbG9vcCBnYWlucyAKKwkJYSBzZW1pY29sb24gZWFjaCB0aW1lIGl0IGlzIHRv U3RyaW5nZWQpCisJCUdyYW1tYXIgaW4gRWNtYS02NjI2MiwgMTIuNjogImRvIFN0YXRlbWVudCB3 aGlsZSAoIEV4cHJlc3Npb24gKTsiCisJCUVtcHR5U3RhdGVtZW50IHdhcyBjcmVhdGVkIGFmdGVy IGV2ZXJ5IGRvLi53aGlsZShleHByKSB3aGljaAorCQloYWQgc2VtaWNvbG9uIGF0IHRoZSBlbmQu CisJCQorICAgICAgICAqIGtqcy9ncmFtbWFyLnk6IFJlcXVpcmUgc2VtaWNvbG9uIGF0IHRoZSBl bmQgb2YgZG8uLndoaWxlCisKIDIwMDctMDUtMDQgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkZWxlLgpJbmRleDogSmF2YVNjcmlwdENvcmUv a2pzL2dyYW1tYXIueQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ranMvZ3JhbW1hci55 CShyZXZpc2lvbiAyMTMwNSkKKysrIEphdmFTY3JpcHRDb3JlL2tqcy9ncmFtbWFyLnkJKHdvcmtp bmcgY29weSkKQEAgLTcyMSw3ICs3MjEsOCBAQCBJZlN0YXRlbWVudDoKIDsKIAogSXRlcmF0aW9u U3RhdGVtZW50OgotICAgIERPIFN0YXRlbWVudCBXSElMRSAnKCcgRXhwciAnKScgICAgIHsgJCQg PSBuZXcgRG9XaGlsZU5vZGUoJDIsICQ1KTsgREJHKCQkLCBAMSwgQDMpO30KKyAgICBETyBTdGF0 ZW1lbnQgV0hJTEUgJygnIEV4cHIgJyknICc7JyAgICB7ICQkID0gbmV3IERvV2hpbGVOb2RlKCQy LCAkNSk7IERCRygkJCwgQDEsIEAzKTt9CisgIHwgRE8gU3RhdGVtZW50IFdISUxFICcoJyBFeHBy ICcpJyBlcnJvciAgICB7ICQkID0gbmV3IERvV2hpbGVOb2RlKCQyLCAkNSk7IERCRygkJCwgQDEs IEAzKTsgQVVUT19TRU1JQ09MT047fQogICB8IFdISUxFICcoJyBFeHByICcpJyBTdGF0ZW1lbnQg ICAgICAgIHsgJCQgPSBuZXcgV2hpbGVOb2RlKCQzLCAkNSk7IERCRygkJCwgQDEsIEA0KTsgfQog ICB8IEZPUiAnKCcgRXhwck5vSW5PcHQgJzsnIEV4cHJPcHQgJzsnIEV4cHJPcHQgJyknIFN0YXRl bWVudAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHsgJCQgPSBuZXcg Rm9yTm9kZSgkMywgJDUsICQ3LCAkOSk7IERCRygkJCwgQDEsIEA4KTsgfQpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9qcy9kby13aGlsZS1zZW1pY29sb24tZXhwZWN0ZWQudHh0Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2Zhc3QvanMvZG8td2hpbGUtc2VtaWNvbG9uLWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvanMvZG8td2hpbGUtc2VtaWNvbG9uLWV4 cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMyBAQAorVGhpcyB0ZXN0IGNoZWNr cyB0aGF0IHRvU3RyaW5nKCkgcm91bmQtdHJpcCBvbiBhIGZ1bmN0aW9uIHRoYXQgaGFzIGRvLi53 aGlsZSBpbiBKYXZhU2NyaXB0IGRvZXMgbm90IGluc2VydCBleHRyYSBzZW1pY29sb24uCisKK09u IHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxv d2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIHVldWYxIGlzIHVmMQorUEFTUyB1ZXVm MiBpcyB1ZjIKK1BBU1MgdWV1ZjMgaXMgdWYzCitQQVNTIHVldWY0IGlzIHVmNAorUEFTUyBzdWNj ZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRl c3RzL2Zhc3QvanMvZG8td2hpbGUtc2VtaWNvbG9uLmh0bWwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvZmFzdC9qcy9kby13aGlsZS1zZW1pY29sb24uaHRtbAkocmV2aXNpb24gMCkKKysrIExh eW91dFRlc3RzL2Zhc3QvanMvZG8td2hpbGUtc2VtaWNvbG9uLmh0bWwJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEsMTMgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwv L0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9InJlc291 cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0icmVzb3VyY2VzL2pzLXRlc3Qt cHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48 L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvZG8t d2hpbGUtc2VtaWNvbG9uLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvanMt dGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IExheW91dFRl c3RzL2Zhc3QvanMvcmVzb3VyY2VzL2RvLXdoaWxlLXNlbWljb2xvbi5qcwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9kby13aGlsZS1zZW1pY29sb24uanMJKHJl dmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9kby13aGlsZS1zZW1p Y29sb24uanMJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNDYgQEAKK2Rlc2NyaXB0aW9uKAorIlRo aXMgdGVzdCBjaGVja3MgdGhhdCB0b1N0cmluZygpIHJvdW5kLXRyaXAgb24gYSBmdW5jdGlvbiB0 aGF0IGhhcyBkby4ud2hpbGUgaW4gSmF2YVNjcmlwdCBkb2VzIG5vdCBpbnNlcnQgZXh0cmEgc2Vt aWNvbG9uLiIKKyk7CisKK2Z1bmN0aW9uIGYxKCkgeworICAgIGRvIHt9IHdoaWxlKDApOworfQor CitmdW5jdGlvbiBmMigpIHsKKyAgICBkbyB7fSB3aGlsZSgwKQorfQorCitmdW5jdGlvbiBmMygp IHsKKyAgICBkbyB7fSB3aGlsZSgwKSAgIDsKK30KKworZnVuY3Rpb24gZjQoKSB7CisgICAgZG8g e30gd2hpbGUoMCkgIC8qZW1wdHkqLyA7Cit9CisKKworCitpZiAodHlwZW9mIHVuZXZhbCA9PSAi dW5kZWZpbmVkIikKKyAgICB1bmV2YWwgPSBmdW5jdGlvbih4KSB7IHJldHVybiAnKCcgKyB4LnRv U3RyaW5nKCkrICcpJzsgfQorCisKK3VmMSA9IHVuZXZhbChmMSk7Cit1ZXVmMSA9IHVuZXZhbChl dmFsKHVuZXZhbChmMSkpKTsKKwordWYyID0gdW5ldmFsKGYyKTsKK3VldWYyID0gdW5ldmFsKGV2 YWwodW5ldmFsKGYyKSkpOworCit1ZjMgPSB1bmV2YWwoZjMpOwordWV1ZjMgPSB1bmV2YWwoZXZh bCh1bmV2YWwoZjMpKSk7CisKK3VmNCA9IHVuZXZhbChmNCk7Cit1ZXVmNCA9IHVuZXZhbChldmFs KHVuZXZhbChmNCkpKTsKKworCisKK3Nob3VsZEJlKCJ1ZXVmMSIsICJ1ZjEiKTsKK3Nob3VsZEJl KCJ1ZXVmMiIsICJ1ZjIiKTsKK3Nob3VsZEJlKCJ1ZXVmMyIsICJ1ZjMiKTsKK3Nob3VsZEJlKCJ1 ZXVmNCIsICJ1ZjQiKTsKKwordmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cg==