108784 2013-02-03 18:25:20 -0800 Fix build warning after r141648 2013-02-04 16:10:58 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ky0.choi ky0.choi andersca gyuyoung.kim haraken lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 823962 0 ky0.choi 2013-02-03 18:25:20 -0800 /home/cky/open-source/WebKit/Source/WebKit2/UIProcess/Storage/StorageManager.cpp:52:6: warning: unused parameter ‘storageAreaID’ [-Wunused-parameter] /home/cky/open-source/WebKit/Source/WebKit2/UIProcess/Storage/StorageManager.cpp:52:6: warning: unused parameter ‘storageNamespaceID’ [-Wunused-parameter] /home/cky/open-source/WebKit/Source/WebKit2/UIProcess/Storage/StorageManager.cpp:56:6: warning: unused parameter ‘storageAreaID’ [-Wunused-parameter] 823966 1 186286 ky0.choi 2013-02-03 18:29:23 -0800 Created attachment 186286 Patch 823970 2 186286 haraken 2013-02-03 18:34:43 -0800 Comment on attachment 186286 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186286&action=review > Source/WebKit2/UIProcess/Storage/StorageManager.cpp:52 > -void StorageManager::createStorageArea(CoreIPC::Connection*, uint64_t storageAreaID, uint64_t storageNamespaceID, const SecurityOriginData&) > +void StorageManager::createStorageArea(CoreIPC::Connection*, uint64_t, uint64_t, const SecurityOriginData&) You might want to use 'uint64_t /* storageAreaID */, uint64_t /* storageNamespaceID */', because otherwise you cannot distinguish two parameters. 823972 3 186286 ky0.choi 2013-02-03 18:39:16 -0800 Comment on attachment 186286 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186286&action=review >> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:52 >> +void StorageManager::createStorageArea(CoreIPC::Connection*, uint64_t, uint64_t, const SecurityOriginData&) > > You might want to use 'uint64_t /* storageAreaID */, uint64_t /* storageNamespaceID */', because otherwise you cannot distinguish two parameters. Ok I will change. 823986 4 186288 ky0.choi 2013-02-03 19:32:28 -0800 Created attachment 186288 Patch 823987 5 186288 haraken 2013-02-03 19:33:00 -0800 Comment on attachment 186288 Patch thanks 823996 6 186288 webkit.review.bot 2013-02-03 20:27:20 -0800 Comment on attachment 186288 Patch Clearing flags on attachment: 186288 Committed r141732: <http://trac.webkit.org/changeset/141732> 823997 7 webkit.review.bot 2013-02-03 20:27:25 -0800 All reviewed patches have been landed. Closing bug. 824500 8 andersca 2013-02-04 10:14:32 -0800 (In reply to comment #5) > (From update of attachment 186288 [details]) > thanks Kentaro, this is a WebKit2 patch and needs to be reviewed by a WebKit2 owner. This is not the right fix either. The right fix is to use UNUSED_PARAM. 824866 9 haraken 2013-02-04 16:10:58 -0800 (In reply to comment #8) > Kentaro, this is a WebKit2 patch and needs to be reviewed by a WebKit2 owner. This is not the right fix either. The right fix is to use UNUSED_PARAM. I'm sorry. I'll be careful. I think that was a right fix. We use UNUSED_PARAM only when a parameter is in an #if macro. (Please look at this discussion: http://markmail.org/message/jv3ncbuhropkkzoq ) 186286 2013-02-03 18:29:23 -0800 2013-02-03 19:32:28 -0800 Patch diff text/plain 1563 ky0.choi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmNzhiZmFjLi5lNWRkNDA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDItMDMgIEt3YW5nWW9uZyBDaG9pICA8a3kwLmNob2lAc2Ftc3VuZy5jb20+CisK KyAgICAgICAgRml4IGJ1aWxkIHdhcm5pbmcgYWZ0ZXIgcjE0MTY0OAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4Nzg0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IC1XdW51c2VkLXBhcmFtZXRlciBi dWlsZCB3YXJuaW5nLgorCisgICAgICAgICogVUlQcm9jZXNzL1N0b3JhZ2UvU3RvcmFnZU1hbmFn ZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpTdG9yYWdlTWFuYWdlcjo6Y3JlYXRlU3RvcmFnZUFy ZWEpOgorICAgICAgICAoV2ViS2l0OjpTdG9yYWdlTWFuYWdlcjo6ZGVzdHJveVN0b3JhZ2VBcmVh KToKKwogMjAxMy0wMi0wMyAgSm9hbm1hcmllIERpZ2dzICA8amRpZ2dzQGlnYWxpYS5jb20+CiAK ICAgICAgICAgW0dUS10gTWFrZSBkaXN0Y2hlY2sgZmFpbHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9TdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9TdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyLmNwcAppbmRleCBhNWM3MTI2Li45 NTg4YTVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvU3RvcmFnZS9TdG9y YWdlTWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1N0b3JhZ2UvU3Rv cmFnZU1hbmFnZXIuY3BwCkBAIC00OSwxMSArNDksMTEgQEAgdm9pZCBTdG9yYWdlTWFuYWdlcjo6 ZGlkUmVjZWl2ZU1lc3NhZ2VPbkNvbm5lY3Rpb25Xb3JrUXVldWUoQ29yZUlQQzo6Q29ubmVjdGlv bioKICAgICAgICAgZGlkUmVjZWl2ZVN0b3JhZ2VNYW5hZ2VyTWVzc2FnZU9uQ29ubmVjdGlvbldv cmtRdWV1ZShjb25uZWN0aW9uLCBkZWNvZGVyLCBkaWRIYW5kbGVNZXNzYWdlKTsKIH0KIAotdm9p ZCBTdG9yYWdlTWFuYWdlcjo6Y3JlYXRlU3RvcmFnZUFyZWEoQ29yZUlQQzo6Q29ubmVjdGlvbios IHVpbnQ2NF90IHN0b3JhZ2VBcmVhSUQsIHVpbnQ2NF90IHN0b3JhZ2VOYW1lc3BhY2VJRCwgY29u c3QgU2VjdXJpdHlPcmlnaW5EYXRhJikKK3ZvaWQgU3RvcmFnZU1hbmFnZXI6OmNyZWF0ZVN0b3Jh Z2VBcmVhKENvcmVJUEM6OkNvbm5lY3Rpb24qLCB1aW50NjRfdCwgdWludDY0X3QsIGNvbnN0IFNl Y3VyaXR5T3JpZ2luRGF0YSYpCiB7CiB9CiAKLXZvaWQgU3RvcmFnZU1hbmFnZXI6OmRlc3Ryb3lT dG9yYWdlQXJlYShDb3JlSVBDOjpDb25uZWN0aW9uKiwgdWludDY0X3Qgc3RvcmFnZUFyZWFJRCkK K3ZvaWQgU3RvcmFnZU1hbmFnZXI6OmRlc3Ryb3lTdG9yYWdlQXJlYShDb3JlSVBDOjpDb25uZWN0 aW9uKiwgdWludDY0X3QpCiB7CiB9CiAK 186288 2013-02-03 19:32:28 -0800 2013-02-03 20:27:20 -0800 Patch diff text/plain 1608 ky0.choi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmNzhiZmFjLi5lNWRkNDA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDItMDMgIEt3YW5nWW9uZyBDaG9pICA8a3kwLmNob2lAc2Ftc3VuZy5jb20+CisK KyAgICAgICAgRml4IGJ1aWxkIHdhcm5pbmcgYWZ0ZXIgcjE0MTY0OAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4Nzg0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IC1XdW51c2VkLXBhcmFtZXRlciBi dWlsZCB3YXJuaW5nLgorCisgICAgICAgICogVUlQcm9jZXNzL1N0b3JhZ2UvU3RvcmFnZU1hbmFn ZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpTdG9yYWdlTWFuYWdlcjo6Y3JlYXRlU3RvcmFnZUFy ZWEpOgorICAgICAgICAoV2ViS2l0OjpTdG9yYWdlTWFuYWdlcjo6ZGVzdHJveVN0b3JhZ2VBcmVh KToKKwogMjAxMy0wMi0wMyAgSm9hbm1hcmllIERpZ2dzICA8amRpZ2dzQGlnYWxpYS5jb20+CiAK ICAgICAgICAgW0dUS10gTWFrZSBkaXN0Y2hlY2sgZmFpbHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9TdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9TdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyLmNwcAppbmRleCBhNWM3MTI2Li4z NGY0MzlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvU3RvcmFnZS9TdG9y YWdlTWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1N0b3JhZ2UvU3Rv cmFnZU1hbmFnZXIuY3BwCkBAIC00OSwxMSArNDksMTEgQEAgdm9pZCBTdG9yYWdlTWFuYWdlcjo6 ZGlkUmVjZWl2ZU1lc3NhZ2VPbkNvbm5lY3Rpb25Xb3JrUXVldWUoQ29yZUlQQzo6Q29ubmVjdGlv bioKICAgICAgICAgZGlkUmVjZWl2ZVN0b3JhZ2VNYW5hZ2VyTWVzc2FnZU9uQ29ubmVjdGlvbldv cmtRdWV1ZShjb25uZWN0aW9uLCBkZWNvZGVyLCBkaWRIYW5kbGVNZXNzYWdlKTsKIH0KIAotdm9p ZCBTdG9yYWdlTWFuYWdlcjo6Y3JlYXRlU3RvcmFnZUFyZWEoQ29yZUlQQzo6Q29ubmVjdGlvbios IHVpbnQ2NF90IHN0b3JhZ2VBcmVhSUQsIHVpbnQ2NF90IHN0b3JhZ2VOYW1lc3BhY2VJRCwgY29u c3QgU2VjdXJpdHlPcmlnaW5EYXRhJikKK3ZvaWQgU3RvcmFnZU1hbmFnZXI6OmNyZWF0ZVN0b3Jh Z2VBcmVhKENvcmVJUEM6OkNvbm5lY3Rpb24qLCB1aW50NjRfdCAvKiBzdG9yYWdlQXJlYUlEICov LCB1aW50NjRfdCAvKiBzdG9yYWdlTmFtZXNwYWNlSUQgKi8sIGNvbnN0IFNlY3VyaXR5T3JpZ2lu RGF0YSYpCiB7CiB9CiAKLXZvaWQgU3RvcmFnZU1hbmFnZXI6OmRlc3Ryb3lTdG9yYWdlQXJlYShD b3JlSVBDOjpDb25uZWN0aW9uKiwgdWludDY0X3Qgc3RvcmFnZUFyZWFJRCkKK3ZvaWQgU3RvcmFn ZU1hbmFnZXI6OmRlc3Ryb3lTdG9yYWdlQXJlYShDb3JlSVBDOjpDb25uZWN0aW9uKiwgdWludDY0 X3QpCiB7CiB9CiAK