108776 2013-02-03 16:24:35 -0800 Web Inspector: prevent crash, add required error string value 2013-02-05 07:07:29 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 prybin webkit-unassigned apavlov buildbot dglazkov keishi loislo pfeldman pmuellr rniwa vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 823910 0 prybin 2013-02-03 16:24:35 -0800 Make inspector more fair to either-result-or-error-string convention. 823914 1 186275 prybin 2013-02-03 16:35:34 -0800 Created attachment 186275 Patch 823941 2 186275 buildbot 2013-02-03 17:24:47 -0800 Comment on attachment 186275 Patch Attachment 186275 did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16359804 New failing tests: inspector/debugger/watch-expressions-preserve-expansion.html 823942 3 186275 buildbot 2013-02-03 17:42:52 -0800 Comment on attachment 186275 Patch Attachment 186275 did not pass win-ews (win): Output: http://queues.webkit.org/results/16354870 823944 4 186275 buildbot 2013-02-03 17:57:27 -0800 Comment on attachment 186275 Patch Attachment 186275 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16355911 New failing tests: inspector/debugger/watch-expressions-preserve-expansion.html 823958 5 186275 buildbot 2013-02-03 18:23:04 -0800 Comment on attachment 186275 Patch Attachment 186275 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16352918 New failing tests: inspector/debugger/watch-expressions-preserve-expansion.html 823967 6 186275 webkit.review.bot 2013-02-03 18:31:07 -0800 Comment on attachment 186275 Patch Attachment 186275 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16359826 New failing tests: inspector/debugger/watch-expressions-preserve-expansion.html 824110 7 186275 pfeldman 2013-02-04 00:24:01 -0800 Comment on attachment 186275 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186275&action=review > Source/WebCore/inspector/InspectorRuntimeAgent.cpp:84 > + *errorString = "Capybara, capybara capybara capybara: capybara!"; Please use proper wording. 824212 8 prybin 2013-02-04 03:46:01 -0800 (In reply to comment #7) > (From update of attachment 186275 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=186275&action=review > > > Source/WebCore/inspector/InspectorRuntimeAgent.cpp:84 > > + *errorString = "Capybara, capybara capybara capybara: capybara!"; > > Please use proper wording. I meant I didn't know what the proper wording was here. Could you please advise? 824880 9 prybin 2013-02-04 16:28:55 -0800 > I meant I didn't know what the proper wording was here. Could you please advise? Oh, wait. That's something stupid here, error string must be already provided. Let me watch again. 824902 10 186497 prybin 2013-02-04 16:55:52 -0800 Created attachment 186497 Patch 824905 11 prybin 2013-02-04 16:57:14 -0800 (In reply to comment #10) > Patch Please advise what a proper wording should be instead of bogus message currently in patch. This is a protocol-visible message. 825273 12 186497 pfeldman 2013-02-05 01:45:56 -0800 Comment on attachment 186497 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186497&action=review > Source/WebCore/inspector/PageRuntimeAgent.cpp:141 > + *errorString = "Main world execution context not found. Capybara! Capybara!"; Is this some kind of joke? 825318 13 186586 prybin 2013-02-05 02:48:08 -0800 Created attachment 186586 Patch 825324 14 prybin 2013-02-05 02:49:44 -0800 > > Source/WebCore/inspector/PageRuntimeAgent.cpp:141 > > + *errorString = "Main world execution context not found. Capybara! Capybara!"; > > Is this some kind of joke? Fixed. 825403 15 186586 pfeldman 2013-02-05 05:31:55 -0800 Comment on attachment 186586 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186586&action=review > Source/WebCore/inspector/PageRuntimeAgent.cpp:140 > + // FIXME(code.review): correct or confirm the message. Please remove this fixme. > Source/WebCore/inspector/PageRuntimeAgent.cpp:141 > + *errorString = "Main world execution context not found."; "Internal error: main world execution context not found." ? 825415 16 186610 prybin 2013-02-05 05:49:16 -0800 Created attachment 186610 Patch 825452 17 186610 webkit.review.bot 2013-02-05 07:07:24 -0800 Comment on attachment 186610 Patch Clearing flags on attachment: 186610 Committed r141891: <http://trac.webkit.org/changeset/141891> 825454 18 webkit.review.bot 2013-02-05 07:07:29 -0800 All reviewed patches have been landed. Closing bug. 186275 2013-02-03 16:35:34 -0800 2013-02-04 16:55:47 -0800 Patch bug-108776-20130204043213.patch text/plain 2931 prybin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDhkZjYxY2YwMDYzYTc2 NjA5MmMzNGJmYjc2Nzk3M2M1NmE3M2Q5NC4uMDk2MDA2M2YzNGI3MjYzODdiNGZhYTBlYTkyMmNj YWJkOTlkZTQ5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAyLTAzICBQZXRl ciBSeWJpbiAgPHBldGVyLnJ5YmluQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBwcmV2ZW50IGNyYXNoLCBhZGQgcmVxdWlyZWQgZXJyb3Igc3RyaW5nIHZhbHVlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg3NzYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFcnJvciBzdHJpbmcgaXMg YXNzaWduZWQgd2hlcmUgbWlzc2luZywgYXNzZXJ0IGlzIGFkZGVkIHdoZXJlIGVtcHR5IHN0cmlu ZyBpcworICAgICAgICBwb3NzaWJsZS4KKworICAgICAgICAqIGluc3BlY3Rvci9JbmplY3RlZFNj cmlwdEJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5qZWN0ZWRTY3JpcHRCYXNlOjptYWtl RXZhbENhbGwpOgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JSdW50aW1lQWdlbnQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yUnVudGltZUFnZW50OjpldmFsdWF0ZSk6CisK IDIwMTMtMDEtMjkgIEFuZHJleSBMdXNobmlrb3YgIDxsdXNobmlrb3ZAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGZpeCBib3R0b20gc3BhbiBpbiB0b2tlbiBoaWdobGln aHQgaW4gRFRFCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRT Y3JpcHRCYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdEJh c2UuY3BwCmluZGV4IDE5YzBhYTFiNWIxMjc3N2YzNDVhMThkYjVlNWUzMmUxNjc1OTcyZGQuLjA5 YmNhYWM1YzFjYWMzMGMwYmM1MjVmMjQzZjdhMjE0YjE4NGMwYzIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdEJhc2UuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdEJhc2UuY3BwCkBAIC0xMjQsNiArMTI0LDcg QEAgdm9pZCBJbmplY3RlZFNjcmlwdEJhc2U6Om1ha2VFdmFsQ2FsbChFcnJvclN0cmluZyogZXJy b3JTdHJpbmcsIFNjcmlwdEZ1bmN0aW9uQ2EKICAgICB9CiAgICAgaWYgKHJlc3VsdC0+dHlwZSgp ID09IEluc3BlY3RvclZhbHVlOjpUeXBlU3RyaW5nKSB7CiAgICAgICAgIHJlc3VsdC0+YXNTdHJp bmcoZXJyb3JTdHJpbmcpOworICAgICAgICBBU1NFUlQoZXJyb3JTdHJpbmctPmxlbmd0aCgpKTsK ICAgICAgICAgcmV0dXJuOwogICAgIH0KICAgICBSZWZQdHI8SW5zcGVjdG9yT2JqZWN0PiByZXN1 bHRQYWlyID0gcmVzdWx0LT5hc09iamVjdCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL0luc3BlY3RvclJ1bnRpbWVBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9yUnVudGltZUFnZW50LmNwcAppbmRleCAwNjk1OTk2MjdjZGQ3YjhiZmIx YjdlZTQzYzMxNDg0M2UzNjE4MTE4Li5hYjJkOGE5MmZlNzFjNTI0NjMwYWNhNDFmZDJiZTE4MmIx YzI2MmIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUnVu dGltZUFnZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUnVu dGltZUFnZW50LmNwcApAQCAtNzksOCArNzksMTEgQEAgc3RhdGljIFNjcmlwdERlYnVnU2VydmVy OjpQYXVzZU9uRXhjZXB0aW9uc1N0YXRlIHNldFBhdXNlT25FeGNlcHRpb25zU3RhdGUoU2NyaXAK IHZvaWQgSW5zcGVjdG9yUnVudGltZUFnZW50OjpldmFsdWF0ZShFcnJvclN0cmluZyogZXJyb3JT dHJpbmcsIGNvbnN0IFN0cmluZyYgZXhwcmVzc2lvbiwgY29uc3QgU3RyaW5nKiBjb25zdCBvYmpl Y3RHcm91cCwgY29uc3QgYm9vbCogY29uc3QgaW5jbHVkZUNvbW1hbmRMaW5lQVBJLCBjb25zdCBi b29sKiBjb25zdCBkb05vdFBhdXNlT25FeGNlcHRpb25zQW5kTXV0ZUNvbnNvbGUsIGNvbnN0IGlu dCogZXhlY3V0aW9uQ29udGV4dElkLCBjb25zdCBib29sKiBjb25zdCByZXR1cm5CeVZhbHVlLCBj b25zdCBib29sKiBnZW5lcmF0ZVByZXZpZXcsIFJlZlB0cjxUeXBlQnVpbGRlcjo6UnVudGltZTo6 UmVtb3RlT2JqZWN0PiYgcmVzdWx0LCBUeXBlQnVpbGRlcjo6T3B0T3V0cHV0PGJvb2w+KiB3YXNU aHJvd24pCiB7CiAgICAgSW5qZWN0ZWRTY3JpcHQgaW5qZWN0ZWRTY3JpcHQgPSBpbmplY3RlZFNj cmlwdEZvckV2YWwoZXJyb3JTdHJpbmcsIGV4ZWN1dGlvbkNvbnRleHRJZCk7Ci0gICAgaWYgKGlu amVjdGVkU2NyaXB0Lmhhc05vVmFsdWUoKSkKKyAgICBpZiAoaW5qZWN0ZWRTY3JpcHQuaGFzTm9W YWx1ZSgpKSB7CisgICAgICAgIC8vIEZJWE1FOiBmaW5kIGEgYmV0dGVyIHdvcmRpbmcgaGVyZS4K KyAgICAgICAgKmVycm9yU3RyaW5nID0gIkNhcHliYXJhLCBjYXB5YmFyYSBjYXB5YmFyYSBjYXB5 YmFyYTogY2FweWJhcmEhIjsKICAgICAgICAgcmV0dXJuOworICAgIH0KICNpZiBFTkFCTEUoSkFW QVNDUklQVF9ERUJVR0dFUikKICAgICBTY3JpcHREZWJ1Z1NlcnZlcjo6UGF1c2VPbkV4Y2VwdGlv bnNTdGF0ZSBwcmV2aW91c1BhdXNlT25FeGNlcHRpb25zU3RhdGUgPSBTY3JpcHREZWJ1Z1NlcnZl cjo6RG9udFBhdXNlT25FeGNlcHRpb25zOwogICAgIGlmIChhc0Jvb2woZG9Ob3RQYXVzZU9uRXhj ZXB0aW9uc0FuZE11dGVDb25zb2xlKSkK 186497 2013-02-04 16:55:52 -0800 2013-02-05 02:48:02 -0800 Patch bug-108776-20130205045230.patch text/plain 2628 prybin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxODI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTRkZjJlNDAxOWI1OTdi ZTE0ZGFlMzVlNzlkMTJmMDMxODA4OTNmZi4uYTU1NTI5ZjI0OGI3NWUwMjhhZmVjODFiNTUyOTM4 NDFiNTk4ZWQyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAyLTA0ICBQZXRl ciBSeWJpbiAgPHByeWJpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog cHJldmVudCBjcmFzaCwgYWRkIHJlcXVpcmVkIGVycm9yIHN0cmluZyB2YWx1ZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4Nzc2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXJyb3Igc3RyaW5nIGlzIGFz c2lnbmVkIHdoZXJlIG1pc3NpbmcsIGFzc2VydCBpcyBhZGRlZCB3aGVyZSBlbXB0eSBzdHJpbmcg aXMKKyAgICAgICAgcG9zc2libGUuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5qZWN0ZWRTY3Jp cHRCYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkluamVjdGVkU2NyaXB0QmFzZTo6bWFrZUV2 YWxDYWxsKToKKyAgICAgICAgKiBpbnNwZWN0b3IvUGFnZVJ1bnRpbWVBZ2VudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpQYWdlUnVudGltZUFnZW50OjppbmplY3RlZFNjcmlwdEZvckV2YWwpOgor CiAyMDEzLTAyLTA0ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgogCiAg ICAgICAgIFtTb3VwXSBSZW1vdmUgZHVwbGljYXRlIHNldHRpbmcgb2YgZmlyc3QgcGFydHkgZm9y IGNvb2tpZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNj cmlwdEJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0QmFz ZS5jcHAKaW5kZXggMTljMGFhMWI1YjEyNzc3ZjM0NWExOGRiNWU1ZTMyZTE2NzU5NzJkZC4uMDli Y2FhYzVjMWNhYzMwYzBiYzUyNWYyNDNmN2EyMTRiMTg0YzBjMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0QmFzZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0QmFzZS5jcHAKQEAgLTEyNCw2ICsxMjQsNyBA QCB2b2lkIEluamVjdGVkU2NyaXB0QmFzZTo6bWFrZUV2YWxDYWxsKEVycm9yU3RyaW5nKiBlcnJv clN0cmluZywgU2NyaXB0RnVuY3Rpb25DYQogICAgIH0KICAgICBpZiAocmVzdWx0LT50eXBlKCkg PT0gSW5zcGVjdG9yVmFsdWU6OlR5cGVTdHJpbmcpIHsKICAgICAgICAgcmVzdWx0LT5hc1N0cmlu ZyhlcnJvclN0cmluZyk7CisgICAgICAgIEFTU0VSVChlcnJvclN0cmluZy0+bGVuZ3RoKCkpOwog ICAgICAgICByZXR1cm47CiAgICAgfQogICAgIFJlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IHJlc3Vs dFBhaXIgPSByZXN1bHQtPmFzT2JqZWN0KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvUGFnZVJ1bnRpbWVBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv UGFnZVJ1bnRpbWVBZ2VudC5jcHAKaW5kZXggNTg0NGE1ZTg4NmE1NzM2MWJkMzNmOWJmZjExN2M1 OTVjY2M2NzQ3YS4uNjczNjNiZmEwZjkwYTA0OGRiZTI4ZTYzYWExNTdiOWE4OTM0NDEzZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL1BhZ2VSdW50aW1lQWdlbnQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9QYWdlUnVudGltZUFnZW50LmNwcApAQCAtMTM1 LDcgKzEzNSwxMSBAQCBJbmplY3RlZFNjcmlwdCBQYWdlUnVudGltZUFnZW50OjppbmplY3RlZFNj cmlwdEZvckV2YWwoRXJyb3JTdHJpbmcqIGVycm9yU3RyaW5nLAogewogICAgIGlmICghZXhlY3V0 aW9uQ29udGV4dElkKSB7CiAgICAgICAgIFNjcmlwdFN0YXRlKiBzY3JpcHRTdGF0ZSA9IG1haW5X b3JsZFNjcmlwdFN0YXRlKG1faW5zcGVjdGVkUGFnZS0+bWFpbkZyYW1lKCkpOwotICAgICAgICBy ZXR1cm4gaW5qZWN0ZWRTY3JpcHRNYW5hZ2VyKCktPmluamVjdGVkU2NyaXB0Rm9yKHNjcmlwdFN0 YXRlKTsKKyAgICAgICAgSW5qZWN0ZWRTY3JpcHQgcmVzdWx0ID0gaW5qZWN0ZWRTY3JpcHRNYW5h Z2VyKCktPmluamVjdGVkU2NyaXB0Rm9yKHNjcmlwdFN0YXRlKTsKKyAgICAgICAgaWYgKHJlc3Vs dC5oYXNOb1ZhbHVlKCkpCisgICAgICAgICAgICAvLyBGSVhNRShjb2RlLnJldmlldyk6IGNvcnJl Y3Qgb3IgY29uZmlybSB0aGUgbWVzc2FnZS4KKyAgICAgICAgICAgICplcnJvclN0cmluZyA9ICJN YWluIHdvcmxkIGV4ZWN1dGlvbiBjb250ZXh0IG5vdCBmb3VuZC4gQ2FweWJhcmEhIENhcHliYXJh ISI7CisgICAgICAgIHJldHVybiByZXN1bHQ7CiAgICAgfQogICAgIEluamVjdGVkU2NyaXB0IGlu amVjdGVkU2NyaXB0ID0gaW5qZWN0ZWRTY3JpcHRNYW5hZ2VyKCktPmluamVjdGVkU2NyaXB0Rm9y SWQoKmV4ZWN1dGlvbkNvbnRleHRJZCk7CiAgICAgaWYgKGluamVjdGVkU2NyaXB0Lmhhc05vVmFs dWUoKSkK 186586 2013-02-05 02:48:08 -0800 2013-02-05 05:49:10 -0800 Patch bug-108776-20130205144445.patch text/plain 2608 prybin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxODI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTRkZjJlNDAxOWI1OTdi ZTE0ZGFlMzVlNzlkMTJmMDMxODA4OTNmZi4uMjYzMmVlMmE1Y2M3YTFjYmZlMjg2Zjc4ZTYwZGY1 ZDViN2U1MmE0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAyLTA1ICBQZXRl ciBSeWJpbiAgPHByeWJpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog cHJldmVudCBjcmFzaCwgYWRkIHJlcXVpcmVkIGVycm9yIHN0cmluZyB2YWx1ZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4Nzc2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXJyb3Igc3RyaW5nIGlzIGFz c2lnbmVkIHdoZXJlIG1pc3NpbmcsIGFzc2VydCBpcyBhZGRlZCB3aGVyZSBlbXB0eSBzdHJpbmcg aXMKKyAgICAgICAgcG9zc2libGUuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5qZWN0ZWRTY3Jp cHRCYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkluamVjdGVkU2NyaXB0QmFzZTo6bWFrZUV2 YWxDYWxsKToKKyAgICAgICAgKiBpbnNwZWN0b3IvUGFnZVJ1bnRpbWVBZ2VudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpQYWdlUnVudGltZUFnZW50OjppbmplY3RlZFNjcmlwdEZvckV2YWwpOgor CiAyMDEzLTAyLTA0ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgogCiAg ICAgICAgIFtTb3VwXSBSZW1vdmUgZHVwbGljYXRlIHNldHRpbmcgb2YgZmlyc3QgcGFydHkgZm9y IGNvb2tpZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNj cmlwdEJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0QmFz ZS5jcHAKaW5kZXggMTljMGFhMWI1YjEyNzc3ZjM0NWExOGRiNWU1ZTMyZTE2NzU5NzJkZC4uMDli Y2FhYzVjMWNhYzMwYzBiYzUyNWYyNDNmN2EyMTRiMTg0YzBjMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0QmFzZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0QmFzZS5jcHAKQEAgLTEyNCw2ICsxMjQsNyBA QCB2b2lkIEluamVjdGVkU2NyaXB0QmFzZTo6bWFrZUV2YWxDYWxsKEVycm9yU3RyaW5nKiBlcnJv clN0cmluZywgU2NyaXB0RnVuY3Rpb25DYQogICAgIH0KICAgICBpZiAocmVzdWx0LT50eXBlKCkg PT0gSW5zcGVjdG9yVmFsdWU6OlR5cGVTdHJpbmcpIHsKICAgICAgICAgcmVzdWx0LT5hc1N0cmlu ZyhlcnJvclN0cmluZyk7CisgICAgICAgIEFTU0VSVChlcnJvclN0cmluZy0+bGVuZ3RoKCkpOwog ICAgICAgICByZXR1cm47CiAgICAgfQogICAgIFJlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IHJlc3Vs dFBhaXIgPSByZXN1bHQtPmFzT2JqZWN0KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvUGFnZVJ1bnRpbWVBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv UGFnZVJ1bnRpbWVBZ2VudC5jcHAKaW5kZXggNTg0NGE1ZTg4NmE1NzM2MWJkMzNmOWJmZjExN2M1 OTVjY2M2NzQ3YS4uZGYxODE3NDBmZGQxNTM1OTg5OTYwOThhNDhmOGUzZjBjYWZkZTBkOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL1BhZ2VSdW50aW1lQWdlbnQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9QYWdlUnVudGltZUFnZW50LmNwcApAQCAtMTM1 LDcgKzEzNSwxMSBAQCBJbmplY3RlZFNjcmlwdCBQYWdlUnVudGltZUFnZW50OjppbmplY3RlZFNj cmlwdEZvckV2YWwoRXJyb3JTdHJpbmcqIGVycm9yU3RyaW5nLAogewogICAgIGlmICghZXhlY3V0 aW9uQ29udGV4dElkKSB7CiAgICAgICAgIFNjcmlwdFN0YXRlKiBzY3JpcHRTdGF0ZSA9IG1haW5X b3JsZFNjcmlwdFN0YXRlKG1faW5zcGVjdGVkUGFnZS0+bWFpbkZyYW1lKCkpOwotICAgICAgICBy ZXR1cm4gaW5qZWN0ZWRTY3JpcHRNYW5hZ2VyKCktPmluamVjdGVkU2NyaXB0Rm9yKHNjcmlwdFN0 YXRlKTsKKyAgICAgICAgSW5qZWN0ZWRTY3JpcHQgcmVzdWx0ID0gaW5qZWN0ZWRTY3JpcHRNYW5h Z2VyKCktPmluamVjdGVkU2NyaXB0Rm9yKHNjcmlwdFN0YXRlKTsKKyAgICAgICAgaWYgKHJlc3Vs dC5oYXNOb1ZhbHVlKCkpCisgICAgICAgICAgICAvLyBGSVhNRShjb2RlLnJldmlldyk6IGNvcnJl Y3Qgb3IgY29uZmlybSB0aGUgbWVzc2FnZS4KKyAgICAgICAgICAgICplcnJvclN0cmluZyA9ICJN YWluIHdvcmxkIGV4ZWN1dGlvbiBjb250ZXh0IG5vdCBmb3VuZC4iOworICAgICAgICByZXR1cm4g cmVzdWx0OwogICAgIH0KICAgICBJbmplY3RlZFNjcmlwdCBpbmplY3RlZFNjcmlwdCA9IGluamVj dGVkU2NyaXB0TWFuYWdlcigpLT5pbmplY3RlZFNjcmlwdEZvcklkKCpleGVjdXRpb25Db250ZXh0 SWQpOwogICAgIGlmIChpbmplY3RlZFNjcmlwdC5oYXNOb1ZhbHVlKCkpCg== 186610 2013-02-05 05:49:16 -0800 2013-02-05 07:07:24 -0800 Patch bug-108776-20130205174553.patch text/plain 2556 prybin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxODI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTRkZjJlNDAxOWI1OTdi ZTE0ZGFlMzVlNzlkMTJmMDMxODA4OTNmZi4uMjYzMmVlMmE1Y2M3YTFjYmZlMjg2Zjc4ZTYwZGY1 ZDViN2U1MmE0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAyLTA1ICBQZXRl ciBSeWJpbiAgPHByeWJpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog cHJldmVudCBjcmFzaCwgYWRkIHJlcXVpcmVkIGVycm9yIHN0cmluZyB2YWx1ZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4Nzc2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXJyb3Igc3RyaW5nIGlzIGFz c2lnbmVkIHdoZXJlIG1pc3NpbmcsIGFzc2VydCBpcyBhZGRlZCB3aGVyZSBlbXB0eSBzdHJpbmcg aXMKKyAgICAgICAgcG9zc2libGUuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5qZWN0ZWRTY3Jp cHRCYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkluamVjdGVkU2NyaXB0QmFzZTo6bWFrZUV2 YWxDYWxsKToKKyAgICAgICAgKiBpbnNwZWN0b3IvUGFnZVJ1bnRpbWVBZ2VudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpQYWdlUnVudGltZUFnZW50OjppbmplY3RlZFNjcmlwdEZvckV2YWwpOgor CiAyMDEzLTAyLTA0ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgogCiAg ICAgICAgIFtTb3VwXSBSZW1vdmUgZHVwbGljYXRlIHNldHRpbmcgb2YgZmlyc3QgcGFydHkgZm9y IGNvb2tpZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNj cmlwdEJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0QmFz ZS5jcHAKaW5kZXggMTljMGFhMWI1YjEyNzc3ZjM0NWExOGRiNWU1ZTMyZTE2NzU5NzJkZC4uMDli Y2FhYzVjMWNhYzMwYzBiYzUyNWYyNDNmN2EyMTRiMTg0YzBjMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0QmFzZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0QmFzZS5jcHAKQEAgLTEyNCw2ICsxMjQsNyBA QCB2b2lkIEluamVjdGVkU2NyaXB0QmFzZTo6bWFrZUV2YWxDYWxsKEVycm9yU3RyaW5nKiBlcnJv clN0cmluZywgU2NyaXB0RnVuY3Rpb25DYQogICAgIH0KICAgICBpZiAocmVzdWx0LT50eXBlKCkg PT0gSW5zcGVjdG9yVmFsdWU6OlR5cGVTdHJpbmcpIHsKICAgICAgICAgcmVzdWx0LT5hc1N0cmlu ZyhlcnJvclN0cmluZyk7CisgICAgICAgIEFTU0VSVChlcnJvclN0cmluZy0+bGVuZ3RoKCkpOwog ICAgICAgICByZXR1cm47CiAgICAgfQogICAgIFJlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IHJlc3Vs dFBhaXIgPSByZXN1bHQtPmFzT2JqZWN0KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvUGFnZVJ1bnRpbWVBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv UGFnZVJ1bnRpbWVBZ2VudC5jcHAKaW5kZXggNTg0NGE1ZTg4NmE1NzM2MWJkMzNmOWJmZjExN2M1 OTVjY2M2NzQ3YS4uYTI5MDhkMDhhNjI2ZGUxYjFiNGQ1ZmM5MmMzOWNmZWE3OGQ1MzZlNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL1BhZ2VSdW50aW1lQWdlbnQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9QYWdlUnVudGltZUFnZW50LmNwcApAQCAtMTM1 LDcgKzEzNSwxMCBAQCBJbmplY3RlZFNjcmlwdCBQYWdlUnVudGltZUFnZW50OjppbmplY3RlZFNj cmlwdEZvckV2YWwoRXJyb3JTdHJpbmcqIGVycm9yU3RyaW5nLAogewogICAgIGlmICghZXhlY3V0 aW9uQ29udGV4dElkKSB7CiAgICAgICAgIFNjcmlwdFN0YXRlKiBzY3JpcHRTdGF0ZSA9IG1haW5X b3JsZFNjcmlwdFN0YXRlKG1faW5zcGVjdGVkUGFnZS0+bWFpbkZyYW1lKCkpOwotICAgICAgICBy ZXR1cm4gaW5qZWN0ZWRTY3JpcHRNYW5hZ2VyKCktPmluamVjdGVkU2NyaXB0Rm9yKHNjcmlwdFN0 YXRlKTsKKyAgICAgICAgSW5qZWN0ZWRTY3JpcHQgcmVzdWx0ID0gaW5qZWN0ZWRTY3JpcHRNYW5h Z2VyKCktPmluamVjdGVkU2NyaXB0Rm9yKHNjcmlwdFN0YXRlKTsKKyAgICAgICAgaWYgKHJlc3Vs dC5oYXNOb1ZhbHVlKCkpCisgICAgICAgICAgICAqZXJyb3JTdHJpbmcgPSAiSW50ZXJuYWwgZXJy b3I6IG1haW4gd29ybGQgZXhlY3V0aW9uIGNvbnRleHQgbm90IGZvdW5kLiI7CisgICAgICAgIHJl dHVybiByZXN1bHQ7CiAgICAgfQogICAgIEluamVjdGVkU2NyaXB0IGluamVjdGVkU2NyaXB0ID0g aW5qZWN0ZWRTY3JpcHRNYW5hZ2VyKCktPmluamVjdGVkU2NyaXB0Rm9ySWQoKmV4ZWN1dGlvbkNv bnRleHRJZCk7CiAgICAgaWYgKGluamVjdGVkU2NyaXB0Lmhhc05vVmFsdWUoKSkK