108766 2013-02-03 02:16:45 -0800 Cleanup: Normalize usage of ExceptionCode in ContainerNode::checkXxxChild() 2013-02-04 00:28:31 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108180 1 mkwst mkwst haraken ojan.autocc webkit.review.bot oldest_to_newest 823792 0 mkwst 2013-02-03 02:16:45 -0800 Cleanup: Normalize usage of ExceptionCode in ContainerNode::checkXxxChild() 823796 1 186256 mkwst 2013-02-03 02:49:53 -0800 Created attachment 186256 Patch 823799 2 mkwst 2013-02-03 02:53:32 -0800 Marking this as blocking the broader https://bugs.webkit.org/show_bug.cgi?id=108180, and adding moritta@, as https://bugs.webkit.org/show_bug.cgi?id=103372 is the last modification to this code. I've checked the callsites, and this change should have no visible effect other than making the code more consistent, as the calls to checkXXXChild are all prefaced by 'if (ec) return;' statements. Let's see if the bots agree. WDYT? 823897 3 186256 haraken 2013-02-03 15:48:19 -0800 Comment on attachment 186256 Patch Looks reasonable. No harm, better consistency. 824108 4 186256 mkwst 2013-02-04 00:20:56 -0800 Comment on attachment 186256 Patch Thanks! 824114 5 186256 webkit.review.bot 2013-02-04 00:28:28 -0800 Comment on attachment 186256 Patch Clearing flags on attachment: 186256 Committed r141746: <http://trac.webkit.org/changeset/141746> 824115 6 webkit.review.bot 2013-02-04 00:28:31 -0800 All reviewed patches have been landed. Closing bug. 186256 2013-02-03 02:49:53 -0800 2013-02-04 00:28:28 -0800 Patch bug-108766-20130203114633.patch text/plain 2637 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNzEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGZkYTM0ODc2YjI1ZTcw MmFlYWY1ZGQxMmI2MDA2NWEzYmZjYWE1YS4uNGMxYTI0OGZhYTRhN2NiYTJkOTdjZDVkNDI5MDdj MGE1M2NmN2ZhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEzLTAyLTAzICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ2xlYW51cDogTm9ybWFsaXpl IHVzYWdlIG9mIEV4Y2VwdGlvbkNvZGUgaW4gQ29udGFpbmVyTm9kZTo6Y2hlY2tYeHhDaGlsZCgp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg3NjYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBh dGNoIHJlZmFjdG9ycyBjaGVja0FkZENoaWxkIGFuZCBjaGVja1JlcGxhY2VDaGlsZCB0byByZW1v dmUgdGhlCisgICAgICAgIGNyZWF0aW9uIG9mIGFuIGV4dHJhIEV4Y2VwdGlvbkNvZGUgdGhhdCdz IG5vdCBuZWNlc3NhcnkgZm9yIHRoZQorICAgICAgICBkZXNpcmVkIGJlaGF2aW9yLCBhbmQgdG8g YnJpbmcgdGhlIEV4Y2VwdGlvbkNvZGUgdXNhZ2UgaW50byBsaW5lIHdpdGgKKyAgICAgICAgdGhl IHJlc3Qgb2YgV2ViS2l0ICh0aGlzIHdhcyB0aGUgb25seSBjYXNlIHdoZXJlIEV4Y2VwdGlvbkNv ZGUgd2FzCisgICAgICAgIGFzc2lnbmVkIGluc2lkZSBhbiAnaWYnIHN0YXRlbWVudCdzIGNvbmRp dGlvbikuCisKKyAgICAgICAgQWZ0ZXIgdGhpcyBwYXRjaCwgJ2VjJyB3aWxsIGFsd2F5cyBiZSBh c3NpZ25lZCBhIHZhbHVlLCBldmVuIGlmIHRoZQorICAgICAgICByZXN1bHQgb2YgJ2NoZWNrQWNj ZXB0Q2hpbGQnIGlzIDAuIFRoaXMgd291bGQgb25seSBjaGFuZ2UgYmVoYXZpb3IgaWYKKyAgICAg ICAgJ2VjJyB3YXMgbm9uLXplcm8gY29taW5nIGludG8gdGhlIGZ1bmN0aW9uLCBhbmQgJ2NoZWNr QWNjZXB0Q2hpbGQnCisgICAgICAgIHJldHVybmVkIDAuIFNpbmNlIGV2ZXJ5IGNhbGxzaXRlIGlz IGVpdGhlciBkaXJlY3RseSBhZnRlciBhbiBleHBsaWNpdAorICAgICAgICB6ZXJvaW5nIG9mICdl YycsIG9yIGFmdGVyIGFuICdpZiAoZWMpJyBjbGF1c2UsIHRoYXQgY2FzZSBzaG91bGQgbmV2ZXIK KyAgICAgICAgYXBwZWFyLiBUaGlzIHBhdGNoLCB0aGVyZWZvcmUsIHNob3VsZG4ndCB2aXNpYmx5 IGNoYW5nZSBXZWJLaXQncworICAgICAgICBiZWhhdmlvci4KKworICAgICAgICAqIGRvbS9Db250 YWluZXJOb2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNoZWNrQWRkQ2hpbGQpOgorICAgICAg ICAoV2ViQ29yZTo6Y2hlY2tSZXBsYWNlQ2hpbGQpOgorCiAyMDEzLTAyLTAyICBKdW4gSmlhbmcg IDxqdW4uYS5qaWFuZ0BpbnRlbC5jb20+CiAKICAgICAgICAgT3B0aW1pemUgc29tZSBvcGVyYXRp b25zIGZvciBmbG9hdCB0eXBlIGluIHRleHR1cmUgZm9ybWF0IGNvbnZlcnNpb25zIG9mIFdlYkdM CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5jcHAKaW5kZXggODc1YmNkMmVmZGNmMmE0NWEy ZGUxYTA4YzMyZTRiOGY4MTM1Mjc3ZS4uMjc3ZmNhMGY3M2M0ODdiYWQ3YzQ4NzgxMmRhYTE4YTFm ZmM3OGYzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcApAQCAtMjE0LDIxICsy MTQsMTkgQEAgc3RhdGljIGlubGluZSBib29sIGNoZWNrQWNjZXB0Q2hpbGRHdWFyYW50ZWVkTm9k ZVR5cGVzKENvbnRhaW5lck5vZGUqIG5ld1BhcmVudCwKIAogc3RhdGljIGlubGluZSBib29sIGNo ZWNrQWRkQ2hpbGQoQ29udGFpbmVyTm9kZSogbmV3UGFyZW50LCBOb2RlKiBuZXdDaGlsZCwgRXhj ZXB0aW9uQ29kZSYgZWMpCiB7Ci0gICAgaWYgKEV4Y2VwdGlvbkNvZGUgY29kZSA9IGNoZWNrQWNj ZXB0Q2hpbGQobmV3UGFyZW50LCBuZXdDaGlsZCwgMCkpIHsKLSAgICAgICAgZWMgPSBjb2RlOwor ICAgIGVjID0gY2hlY2tBY2NlcHRDaGlsZChuZXdQYXJlbnQsIG5ld0NoaWxkLCAwKTsKKyAgICBp ZiAoZWMpCiAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICB9CiAKICAgICByZXR1cm4gdHJ1ZTsK IH0KIAogc3RhdGljIGlubGluZSBib29sIGNoZWNrUmVwbGFjZUNoaWxkKENvbnRhaW5lck5vZGUq IG5ld1BhcmVudCwgTm9kZSogbmV3Q2hpbGQsIE5vZGUqIG9sZENoaWxkLCBFeGNlcHRpb25Db2Rl JiBlYykKIHsKLSAgICBpZiAoRXhjZXB0aW9uQ29kZSBjb2RlID0gY2hlY2tBY2NlcHRDaGlsZChu ZXdQYXJlbnQsIG5ld0NoaWxkLCBvbGRDaGlsZCkpIHsKLSAgICAgICAgZWMgPSBjb2RlOworICAg IGVjID0gY2hlY2tBY2NlcHRDaGlsZChuZXdQYXJlbnQsIG5ld0NoaWxkLCBvbGRDaGlsZCk7Cisg ICAgaWYgKGVjKQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgfQotICAgIAorCiAgICAgcmV0 dXJuIHRydWU7CiB9CiAK