108761 2013-02-02 20:37:21 -0800 [CMake] Don't warn unused cmake variables which aren't used by cmake ports 2013-02-05 15:42:12 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim dbates laszlo.gombos paroga rakuco webkit.review.bot oldest_to_newest 823760 0 gyuyoung.kim 2013-02-02 20:37:21 -0800 There is cmake warning because ENABLE_DOM4_EVENTS_CONSTRUCTOR and ENABLE_SUID_SANDBOX_LINUX is not defined in cmake files. CMake Warning: Manually-specified variables were not used by the project: ENABLE_DOM4_EVENTS_CONSTRUCTOR ENABLE_SUID_SANDBOX_LINUX 823762 1 186247 gyuyoung.kim 2013-02-02 20:50:42 -0800 Created attachment 186247 Patch 823767 2 186247 buildbot 2013-02-02 22:03:14 -0800 Comment on attachment 186247 Patch Attachment 186247 did not pass win-ews (win): Output: http://queues.webkit.org/results/16357232 823833 3 laszlo.gombos 2013-02-03 05:45:25 -0800 Perhaps we should disable this warning instead of keep adding CMake variables to the build system that does not seems to be used (I do not see a conditional in any CMake file using this guard). I think if one of the CMake based ports would turn this feature on it would be ok to add this falg (for the purpose of turning it on). We're planning to move most of the defining of these flags in .h files and this patch seems to move in the opposite direction. Here is how to disable the warning - http://www.cmake.org/cmake/help/v2.8.8/cmake.html#opt:--no-warn-unused-cli 824031 4 186301 gyuyoung.kim 2013-02-03 21:48:15 -0800 Created attachment 186301 Patch 824032 5 gyuyoung.kim 2013-02-03 21:49:31 -0800 Thank you for your review. I agree to your suggestion. So, I use "--no-warn-unused-cli" option in new patch. 824109 6 186301 buildbot 2013-02-04 00:23:28 -0800 Comment on attachment 186301 Patch Attachment 186301 did not pass win-ews (win): Output: http://queues.webkit.org/results/16372077 824962 7 186301 laszlo.gombos 2013-02-04 17:54:08 -0800 Comment on attachment 186301 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186301&action=review > Tools/Scripts/webkitdirs.pm:2200 > + $additionalCMakeArgs = "--no-warn-unused-cli"; It seems to me that (re)setting this variable - instead of appending to it - would loose the CMake arguments passed on the command line to build-webkit. As an example disabling WebKit1 using <<build-webkit --efl --cmakeargs="-DENABLE_WEBKIT=OFF">> probably no longer works with this patch. Can you double-check and perhaps append instead ? 825036 8 186527 gyuyoung.kim 2013-02-04 19:33:03 -0800 Created attachment 186527 Patch 825038 9 gyuyoung.kim 2013-02-04 19:34:48 -0800 (In reply to comment #7) > (From update of attachment 186301 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=186301&action=review > > > Tools/Scripts/webkitdirs.pm:2200 > > + $additionalCMakeArgs = "--no-warn-unused-cli"; > > As an example disabling WebKit1 using <<build-webkit --efl --cmakeargs="-DENABLE_WEBKIT=OFF">> probably no longer works with this patch. Can you double-check and perhaps append instead ? I update this patch. This one works with "-DENABLE_WEBKIT=ON/OFF". Thanks. 825495 10 186527 laszlo.gombos 2013-02-05 08:06:58 -0800 Comment on attachment 186527 Patch lgtm. 825890 11 186527 webkit.review.bot 2013-02-05 15:42:06 -0800 Comment on attachment 186527 Patch Clearing flags on attachment: 186527 Committed r141942: <http://trac.webkit.org/changeset/141942> 825891 12 webkit.review.bot 2013-02-05 15:42:12 -0800 All reviewed patches have been landed. Closing bug. 186247 2013-02-02 20:50:42 -0800 2013-02-03 21:48:10 -0800 Patch bug-108761-20130203134716.patch text/plain 3210 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggNjY2MWU0NDkzMDExNTdiZWRhODViMDJhZDIwMmE4OGY1MDBkNWU0Ny4uZjk1MjgwNGNmNThk YjY0MjU5MTcwYzI0MzUzZTZkNTU5ODc5YTAxOCAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtNDQsNiArNDQsNyBAQCBtYWNybyhXRUJLSVRfT1BUSU9OX0JFR0lOKQogICAgIFdFQktJ VF9PUFRJT05fREVGSU5FKEVOQUJMRV9ERVZJQ0VfT1JJRU5UQVRJT04gIlRvZ2dsZSBEZXZpY2VP cmllbnRhdGlvbiBzdXBwb3J0IiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxF X0RJQUxPR19FTEVNRU5UICJUb2dnbGUgRGlhbG9nIEVsZW1lbnQgc3VwcG9ydCIgT0ZGKQogICAg IFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9ESVJFQ1RPUllfVVBMT0FEICJUb2dnbGUgRGly ZWN0b3J5IHVwbG9hZCBzdXBwb3J0IiBPRkYpCisgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5B QkxFX0RPTTRfRVZFTlRTX0NPTlNUUlVDVE9SICJUb2dnbGUgRE9NNF9FVkVOVF9DT05TVFJVQ1RP UiBzdXBwb3J0IiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0RPV05MT0FE X0FUVFJJQlVURSAiVG9nZ2xlIGRvd25sb2FkIGF0dHJpYnV0ZSBzdXBwb3J0IiBPRkYpCiAgICAg V0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0RSQUdfU1VQUE9SVCAiVG9nZ2xlIERyYWcgU3Vw cG9ydCIgT0ZGKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9GQVNUX01PQklMRV9T Q1JPTExJTkcgIlRvZ2dsZSBGYXN0IE1vYmlsZSBTY3JvbGxpbmcgc3VwcG9ydCIgT0ZGKQpAQCAt MTA4LDYgKzEwOSw3IEBAIG1hY3JvKFdFQktJVF9PUFRJT05fQkVHSU4pCiAgICAgV0VCS0lUX09Q VElPTl9ERUZJTkUoRU5BQkxFX1NQRUxMQ0hFQ0sgIlRvZ2dsZSBTcGVsbGNoZWNraW5nIHN1cHBv cnQgKHJlcXVpcmVzIEVuY2hhbnQpIiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5B QkxFX1NRTF9EQVRBQkFTRSAiVG9nZ2xlIFNRTCBEYXRhYmFzZSBTdXBwb3J0IiBPTikKICAgICBX RUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfU1RZTEVfU0NPUEVEICJUb2dnbGUgPHN0eWxlIHNj b3BlZD4gc3VwcG9ydCIgT0ZGKQorICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9TVUlE X1NBTkRCT1hfTElOVVggIlRvZ2dsZSBTVUlEIHNhbmRib3ggbGludXggc3VwcG9ydCIgT0ZGKQog ICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9TVkcgIlRvZ2dsZSBTVkcgc3VwcG9ydCIg T04pCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1NWR19ET01fT0JKQ19CSU5ESU5H UyAiVG9nZ2xlIFNWRyBET00gT2JqZWN0aXZlLUMgYmluZGluZ3Mgc3VwcG9ydCAoaW1wbGllcyBT Vkcgc3VwcG9ydCkiIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfU1ZHX0ZP TlRTICJUb2dnbGUgU1ZHIGZvbnRzIHN1cHBvcnQgKGltcGxlcyBTVkcgc3VwcG9ydCkiIE9OKQpk aWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlY29uZmlnLmguY21ha2UgYi9Tb3VyY2UvY21ha2Vjb25m aWcuaC5jbWFrZQppbmRleCBmYmY3ZGE5MTllZGU1OTlmNGJmMjI4ODYzMjk1NTFhNDE5YzM2ZWQ1 Li4zZTI3YTI3YmE0ZTYyNmM2MjY1YWZhOTQ2NDJiNTg1ZWZlNjBlNmRjIDEwMDY0NAotLS0gYS9T b3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2Vjb25maWcuaC5jbWFr ZQpAQCAtMzUsNiArMzUsNyBAQAogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0RFVEFJTFNfRUxFTUVO VAogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0RFVklDRV9PUklFTlRBVElPTgogI2NtYWtlZGVmaW5l MDEgRU5BQkxFX0RJQUxPR19FTEVNRU5UCisjY21ha2VkZWZpbmUwMSBFTkFCTEVfRE9NNF9FVkVO VFNfQ09OU1RSVUNUT1IKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9ET1dOTE9BRF9BVFRSSUJVVEUK ICNjbWFrZWRlZmluZTAxIEVOQUJMRV9EUkFHX1NVUFBPUlQKICNjbWFrZWRlZmluZTAxIEVOQUJM RV9FVkVOVF9NT0RFX01FVEFUQUdTCkBAIC0xMDMsNiArMTA0LDcgQEAKICNjbWFrZWRlZmluZTAx IEVOQUJMRV9TUEVMTENIRUNLCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfU1FMX0RBVEFCQVNFCiAj Y21ha2VkZWZpbmUwMSBFTkFCTEVfU1RZTEVfU0NPUEVECisjY21ha2VkZWZpbmUwMSBFTkFCTEVf U1VJRF9TQU5EQk9YX0xJTlVYCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfU1ZHCiAjY21ha2VkZWZp bmUwMSBFTkFCTEVfU1ZHX0RPTV9PQkpDX0JJTkRJTkdTCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVf U1ZHX0ZPTlRTCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggZWNjMzU3 MmJmMDQ4YTFmZDBjZDUwYmNkYmU0YjI4YTMxNDQxYmM2Mi4uMjJkZjliOTg3NTNjYmM1ZTU1ZTA5 NWIzNjI0MzRhNGY5NTdjN2U3OCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAyLTAyICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5r aW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0NNYWtlXSBGaXggY21ha2Ugd2FybmluZworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4NzYxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgaXMgY21h a2Ugd2FybmluZyBiZWNhdXNlIEVOQUJMRV9ET000X0VWRU5UU19DT05TVFJVQ1RPUiBhbmQgRU5B QkxFX1NVSURfU0FOREJPWF9MSU5VWAorICAgICAgICBpcyBub3QgZGVmaW5lZCBpbiBjbWFrZSBm aWxlcy4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZToKKyAg ICAgICAgKiBTb3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZToKKwogMjAxMy0wMi0wMSAgQmVuamFt aW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBDbGVhbiB0aGUgU3Ry aW5nLT5BdG9taWNTdHJpbmcgY29udmVyc2lvbiBmb3IgQW5pbWF0aW9uQ29udHJvbGxlcjo6cGF1 c2VBbmltYXRpb25BdFRpbWUK 186301 2013-02-03 21:48:15 -0800 2013-02-04 19:32:58 -0800 Patch bug-108761-20130204144454.patch text/plain 1411 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNzM0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmFiZGQ1YjY0ODc2Njk1N2RiNTdiZDZlZjYzMzg0MzM4 YTc4ZmE5Yi4uNzM3YTgwNDVhNmZkNWMyYjNjNjk5NWZhMTg2MThmZjAxOWExODBjMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTAyLTAzICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+ CisKKyAgICAgICAgW0NNYWtlXSBEb24ndCB3YXJuIHVudXNlZCBjbWFrZSB2YXJpYWJsZXMgd2hp Y2ggYXJlbid0IHVzZWQgYnkgY21ha2UgcG9ydHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODc2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIElnbm9yZSB1bnVzZWQgbWFjcm8gdmFyaWFibGVzIHdoaWNo IGFyZW4ndCB1c2VkIGJ5IGNtYWtlIHBvcnRzLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRk aXJzLnBtOgorICAgICAgICAoZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QpOgor CiAyMDEzLTAyLTAzICBEb3VnbGFzIFN0b2Nrd2VsbCAgPGRzdG9ja3dlbGxAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEFkZCBkc3RvY2t3ZWxsIGFzIGEgY29udHJpYnV0b3Ig aW4gY29taXR0ZXJzLnB5IGFuZCB0byB0aGUgd2F0Y2hsaXN0IGZvciBhbmltYXRpb24KZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 ZGlycy5wbQppbmRleCBlZWU4YTFiN2M1YzE5NWQyOGNkYjZkOGRhMzIxYjRhNjE2ZmFiNGMzLi5h NzM2MjkwZDlkYWJiMDU3ZTY5Mzk0MGZmMDE5YmE0ZGY5ZTFiNWRlIDEwMDc1NQotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBt CkBAIC0yMTk1LDYgKzIxOTUsOSBAQCBzdWIgZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVBy b2plY3QKICAgICAgICAgcHVzaCBAYXJncywgIi1EQ01BS0VfQlVJTERfVFlQRT1EZWJ1ZyI7CiAg ICAgfQogICAgIHB1c2ggQGFyZ3MsIEBjbWFrZUFyZ3MgaWYgQGNtYWtlQXJnczsKKworICAgICMg RG9uJ3Qgd2FybiB2YXJpYWJsZXMgd2hpY2ggYXJlbid0IHVzZWQgYnkgY21ha2UgcG9ydHMuCisg ICAgJGFkZGl0aW9uYWxDTWFrZUFyZ3MgPSAiLS1uby13YXJuLXVudXNlZC1jbGkiOwogICAgIHB1 c2ggQGFyZ3MsICRhZGRpdGlvbmFsQ01ha2VBcmdzIGlmICRhZGRpdGlvbmFsQ01ha2VBcmdzOwog CiAgICAgcHVzaCBAYXJncywgJyInIC4gc291cmNlRGlyKCkgLiAnIic7Cg== 186527 2013-02-04 19:33:03 -0800 2013-02-05 15:42:06 -0800 Patch bug-108761-20130205122942.patch text/plain 1357 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxODQzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjA0NDkwYjdiYTU2NjNiNzFmNmYwOTRlZDJjZTgxYzNl NjRlNWQzYi4uNjZlNDBjZDNmOTk4MjBjNjM0M2NkZWU4MjY3YjBiY2RlYWZmNDNkNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTAyLTA0ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+ CisKKyAgICAgICAgW0NNYWtlXSBEb24ndCB3YXJuIHVudXNlZCBjbWFrZSB2YXJpYWJsZXMgd2hp Y2ggYXJlbid0IHVzZWQgYnkgY21ha2UgcG9ydHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODc2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIElnbm9yZSB1bnVzZWQgbWFjcm8gdmFyaWFibGVzIHdoaWNo IGFyZW4ndCB1c2VkIGJ5IGNtYWtlIHBvcnRzLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRk aXJzLnBtOgorICAgICAgICAoZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QpOgor CiAyMDEzLTAyLTA0ICBKdWxpZSBQYXJlbnQgIDxqcGFyZW50QGNocm9taXVtLm9yZz4KIAogICAg ICAgICBEYXNoYm9hcmQgY2xlYW51cDogTWFrZSBidWlsZGVyIGEgcmVhbCBkYXNoYm9hcmRTcGVj aWZpY1BhcmFtZXRlci4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCBlZWU4YTFiN2M1YzE5NWQyOGNkYjZk OGRhMzIxYjRhNjE2ZmFiNGMzLi42ZjNiMGM3ZmFkZWNmMmMyYWIyYTdlZWFiNjMwNjgyNzUwZGIy YzdhIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC0yMTk0LDYgKzIxOTQsOCBAQCBzdWIgZ2VuZXJhdGVC dWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QKICAgICB9IGVsc2lmICgkY29uZmlnID1+IC9kZWJ1 Zy9pKSB7CiAgICAgICAgIHB1c2ggQGFyZ3MsICItRENNQUtFX0JVSUxEX1RZUEU9RGVidWciOwog ICAgIH0KKyAgICAjIERvbid0IHdhcm4gdmFyaWFibGVzIHdoaWNoIGFyZW4ndCB1c2VkIGJ5IGNt YWtlIHBvcnRzLgorICAgIHB1c2ggQGFyZ3MsICItLW5vLXdhcm4tdW51c2VkLWNsaSI7CiAgICAg cHVzaCBAYXJncywgQGNtYWtlQXJncyBpZiBAY21ha2VBcmdzOwogICAgIHB1c2ggQGFyZ3MsICRh ZGRpdGlvbmFsQ01ha2VBcmdzIGlmICRhZGRpdGlvbmFsQ01ha2VBcmdzOwogCg==