<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>10876</bug_id>
          
          <creation_ts>2006-09-15 14:53:57 -0700</creation_ts>
          <short_desc>containsItemForURLUnicode uses matchLetter instead of matchUnicodeLetter</short_desc>
          <delta_ts>2006-09-15 15:26:27 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>History</component>
          <version>420+</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Roben (:aroben)">aroben</reporter>
          <assigned_to name="Adam Roben (:aroben)">aroben</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>55613</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2006-09-15 14:53:57 -0700</bug_when>
    <thetext>WebHistory::containsItemForURLUnicode calls matchLetter instead of matchUnicodeLetter.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>55614</commentid>
    <comment_count>1</comment_count>
      <attachid>10582</attachid>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2006-09-15 14:55:28 -0700</bug_when>
    <thetext>Created attachment 10582
Change call, use BUFFER_SIZE consistently

This patch replaces the call to matchLetter with matchUnicodeLetter, and also uses BUFFER_SIZE more consistently.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>55619</commentid>
    <comment_count>2</comment_count>
      <attachid>10582</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2006-09-15 15:13:17 -0700</bug_when>
    <thetext>Comment on attachment 10582
Change call, use BUFFER_SIZE consistently

looks good.  (discussed over irc) r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>55621</commentid>
    <comment_count>3</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2006-09-15 15:26:27 -0700</bug_when>
    <thetext>Landed as r16375.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>10582</attachid>
            <date>2006-09-15 14:55:28 -0700</date>
            <delta_ts>2006-09-15 15:13:17 -0700</delta_ts>
            <desc>Change call, use BUFFER_SIZE consistently</desc>
            <filename>bugzilla-10876-matchunicodeletter.diff</filename>
            <type>text/plain</type>
            <size>2261</size>
            <attacher name="Adam Roben (:aroben)">aroben</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko
cmV2aXNpb24gMTYzNzApCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x
LDMgKzEsMTQgQEAKKzIwMDYtMDktMTUgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNtYWxsIGZp
eGVzIGZvciBfV2ViQ29yZUhpc3RvcnlQcm92aWRlci4KKworICAgICAgICAqIEhpc3RvcnkvV2Vi
SGlzdG9yeS5tOiBDb25zaXN0ZW50bHkgdXNlIEJVRkZFUl9TSVpFICNkZWZpbmUKKyAgICAgICAg
KC1bX1dlYkNvcmVIaXN0b3J5UHJvdmlkZXIgY29udGFpbnNJdGVtRm9yVVJMTGF0aW4xOmxlbmd0
aDpdKToKKyAgICAgICAgKC1bX1dlYkNvcmVIaXN0b3J5UHJvdmlkZXIgY29udGFpbnNJdGVtRm9y
VVJMVW5pY29kZTpsZW5ndGg6XSk6CisgICAgICAgIFJlcGxhY2UgaW5jb3JyZWN0IGNhbGwgdG8g
bWF0Y2hMZXR0ZXIgdG8gbWF0Y2hVbmljb2RlTGV0dGVyCisKIDIwMDYtMDktMTMgIEJyYWR5IEVp
ZHNvbiA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqCklu
ZGV4OiBXZWJLaXQvSGlzdG9yeS9XZWJIaXN0b3J5Lm0KPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0hp
c3RvcnkvV2ViSGlzdG9yeS5tCShyZXZpc2lvbiAxNjM2OSkKKysrIFdlYktpdC9IaXN0b3J5L1dl
Ykhpc3RvcnkubQkod29ya2luZyBjb3B5KQpAQCAtNTkwLDcgKzU5MCw3IEBAIHN0YXRpYyBpbmxp
bmUgYm9vbCBtYXRjaFVuaWNvZGVMZXR0ZXIoVW4KICAgICB9CiAKICAgICBpZiAobmVlZFRvQWRk
U2xhc2gpIHsKLSAgICAgICAgaWYgKGxlbmd0aCArIDEgPD0gMjA0OCkgeworICAgICAgICBpZiAo
bGVuZ3RoICsgMSA8PSBCVUZGRVJfU0laRSkgewogICAgICAgICAgICAgc3RyQnVmZmVyID0gc3Rh
dGljU3RyQnVmZmVyOwogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgc3RyQnVmZmVyID0g
bWFsbG9jKGxlbmd0aCArIDIpOwpAQCAtNjE0LDEwICs2MTQsMTIgQEAgc3RhdGljIGlubGluZSBi
b29sIG1hdGNoVW5pY29kZUxldHRlcihVbgogICAgIHJldHVybiByZXN1bHQ7CiB9CiAKKyNkZWZp
bmUgVU5JQ09ERV9CVUZGRVJfU0laRSAxMDI0CisKIC0gKEJPT0wpY29udGFpbnNJdGVtRm9yVVJM
VW5pY29kZTooY29uc3QgVW5pQ2hhciAqKXVuaWNvZGUgbGVuZ3RoOih1bnNpZ25lZClsZW5ndGgK
IHsKICAgICBjb25zdCBVbmlDaGFyICp1bmljb2RlU3RyID0gdW5pY29kZTsKLSAgICBVbmlDaGFy
IHN0YXRpY1N0ckJ1ZmZlclsxMDI0XTsKKyAgICBVbmlDaGFyIHN0YXRpY1N0ckJ1ZmZlcltVTklD
T0RFX0JVRkZFUl9TSVpFXTsKICAgICBVbmlDaGFyICpzdHJCdWZmZXIgPSBOVUxMOwogICAgIEJP
T0wgbmVlZFRvQWRkU2xhc2ggPSBGQUxTRTsKIApAQCAtNjI3LDcgKzYyOSw3IEBAIHN0YXRpYyBp
bmxpbmUgYm9vbCBtYXRjaFVuaWNvZGVMZXR0ZXIoVW4KICAgICAgICAgbWF0Y2hVbmljb2RlTGV0
dGVyKHVuaWNvZGVbMl0sICd0JykgJiYKICAgICAgICAgbWF0Y2hVbmljb2RlTGV0dGVyKHVuaWNv
ZGVbM10sICdwJykgJiYKICAgICAgICAgKHVuaWNvZGVbNF0gPT0gJzonIAotICAgICAgICAgfHwg
KG1hdGNoTGV0dGVyKHVuaWNvZGVbNF0sICdzJykgJiYgdW5pY29kZVs1XSA9PSAnOicpKSkgewor
ICAgICAgICAgfHwgKG1hdGNoVW5pY29kZUxldHRlcih1bmljb2RlWzRdLCAncycpICYmIHVuaWNv
ZGVbNV0gPT0gJzonKSkpIHsKIAogICAgICAgICB1bnNpZ25lZCBwb3MgPSB1bmljb2RlWzRdID09
ICc6JyA/IDUgOiA2OwogCkBAIC02NDYsNyArNjQ4LDcgQEAgc3RhdGljIGlubGluZSBib29sIG1h
dGNoVW5pY29kZUxldHRlcihVbgogICAgIH0KIAogICAgIGlmIChuZWVkVG9BZGRTbGFzaCkgewot
ICAgICAgICBpZiAobGVuZ3RoICsgMSA8PSAxMDI0KSB7CisgICAgICAgIGlmIChsZW5ndGggKyAx
IDw9IFVOSUNPREVfQlVGRkVSX1NJWkUpIHsKICAgICAgICAgICAgIHN0ckJ1ZmZlciA9IHN0YXRp
Y1N0ckJ1ZmZlcjsKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgIHN0ckJ1ZmZlciA9IG1h
bGxvYyhzaXplb2YoVW5pQ2hhcikgKiAobGVuZ3RoICsgMSkpOwo=
</data>
<flag name="review"
          id="3435"
          type_id="1"
          status="+"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>