108752 2013-02-02 06:13:08 -0800 class="cue" is getting some default style 2013-02-04 13:47:21 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dgorbik cmarcelo dgorbik eric.carlson feature-media-reviews kling macpherson menard ojan.autocc webkit-bug-importer webkit.review.bot oldest_to_newest 823651 0 186228 dino 2013-02-02 06:13:08 -0800 Created attachment 186228 Testcase See testcase. Anything with class="cue" is getting some default style. For example, display: block no matter what you set in CSS. This is a regression since <whatever WebKit is in Safari 6> My guess is that video captions are doing something. 823652 1 webkit-bug-importer 2013-02-02 06:13:21 -0800 <rdar://problem/13139980> 823653 2 dino 2013-02-02 06:21:06 -0800 Actually, might not be some default style. Could just be something that overrides the display property. That's the only property I've been able to find this happen to. 823705 3 dino 2013-02-02 13:43:29 -0800 Regressed in http://trac.webkit.org/changeset/140505 823707 4 dino 2013-02-02 13:47:43 -0800 My guess is Source/WebCore/css/RuleSet.cpp - if (component->pseudoType() == CSSSelector::PseudoCue) + if (component->pseudoType() == CSSSelector::PseudoCue || (component->m_match != CSSSelector::Tag && component->value() == TextTrackCue::cueShadowPseudoId())) 824655 5 186440 dgorbik 2013-02-04 12:40:06 -0800 Created attachment 186440 Proposed fix 0.1 824716 6 186440 webkit.review.bot 2013-02-04 13:47:16 -0800 Comment on attachment 186440 Proposed fix 0.1 Clearing flags on attachment: 186440 Committed r141806: <http://trac.webkit.org/changeset/141806> 824717 7 webkit.review.bot 2013-02-04 13:47:21 -0800 All reviewed patches have been landed. Closing bug. 186228 2013-02-02 06:13:08 -0800 2013-02-04 12:40:06 -0800 Testcase cuebug.html text/html 391 dino PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KICA8dGl0bGU+Q3VlIGNsYXNzIGJ1ZzwvdGl0 bGU+CiAgPHN0eWxlPgoKICAuY3VlIHsKICAgIGRpc3BsYXk6IGlubGluZTsKICAgIGJhY2tncm91 bmQtY29sb3I6IHJlZDsKICB9CgogIC5ub3QtY3VlIHsKICAgIGRpc3BsYXk6IGlubGluZTsKICAg IGJhY2tncm91bmQtY29sb3I6IGdyZWVuOwogIH0KICA8L3N0eWxlPgo8L2hlYWQ+Cjxib2R5Pgog IDxkaXY+CiAgICA8ZGl2IGNsYXNzPSJjdWUiPlRoaXMgc2hvdWxkIGRpc3BsYXkgaW5saW5lPC9k aXY+CiAgPC9kaXY+CgogIDxkaXY+CiAgICA8ZGl2IGNsYXNzPSJub3QtY3VlIj5UaGlzIHNob3Vs ZCBkaXNwbGF5IGlubGluZTwvZGl2PgogIDwvZGl2PgoKPC9ib2R5Pgo8L2h0bWw+Cg== 186440 2013-02-04 12:40:06 -0800 2013-02-04 13:47:16 -0800 Proposed fix 0.1 patch text/plain 4535 dgorbik ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiNDg3ODM4Li4yZWMyZWRjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMDIt MDQgIERpbWEgR29yYmlrICA8ZGdvcmJpa0BhcHBsZS5jb20+CisKKyAgICAgICAgY2xhc3M9ImN1 ZSIgaXMgZ2V0dGluZyBzb21lIGRlZmF1bHQgc3R5bGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODc1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogbWVkaWEvdHJhY2svdHJhY2stY3NzLXByb3BlcnR5 LXdoaXRlbGlzdC1leHBlY3RlZC50eHQ6CisgICAgICAgICogbWVkaWEvdHJhY2svdHJhY2stY3Nz LXByb3BlcnR5LXdoaXRlbGlzdC5odG1sOgorCiAyMDEzLTAyLTA0ICBKdWxpZW4gQ2hhZmZyYWl4 ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgogCiAgICAgICAgIFtDU1MgR3JpZCBMYXlvdXRdIEFk ZCBwYXJzaW5nIGZvciBncmlkLWF1dG8tZmxvdwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVk aWEvdHJhY2svdHJhY2stY3NzLXByb3BlcnR5LXdoaXRlbGlzdC1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1jc3MtcHJvcGVydHktd2hpdGVsaXN0LWV4cGVjdGVk LnR4dAppbmRleCBhZjEzODExLi5hOTc2YTcyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9tZWRp YS90cmFjay90cmFjay1jc3MtcHJvcGVydHktd2hpdGVsaXN0LWV4cGVjdGVkLnR4dAorKysgYi9M YXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1jc3MtcHJvcGVydHktd2hpdGVsaXN0LWV4cGVj dGVkLnR4dApAQCAtMSwzICsxLDQgQEAKK1RoaXMgc2hvdWxkIGRpc3BsYXkgaW5saW5lCiBFVkVO VChjYW5wbGF5dGhyb3VnaCkKIEVWRU5UKHNlZWtlZCkKIApAQCAtMTIsNSArMTMsOCBAQCBFWFBF Q1RFRCAoZ2V0Q29tcHV0ZWRTdHlsZShjdWVOb2RlKS53b3JkU3BhY2luZyA9PSAnMHB4JykgT0sK IEVYUEVDVEVEIChnZXRDb21wdXRlZFN0eWxlKGN1ZU5vZGUpLmNvbG9yID09ICdyZ2IoMjU1LCAw LCAwKScpIE9LCiBFWFBFQ1RFRCAoZ2V0Q29tcHV0ZWRTdHlsZShjdWVOb2RlKS5wYWRkaW5nID09 ICcwcHgnKSBPSwogRVhQRUNURUQgKGdldENvbXB1dGVkU3R5bGUoY3VlTm9kZSkud29yZFNwYWNp bmcgPT0gJzBweCcpIE9LCisKK1Rlc3QgdGhhdCBmaWx0ZXJpbmcgZG9lc24ndCBhcHBseSB0byBl bGVtZW50cyB3aGljaCBjbGFzcyBlcXVhbHMgJ2N1ZScgb3V0c2lkZSBXZWJWVFQgc2NvcGUuCitF WFBFQ1RFRCAoZ2V0Q29tcHV0ZWRTdHlsZShjdWVOb2RlKS5kaXNwbGF5ID09ICdpbmxpbmUnKSBP SwogRU5EIE9GIFRFU1QKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJh Y2stY3NzLXByb3BlcnR5LXdoaXRlbGlzdC5odG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2sv dHJhY2stY3NzLXByb3BlcnR5LXdoaXRlbGlzdC5odG1sCmluZGV4IGExNjc1NTQuLjViMzQ4NzMg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWNzcy1wcm9wZXJ0eS13 aGl0ZWxpc3QuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1jc3MtcHJv cGVydHktd2hpdGVsaXN0Lmh0bWwKQEAgLTEwLDYgKzEwLDEwIEBACiAgICAgICAgIDxzdHlsZT4K ICAgICAgICAgOjpjdWUge3dvcmQtc3BhY2luZzogMTAwcHg7fQogICAgICAgICA6OmN1ZShjKSB7 cGFkZGluZy1sZWZ0OiAxMHB4OyBjb2xvcjogcmVkO30KKyAgICAgICAgLmN1ZSB7CisgICAgICAg ICAgICBkaXNwbGF5OiBpbmxpbmU7CisgICAgICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBncmVl bjsKKyAgICAgICAgfQogICAgICAgICA8L3N0eWxlPgogCiAgICAgICAgIDxzY3JpcHQ+CkBAIC0z Niw2ICs0MCwxMCBAQAogICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCJnZXRDb21wdXRlZFN0eWxl KGN1ZU5vZGUpLmNvbG9yIiwgInJnYigyNTUsIDAsIDApIik7CiAgICAgICAgICAgICB0ZXN0RXhw ZWN0ZWQoImdldENvbXB1dGVkU3R5bGUoY3VlTm9kZSkucGFkZGluZyIsICIwcHgiKTsKICAgICAg ICAgICAgIHRlc3RFeHBlY3RlZCgiZ2V0Q29tcHV0ZWRTdHlsZShjdWVOb2RlKS53b3JkU3BhY2lu ZyIsICIwcHgiKTsKKyAgICAgICAgICAgIAorICAgICAgICAgICAgY29uc29sZVdyaXRlKCI8YnI+ VGVzdCB0aGF0IGZpbHRlcmluZyBkb2Vzbid0IGFwcGx5IHRvIGVsZW1lbnRzIHdoaWNoIGNsYXNz IGVxdWFscyAnY3VlJyBvdXRzaWRlIFdlYlZUVCBzY29wZS4iKTsKKyAgICAgICAgICAgIGN1ZU5v ZGUgPSBkb2N1bWVudC5nZXRFbGVtZW50c0J5Q2xhc3NOYW1lKCJjdWUiKVswXTsKKyAgICAgICAg ICAgIHRlc3RFeHBlY3RlZCgiZ2V0Q29tcHV0ZWRTdHlsZShjdWVOb2RlKS5kaXNwbGF5IiwgImlu bGluZSIpOwogICAgICAgICAgICAgZW5kVGVzdCgpOwogICAgICAgICB9CiAKQEAgLTU0LDUgKzYy LDYgQEAKICAgICAgICAgPHZpZGVvIGNvbnRyb2xzID4KICAgICAgICAgICAgIDx0cmFjayBzcmM9 ImNhcHRpb25zLXdlYnZ0dC93aGl0ZWxpc3QudnR0IiBraW5kPSJjYXB0aW9ucyIgZGVmYXVsdD4K ICAgICAgICAgPC92aWRlbz4KKyAgICAgICAgPGRpdj48ZGl2IGNsYXNzPSJjdWUiPlRoaXMgc2hv dWxkIGRpc3BsYXkgaW5saW5lPC9kaXY+PC9kaXY+CiAgICAgPC9ib2R5PgogPC9odG1sPgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IDNlZjU1NTMuLjFhNWYxODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAor MjAxMy0wMi0wNCAgRGltYSBHb3JiaWsgIDxkZ29yYmlrQGFwcGxlLmNvbT4KKworICAgICAgICBj bGFzcz0iY3VlIiBpcyBnZXR0aW5nIHNvbWUgZGVmYXVsdCBzdHlsZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4NzUyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBUaGUgdmFsdWUgdmFyaWFi bGUgaW5zaWRlIHRoZSBzZWxlY3RvciBpcyB1c2VkIHRvIHN0b3JlIGRpZmZlcmVudCBpbmZvcm1h dGlvbiBkZXBlbmRpbmcgb24gdGhlIAorICAgICAgICB0eXBlIG9mIHRoZSBzZWxlY3RvciBzbyB3 ZSBoYXZlIHRvIGNoZWNrIGV4cGxpY2l0bHkgdGhhdCB0aGUgc2VsZWN0b3Igd2UgYXBwbHkgZmls dGVyaW5nIHRvIAorICAgICAgICBtYXRjaGVzIGEgcHNldWRvIGVsZW1lbnQuCisgICAgICAgIAor ICAgICAgICBFeGlzdGluZyB0ZXN0cyBtb2RpZmllZCB0byBjb3ZlciB0aGlzIGNhc2UuCisKKyAg ICAgICAgKiBjc3MvUnVsZVNldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpkZXRlcm1pbmVQcm9w ZXJ0eVdoaXRlbGlzdFR5cGUpOgorCiAyMDEzLTAyLTA0ICBUaW0gSG9ydG9uICA8dGltb3RoeV9o b3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIEFsbG93IFRpbGVkQ29yZUFuaW1hdGlvbkRyYXdp bmdBcmVhIG92ZXJsYXkgbGF5ZXJzIHRvIGJlY29tZSB0aWxlZApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvY3NzL1J1bGVTZXQuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL1J1bGVTZXQuY3Bw CmluZGV4IGI1MjlmNDguLjYyNjc5MDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9S dWxlU2V0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvUnVsZVNldC5jcHAKQEAgLTEyMiw3 ICsxMjIsNyBAQCBzdGF0aWMgaW5saW5lIFByb3BlcnR5V2hpdGVsaXN0VHlwZSBkZXRlcm1pbmVQ cm9wZXJ0eVdoaXRlbGlzdFR5cGUoY29uc3QgQWRkUnVsZQogICAgICAgICByZXR1cm4gUHJvcGVy dHlXaGl0ZWxpc3RSZWdpb247CiAjaWYgRU5BQkxFKFZJREVPX1RSQUNLKQogICAgIGZvciAoY29u c3QgQ1NTU2VsZWN0b3IqIGNvbXBvbmVudCA9IHNlbGVjdG9yOyBjb21wb25lbnQ7IGNvbXBvbmVu dCA9IGNvbXBvbmVudC0+dGFnSGlzdG9yeSgpKSB7Ci0gICAgICAgIGlmIChjb21wb25lbnQtPnBz ZXVkb1R5cGUoKSA9PSBDU1NTZWxlY3Rvcjo6UHNldWRvQ3VlIHx8IChjb21wb25lbnQtPm1fbWF0 Y2ggIT0gQ1NTU2VsZWN0b3I6OlRhZyAmJiBjb21wb25lbnQtPnZhbHVlKCkgPT0gVGV4dFRyYWNr Q3VlOjpjdWVTaGFkb3dQc2V1ZG9JZCgpKSkKKyAgICAgICAgaWYgKGNvbXBvbmVudC0+cHNldWRv VHlwZSgpID09IENTU1NlbGVjdG9yOjpQc2V1ZG9DdWUgfHwgKGNvbXBvbmVudC0+bV9tYXRjaCA9 PSBDU1NTZWxlY3Rvcjo6UHNldWRvRWxlbWVudCAmJiBjb21wb25lbnQtPnZhbHVlKCkgPT0gVGV4 dFRyYWNrQ3VlOjpjdWVTaGFkb3dQc2V1ZG9JZCgpKSkKICAgICAgICAgICAgIHJldHVybiBQcm9w ZXJ0eVdoaXRlbGlzdEN1ZTsKICAgICB9CiAjZWxzZQo=