108749 2013-02-02 05:01:22 -0800 Check PrivateHeaders/JSBasePrivate.h for inappropriate macros 2013-02-04 11:03:25 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 105341 1 ddkilzer ddkilzer joepeck msaboff roger_fong webkit.review.bot oldest_to_newest 823631 0 ddkilzer 2013-02-02 05:01:22 -0800 * JavaScriptCore.xcodeproj/project.pbxproj: Add PrivateHeaders/JSBasePrivate.h to list of headers to check in "Check for Inappropriate Macros in External Headers" build phase script. 823633 1 186223 ddkilzer 2013-02-02 05:03:36 -0800 Created attachment 186223 Patch v1 823648 2 186223 buildbot 2013-02-02 06:08:30 -0800 Comment on attachment 186223 Patch v1 Attachment 186223 did not pass win-ews (win): Output: http://queues.webkit.org/results/16340761 823667 3 ddkilzer 2013-02-02 08:41:50 -0800 (In reply to comment #2) > (From update of attachment 186223 [details]) > Attachment 186223 [details] did not pass win-ews (win): > Output: http://queues.webkit.org/results/16340761 1>..\cg\ImageDiffCG.cpp(37) : fatal error C1083: Cannot open include file: 'wtf/Platform.h': No such file or directory Hmm...could this patch have caused that? 823669 4 186223 ddkilzer 2013-02-02 09:12:20 -0800 Comment on attachment 186223 Patch v1 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 186223 [details] [details]) > > Attachment 186223 [details] [details] did not pass win-ews (win): > > Output: http://queues.webkit.org/results/16340761 > > 1>..\cg\ImageDiffCG.cpp(37) : fatal error C1083: Cannot open include file: 'wtf/Platform.h': No such file or directory > > Hmm...could this patch have caused that? Nope. 824547 5 186223 joepeck 2013-02-04 10:45:35 -0800 Comment on attachment 186223 Patch v1 r=me 824577 6 186223 webkit.review.bot 2013-02-04 11:03:20 -0800 Comment on attachment 186223 Patch v1 Clearing flags on attachment: 186223 Committed r141786: <http://trac.webkit.org/changeset/141786> 824578 7 webkit.review.bot 2013-02-04 11:03:25 -0800 All reviewed patches have been landed. Closing bug. 186223 2013-02-02 05:03:36 -0800 2013-02-04 11:03:20 -0800 Patch v1 bug-108749-20130202050017.patch text/plain 1932 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNTk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 MmE0NzlmYjdiOWNmMzA2MTk0NTJlMGI1N2JhOWFiYmU2ZTU1Yzk5Li43Y2FiODMwMTliMjNjMjRj YjhmYTcxZjc0MzkzNWNiMTU4Y2Q1OWEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMy0wMi0wMiAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t PgorCisgICAgICAgIENoZWNrIFByaXZhdGVIZWFkZXJzL0pTQmFzZVByaXZhdGUuaCBmb3IgaW5h cHByb3ByaWF0ZSBtYWNyb3MKKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMTA4NzQ5Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogSmF2YVNj cmlwdENvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvajogQWRkCisgICAgICAgIFByaXZhdGVI ZWFkZXJzL0pTQmFzZVByaXZhdGUuaCB0byBsaXN0IG9mIGhlYWRlcnMgdG8gY2hlY2sgaW4KKyAg ICAgICAgIkNoZWNrIGZvciBJbmFwcHJvcHJpYXRlIE1hY3JvcyBpbiBFeHRlcm5hbCBIZWFkZXJz IiBidWlsZCBwaGFzZQorICAgICAgICBzY3JpcHQuCisKIDIwMTMtMDItMDEgIEdlb2ZmcmV5IEdh cmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGRlZCBUcmlTdGF0ZSB0byBXVEYg YW5kIHN0YXJ0ZWQgdXNpbmcgaXQgaW4gb25lIHBsYWNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvaiBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhw cm9qCmluZGV4IDQ3N2M4ZmZhMjdjOGU1M2NkODE5YTJlNWM2ZWYwYWQzMGYzZTYxYWQuLmViMTU3 ZGJiZTdiMzM3NzQ3MDE0ZWE2ZGZhNzhjZGIyNWFlY2JhNzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS54Y29kZXByb2ovcHJvamVj dC5wYnhwcm9qCkBAIC0zNjExLDcgKzM2MTEsNyBAQAogCQkJKTsKIAkJCXJ1bk9ubHlGb3JEZXBs b3ltZW50UG9zdHByb2Nlc3NpbmcgPSAwOwogCQkJc2hlbGxQYXRoID0gL2Jpbi9zaDsKLQkJCXNo ZWxsU2NyaXB0ID0gImlmIFsgXCIke0FDVElPTn1cIiA9IFwiaW5zdGFsbGhkcnNcIiBdOyB0aGVu XG4gICAgZXhpdCAwO1xuZmlcblxuaWYgWyAtZiAuLi8uLi9Ub29scy9TY3JpcHRzL2NoZWNrLWZv ci1pbmFwcHJvcHJpYXRlLW1hY3Jvcy1pbi1leHRlcm5hbC1oZWFkZXJzIF07IHRoZW5cbiAgICAu Li8uLi9Ub29scy9TY3JpcHRzL2NoZWNrLWZvci1pbmFwcHJvcHJpYXRlLW1hY3Jvcy1pbi1leHRl cm5hbC1oZWFkZXJzIEhlYWRlcnMgfHwgZXhpdCAkP1xuZmkiOworCQkJc2hlbGxTY3JpcHQgPSAi aWYgWyBcIiR7QUNUSU9OfVwiID0gXCJpbnN0YWxsaGRyc1wiIF07IHRoZW5cbiAgICBleGl0IDA7 XG5maVxuXG5pZiBbIC1mIC4uLy4uL1Rvb2xzL1NjcmlwdHMvY2hlY2stZm9yLWluYXBwcm9wcmlh dGUtbWFjcm9zLWluLWV4dGVybmFsLWhlYWRlcnMgXTsgdGhlblxuICAgIC4uLy4uL1Rvb2xzL1Nj cmlwdHMvY2hlY2stZm9yLWluYXBwcm9wcmlhdGUtbWFjcm9zLWluLWV4dGVybmFsLWhlYWRlcnMg SGVhZGVycyBQcml2YXRlSGVhZGVycy9KU0Jhc2VQcml2YXRlLmggfHwgZXhpdCAkP1xuZmkiOwog CQl9OwogLyogRW5kIFBCWFNoZWxsU2NyaXB0QnVpbGRQaGFzZSBzZWN0aW9uICovCiAK