108728 2013-02-01 17:23:33 -0800 REGRESSION(r141669): Broke the windows build. (Requested by leviw on #webkit). 2013-02-01 17:28:25 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108707 1 webkit.review.bot webkit.review.bot eae leviw oldest_to_newest 823450 0 webkit.review.bot 2013-02-01 17:23:33 -0800 http://trac.webkit.org/changeset/141669 broke the build: Broke the windows build. (Requested by leviw on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 823452 1 186191 webkit.review.bot 2013-02-01 17:24:01 -0800 Created attachment 186191 ROLLOUT of r141669 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 823456 2 186191 leviw 2013-02-01 17:28:24 -0800 Comment on attachment 186191 ROLLOUT of r141669 Clearing flags on attachment: 186191 Committed r141670: <http://trac.webkit.org/changeset/141670> 823457 3 leviw 2013-02-01 17:28:25 -0800 All reviewed patches have been landed. Closing bug. 186191 2013-02-01 17:24:01 -0800 2013-02-01 17:28:24 -0800 ROLLOUT of r141669 bug-108728-20130202012043.patch text/plain 7167 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNjY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDkzYjdmMzc4YWIzOTk0 OTUzYjViMGQ5MTM0N2Q2M2M4N2EzY2Q1MS4uNDZkOWRmZDBiYzEyYWI0MTY4ODcwZjI3YjUwMDc2 Mzc0NGU3NGZhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAyLTAxICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTQxNjY5LgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xNDE2NjkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwODcyOAorCisgICAgICAgIEJyb2tlIHRoZSB3aW5kb3dzIGJ1aWxkLiAoUmVx dWVzdGVkIGJ5IGxldml3IG9uICN3ZWJraXQpLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl ckJveE1vZGVsT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveE1vZGVsT2Jq ZWN0Ojpjb21wdXRlZENTU1BhZGRpbmdUb3ApOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJCb3hNb2RlbE9iamVjdDo6Y29tcHV0ZWRDU1NQYWRkaW5nQm90dG9t KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveE1vZGVsT2JqZWN0Ojpjb21wdXRlZENTU1Bh ZGRpbmdMZWZ0KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveE1vZGVsT2JqZWN0Ojpjb21w dXRlZENTU1BhZGRpbmdSaWdodCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3hNb2RlbE9i amVjdDo6Y29tcHV0ZWRDU1NQYWRkaW5nQmVmb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ckJveE1vZGVsT2JqZWN0Ojpjb21wdXRlZENTU1BhZGRpbmdBZnRlcik6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJCb3hNb2RlbE9iamVjdDo6Y29tcHV0ZWRDU1NQYWRkaW5nU3RhcnQpOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyQm94TW9kZWxPYmplY3Q6OmNvbXB1dGVkQ1NTUGFkZGluZ0Vu ZCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0Lmg6CisgICAgICAg IChSZW5kZXJCb3hNb2RlbE9iamVjdCk6CisKIDIwMTMtMDItMDEgIEVtaWwgQSBFa2x1bmQgIDxl YWVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlbW92ZSBkdXBsaWNhdGUgY29kZSBpbiBSZW5k ZXJCb3hNb2RlbE9iamVjdDo6Y29tcHV0ZWRDU1NQYWRkaW5nKgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcCBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAKaW5kZXggODg1OGYwZTJhN2Rl YTNjNDE2YTVlYzAzODQzMDc2YzdiZTk4ZjkyZC4uM2QyZDUwMGI0Y2U1MTc0MjJjNDYyNGM5ODMz YTFhMjhmY2FmNzE1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJveE1vZGVsT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy Qm94TW9kZWxPYmplY3QuY3BwCkBAIC01NTgsMTAgKzU1OCw5NSBAQCBpbnQgUmVuZGVyQm94TW9k ZWxPYmplY3Q6OnBpeGVsU25hcHBlZE9mZnNldEhlaWdodCgpIGNvbnN0CiAgICAgcmV0dXJuIHNu YXBTaXplVG9QaXhlbChvZmZzZXRIZWlnaHQoKSwgb2Zmc2V0VG9wKCkpOwogfQogCi1MYXlvdXRV bml0IFJlbmRlckJveE1vZGVsT2JqZWN0Ojpjb21wdXRlZENTU1BhZGRpbmcoTGVuZ3RoIHBhZGRp bmcpIGNvbnN0CitMYXlvdXRVbml0IFJlbmRlckJveE1vZGVsT2JqZWN0Ojpjb21wdXRlZENTU1Bh ZGRpbmdUb3AoKSBjb25zdAogewogICAgIExheW91dFVuaXQgdyA9IDA7CiAgICAgUmVuZGVyVmll dyogcmVuZGVyVmlldyA9IDA7CisgICAgTGVuZ3RoIHBhZGRpbmcgPSBzdHlsZSgpLT5wYWRkaW5n VG9wKCk7CisgICAgaWYgKHBhZGRpbmcuaXNQZXJjZW50KCkpCisgICAgICAgIHcgPSBjb250YWlu aW5nQmxvY2tMb2dpY2FsV2lkdGhGb3JDb250ZW50KCk7CisgICAgZWxzZSBpZiAocGFkZGluZy5p c1ZpZXdwb3J0UGVyY2VudGFnZSgpKQorICAgICAgICByZW5kZXJWaWV3ID0gdmlldygpOworICAg IHJldHVybiBtaW5pbXVtVmFsdWVGb3JMZW5ndGgocGFkZGluZywgdywgcmVuZGVyVmlldyk7Cit9 CisKK0xheW91dFVuaXQgUmVuZGVyQm94TW9kZWxPYmplY3Q6OmNvbXB1dGVkQ1NTUGFkZGluZ0Jv dHRvbSgpIGNvbnN0Cit7CisgICAgTGF5b3V0VW5pdCB3ID0gMDsKKyAgICBSZW5kZXJWaWV3KiBy ZW5kZXJWaWV3ID0gMDsKKyAgICBMZW5ndGggcGFkZGluZyA9IHN0eWxlKCktPnBhZGRpbmdCb3R0 b20oKTsKKyAgICBpZiAocGFkZGluZy5pc1BlcmNlbnQoKSkKKyAgICAgICAgdyA9IGNvbnRhaW5p bmdCbG9ja0xvZ2ljYWxXaWR0aEZvckNvbnRlbnQoKTsKKyAgICBlbHNlIGlmIChwYWRkaW5nLmlz Vmlld3BvcnRQZXJjZW50YWdlKCkpCisgICAgICAgIHJlbmRlclZpZXcgPSB2aWV3KCk7CisgICAg cmV0dXJuIG1pbmltdW1WYWx1ZUZvckxlbmd0aChwYWRkaW5nLCB3LCByZW5kZXJWaWV3KTsKK30K KworTGF5b3V0VW5pdCBSZW5kZXJCb3hNb2RlbE9iamVjdDo6Y29tcHV0ZWRDU1NQYWRkaW5nTGVm dCgpIGNvbnN0Cit7CisgICAgTGF5b3V0VW5pdCB3ID0gMDsKKyAgICBSZW5kZXJWaWV3KiByZW5k ZXJWaWV3ID0gMDsKKyAgICBMZW5ndGggcGFkZGluZyA9IHN0eWxlKCktPnBhZGRpbmdMZWZ0KCk7 CisgICAgaWYgKHBhZGRpbmcuaXNQZXJjZW50KCkpCisgICAgICAgIHcgPSBjb250YWluaW5nQmxv Y2tMb2dpY2FsV2lkdGhGb3JDb250ZW50KCk7CisgICAgZWxzZSBpZiAocGFkZGluZy5pc1ZpZXdw b3J0UGVyY2VudGFnZSgpKQorICAgICAgICByZW5kZXJWaWV3ID0gdmlldygpOworICAgIHJldHVy biBtaW5pbXVtVmFsdWVGb3JMZW5ndGgocGFkZGluZywgdywgcmVuZGVyVmlldyk7Cit9CisKK0xh eW91dFVuaXQgUmVuZGVyQm94TW9kZWxPYmplY3Q6OmNvbXB1dGVkQ1NTUGFkZGluZ1JpZ2h0KCkg Y29uc3QKK3sKKyAgICBMYXlvdXRVbml0IHcgPSAwOworICAgIFJlbmRlclZpZXcqIHJlbmRlclZp ZXcgPSAwOworICAgIExlbmd0aCBwYWRkaW5nID0gc3R5bGUoKS0+cGFkZGluZ1JpZ2h0KCk7Cisg ICAgaWYgKHBhZGRpbmcuaXNQZXJjZW50KCkpCisgICAgICAgIHcgPSBjb250YWluaW5nQmxvY2tM b2dpY2FsV2lkdGhGb3JDb250ZW50KCk7CisgICAgZWxzZSBpZiAocGFkZGluZy5pc1ZpZXdwb3J0 UGVyY2VudGFnZSgpKQorICAgICAgICByZW5kZXJWaWV3ID0gdmlldygpOworICAgIHJldHVybiBt aW5pbXVtVmFsdWVGb3JMZW5ndGgocGFkZGluZywgdywgcmVuZGVyVmlldyk7Cit9CisKK0xheW91 dFVuaXQgUmVuZGVyQm94TW9kZWxPYmplY3Q6OmNvbXB1dGVkQ1NTUGFkZGluZ0JlZm9yZSgpIGNv bnN0Cit7CisgICAgTGF5b3V0VW5pdCB3ID0gMDsKKyAgICBSZW5kZXJWaWV3KiByZW5kZXJWaWV3 ID0gMDsKKyAgICBMZW5ndGggcGFkZGluZyA9IHN0eWxlKCktPnBhZGRpbmdCZWZvcmUoKTsKKyAg ICBpZiAocGFkZGluZy5pc1BlcmNlbnQoKSkKKyAgICAgICAgdyA9IGNvbnRhaW5pbmdCbG9ja0xv Z2ljYWxXaWR0aEZvckNvbnRlbnQoKTsKKyAgICBlbHNlIGlmIChwYWRkaW5nLmlzVmlld3BvcnRQ ZXJjZW50YWdlKCkpCisgICAgICAgIHJlbmRlclZpZXcgPSB2aWV3KCk7CisgICAgcmV0dXJuIG1p bmltdW1WYWx1ZUZvckxlbmd0aChwYWRkaW5nLCB3LCByZW5kZXJWaWV3KTsKK30KKworTGF5b3V0 VW5pdCBSZW5kZXJCb3hNb2RlbE9iamVjdDo6Y29tcHV0ZWRDU1NQYWRkaW5nQWZ0ZXIoKSBjb25z dAoreworICAgIExheW91dFVuaXQgdyA9IDA7CisgICAgUmVuZGVyVmlldyogcmVuZGVyVmlldyA9 IDA7CisgICAgTGVuZ3RoIHBhZGRpbmcgPSBzdHlsZSgpLT5wYWRkaW5nQWZ0ZXIoKTsKKyAgICBp ZiAocGFkZGluZy5pc1BlcmNlbnQoKSkKKyAgICAgICAgdyA9IGNvbnRhaW5pbmdCbG9ja0xvZ2lj YWxXaWR0aEZvckNvbnRlbnQoKTsKKyAgICBlbHNlIGlmIChwYWRkaW5nLmlzVmlld3BvcnRQZXJj ZW50YWdlKCkpCisgICAgICAgIHJlbmRlclZpZXcgPSB2aWV3KCk7CisgICAgcmV0dXJuIG1pbmlt dW1WYWx1ZUZvckxlbmd0aChwYWRkaW5nLCB3LCByZW5kZXJWaWV3KTsKK30KKworTGF5b3V0VW5p dCBSZW5kZXJCb3hNb2RlbE9iamVjdDo6Y29tcHV0ZWRDU1NQYWRkaW5nU3RhcnQoKSBjb25zdAor eworICAgIExheW91dFVuaXQgdyA9IDA7CisgICAgUmVuZGVyVmlldyogcmVuZGVyVmlldyA9IDA7 CisgICAgTGVuZ3RoIHBhZGRpbmcgPSBzdHlsZSgpLT5wYWRkaW5nU3RhcnQoKTsKKyAgICBpZiAo cGFkZGluZy5pc1BlcmNlbnQoKSkKKyAgICAgICAgdyA9IGNvbnRhaW5pbmdCbG9ja0xvZ2ljYWxX aWR0aEZvckNvbnRlbnQoKTsKKyAgICBlbHNlIGlmIChwYWRkaW5nLmlzVmlld3BvcnRQZXJjZW50 YWdlKCkpCisgICAgICAgIHJlbmRlclZpZXcgPSB2aWV3KCk7CisgICAgcmV0dXJuIG1pbmltdW1W YWx1ZUZvckxlbmd0aChwYWRkaW5nLCB3LCByZW5kZXJWaWV3KTsKK30KKworTGF5b3V0VW5pdCBS ZW5kZXJCb3hNb2RlbE9iamVjdDo6Y29tcHV0ZWRDU1NQYWRkaW5nRW5kKCkgY29uc3QKK3sKKyAg ICBMYXlvdXRVbml0IHcgPSAwOworICAgIFJlbmRlclZpZXcqIHJlbmRlclZpZXcgPSAwOworICAg IExlbmd0aCBwYWRkaW5nID0gc3R5bGUoKS0+cGFkZGluZ0VuZCgpOwogICAgIGlmIChwYWRkaW5n LmlzUGVyY2VudCgpKQogICAgICAgICB3ID0gY29udGFpbmluZ0Jsb2NrTG9naWNhbFdpZHRoRm9y Q29udGVudCgpOwogICAgIGVsc2UgaWYgKHBhZGRpbmcuaXNWaWV3cG9ydFBlcmNlbnRhZ2UoKSkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVj dC5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmgKaW5k ZXggOTllNmZkOWZkODdkOWQ4OGI4MDQ3MDliOGRlYzEzOTA2OGQ1YWJhZC4uMWYwNTY0ZDQ1NmRh NzdjMmEwYTNlMGI5NTM1YWY0N2QyNTQyOTE2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmgKQEAgLTkxLDE0ICs5MSwxNCBAQCBwdWJsaWM6 CiAgICAgdmlydHVhbCBJbnRSZWN0IGJvcmRlckJvdW5kaW5nQm94KCkgY29uc3QgPSAwOwogCiAg ICAgLy8gVGhlc2UgcmV0dXJuIHRoZSBDU1MgY29tcHV0ZWQgcGFkZGluZyB2YWx1ZXMuCi0gICAg TGF5b3V0VW5pdCBjb21wdXRlZENTU1BhZGRpbmdUb3AoKSBjb25zdCB7IHJldHVybiBjb21wdXRl ZENTU1BhZGRpbmcoc3R5bGUoKS0+cGFkZGluZ1RvcCgpKTsgfQotICAgIExheW91dFVuaXQgY29t cHV0ZWRDU1NQYWRkaW5nQm90dG9tKCkgY29uc3QgeyByZXR1cm4gY29tcHV0ZWRDU1NQYWRkaW5n KHN0eWxlKCktPnBhZGRpbmdCb3R0b20oKSk7IH0KLSAgICBMYXlvdXRVbml0IGNvbXB1dGVkQ1NT UGFkZGluZ0xlZnQoKSBjb25zdCB7IHJldHVybiBjb21wdXRlZENTU1BhZGRpbmcoc3R5bGUoKS0+ cGFkZGluZ0xlZnQoKSk7IH0KLSAgICBMYXlvdXRVbml0IGNvbXB1dGVkQ1NTUGFkZGluZ1JpZ2h0 KCkgY29uc3QgeyByZXR1cm4gY29tcHV0ZWRDU1NQYWRkaW5nKHN0eWxlKCktPnBhZGRpbmdSaWdo dCgpKTsgfQotICAgIExheW91dFVuaXQgY29tcHV0ZWRDU1NQYWRkaW5nQmVmb3JlKCkgY29uc3Qg eyByZXR1cm4gY29tcHV0ZWRDU1NQYWRkaW5nKHN0eWxlKCktPnBhZGRpbmdCZWZvcmUoKSk7IH0K LSAgICBMYXlvdXRVbml0IGNvbXB1dGVkQ1NTUGFkZGluZ0FmdGVyKCkgY29uc3QgeyByZXR1cm4g Y29tcHV0ZWRDU1NQYWRkaW5nKHN0eWxlKCktPnBhZGRpbmdBZnRlcigpKTsgfQotICAgIExheW91 dFVuaXQgY29tcHV0ZWRDU1NQYWRkaW5nU3RhcnQoKSBjb25zdCB7IHJldHVybiBjb21wdXRlZENT U1BhZGRpbmcoc3R5bGUoKS0+cGFkZGluZ1N0YXJ0KCkpOyB9Ci0gICAgTGF5b3V0VW5pdCBjb21w dXRlZENTU1BhZGRpbmdFbmQoKSBjb25zdCB7IHJldHVybiBjb21wdXRlZENTU1BhZGRpbmcoc3R5 bGUoKS0+cGFkZGluZ0VuZCgpKTsgfQorICAgIExheW91dFVuaXQgY29tcHV0ZWRDU1NQYWRkaW5n VG9wKCkgY29uc3Q7CisgICAgTGF5b3V0VW5pdCBjb21wdXRlZENTU1BhZGRpbmdCb3R0b20oKSBj b25zdDsKKyAgICBMYXlvdXRVbml0IGNvbXB1dGVkQ1NTUGFkZGluZ0xlZnQoKSBjb25zdDsKKyAg ICBMYXlvdXRVbml0IGNvbXB1dGVkQ1NTUGFkZGluZ1JpZ2h0KCkgY29uc3Q7CisgICAgTGF5b3V0 VW5pdCBjb21wdXRlZENTU1BhZGRpbmdCZWZvcmUoKSBjb25zdDsKKyAgICBMYXlvdXRVbml0IGNv bXB1dGVkQ1NTUGFkZGluZ0FmdGVyKCkgY29uc3Q7CisgICAgTGF5b3V0VW5pdCBjb21wdXRlZENT U1BhZGRpbmdTdGFydCgpIGNvbnN0OworICAgIExheW91dFVuaXQgY29tcHV0ZWRDU1NQYWRkaW5n RW5kKCkgY29uc3Q7CiAKICAgICAvLyBUaGVzZSBmdW5jdGlvbnMgYXJlIHVzZWQgZHVyaW5nIGxh eW91dC4gVGFibGUgY2VsbHMgYW5kIHRoZSBNYXRoTUwKICAgICAvLyBjb2RlIG92ZXJyaWRlIHRo ZW0gdG8gaW5jbHVkZSBzb21lIGV4dHJhIGludHJpbnNpYyBwYWRkaW5nLgpAQCAtMjc4LDcgKzI3 OCw2IEBAIHB1YmxpYzoKICAgICB2b2lkIG1vdmVDaGlsZHJlblRvKFJlbmRlckJveE1vZGVsT2Jq ZWN0KiB0b0JveE1vZGVsT2JqZWN0LCBSZW5kZXJPYmplY3QqIHN0YXJ0Q2hpbGQsIFJlbmRlck9i amVjdCogZW5kQ2hpbGQsIFJlbmRlck9iamVjdCogYmVmb3JlQ2hpbGQsIGJvb2wgZnVsbFJlbW92 ZUluc2VydCA9IGZhbHNlKTsKIAogcHJpdmF0ZToKLSAgICBMYXlvdXRVbml0IGNvbXB1dGVkQ1NT UGFkZGluZyhMZW5ndGgpIGNvbnN0OwogICAgIHZpcnR1YWwgYm9vbCBpc0JveE1vZGVsT2JqZWN0 KCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQogICAgIAogICAgIHZpcnR1YWwgTGF5b3V0UmVjdCBm cmFtZVJlY3RGb3JTdGlja3lQb3NpdGlvbmluZygpIGNvbnN0ID0gMDsK