108718 2013-02-01 15:49:50 -0800 LLDB: add synthetic provider for WTF::HashTable 2013-02-01 16:53:20 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble andersca beidson mitz oldest_to_newest 823377 0 jer.noble 2013-02-01 15:49:50 -0800 LLDB: add synthetic provider for WTF::HashTable 823384 1 186176 jer.noble 2013-02-01 15:55:31 -0800 Created attachment 186176 Patch 823389 2 186176 darin 2013-02-01 15:59:21 -0800 Comment on attachment 186176 Patch Wow, neat. Tell us how to use this! 823399 3 jer.noble 2013-02-01 16:05:05 -0800 Thanks! There are some short instructions at the top of the lldb_webkit.py file: LLDB Support for WebKit Types Add the following to your ~/.lldbinit file to add WebKit Type summaries in LLDB and Xcode: command script import {Path to WebKit Root}/Tools/lldb/lldb_webkit.py (You can also paste that command into into a running LLDB session.) You'll need to restart Xcode after updating this file, but once you do, the Xcode variables view will allow you to inspect the contents of a HashTable, i.e. it will act as if the HashTable variable was an array of length var.m_tableSize. Example from command-line lldb: (lldb) p foo.m_impl (WTF::HashSet<const char *, WTF::PtrHash<const char *>, WTF::HashTraits<const char> >::HashTableType) $0 = { tableSize = 64, keyCount = 3 } { (const char *) [0] = 0x0000000000000000 (const char *) [1] = 0x0000000000000000 (const char *) [2] = 0x0000000000000000 (const char *) [3] = 0x0000000000000000 (const char *) [4] = 0x0000000000000000 823433 4 jer.noble 2013-02-01 16:53:20 -0800 Committed r141666: <http://trac.webkit.org/changeset/141666> 186176 2013-02-01 15:55:31 -0800 2013-02-01 15:59:21 -0800 Patch bug-108718-20130201155214.patch text/plain 5030 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNjI4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDEyNmVmNjhiNmU1M2ZhNWMwMGU3YjUxNmNkMTdlN2Fh NDJkZjhjOC4uYTVkODQxZDEyZTllNmYwZTI3YTA2NTZhYTQ3NmFiZDhlMTQ1NjRiOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5 IEBACisyMDEzLTAyLTAxICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAg ICAgIExMREI6IGFkZCBzeW50aGV0aWMgcHJvdmlkZXIgZm9yIFdURjo6SGFzaFRhYmxlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg3MTgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBzeW50aGV0 aWMgcHJvdmlkZXIgd2hpY2ggd2lsbCBlbWl0IHRoZSBjb250ZW50cyBvZiBhIGdpdmVuCisgICAg ICAgIFdURjo6SGFzaFRhYmxlLiBUaGlzIGFsbG93cyBjbGllbnRzIHVzaW5nIFhjb2RlL2xsZGIg dG8gZW51bWVyYXRlCisgICAgICAgIHRoZSBoYXNoIGNvbnRlbnRzLgorCisgICAgICAgICogbGxk Yi9sbGRiX3dlYmtpdC5weToKKyAgICAgICAgKF9fbGxkYl9pbml0X21vZHVsZSk6CisgICAgICAg IChfX2xsZGJfaW5pdF9tb2R1bGUubGxkYl93ZWJraXQpOgorICAgICAgICAoV1RGSGFzaFRhYmxl X1N1bW1hcnlQcm92aWRlcik6CisgICAgICAgIChXVEZWZWN0b3JQcm92aWRlci5oYXNfY2hpbGRy ZW4pOgorICAgICAgICAoV1RGSGFzaFRhYmxlUHJvdmlkZXIpOgorICAgICAgICAoV1RGSGFzaFRh YmxlUHJvdmlkZXIuX19pbml0X18pOgorICAgICAgICAoV1RGSGFzaFRhYmxlUHJvdmlkZXIubnVt X2NoaWxkcmVuKToKKyAgICAgICAgKFdURkhhc2hUYWJsZVByb3ZpZGVyLmdldF9jaGlsZF9pbmRl eCk6CisgICAgICAgIChXVEZIYXNoVGFibGVQcm92aWRlci5nZXRfY2hpbGRfYXRfaW5kZXgpOgor ICAgICAgICAoV1RGSGFzaFRhYmxlUHJvdmlkZXIudGFibGVTaXplKToKKyAgICAgICAgKFdURkhh c2hUYWJsZVByb3ZpZGVyLmtleUNvdW50KToKKyAgICAgICAgKFdURkhhc2hUYWJsZVByb3ZpZGVy LnVwZGF0ZSk6CisgICAgICAgIChXVEZIYXNoVGFibGVQcm92aWRlci5oYXNfY2hpbGRyZW4pOgor CiAyMDEzLTAxLTMxICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CiAKICAgICAg ICAgRml4IHRlc3Qgc2NyaXB0cyBmb3IgRVdTIGJvdHMgdG8gZ2V0IHRoZW0gcnVubmluZyBvbmNl IGFuZCBmb3IgYWxsLgpkaWZmIC0tZ2l0IGEvVG9vbHMvbGxkYi9sbGRiX3dlYmtpdC5weSBiL1Rv b2xzL2xsZGIvbGxkYl93ZWJraXQucHkKaW5kZXggMzc4NDRmODliMzJhYTA2ZjY3MTc5YTUxMjJm NmU5NTg0NTViMWNhYi4uNGFkYzQzODgzNTBhNmViOTlhYTQ2NzNhOTI1NTE5YzAyMGZjMzgzMSAx MDA2NDQKLS0tIGEvVG9vbHMvbGxkYi9sbGRiX3dlYmtpdC5weQorKysgYi9Ub29scy9sbGRiL2xs ZGJfd2Via2l0LnB5CkBAIC0zNyw3ICszNyw5IEBAIGRlZiBfX2xsZGJfaW5pdF9tb2R1bGUoZGVi dWdnZXIsIGRpY3QpOgogICAgIGRlYnVnZ2VyLkhhbmRsZUNvbW1hbmQoJ3R5cGUgc3VtbWFyeSBh ZGQgLS1leHBhbmQgLUYgbGxkYl93ZWJraXQuV1RGU3RyaW5nSW1wbF9TdW1tYXJ5UHJvdmlkZXIg V1RGOjpTdHJpbmdJbXBsJykKICAgICBkZWJ1Z2dlci5IYW5kbGVDb21tYW5kKCd0eXBlIHN1bW1h cnkgYWRkIC0tZXhwYW5kIC1GIGxsZGJfd2Via2l0LldURkF0b21pY1N0cmluZ19TdW1tYXJ5UHJv dmlkZXIgV1RGOjpBdG9taWNTdHJpbmcnKQogICAgIGRlYnVnZ2VyLkhhbmRsZUNvbW1hbmQoJ3R5 cGUgc3VtbWFyeSBhZGQgLS1leHBhbmQgLUYgbGxkYl93ZWJraXQuV1RGVmVjdG9yX1N1bW1hcnlQ cm92aWRlciAteCAiV1RGOjpWZWN0b3I8Lis+JCInKQorICAgIGRlYnVnZ2VyLkhhbmRsZUNvbW1h bmQoJ3R5cGUgc3VtbWFyeSBhZGQgLS1leHBhbmQgLUYgbGxkYl93ZWJraXQuV1RGSGFzaFRhYmxl X1N1bW1hcnlQcm92aWRlciAteCAiV1RGOjpIYXNoVGFibGU8Lis+JCInKQogICAgIGRlYnVnZ2Vy LkhhbmRsZUNvbW1hbmQoJ3R5cGUgc3ludGhldGljIGFkZCAteCAiV1RGOjpWZWN0b3I8Lis+JCIg LS1weXRob24tY2xhc3MgbGxkYl93ZWJraXQuV1RGVmVjdG9yUHJvdmlkZXInKQorICAgIGRlYnVn Z2VyLkhhbmRsZUNvbW1hbmQoJ3R5cGUgc3ludGhldGljIGFkZCAteCAiV1RGOjpIYXNoVGFibGU8 Lis+JCIgLS1weXRob24tY2xhc3MgbGxkYl93ZWJraXQuV1RGSGFzaFRhYmxlUHJvdmlkZXInKQog CiAKIGRlZiBXVEZTdHJpbmdfU3VtbWFyeVByb3ZpZGVyKHZhbG9iaiwgZGljdCk6CkBAIC01OCw2 ICs2MCwxMSBAQCBkZWYgV1RGVmVjdG9yX1N1bW1hcnlQcm92aWRlcih2YWxvYmosIGRpY3QpOgog ICAgIHByb3ZpZGVyID0gV1RGVmVjdG9yUHJvdmlkZXIodmFsb2JqLCBkaWN0KQogICAgIHJldHVy biAieyBzaXplID0gJWQsIGNhcGFjaXR5ID0gJWQgfSIgJSAocHJvdmlkZXIuc2l6ZSwgcHJvdmlk ZXIuY2FwYWNpdHkpCiAKKworZGVmIFdURkhhc2hUYWJsZV9TdW1tYXJ5UHJvdmlkZXIodmFsb2Jq LCBkaWN0KToKKyAgICBwcm92aWRlciA9IFdURkhhc2hUYWJsZVByb3ZpZGVyKHZhbG9iaiwgZGlj dCkKKyAgICByZXR1cm4gInsgdGFibGVTaXplID0gJWQsIGtleUNvdW50ID0gJWQgfSIgJSAocHJv dmlkZXIudGFibGVTaXplKCksIHByb3ZpZGVyLmtleUNvdW50KCkpCisKICMgRklYTUU6IFByb3Zp ZGUgc3VwcG9ydCBmb3IgdGhlIGZvbGxvd2luZyB0eXBlczoKICMgZGVmIFdURlZlY3Rvcl9TdW1t YXJ5UHJvdmlkZXIodmFsb2JqLCBkaWN0KToKICMgZGVmIFdURkNTdHJpbmdfU3VtbWFyeVByb3Zp ZGVyKHZhbG9iaiwgZGljdCk6CkBAIC0xOTAsMyArMTk3LDU2IEBAIGNsYXNzIFdURlZlY3RvclBy b3ZpZGVyOgogCiAgICAgZGVmIGhhc19jaGlsZHJlbihzZWxmKToKICAgICAgICAgcmV0dXJuIFRy dWUKKworCitjbGFzcyBXVEZIYXNoVGFibGVQcm92aWRlcjoKKyAgICBkZWYgX19pbml0X18oc2Vs ZiwgdmFsb2JqLCBpbnRlcm5hbF9kaWN0KToKKyAgICAgICAgc2VsZi52YWxvYmogPSB2YWxvYmoK KyAgICAgICAgc2VsZi51cGRhdGUoKQorCisgICAgZGVmIG51bV9jaGlsZHJlbihzZWxmKToKKyAg ICAgICAgcmV0dXJuIHNlbGYudGFibGVTaXplKCkgKyA1CisKKyAgICBkZWYgZ2V0X2NoaWxkX2lu ZGV4KHNlbGYsIG5hbWUpOgorICAgICAgICBpZiBuYW1lID09ICJtX3RhYmxlIjoKKyAgICAgICAg ICAgIHJldHVybiBzZWxmLnRhYmxlU2l6ZSgpCisgICAgICAgIGVsaWYgbmFtZSA9PSAibV90YWJs ZVNpemUiOgorICAgICAgICAgICAgcmV0dXJuIHNlbGYudGFibGVTaXplKCkgKyAxCisgICAgICAg IGVsaWYgbmFtZSA9PSAibV90YWJsZVNpemVNYXNrIjoKKyAgICAgICAgICAgIHJldHVybiBzZWxm LnRhYmxlU2l6ZSgpICsgMgorICAgICAgICBlbGlmIG5hbWUgPT0gIm1fa2V5Q291bnQiOgorICAg ICAgICAgICAgcmV0dXJuIHNlbGYudGFibGVTaXplKCkgKyAzCisgICAgICAgIGVsaWYgbmFtZSA9 PSAibV9kZWxldGVkQ291bnQiOgorICAgICAgICAgICAgcmV0dXJuIHNlbGYudGFibGVTaXplKCkg KyA0CisgICAgICAgIGVsc2U6CisgICAgICAgICAgICByZXR1cm4gaW50KG5hbWUubHN0cmlwKCdb JykucnN0cmlwKCddJykpCisKKyAgICBkZWYgZ2V0X2NoaWxkX2F0X2luZGV4KHNlbGYsIGluZGV4 KToKKyAgICAgICAgaWYgaW5kZXggPT0gc2VsZi50YWJsZVNpemUoKToKKyAgICAgICAgICAgIHJl dHVybiBzZWxmLnZhbG9iai5HZXRDaGlsZE1lbWJlcldpdGhOYW1lKCdtX3RhYmxlJykKKyAgICAg ICAgZWxpZiBpbmRleCA9PSBzZWxmLnRhYmxlU2l6ZSgpICsgMToKKyAgICAgICAgICAgIHJldHVy biBzZWxmLnZhbG9iai5HZXRDaGlsZE1lbWJlcldpdGhOYW1lKCdtX3RhYmxlU2l6ZScpCisgICAg ICAgIGVsaWYgaW5kZXggPT0gc2VsZi50YWJsZVNpemUoKSArIDI6CisgICAgICAgICAgICByZXR1 cm4gc2VsZi52YWxvYmouR2V0Q2hpbGRNZW1iZXJXaXRoTmFtZSgnbV90YWJsZVNpemVNYXNrJykK KyAgICAgICAgZWxpZiBpbmRleCA9PSBzZWxmLnRhYmxlU2l6ZSgpICsgMzoKKyAgICAgICAgICAg IHJldHVybiBzZWxmLnZhbG9iai5HZXRDaGlsZE1lbWJlcldpdGhOYW1lKCdtX2tleUNvdW50JykK KyAgICAgICAgZWxpZiBpbmRleCA9PSBzZWxmLnRhYmxlU2l6ZSgpICsgNDoKKyAgICAgICAgICAg IHJldHVybiBzZWxmLnZhbG9iai5HZXRDaGlsZE1lbWJlcldpdGhOYW1lKCdtX2RlbGV0ZWRDb3Vu dCcpCisgICAgICAgIGVsaWYgaW5kZXggPCBzZWxmLnRhYmxlU2l6ZSgpOgorICAgICAgICAgICAg dGFibGUgPSBzZWxmLnZhbG9iai5HZXRDaGlsZE1lbWJlcldpdGhOYW1lKCdtX3RhYmxlJykKKyAg ICAgICAgICAgIHJldHVybiB0YWJsZS5DcmVhdGVDaGlsZEF0T2Zmc2V0KCdbJyArIHN0cihpbmRl eCkgKyAnXScsIGluZGV4ICogc2VsZi5kYXRhX3NpemUsIHNlbGYuZGF0YV90eXBlKQorICAgICAg ICBlbHNlOgorICAgICAgICAgICAgcmV0dXJuIE5vbmUKKworICAgIGRlZiB0YWJsZVNpemUoc2Vs Zik6CisgICAgICAgIHJldHVybiBzZWxmLnZhbG9iai5HZXRDaGlsZE1lbWJlcldpdGhOYW1lKCdt X3RhYmxlU2l6ZScpLkdldFZhbHVlQXNVbnNpZ25lZCgwKQorCisgICAgZGVmIGtleUNvdW50KHNl bGYpOgorICAgICAgICByZXR1cm4gc2VsZi52YWxvYmouR2V0Q2hpbGRNZW1iZXJXaXRoTmFtZSgn bV9rZXlDb3VudCcpLkdldFZhbHVlQXNVbnNpZ25lZCgwKQorCisgICAgZGVmIHVwZGF0ZShzZWxm KToKKyAgICAgICAgc2VsZi5kYXRhX3R5cGUgPSBzZWxmLnZhbG9iai5HZXRUeXBlKCkuR2V0VGVt cGxhdGVBcmd1bWVudFR5cGUoMCkKKyAgICAgICAgc2VsZi5kYXRhX3NpemUgPSBzZWxmLmRhdGFf dHlwZS5HZXRCeXRlU2l6ZSgpCisKKyAgICBkZWYgaGFzX2NoaWxkcmVuKHNlbGYpOgorICAgICAg ICByZXR1cm4gVHJ1ZQo=