108693 2013-02-01 14:20:50 -0800 Make ConfigurationBuildDir include directories precede WebKitLibraries in JSC 2013-02-05 13:19:04 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned bfulgham roger_fong thorton oldest_to_newest 823262 0 roger_fong 2013-02-01 14:20:50 -0800 ConfigurationBuildDir includes should precede WebKitLibraries. This is because some files in the newer WebKitLibaries versions have overlapping files "include/private/wtf". These files will not necessarily match up with whatever is on ToT since new WebKitLibraries are only released periodically. This caused build issues when using a newer WebKitLibraries version, specifically in JSC. JSC should prioritize the files in the build directory which are copied from ToT when searching for file includes. This might also be an issue in other projects down the road but I think taking a "fix it as they come" approach is better here. 823270 1 186138 roger_fong 2013-02-01 14:23:37 -0800 Created attachment 186138 patch 825756 2 186138 roger_fong 2013-02-05 13:13:58 -0800 Comment on attachment 186138 patch rubberstamped by thorton 825765 3 roger_fong 2013-02-05 13:18:56 -0800 http://trac.webkit.org/changeset/141921 186138 2013-02-01 14:23:37 -0800 2013-02-05 13:13:58 -0800 patch patch.patch text/plain 2516 roger_fong SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE0MTY0 MykKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAy LTAxICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBD b25maWd1cmF0aW9uQnVpbGREaXIgaW5jbHVkZSBkaXJlY3RvcmllcyBwcmVjZWRlIFdlYktpdExp YnJhcmllcyBpbiBKU0MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMDg2OTMuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBKYXZhU2NyaXB0Q29yZS52Y3Byb2ovSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlw dENvcmVDb21tb24udnNwcm9wczoKKwogMjAxMy0wMi0wMSAgQmFsYXpzIEtpbHZhZHkgIDxraWx2 YWR5YkBob21lamlubmkuY29tPgogCiAgICAgICAgIG9mZmxpbmVhc20gQmFzZUluZGV4IGhhbmRs aW5nIGlzIGJyb2tlbiBvbiBBUk0gZHVlIHRvIE1JUFMgY2hhbmdlcwpJbmRleDogSmF2YVNjcmlw dENvcmUudmNwcm9qL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlQ29tbW9uLnZzcHJvcHMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUudmNwcm9qL0phdmFTY3JpcHRDb3JlL0phdmFT Y3JpcHRDb3JlQ29tbW9uLnZzcHJvcHMJKHJldmlzaW9uIDE0MTYxNCkKKysrIEphdmFTY3JpcHRD b3JlLnZjcHJvai9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZUNvbW1vbi52c3Byb3BzCSh3 b3JraW5nIGNvcHkpCkBAIC02LDcgKzYsNyBAQAogCT4KIAk8VG9vbAogCQlOYW1lPSJWQ0NMQ29t cGlsZXJUb29sIgotCQlBZGRpdGlvbmFsSW5jbHVkZURpcmVjdG9yaWVzPSImcXVvdDskKENvbmZp Z3VyYXRpb25CdWlsZERpcilcb2JqXEphdmFTY3JpcHRDb3JlXERlcml2ZWRTb3VyY2VzXCZxdW90 OzsuLi8uLi87Li4vLi4vQVBJLzsuLi8uLi9wYXJzZXIvOy4uLy4uL2J5dGVjb21waWxlci87Li4v Li4vZGZnLzsuLi8uLi9kaXNhc3NlbWJsZXI7Li4vLi4vaml0LzsuLi8uLi9sbGludC87Li4vLi4v cnVudGltZS87Li4vLi4vdG9vbHMvOy4uLy4uL2J5dGVjb2RlLzsuLi8uLi9pbnRlcnByZXRlci87 Li4vLi4vd3RmLzsuLi8uLi9wcm9maWxlcjsuLi8uLi9hc3NlbWJsZXIvOy4uLy4uL2RlYnVnZ2Vy LzsuLi8uLi9oZWFwLzsmcXVvdDskKFdlYktpdExpYnJhcmllc0RpcilcaW5jbHVkZSZxdW90Ozsm cXVvdDskKFdlYktpdExpYnJhcmllc0RpcilcaW5jbHVkZVxwcml2YXRlJnF1b3Q7OyZxdW90OyQo Q29uZmlndXJhdGlvbkJ1aWxkRGlyKVxpbmNsdWRlJnF1b3Q7OyZxdW90OyQoQ29uZmlndXJhdGlv bkJ1aWxkRGlyKVxpbmNsdWRlXEphdmFTY3JpcHRDb3JlJnF1b3Q7OyZxdW90OyQoQ29uZmlndXJh dGlvbkJ1aWxkRGlyKVxpbmNsdWRlXHByaXZhdGUmcXVvdDs7JnF1b3Q7JChDb25maWd1cmF0aW9u QnVpbGREaXIpXGluY2x1ZGVccHJpdmF0ZVxKYXZhU2NyaXB0Q29yZSZxdW90OzsmcXVvdDskKFdl YktpdExpYnJhcmllc0RpcilcaW5jbHVkZVxwdGhyZWFkcyZxdW90OyIKKwkJQWRkaXRpb25hbElu Y2x1ZGVEaXJlY3Rvcmllcz0iJnF1b3Q7JChDb25maWd1cmF0aW9uQnVpbGREaXIpXG9ialxKYXZh U2NyaXB0Q29yZVxEZXJpdmVkU291cmNlc1wmcXVvdDs7Li4vLi4vOy4uLy4uL0FQSS87Li4vLi4v cGFyc2VyLzsuLi8uLi9ieXRlY29tcGlsZXIvOy4uLy4uL2RmZy87Li4vLi4vZGlzYXNzZW1ibGVy Oy4uLy4uL2ppdC87Li4vLi4vbGxpbnQvOy4uLy4uL3J1bnRpbWUvOy4uLy4uL3Rvb2xzLzsuLi8u Li9ieXRlY29kZS87Li4vLi4vaW50ZXJwcmV0ZXIvOy4uLy4uL3d0Zi87Li4vLi4vcHJvZmlsZXI7 Li4vLi4vYXNzZW1ibGVyLzsuLi8uLi9kZWJ1Z2dlci87Li4vLi4vaGVhcC87JnF1b3Q7JChDb25m aWd1cmF0aW9uQnVpbGREaXIpXGluY2x1ZGUmcXVvdDs7JnF1b3Q7JChDb25maWd1cmF0aW9uQnVp bGREaXIpXGluY2x1ZGVcSmF2YVNjcmlwdENvcmUmcXVvdDs7JnF1b3Q7JChDb25maWd1cmF0aW9u QnVpbGREaXIpXGluY2x1ZGVccHJpdmF0ZSZxdW90OzsmcXVvdDskKENvbmZpZ3VyYXRpb25CdWls ZERpcilcaW5jbHVkZVxwcml2YXRlXEphdmFTY3JpcHRDb3JlJnF1b3Q7OyZxdW90OyQoV2ViS2l0 TGlicmFyaWVzRGlyKVxpbmNsdWRlJnF1b3Q7OyZxdW90OyQoV2ViS2l0TGlicmFyaWVzRGlyKVxp bmNsdWRlXHByaXZhdGUmcXVvdDs7JnF1b3Q7JChXZWJLaXRMaWJyYXJpZXNEaXIpXGluY2x1ZGVc cHRocmVhZHMmcXVvdDsiCiAJCVByZXByb2Nlc3NvckRlZmluaXRpb25zPSJTVEFUSUNBTExZX0xJ TktFRF9XSVRIX1dURjtfX1NURF9DIgogCQlGb3JjZWRJbmNsdWRlRmlsZXM9IklDVVZlcnNpb24u aCIKIAkvPgo=