108689 2013-02-01 14:03:31 -0800 Web Inspector: fix "DOM Exception 8" when deleting lines containing decoration in DTE. 2013-02-02 04:11:09 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 lushnikov lushnikov apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 823243 0 lushnikov 2013-02-01 14:03:31 -0800 Fix "DOM Exception 8" when deleting lines containing decoration in DTE. 823249 1 186134 lushnikov 2013-02-01 14:08:17 -0800 Created attachment 186134 Patch 823257 2 186134 apavlov 2013-02-01 14:16:26 -0800 Comment on attachment 186134 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186134&action=review > Source/WebCore/inspector/front-end/DefaultTextEditor.js:2931 > + if (this.element.contains(this.element.decorationsElement)) We usually use the parentElement check, something like if (this.element.decorationsElement.parentElement) this.element.decorationsElement.parentElement.removeChild(this.element.decorationsElement); The node.contains() method is potentially slower, since it will check all the element's descendants, not only immediate children. 823274 3 186134 lushnikov 2013-02-01 14:29:31 -0800 Comment on attachment 186134 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186134&action=review >> Source/WebCore/inspector/front-end/DefaultTextEditor.js:2931 >> + if (this.element.contains(this.element.decorationsElement)) > > We usually use the parentElement check, something like > > if (this.element.decorationsElement.parentElement) > this.element.decorationsElement.parentElement.removeChild(this.element.decorationsElement); > > The node.contains() method is potentially slower, since it will check all the element's descendants, not only immediate children. That is reasonable! 823329 4 186157 lushnikov 2013-02-01 15:15:01 -0800 Created attachment 186157 Patch 823427 5 186157 apavlov 2013-02-01 16:44:01 -0800 Comment on attachment 186157 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186157&action=review > Source/WebCore/inspector/front-end/DefaultTextEditor.js:2931 > + if (this.element.decorationsElement.parentElement) I DO hope the parentElement is guaranteed to be this.element 823480 6 186157 webkit.review.bot 2013-02-01 18:19:05 -0800 Comment on attachment 186157 Patch Clearing flags on attachment: 186157 Committed r141673: <http://trac.webkit.org/changeset/141673> 823481 7 webkit.review.bot 2013-02-01 18:19:09 -0800 All reviewed patches have been landed. Closing bug. 823623 8 186157 pfeldman 2013-02-02 04:11:09 -0800 Comment on attachment 186157 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186157&action=review >> Source/WebCore/inspector/front-end/DefaultTextEditor.js:2931 >> + if (this.element.decorationsElement.parentElement) > > I DO hope the parentElement is guaranteed to be this.element Should have been this.element.decorationElement.removeSelf(); 186134 2013-02-01 14:08:17 -0800 2013-02-01 15:14:57 -0800 Patch bug-108689-20130202020459.patch text/plain 1997 lushnikov U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTNmOGZkNDFkMWI3ZDdh ZWFmNDk4N2NlOGQ2NzExMjRhYWZlNzk1OS4uNmRlNjY5ZmUxOTI2N2E5OTIxMDY4NTBhMDc0YjY4 NDI2OGVlZjU0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTAxICBBbmRy ZXkgTHVzaG5pa292ICA8bHVzaG5pa292QGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBmaXggIkRPTSBFeGNlcHRpb24gOCIgd2hlbiBkZWxldGluZyBsaW5lcyBjb250YWlu aW5nIGRlY29yYXRpb24gaW4gRFRFLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTA4Njg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWRkIGEgY2hlY2sgdGhhdCBkZWNvcmF0aW9uIGVsZW1lbnQgaXMgc3Rp bGwgYWRkZWQgdG8gdGhlIGxpbmUuIFRoaXMKKyAgICAgICAgd29uJ3QgYmUgdHJ1ZSBpZiB0aGUg d2hvbGUgbGluZSBpcyBkZWxldGVkIGluIGNvbnRlbnRFZGl0YWJsZSwKKyAgICAgICAgYW5kIHRo aXMgaXMgdGhlIHJlYXNvbiBmb3IgdGhlIGV4Y2VwdGlvbiB0byBiZSB0aHJvd24uCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9EZWZhdWx0 VGV4dEVkaXRvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yTWFpbkNodW5r LnByb3RvdHlwZS5yZW1vdmVBbGxEZWNvcmF0aW9ucyk6CisKIDIwMTMtMDItMDEgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjE0MTI4MSk6 IE5hdmlnYXRpbmcgdG8gdGhpcyBIVFRQIExpdmUgU3RyZWFtaW5nIChhcHBsaWNhdGlvbi92bmQu YXBwbGUubXBlZ3VybCkgVVJMIGRvd25sb2FkcyBhIGZpbGUgaW5zdGVhZCBvZiBwbGF5aW5nIGl0 IGluIHRoZSBicm93c2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL0RlZmF1bHRUZXh0RWRpdG9yLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9EZWZhdWx0VGV4dEVkaXRvci5qcwppbmRleCBlYmRmZDYzNWEyM2Q5OWIwMWVkYmNj ZGIxNTdiN2MwZGQ2YzE1NzVkLi4yODRmYTJlYjFmMTRlNDNkZDI0YTM2OGUxZjdkMzQ3OWRlYWY0 Mjc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RlZmF1 bHRUZXh0RWRpdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv RGVmYXVsdFRleHRFZGl0b3IuanMKQEAgLTI5MjgsNyArMjkyOCw4IEBAIFdlYkluc3BlY3Rvci5U ZXh0RWRpdG9yTWFpbkNodW5rLnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5fY2h1bmtlZFBh bmVsLmJlZ2luRG9tVXBkYXRlcygpOwogICAgICAgICB0aGlzLmVsZW1lbnQuY2xhc3NOYW1lID0g IndlYmtpdC1saW5lLWNvbnRlbnQiOwogICAgICAgICBpZiAodGhpcy5lbGVtZW50LmRlY29yYXRp b25zRWxlbWVudCkgewotICAgICAgICAgICAgdGhpcy5lbGVtZW50LnJlbW92ZUNoaWxkKHRoaXMu ZWxlbWVudC5kZWNvcmF0aW9uc0VsZW1lbnQpOworICAgICAgICAgICAgaWYgKHRoaXMuZWxlbWVu dC5jb250YWlucyh0aGlzLmVsZW1lbnQuZGVjb3JhdGlvbnNFbGVtZW50KSkKKyAgICAgICAgICAg ICAgICB0aGlzLmVsZW1lbnQucmVtb3ZlQ2hpbGQodGhpcy5lbGVtZW50LmRlY29yYXRpb25zRWxl bWVudCk7CiAgICAgICAgICAgICBkZWxldGUgdGhpcy5lbGVtZW50LmRlY29yYXRpb25zRWxlbWVu dDsKICAgICAgICAgfQogICAgICAgICB0aGlzLl9jaHVua2VkUGFuZWwuZW5kRG9tVXBkYXRlcygp Owo= 186157 2013-02-01 15:15:01 -0800 2013-02-02 04:11:09 -0800 Patch bug-108689-20130202031143.patch text/plain 2015 lushnikov U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTNmOGZkNDFkMWI3ZDdh ZWFmNDk4N2NlOGQ2NzExMjRhYWZlNzk1OS4uMTExYzczZDc2MDdlYzg2NzIwZDUxMmQ3OTQzYTNm OTdhOGVhYmYyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTAxICBBbmRy ZXkgTHVzaG5pa292ICA8bHVzaG5pa292QGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBmaXggIkRPTSBFeGNlcHRpb24gOCIgd2hlbiBkZWxldGluZyBsaW5lcyBjb250YWlu aW5nIGRlY29yYXRpb24gaW4gRFRFLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTA4Njg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWRkIGEgY2hlY2sgdGhhdCBkZWNvcmF0aW9uIGVsZW1lbnQgaXMgc3Rp bGwgYWRkZWQgdG8gdGhlIGxpbmUgYmVmb3JlIHRyeWluZyB0byBkZWxldGUgaXQuIFRoaXMKKyAg ICAgICAgd29uJ3QgYmUgdHJ1ZSBpZiB0aGUgd2hvbGUgbGluZSBpcyBkZWxldGVkIGluIGNvbnRl bnRFZGl0YWJsZSwKKyAgICAgICAgYW5kIHRoaXMgaXMgdGhlIHJlYXNvbiBmb3IgdGhlIGV4Y2Vw dGlvbiB0byBiZSB0aHJvd24uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICog aW5zcGVjdG9yL2Zyb250LWVuZC9EZWZhdWx0VGV4dEVkaXRvci5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5UZXh0RWRpdG9yTWFpbkNodW5rLnByb3RvdHlwZS5yZW1vdmVBbGxEZWNvcmF0aW9u cyk6CisKIDIwMTMtMDItMDEgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAg ICAgICAgUkVHUkVTU0lPTiAocjE0MTI4MSk6IE5hdmlnYXRpbmcgdG8gdGhpcyBIVFRQIExpdmUg U3RyZWFtaW5nIChhcHBsaWNhdGlvbi92bmQuYXBwbGUubXBlZ3VybCkgVVJMIGRvd25sb2FkcyBh IGZpbGUgaW5zdGVhZCBvZiBwbGF5aW5nIGl0IGluIHRoZSBicm93c2VyCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RlZmF1bHRUZXh0RWRpdG9yLmpzIGIv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EZWZhdWx0VGV4dEVkaXRvci5qcwpp bmRleCBlYmRmZDYzNWEyM2Q5OWIwMWVkYmNjZGIxNTdiN2MwZGQ2YzE1NzVkLi43MzU4MjFjYjA3 YTlkYmU0MGYyOTVkN2NkZWM4ZTc1NzdkZDFjOGY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RlZmF1bHRUZXh0RWRpdG9yLmpzCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGVmYXVsdFRleHRFZGl0b3IuanMKQEAgLTI5Mjgs NyArMjkyOCw4IEBAIFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yTWFpbkNodW5rLnByb3RvdHlwZSA9 IHsKICAgICAgICAgdGhpcy5fY2h1bmtlZFBhbmVsLmJlZ2luRG9tVXBkYXRlcygpOwogICAgICAg ICB0aGlzLmVsZW1lbnQuY2xhc3NOYW1lID0gIndlYmtpdC1saW5lLWNvbnRlbnQiOwogICAgICAg ICBpZiAodGhpcy5lbGVtZW50LmRlY29yYXRpb25zRWxlbWVudCkgewotICAgICAgICAgICAgdGhp cy5lbGVtZW50LnJlbW92ZUNoaWxkKHRoaXMuZWxlbWVudC5kZWNvcmF0aW9uc0VsZW1lbnQpOwor ICAgICAgICAgICAgaWYgKHRoaXMuZWxlbWVudC5kZWNvcmF0aW9uc0VsZW1lbnQucGFyZW50RWxl bWVudCkKKyAgICAgICAgICAgICAgICB0aGlzLmVsZW1lbnQucmVtb3ZlQ2hpbGQodGhpcy5lbGVt ZW50LmRlY29yYXRpb25zRWxlbWVudCk7CiAgICAgICAgICAgICBkZWxldGUgdGhpcy5lbGVtZW50 LmRlY29yYXRpb25zRWxlbWVudDsKICAgICAgICAgfQogICAgICAgICB0aGlzLl9jaHVua2VkUGFu ZWwuZW5kRG9tVXBkYXRlcygpOwo=