108684 2013-02-01 13:38:10 -0800 git.svn_revision doesn't fetch the same revision as svn.svn_revision 2013-02-07 14:05:44 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Critical --- 1 rniwa rniwa abarth dpranke eric mithro ojan webkit.review.bot oldest_to_newest 823213 0 rniwa 2013-02-01 13:38:10 -0800 We compute the revision against LayoutTests for layout and performance tests but git.svn_revision fetches the latest svn revision in LayoutTests, unlike svn.svn_revision that retrieves the latest svn revision in the entire repository. 823214 1 rniwa 2013-02-01 13:38:46 -0800 Unfortunately, I don't know git svn well enough to fix this bug. 823217 2 rniwa 2013-02-01 13:42:11 -0800 Maybe we need to ignore the path in git.svn_revision since you can't really have a partial git checkout like we can with svn. 823276 3 rniwa 2013-02-01 14:32:56 -0800 andersca suggests we can walk up the directories and look for .git but I wonder if there's a more efficient way of finding the root of a git module? 823544 4 eric 2013-02-01 21:22:31 -0800 I'm sure mithro can help us here once SYD is awake on monday (which is sunday for us). 827180 5 187023 rniwa 2013-02-07 01:34:00 -0800 Created attachment 187023 Fixes the bug 827410 6 187023 buildbot 2013-02-07 06:04:29 -0800 Comment on attachment 187023 Fixes the bug Attachment 187023 did not pass win-ews (win): Output: http://queues.webkit.org/results/16435129 827868 7 rniwa 2013-02-07 13:38:53 -0800 (In reply to comment #6) > (From update of attachment 187023 [details]) > Attachment 187023 [details] did not pass win-ews (win): > Output: http://queues.webkit.org/results/16435129 I've notified rfong about the mysterious wtf/Platform.h not found error. 827885 8 187023 webkit.review.bot 2013-02-07 14:05:39 -0800 Comment on attachment 187023 Fixes the bug Clearing flags on attachment: 187023 Committed r142178: <http://trac.webkit.org/changeset/142178> 827886 9 webkit.review.bot 2013-02-07 14:05:44 -0800 All reviewed patches have been landed. Closing bug. 187023 2013-02-07 01:34:00 -0800 2013-02-07 14:05:39 -0800 Fixes the bug bug-108684-20130207013036.patch text/plain 1365 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE0MjA4NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEzLTAyLTA3ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIGdpdC5zdm5fcmV2aXNpb24gZG9lc24ndCBmZXRjaCB0aGUgc2FtZSByZXZpc2lv biBhcyBzdm4uc3ZuX3JldmlzaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDg2ODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBbHdheXMgY2FsbCBnaXQgbG9nIG9uIHRoZSBjaGVja291dCByb290Lgor CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtL2dpdC5weToK KyAgICAgICAgKEdpdC5zdm5fcmV2aXNpb24pOgorCiAyMDEzLTAyLTA1ICBTaW1vbiBIYXVzbWFu biAgPHNpbW9uLmhhdXNtYW5uQGRpZ2lhLmNvbT4KIAogICAgICAgICBbUXRdIENvbXBpbGUgV1RG IHRlc3RzIG9mIFRlc3RXZWJLaXRBUEkKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29t bW9uL2NoZWNrb3V0L3NjbS9naXQucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vY2hlY2tvdXQvc2NtL2dpdC5weQkocmV2aXNpb24gMTQxNjE3KQorKysgVG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtL2dpdC5weQkod29ya2luZyBj b3B5KQpAQCAtMjQ3LDcgKzI0Nyw3IEBAIGNsYXNzIEdpdChTQ00sIFNWTlJlcG9zaXRvcnkpOgog CiAgICAgZGVmIHN2bl9yZXZpc2lvbihzZWxmLCBwYXRoKToKICAgICAgICAgX2xvZy5kZWJ1Zygn UnVubmluZyBnaXQuaGVhZF9zdm5fcmV2aXNpb24uLi4gKFRlbXBvcmFyeSBsb2dnaW5nIG1lc3Nh Z2UpJykKLSAgICAgICAgZ2l0X2xvZyA9IHNlbGYuX3J1bl9naXQoWydsb2cnLCAnLTI1JywgcGF0 aF0pCisgICAgICAgIGdpdF9sb2cgPSBzZWxmLl9ydW5fZ2l0KFsnbG9nJywgJy0yNScsIHNlbGYu ZmluZF9jaGVja291dF9yb290KHBhdGgpXSkKICAgICAgICAgbWF0Y2ggPSByZS5zZWFyY2goIl5c cypnaXQtc3ZuLWlkOi4qQCg/UDxzdm5fcmV2aXNpb24+XGQrKVwgIiwgZ2l0X2xvZywgcmUuTVVM VElMSU5FKQogICAgICAgICBpZiBub3QgbWF0Y2g6CiAgICAgICAgICAgICByZXR1cm4gIiIK