108654 2013-02-01 10:22:44 -0800 Remove unnecessary parameter from DocumentLoader::scheduleArchiveLoad 2013-02-01 10:32:50 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 beidson beidson oldest_to_newest 822918 0 beidson 2013-02-01 10:22:44 -0800 Remove unnecessary parameter from DocumentLoader::scheduleArchiveLoad This method takes both a ResourceRequest and a KURL and contains logic assuming the request URL might be different from the separate URL. In practice, they are always the same. It's also unclear why we might want them to be different. 822924 1 186076 beidson 2013-02-01 10:25:31 -0800 Created attachment 186076 Patch v1 822928 2 186076 ap 2013-02-01 10:27:27 -0800 Comment on attachment 186076 Patch v1 r=me assuming you grepped over other platforms code (this deals with MHTML and other types we don't enable on Mac). Removing code is the best kind of patch! 822929 3 beidson 2013-02-01 10:28:00 -0800 (In reply to comment #2) > (From update of attachment 186076 [details]) > r=me assuming you grepped over other platforms code (this deals with MHTML and other types we don't enable on Mac). > > Removing code is the best kind of patch! Grepped over the entire Source/ directory! 822938 4 beidson 2013-02-01 10:32:50 -0800 http://trac.webkit.org/changeset/141603 186076 2013-02-01 10:25:31 -0800 2013-02-01 10:27:27 -0800 Patch v1 patch text/plain 3283 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlZWNlMGMxLi43ZDNlMjQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTMtMDItMDEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIFJlbW92ZSB1bm5lY2Vzc2FyeSBwYXJhbWV0ZXIgZnJvbSBEb2N1bWVudExvYWRlcjo6c2No ZWR1bGVBcmNoaXZlTG9hZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTA4NjU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzIChObyBiZWhhdmlvciBjaGFuZ2UuKQorCisgICAgICAgIFJl bW92ZSB0aGUgS1VSTCBwYXJhbWV0ZXIgcGFyYW1ldGVyIGZyb20gdGhpcyBtZXRob2Qgd2hpY2gs IGluIHByYWN0aWNlLAorICAgICAgICBpcyBhbHdheXMgdGhlIHNhbWUgYXMgdGhlIHVybCBvZiB0 aGUgUmVzb3VyY2VSZXF1ZXN0IHBhcmFtZXRlci4KKworICAgICAgICAqIGxvYWRlci9Eb2N1bWVu dExvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6c2NoZWR1bGVB cmNoaXZlTG9hZCk6CisgICAgICAgICogbG9hZGVyL0RvY3VtZW50TG9hZGVyLmg6CisKKyAgICAg ICAgKiBsb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3Vy Y2VMb2FkZXI6OnN0YXJ0KToKKwogMjAxMy0wMS0zMSAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1Y4XSBTaW1wbGlmeSBDb2RlR2VuZXJhdG9yVjgucG0g YnkgdXNpbmcgSW5oZXJpdHNFeHRlbmRlZEF0dHJpYnV0ZSgiRXZlbnRUYXJnZXQiKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKaW5kZXggMGRiYTU5ZDMuLjdjYWM0MTMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcApAQCAtNjkwLDE0ICs2 OTAsMTIgQEAgdm9pZCBEb2N1bWVudExvYWRlcjo6Y2FuY2VsUGVuZGluZ1N1YnN0aXR1dGVMb2Fk KFJlc291cmNlTG9hZGVyKiBsb2FkZXIpCiB9CiAKICNpZiBFTkFCTEUoV0VCX0FSQ0hJVkUpIHx8 IEVOQUJMRShNSFRNTCkKLWJvb2wgRG9jdW1lbnRMb2FkZXI6OnNjaGVkdWxlQXJjaGl2ZUxvYWQo UmVzb3VyY2VMb2FkZXIqIGxvYWRlciwgY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBj b25zdCBLVVJMJiBvcmlnaW5hbFVSTCkKK2Jvb2wgRG9jdW1lbnRMb2FkZXI6OnNjaGVkdWxlQXJj aGl2ZUxvYWQoUmVzb3VyY2VMb2FkZXIqIGxvYWRlciwgY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiBy ZXF1ZXN0KQogewotICAgIGlmIChyZXF1ZXN0LnVybCgpID09IG9yaWdpbmFsVVJMKSB7Ci0gICAg ICAgIGlmIChBcmNoaXZlUmVzb3VyY2UqIHJlc291cmNlID0gYXJjaGl2ZVJlc291cmNlRm9yVVJM KG9yaWdpbmFsVVJMKSkgewotICAgICAgICAgICAgbV9wZW5kaW5nU3Vic3RpdHV0ZVJlc291cmNl cy5zZXQobG9hZGVyLCByZXNvdXJjZSk7Ci0gICAgICAgICAgICBkZWxpdmVyU3Vic3RpdHV0ZVJl c291cmNlc0FmdGVyRGVsYXkoKTsKLSAgICAgICAgICAgIHJldHVybiB0cnVlOwotICAgICAgICB9 CisgICAgaWYgKEFyY2hpdmVSZXNvdXJjZSogcmVzb3VyY2UgPSBhcmNoaXZlUmVzb3VyY2VGb3JV UkwocmVxdWVzdC51cmwoKSkpIHsKKyAgICAgICAgbV9wZW5kaW5nU3Vic3RpdHV0ZVJlc291cmNl cy5zZXQobG9hZGVyLCByZXNvdXJjZSk7CisgICAgICAgIGRlbGl2ZXJTdWJzdGl0dXRlUmVzb3Vy Y2VzQWZ0ZXJEZWxheSgpOworICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKICAgICBpZiAo IW1fYXJjaGl2ZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExv YWRlci5oIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmgKaW5kZXggN2Vm MDQ3Ny4uOGI4NDNlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50 TG9hZGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmgKQEAg LTE0Miw3ICsxNDIsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIFBhc3NSZWZQdHI8 QXJjaGl2ZT4gcG9wQXJjaGl2ZUZvclN1YmZyYW1lKGNvbnN0IFN0cmluZyYgZnJhbWVOYW1lLCBj b25zdCBLVVJMJik7CiAgICAgICAgIFNoYXJlZEJ1ZmZlciogcGFyc2VkQXJjaGl2ZURhdGEoKSBj b25zdDsKIAotICAgICAgICBib29sIHNjaGVkdWxlQXJjaGl2ZUxvYWQoUmVzb3VyY2VMb2FkZXIq LCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmLCBjb25zdCBLVVJMJik7CisgICAgICAgIGJvb2wgc2No ZWR1bGVBcmNoaXZlTG9hZChSZXNvdXJjZUxvYWRlciosIGNvbnN0IFJlc291cmNlUmVxdWVzdCYp OwogI2VuZGlmIC8vIEVOQUJMRShXRUJfQVJDSElWRSkgfHwgRU5BQkxFKE1IVE1MKQogCiAgICAg ICAgIC8vIFJldHVybiB0aGUgQXJjaGl2ZVJlc291cmNlIGZvciB0aGUgVVJMIG9ubHkgd2hlbiBs b2FkaW5nIGFuIEFyY2hpdmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNv dXJjZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3Bw CmluZGV4IDk4ZWNlZjAuLmFkYzY5ZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9SZXNvdXJjZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNl TG9hZGVyLmNwcApAQCAtMTU1LDcgKzE1NSw3IEBAIHZvaWQgUmVzb3VyY2VMb2FkZXI6OnN0YXJ0 KCkKICAgICBBU1NFUlQobV9kZWZlcnJlZFJlcXVlc3QuaXNOdWxsKCkpOwogCiAjaWYgRU5BQkxF KFdFQl9BUkNISVZFKSB8fCBFTkFCTEUoTUhUTUwpCi0gICAgaWYgKG1fZG9jdW1lbnRMb2FkZXIt PnNjaGVkdWxlQXJjaGl2ZUxvYWQodGhpcywgbV9yZXF1ZXN0LCBtX3JlcXVlc3QudXJsKCkpKQor ICAgIGlmIChtX2RvY3VtZW50TG9hZGVyLT5zY2hlZHVsZUFyY2hpdmVMb2FkKHRoaXMsIG1fcmVx dWVzdCkpCiAgICAgICAgIHJldHVybjsKICNlbmRpZgogCg==