<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>108633</bug_id>
          
          <creation_ts>2013-02-01 06:57:42 -0800</creation_ts>
          <short_desc>No caret on empty contenteditable element with negative text-indent</short_desc>
          <delta_ts>2013-09-11 13:05:40 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://jsbin.com/etatey/1/quiet</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>HasReduction, InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jake Archibald">jaffathecake</reporter>
          <assigned_to name="Robert Hogan">robert</assigned_to>
          <cc>ap</cc>
    
    <cc>bdakin</cc>
    
    <cc>eric</cc>
    
    <cc>leviw</cc>
    
    <cc>ojan.autocc</cc>
    
    <cc>rniwa</cc>
    
    <cc>robert</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>tkent</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>822728</commentid>
    <comment_count>0</comment_count>
    <who name="Jake Archibald">jaffathecake</who>
    <bug_when>2013-02-01 06:57:42 -0800</bug_when>
    <thetext>Click on the green box, the caret may flash once in the correct place, but doesn&apos;t appear after that.

Once you start typing, the text appears, as does the caret.

Firefox &amp; Opera show a caret, although in the wrong place.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>822952</commentid>
    <comment_count>1</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2013-02-01 10:47:19 -0800</bug_when>
    <thetext>See also: bug 20242, bug 58975, bug 108053. We probably have a few duplicates between these, and other bugs that I didn&apos;t find now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>822959</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2013-02-01 10:51:41 -0800</bug_when>
    <thetext>&lt;rdar://problem/13134969&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>835745</commentid>
    <comment_count>3</comment_count>
      <attachid>188942</attachid>
    <who name="Robert Hogan">robert</who>
    <bug_when>2013-02-18 14:16:15 -0800</bug_when>
    <thetext>Created attachment 188942
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>835747</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-02-18 14:19:02 -0800</bug_when>
    <thetext>Attachment 188942 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;LayoutTests/ChangeLog&apos;, u&apos;LayoutTests/fast/repaint/paint-caret-in-div-with-negative-indent-expected.png&apos;, u&apos;LayoutTests/fast/repaint/paint-caret-in-div-with-negative-indent-expected.txt&apos;, u&apos;LayoutTests/fast/repaint/paint-caret-in-div-with-negative-indent.html&apos;, u&apos;Source/WebCore/ChangeLog&apos;, u&apos;Source/WebCore/rendering/RenderBlock.cpp&apos;]&quot; exit_code: 1
LayoutTests/fast/repaint/paint-caret-in-div-with-negative-indent-expected.png:0:  Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config &quot;enable-auto-props = yes&quot;). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config &quot;*.png = svn:mime-type=image/png&quot;).  [image/png] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>835769</commentid>
    <comment_count>5</comment_count>
      <attachid>188942</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2013-02-18 14:57:57 -0800</bug_when>
    <thetext>Comment on attachment 188942
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188942&amp;action=review

&gt; Source/WebCore/rendering/RenderBlock.cpp:1685
&gt; +    bool caretBrowsing = frame()-&gt;settings() &amp;&amp; frame()-&gt;settings()-&gt;caretBrowsingEnabled();
&gt; +    if (textIndentOffset() &lt; 0 &amp;&amp; (caretBrowsing || (node() &amp;&amp; node()-&gt;rendererIsEditable()))) {

Why do we want to check node()-&gt;rendererIsEditable() when caret browsing is disabled? rendererIsEditable() is a very expensive function, I&apos;d rather not call it here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>836589</commentid>
    <comment_count>6</comment_count>
    <who name="Robert Hogan">robert</who>
    <bug_when>2013-02-19 11:26:07 -0800</bug_when>
    <thetext>(In reply to comment #5)
&gt; (From update of attachment 188942 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=188942&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/rendering/RenderBlock.cpp:1685
&gt; &gt; +    bool caretBrowsing = frame()-&gt;settings() &amp;&amp; frame()-&gt;settings()-&gt;caretBrowsingEnabled();
&gt; &gt; +    if (textIndentOffset() &lt; 0 &amp;&amp; (caretBrowsing || (node() &amp;&amp; node()-&gt;rendererIsEditable()))) {
&gt; 
&gt; Why do we want to check node()-&gt;rendererIsEditable() when caret browsing is disabled? rendererIsEditable() is a very expensive function, I&apos;d rather not call it here.

rendererIsEditable() only gets expensive if you need to climb the tree looking for a HTML element. I don&apos;t think that will happen very often here, especially where a negative text indent has been defined. Does that sound reasonable?

It might be cheaper overall to just add the overflow for any element that has the text indent rather than ones that will want to display a caret at some point. But I don&apos;t think rendererIsEditable() ever gets expensive here.

I need to remove the multiple calls to textIndentOffset().</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>836609</commentid>
    <comment_count>7</comment_count>
      <attachid>189126</attachid>
    <who name="Robert Hogan">robert</who>
    <bug_when>2013-02-19 11:47:23 -0800</bug_when>
    <thetext>Created attachment 189126
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>836616</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-02-19 11:51:01 -0800</bug_when>
    <thetext>Attachment 189126 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;LayoutTests/ChangeLog&apos;, u&apos;LayoutTests/fast/repaint/paint-caret-in-div-with-negative-indent-expected.png&apos;, u&apos;LayoutTests/fast/repaint/paint-caret-in-div-with-negative-indent-expected.txt&apos;, u&apos;LayoutTests/fast/repaint/paint-caret-in-div-with-negative-indent.html&apos;, u&apos;Source/WebCore/ChangeLog&apos;, u&apos;Source/WebCore/rendering/RenderBlock.cpp&apos;]&quot; exit_code: 1
LayoutTests/fast/repaint/paint-caret-in-div-with-negative-indent-expected.png:0:  Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config &quot;enable-auto-props = yes&quot;). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config &quot;*.png = svn:mime-type=image/png&quot;).  [image/png] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>837620</commentid>
    <comment_count>9</comment_count>
      <attachid>189126</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-02-20 11:52:45 -0800</bug_when>
    <thetext>Comment on attachment 189126
Patch

Clearing flags on attachment: 189126

Committed r143483: &lt;http://trac.webkit.org/changeset/143483&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>837621</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-02-20 11:52:49 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>927608</commentid>
    <comment_count>11</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2013-09-10 17:58:00 -0700</bug_when>
    <thetext>This caused a bad repaint regression, when authors combine negative text-indent with overflow:hidden (which is what we recommend they do): bug 121137.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>927941</commentid>
    <comment_count>12</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2013-09-11 13:05:40 -0700</bug_when>
    <thetext>This bug still appears fixed after rollout (maybe &lt;http://trac.webkit.org/changeset/143313&gt; also took care of the same?)

Please comment and possibly open a new bug if the next nightly doesn&apos;t quite work for you in this regard.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>188942</attachid>
            <date>2013-02-18 14:16:15 -0800</date>
            <delta_ts>2013-02-19 11:47:18 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-108633-20130218221231.patch</filename>
            <type>text/plain</type>
            <size>5758</size>
            <attacher name="Robert Hogan">robert</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWJiNTAwZGRiNTZmMjhi
MWQzNjhiYjRjMGJkOWI0OWI4MTM5MmMzNS4uMGE2YTUwZDQ3YzE4YWEwMmEwY2I5M2YzYjFkM2E3
ZDA0NjFjY2Y2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTE4ICBSb2Jl
cnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KKworICAgICAgICBObyBjYXJldCBvbiBlbXB0
eSBjb250ZW50ZWRpdGFibGUgZWxlbWVudCB3aXRoIG5lZ2F0aXZlIHRleHQtaW5kZW50CisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg2MzMKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBmYXN0L3Jl
cGFpbnQvcGFpbnQtY2FyZXQtaW4tZGl2LXdpdGgtbmVnYXRpdmUtaW5kZW50Lmh0bWwKKworICAg
ICAgICBXaGVuIGFuIGVkaXRhYmxlIGVsZW1lbnQgaGFzIGEgbmVnYXRpdmUgdGV4dCBpbmRlbnQg
d2Ugd29uJ3QgcGFpbnQgdGhlIGNhcmV0IHdoZW4gdGhlCisgICAgICAgIGVsZW1lbnQgaXMgZW1w
dHkgYmVjYXVzZSBpdCBmYWxscyBvdXRzaWRlIHRoZSBlbGVtZW50J3MgYm9yZGVyIGJveC4gVG8g
ZW5zdXJlIHRoZSBjYXJldCBpcyBwYWludGVkLAorICAgICAgICBhY2NvdW50IGZvciBhbnkgbmVn
YXRpdmUgaW5kZW50IHdpdGggb3VyIG92ZXJmbG93LgorCisgICAgICAgICogcmVuZGVyaW5nL1Jl
bmRlckJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpjb21wdXRlT3Zl
cmZsb3cpOgorCiAyMDEzLTAyLTE2ICBSb2JlcnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4K
IAogICAgICAgICBpbnB1dCBlbGVtZW50IHdpdGggcGxhY2Vob2xkZXIgdGV4dCBhbmQgd2lkdGgg
c2V0IHRvIDEwMCUgb24gZm9jdXMgY2F1c2VzIG92ZXJmbG93IGV2ZW4gYWZ0ZXIgbG9zaW5nIGZv
Y3VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3Bw
IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAppbmRleCBhYzk2MmUx
YzMxZjUzYjQ0ZWJmMGMxNTAzMGJlMjg4NjNkNjc4YjkyLi5lMmRjYWMwZTJmNjQ5OTI3YzdhZDQz
MzU4OGVlMjRlNTQ3NjA5ZGNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv
UmVuZGVyQmxvY2suY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9j
ay5jcHAKQEAgLTE2ODAsNiArMTY4MCwxNCBAQCB2b2lkIFJlbmRlckJsb2NrOjpjb21wdXRlT3Zl
cmZsb3coTGF5b3V0VW5pdCBvbGRDbGllbnRBZnRlckVkZ2UsIGJvb2wgcmVjb21wdXRlRgogICAg
ICAgICAgICAgbV9vdmVyZmxvdy0+c2V0TGF5b3V0Q2xpZW50QWZ0ZXJFZGdlKG9sZENsaWVudEFm
dGVyRWRnZSk7CiAgICAgfQogICAgICAgICAKKyAgICAvLyBBbGxvdyBvdXIgb3ZlcmZsb3cgdG8g
Y2F0Y2ggY2FzZXMgd2hlcmUgdGhlIGNhcmV0IGluIGFuIGVtcHR5IGVkaXRhYmxlIGVsZW1lbnQg
d2l0aCBuZWdhdGl2ZSB0ZXh0IGluZGVudCBuZWVkcyB0byBnZXQgcGFpbnRlZC4KKyAgICBib29s
IGNhcmV0QnJvd3NpbmcgPSBmcmFtZSgpLT5zZXR0aW5ncygpICYmIGZyYW1lKCktPnNldHRpbmdz
KCktPmNhcmV0QnJvd3NpbmdFbmFibGVkKCk7CisgICAgaWYgKHRleHRJbmRlbnRPZmZzZXQoKSA8
IDAgJiYgKGNhcmV0QnJvd3NpbmcgfHwgKG5vZGUoKSAmJiBub2RlKCktPnJlbmRlcmVySXNFZGl0
YWJsZSgpKSkpIHsKKyAgICAgICAgTGF5b3V0UmVjdCBjbGllbnRSZWN0KGNsaWVudEJveFJlY3Qo
KSk7CisgICAgICAgIExheW91dFJlY3QgcmVjdFRvQXBwbHkgPSBMYXlvdXRSZWN0KGNsaWVudFJl
Y3QueCgpICsgbWluPExheW91dFVuaXQ+KDAsIHRleHRJbmRlbnRPZmZzZXQoKSksIGNsaWVudFJl
Y3QueSgpLCBjbGllbnRSZWN0LndpZHRoKCkgLSBtaW48TGF5b3V0VW5pdD4oMCwgdGV4dEluZGVu
dE9mZnNldCgpKSwgY2xpZW50UmVjdC5oZWlnaHQoKSk7CisgICAgICAgIGFkZFZpc3VhbE92ZXJm
bG93KHJlY3RUb0FwcGx5KTsKKyAgICB9CisKICAgICAvLyBBZGQgdmlzdWFsIG92ZXJmbG93IGZy
b20gYm94LXNoYWRvdyBhbmQgYm9yZGVyLWltYWdlLW91dHNldC4KICAgICBhZGRWaXN1YWxFZmZl
Y3RPdmVyZmxvdygpOwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlv
dXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggY2Y0Y2Q0MDFkY2JiMGNhMDkxMzg3NDk1ZjliZjFmMGRm
MmY2YzM2Yi4uODBjM2FhNTM1ZWIxOTc0YTc3MjgzMTE5YmE0YzU3MDFjOThiYTQ5ZiAxMDA2NDQK
LS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpA
QCAtMSwzICsxLDE0IEBACisyMDEzLTAyLTE4ICBSb2JlcnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0
Lm9yZz4KKworICAgICAgICBObyBjYXJldCBvbiBlbXB0eSBjb250ZW50ZWRpdGFibGUgZWxlbWVu
dCB3aXRoIG5lZ2F0aXZlIHRleHQtaW5kZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg2MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvcmVwYWludC9wYWludC1jYXJldC1pbi1kaXYtd2l0
aC1uZWdhdGl2ZS1pbmRlbnQtZXhwZWN0ZWQucG5nOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3Jl
cGFpbnQvcGFpbnQtY2FyZXQtaW4tZGl2LXdpdGgtbmVnYXRpdmUtaW5kZW50LWV4cGVjdGVkLnR4
dDogQWRkZWQuCisgICAgICAgICogZmFzdC9yZXBhaW50L3BhaW50LWNhcmV0LWluLWRpdi13aXRo
LW5lZ2F0aXZlLWluZGVudC5odG1sOiBBZGRlZC4KKwogMjAxMy0wMi0xNiAgUm9iZXJ0IEhvZ2Fu
ICA8cm9iZXJ0QHdlYmtpdC5vcmc+CiAKICAgICAgICAgaW5wdXQgZWxlbWVudCB3aXRoIHBsYWNl
aG9sZGVyIHRleHQgYW5kIHdpZHRoIHNldCB0byAxMDAlIG9uIGZvY3VzIGNhdXNlcyBvdmVyZmxv
dyBldmVuIGFmdGVyIGxvc2luZyBmb2N1cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9y
ZXBhaW50L3BhaW50LWNhcmV0LWluLWRpdi13aXRoLW5lZ2F0aXZlLWluZGVudC1leHBlY3RlZC5w
bmcgYi9MYXlvdXRUZXN0cy9mYXN0L3JlcGFpbnQvcGFpbnQtY2FyZXQtaW4tZGl2LXdpdGgtbmVn
YXRpdmUtaW5kZW50LWV4cGVjdGVkLnBuZwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41MzVkM2EzMzIyMjUyMTE1Nzhk
Yjc0MzAwMWJjYWE4NDA0Y2Q5Njg0CkdJVCBiaW5hcnkgcGF0Y2gKbGl0ZXJhbCAzMDE5CnpjbWVB
U0BOPyhvbEh5YHVWQnEhaWEweX55VXsrdllWMmE+aTAqWik9aF5obEElQFdzJGxIYG9rPG19P29U
bjZLYAp6UkFifUI2alE/XzN6SzlFbE8hV0VsY1hkdyEkZjBDNkM9eCVxQD1YdmJKLVhleE1Nd0M5
NzhKUnl1RyMyY1hweWsKelRjR3UhVSkqTEojMS1kZXpJWlg9ajctaH1oTVVid3YxfVc+I1NUZ0Aq
YFZSYFJfSWZRey0qT1lBTHo9Ki11Oz1qCnpjX3QmbmdgYjkxMz05VyQzUHZ6NjcmZnZwMm5kZmRN
Z3c2cUNEMC1sWStRWWp4IzluPCkyQzByO0ViN2J7UF4qVQp6IVZsdGlDTk1HX1ZHKDArQEJ1T1lC
cndLSUlER3J2aFdvdjdnLUtFQ21TMyY8IXF2ZzReRmE5Nz1icy1kV2NEYGMKelRrVSFLQDZXIzRU
S1Q8P3ViaDRLXkl6aVhqVFhqQyt6KjBlelV7dkx7cFJ9cGlfN08hP1Y1TUBFdndrYFdCZjNLCno7
V20pWmMkNCpvZm5uZHRFaXcwWD1GTU57e0AmdGl2RWw0IytaVHN9b0liejZNJFg7OyFSdXZMZkJq
M1ctaFJKTgp6dHwlJCRwNU4tUEZHTjhfaWctJVkrTihTQCU9WENQeClFM2VOJHpFMmMoNyYlTis2
SyRMfnQwNllEWjJ7cW9GWXgKcDhqIU1PRyRvOXRnd2QyaFklWH1pZTRKZWA8P1pYbld4Jj1zZ1F1
JlglUX5sb0NJRUpRZDdBKEwKCmxpdGVyYWwgMApIY21WP2QwMDAwMQoKZGlmZiAtLWdpdCBhL0xh
eW91dFRlc3RzL2Zhc3QvcmVwYWludC9wYWludC1jYXJldC1pbi1kaXYtd2l0aC1uZWdhdGl2ZS1p
bmRlbnQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9yZXBhaW50L3BhaW50LWNhcmV0
LWluLWRpdi13aXRoLW5lZ2F0aXZlLWluZGVudC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAx
MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMGRl
MjRlNjI1Mzg3Nzg4NDU3NjlhMWRjNGU0YTMzZmY4Yzg5YTU1OAotLS0gL2Rldi9udWxsCisrKyBi
L0xheW91dFRlc3RzL2Zhc3QvcmVwYWludC9wYWludC1jYXJldC1pbi1kaXYtd2l0aC1uZWdhdGl2
ZS1pbmRlbnQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNyBAQAorbGF5ZXIgYXQgKDAsMCkgc2l6
ZSA4MDB4NjAwCisgIFJlbmRlclZpZXcgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCitsYXllciBhdCAo
MCwwKSBzaXplIDgwMHgyMjgKKyAgUmVuZGVyQmxvY2sge0hUTUx9IGF0ICgwLDApIHNpemUgODAw
eDIyOAorICAgIFJlbmRlckJvZHkge0JPRFl9IGF0ICg4LDIwMCkgc2l6ZSA3ODR4MjAKKyAgICAg
IFJlbmRlckJsb2NrIHtESVZ9IGF0ICg1MDAsMCkgc2l6ZSA1MHgyMCBbYmdjb2xvcj0jMDA4MDAw
XQorY2FyZXQ6IHBvc2l0aW9uIDAgb2YgY2hpbGQgMSB7RElWfSBvZiBib2R5CmRpZmYgLS1naXQg
YS9MYXlvdXRUZXN0cy9mYXN0L3JlcGFpbnQvcGFpbnQtY2FyZXQtaW4tZGl2LXdpdGgtbmVnYXRp
dmUtaW5kZW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3JlcGFpbnQvcGFpbnQtY2FyZXQtaW4t
ZGl2LXdpdGgtbmVnYXRpdmUtaW5kZW50Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uODVjZDg1YzIxMTYxYTc2
NjE0OTUwMjc2M2ZhMTBiZWFiZTFiMTY4MAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz
L2Zhc3QvcmVwYWludC9wYWludC1jYXJldC1pbi1kaXYtd2l0aC1uZWdhdGl2ZS1pbmRlbnQuaHRt
bApAQCAtMCwwICsxLDI1IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorICA8aGVhZD4KKyAg
ICA8c3R5bGU+CisgICAgICAjZWRpdGFibGUgeworICAgICAgICBmb250OiAyMHB4LzEgQWhlbTsK
KyAgICAgICAgd2lkdGg6IDUwcHg7CisgICAgICAgIGhlaWdodDogMWVtOworICAgICAgICBtYXJn
aW4tbGVmdDogNTAwcHg7CisgICAgICAgIG1hcmdpbi10b3A6IDIwMHB4OworICAgICAgICBiYWNr
Z3JvdW5kOiBncmVlbjsKKyAgICAgICAgdGV4dC1pbmRlbnQ6IC0xNTBweDsKKyAgICAgIH0KKyAg
ICA8L3N0eWxlPgorICAgIDxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvcmVwYWludC5qcyIgdHlwZT0i
dGV4dC9qYXZhc2NyaXB0Ij48L3NjcmlwdD4KKyAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNj
cmlwdCI+CisgICAgZnVuY3Rpb24gcmVwYWludFRlc3QoKSB7CisgICAgICAgIGRvY3VtZW50Lmdl
dEVsZW1lbnRCeUlkKCdlZGl0YWJsZScpLmZvY3VzKCk7CisgICAgfQorICAgIDwvc2NyaXB0Pgor
PC9oZWFkPgorPGJvZHkgb25sb2FkPSJydW5SZXBhaW50VGVzdCgpOyI+CisgICAgPGRpdiBpZD0i
ZWRpdGFibGUiIGNvbnRlbnRlZGl0YWJsZT0idHJ1ZSI+PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+
Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>189126</attachid>
            <date>2013-02-19 11:47:23 -0800</date>
            <delta_ts>2013-02-20 11:52:45 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-108633-20130219194338.patch</filename>
            <type>text/plain</type>
            <size>5626</size>
            <attacher name="Robert Hogan">robert</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWJiNTAwZGRiNTZmMjhi
MWQzNjhiYjRjMGJkOWI0OWI4MTM5MmMzNS4uMGE2YTUwZDQ3YzE4YWEwMmEwY2I5M2YzYjFkM2E3
ZDA0NjFjY2Y2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTE4ICBSb2Jl
cnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KKworICAgICAgICBObyBjYXJldCBvbiBlbXB0
eSBjb250ZW50ZWRpdGFibGUgZWxlbWVudCB3aXRoIG5lZ2F0aXZlIHRleHQtaW5kZW50CisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg2MzMKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBmYXN0L3Jl
cGFpbnQvcGFpbnQtY2FyZXQtaW4tZGl2LXdpdGgtbmVnYXRpdmUtaW5kZW50Lmh0bWwKKworICAg
ICAgICBXaGVuIGFuIGVkaXRhYmxlIGVsZW1lbnQgaGFzIGEgbmVnYXRpdmUgdGV4dCBpbmRlbnQg
d2Ugd29uJ3QgcGFpbnQgdGhlIGNhcmV0IHdoZW4gdGhlCisgICAgICAgIGVsZW1lbnQgaXMgZW1w
dHkgYmVjYXVzZSBpdCBmYWxscyBvdXRzaWRlIHRoZSBlbGVtZW50J3MgYm9yZGVyIGJveC4gVG8g
ZW5zdXJlIHRoZSBjYXJldCBpcyBwYWludGVkLAorICAgICAgICBhY2NvdW50IGZvciBhbnkgbmVn
YXRpdmUgaW5kZW50IHdpdGggb3VyIG92ZXJmbG93LgorCisgICAgICAgICogcmVuZGVyaW5nL1Jl
bmRlckJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpjb21wdXRlT3Zl
cmZsb3cpOgorCiAyMDEzLTAyLTE2ICBSb2JlcnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4K
IAogICAgICAgICBpbnB1dCBlbGVtZW50IHdpdGggcGxhY2Vob2xkZXIgdGV4dCBhbmQgd2lkdGgg
c2V0IHRvIDEwMCUgb24gZm9jdXMgY2F1c2VzIG92ZXJmbG93IGV2ZW4gYWZ0ZXIgbG9zaW5nIGZv
Y3VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3Bw
IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAppbmRleCBhYzk2MmUx
YzMxZjUzYjQ0ZWJmMGMxNTAzMGJlMjg4NjNkNjc4YjkyLi40Y2U3Y2NlMDk2YTMyNjlmZWFmYjcx
N2RlZmEzY2FiYTkxZmNhODRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv
UmVuZGVyQmxvY2suY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9j
ay5jcHAKQEAgLTE2ODAsNiArMTY4MCwxNCBAQCB2b2lkIFJlbmRlckJsb2NrOjpjb21wdXRlT3Zl
cmZsb3coTGF5b3V0VW5pdCBvbGRDbGllbnRBZnRlckVkZ2UsIGJvb2wgcmVjb21wdXRlRgogICAg
ICAgICAgICAgbV9vdmVyZmxvdy0+c2V0TGF5b3V0Q2xpZW50QWZ0ZXJFZGdlKG9sZENsaWVudEFm
dGVyRWRnZSk7CiAgICAgfQogICAgICAgICAKKyAgICAvLyBBbGxvdyBvdXIgb3ZlcmZsb3cgdG8g
Y2F0Y2ggY2FzZXMgd2hlcmUgdGhlIGNhcmV0IGluIGFuIGVtcHR5IGVkaXRhYmxlIGVsZW1lbnQg
d2l0aCBuZWdhdGl2ZSB0ZXh0IGluZGVudCBuZWVkcyB0byBnZXQgcGFpbnRlZC4KKyAgICBMYXlv
dXRVbml0IHRleHRJbmRlbnQgPSB0ZXh0SW5kZW50T2Zmc2V0KCk7CisgICAgaWYgKHRleHRJbmRl
bnQgPCAwKSB7CisgICAgICAgIExheW91dFJlY3QgY2xpZW50UmVjdChjbGllbnRCb3hSZWN0KCkp
OworICAgICAgICBMYXlvdXRSZWN0IHJlY3RUb0FwcGx5ID0gTGF5b3V0UmVjdChjbGllbnRSZWN0
LngoKSArIG1pbjxMYXlvdXRVbml0PigwLCB0ZXh0SW5kZW50KSwgY2xpZW50UmVjdC55KCksIGNs
aWVudFJlY3Qud2lkdGgoKSAtIG1pbjxMYXlvdXRVbml0PigwLCB0ZXh0SW5kZW50KSwgY2xpZW50
UmVjdC5oZWlnaHQoKSk7CisgICAgICAgIGFkZFZpc3VhbE92ZXJmbG93KHJlY3RUb0FwcGx5KTsK
KyAgICB9CisKICAgICAvLyBBZGQgdmlzdWFsIG92ZXJmbG93IGZyb20gYm94LXNoYWRvdyBhbmQg
Ym9yZGVyLWltYWdlLW91dHNldC4KICAgICBhZGRWaXN1YWxFZmZlY3RPdmVyZmxvdygpOwogCmRp
ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK
aW5kZXggY2Y0Y2Q0MDFkY2JiMGNhMDkxMzg3NDk1ZjliZjFmMGRmMmY2YzM2Yi4uODBjM2FhNTM1
ZWIxOTc0YTc3MjgzMTE5YmE0YzU3MDFjOThiYTQ5ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv
Q2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisy
MDEzLTAyLTE4ICBSb2JlcnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KKworICAgICAgICBO
byBjYXJldCBvbiBlbXB0eSBjb250ZW50ZWRpdGFibGUgZWxlbWVudCB3aXRoIG5lZ2F0aXZlIHRl
eHQtaW5kZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0xMDg2MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICAqIGZhc3QvcmVwYWludC9wYWludC1jYXJldC1pbi1kaXYtd2l0aC1uZWdhdGl2ZS1pbmRlbnQt
ZXhwZWN0ZWQucG5nOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3JlcGFpbnQvcGFpbnQtY2FyZXQt
aW4tZGl2LXdpdGgtbmVnYXRpdmUtaW5kZW50LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAg
ICogZmFzdC9yZXBhaW50L3BhaW50LWNhcmV0LWluLWRpdi13aXRoLW5lZ2F0aXZlLWluZGVudC5o
dG1sOiBBZGRlZC4KKwogMjAxMy0wMi0xNiAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5v
cmc+CiAKICAgICAgICAgaW5wdXQgZWxlbWVudCB3aXRoIHBsYWNlaG9sZGVyIHRleHQgYW5kIHdp
ZHRoIHNldCB0byAxMDAlIG9uIGZvY3VzIGNhdXNlcyBvdmVyZmxvdyBldmVuIGFmdGVyIGxvc2lu
ZyBmb2N1cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9yZXBhaW50L3BhaW50LWNhcmV0
LWluLWRpdi13aXRoLW5lZ2F0aXZlLWluZGVudC1leHBlY3RlZC5wbmcgYi9MYXlvdXRUZXN0cy9m
YXN0L3JlcGFpbnQvcGFpbnQtY2FyZXQtaW4tZGl2LXdpdGgtbmVnYXRpdmUtaW5kZW50LWV4cGVj
dGVkLnBuZwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwLi41MzVkM2EzMzIyMjUyMTE1NzhkYjc0MzAwMWJjYWE4NDA0Y2Q5
Njg0CkdJVCBiaW5hcnkgcGF0Y2gKbGl0ZXJhbCAzMDE5CnpjbWVBU0BOPyhvbEh5YHVWQnEhaWEw
eX55VXsrdllWMmE+aTAqWik9aF5obEElQFdzJGxIYG9rPG19P29UbjZLYAp6UkFifUI2alE/XzN6
SzlFbE8hV0VsY1hkdyEkZjBDNkM9eCVxQD1YdmJKLVhleE1Nd0M5NzhKUnl1RyMyY1hweWsKelRj
R3UhVSkqTEojMS1kZXpJWlg9ajctaH1oTVVid3YxfVc+I1NUZ0AqYFZSYFJfSWZRey0qT1lBTHo9
Ki11Oz1qCnpjX3QmbmdgYjkxMz05VyQzUHZ6NjcmZnZwMm5kZmRNZ3c2cUNEMC1sWStRWWp4Izlu
PCkyQzByO0ViN2J7UF4qVQp6IVZsdGlDTk1HX1ZHKDArQEJ1T1lCcndLSUlER3J2aFdvdjdnLUtF
Q21TMyY8IXF2ZzReRmE5Nz1icy1kV2NEYGMKelRrVSFLQDZXIzRUS1Q8P3ViaDRLXkl6aVhqVFhq
Qyt6KjBlelV7dkx7cFJ9cGlfN08hP1Y1TUBFdndrYFdCZjNLCno7V20pWmMkNCpvZm5uZHRFaXcw
WD1GTU57e0AmdGl2RWw0IytaVHN9b0liejZNJFg7OyFSdXZMZkJqM1ctaFJKTgp6dHwlJCRwNU4t
UEZHTjhfaWctJVkrTihTQCU9WENQeClFM2VOJHpFMmMoNyYlTis2SyRMfnQwNllEWjJ7cW9GWXgK
cDhqIU1PRyRvOXRnd2QyaFklWH1pZTRKZWA8P1pYbld4Jj1zZ1F1JlglUX5sb0NJRUpRZDdBKEwK
CmxpdGVyYWwgMApIY21WP2QwMDAwMQoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcmVw
YWludC9wYWludC1jYXJldC1pbi1kaXYtd2l0aC1uZWdhdGl2ZS1pbmRlbnQtZXhwZWN0ZWQudHh0
IGIvTGF5b3V0VGVzdHMvZmFzdC9yZXBhaW50L3BhaW50LWNhcmV0LWluLWRpdi13aXRoLW5lZ2F0
aXZlLWluZGVudC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMGRlMjRlNjI1Mzg3Nzg4NDU3Njlh
MWRjNGU0YTMzZmY4Yzg5YTU1OAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv
cmVwYWludC9wYWludC1jYXJldC1pbi1kaXYtd2l0aC1uZWdhdGl2ZS1pbmRlbnQtZXhwZWN0ZWQu
dHh0CkBAIC0wLDAgKzEsNyBAQAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRl
clZpZXcgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCitsYXllciBhdCAoMCwwKSBzaXplIDgwMHgyMjgK
KyAgUmVuZGVyQmxvY2sge0hUTUx9IGF0ICgwLDApIHNpemUgODAweDIyOAorICAgIFJlbmRlckJv
ZHkge0JPRFl9IGF0ICg4LDIwMCkgc2l6ZSA3ODR4MjAKKyAgICAgIFJlbmRlckJsb2NrIHtESVZ9
IGF0ICg1MDAsMCkgc2l6ZSA1MHgyMCBbYmdjb2xvcj0jMDA4MDAwXQorY2FyZXQ6IHBvc2l0aW9u
IDAgb2YgY2hpbGQgMSB7RElWfSBvZiBib2R5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0
L3JlcGFpbnQvcGFpbnQtY2FyZXQtaW4tZGl2LXdpdGgtbmVnYXRpdmUtaW5kZW50Lmh0bWwgYi9M
YXlvdXRUZXN0cy9mYXN0L3JlcGFpbnQvcGFpbnQtY2FyZXQtaW4tZGl2LXdpdGgtbmVnYXRpdmUt
aW5kZW50Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uODVjZDg1YzIxMTYxYTc2NjE0OTUwMjc2M2ZhMTBiZWFi
ZTFiMTY4MAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVwYWludC9wYWlu
dC1jYXJldC1pbi1kaXYtd2l0aC1uZWdhdGl2ZS1pbmRlbnQuaHRtbApAQCAtMCwwICsxLDI1IEBA
Cis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorICA8aGVhZD4KKyAgICA8c3R5bGU+CisgICAgICAj
ZWRpdGFibGUgeworICAgICAgICBmb250OiAyMHB4LzEgQWhlbTsKKyAgICAgICAgd2lkdGg6IDUw
cHg7CisgICAgICAgIGhlaWdodDogMWVtOworICAgICAgICBtYXJnaW4tbGVmdDogNTAwcHg7Cisg
ICAgICAgIG1hcmdpbi10b3A6IDIwMHB4OworICAgICAgICBiYWNrZ3JvdW5kOiBncmVlbjsKKyAg
ICAgICAgdGV4dC1pbmRlbnQ6IC0xNTBweDsKKyAgICAgIH0KKyAgICA8L3N0eWxlPgorICAgIDxz
Y3JpcHQgc3JjPSJyZXNvdXJjZXMvcmVwYWludC5qcyIgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij48
L3NjcmlwdD4KKyAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CisgICAgZnVuY3Rp
b24gcmVwYWludFRlc3QoKSB7CisgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdlZGl0
YWJsZScpLmZvY3VzKCk7CisgICAgfQorICAgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25s
b2FkPSJydW5SZXBhaW50VGVzdCgpOyI+CisgICAgPGRpdiBpZD0iZWRpdGFibGUiIGNvbnRlbnRl
ZGl0YWJsZT0idHJ1ZSI+PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>