108632 2013-02-01 06:54:17 -0800 REGRESSION(r137994): It made JSC tests hang and layout tests fail on ARM Thumb2 / Linux 2013-03-05 07:58:00 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED DUPLICATE 111441 P2 Normal --- 108645 65766 1 ossy rgabor benjamin cmarcelo gaborb galpeter hausmann loki ojan.autocc ossy psychon rgabor webkit.review.bot zherczeg oldest_to_newest 822724 0 ossy 2013-02-01 06:54:17 -0800 Tested on QtWebKit, but it might be valid on other platforms too. - r137993 (with r138032 buildfix applied): http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/7810 - r137994 (with r138032 buildfix applied): http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/7703 822842 1 ossy 2013-02-01 09:10:40 -0800 - ToT (r141579) - http://cute1.inf.u-szeged.hu:8010/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/7809 - JSC tests still hang and inspector tests still crash - ToT (r141590) with reverted r137994 and r138474 - http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/7811 - JSC tests pass, but inspector tests still crash (maybe related to other bug too) 833843 2 ossy 2013-02-15 03:25:05 -0800 The bug is still valid on ToT . :-/ Are you going to fix it or should we revert the buggy patch until somebody find the proper fix? r142785 - http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/7876 r142785 (with reverted r137994 and r138474) - http://trac.webkit.org/changeset/142785 833844 3 ossy 2013-02-15 03:25:44 -0800 (In reply to comment #2) > The bug is still valid on ToT . :-/ Are you going to fix it or should > we revert the buggy patch until somebody find the proper fix? > > r142785 - http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/7876 > r142785 (with reverted r137994 and r138474) - ooops, wrong URL, here is the correct one: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/7877 834016 4 psychon 2013-02-15 07:42:04 -0800 Assuming you mean me with "you": Nope, no idea what I could do about this. I don't see how the patch could cause hangs unless mprotect() is painfully slow on ARM and gets called too often. Also, I don't have any ARM devices to experiment with. So the best that I can suggest: Restrict the #if OS(LINUX) in OSAllocatorPosix.cpp to also exclude ARM so that on these devices overcommit is still used. 840982 5 190062 hausmann 2013-02-25 08:10:12 -0800 Created attachment 190062 Patch Patch re-enables overcommit on ARM 841650 6 ossy 2013-02-25 22:38:30 -0800 Just a note: It caused problem with only with ARM Thumb2 assembler, but didn't with ARM traditional assembler on the same hardware. So I think the problem is something else here. Maybe a hidden bug was revealed by changing allocator. 842916 7 190062 ossy 2013-02-27 04:01:49 -0800 Comment on attachment 190062 Patch rs=me as workaround until proper fix 842917 8 ossy 2013-02-27 04:02:41 -0800 I checked this patch on the bot and it fixed most of the failures on Thumb2: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/7938 The remaining ~150 inspector crash is unrelated to this bug, needs more investigation. 842924 9 190062 webkit.review.bot 2013-02-27 04:11:11 -0800 Comment on attachment 190062 Patch Clearing flags on attachment: 190062 Committed r144170: <http://trac.webkit.org/changeset/144170> 842925 10 webkit.review.bot 2013-02-27 04:11:16 -0800 All reviewed patches have been landed. Closing bug. 842964 11 ossy 2013-02-27 05:32:59 -0800 Reopen, because only the workaround landed, we need to find the root of the problem. (rgabor said he will check it) 847680 12 rgabor 2013-03-05 07:54:04 -0800 I opened a new bug for this: https://bugs.webkit.org/show_bug.cgi?id=111441 847682 13 ossy 2013-03-05 07:58:00 -0800 *** This bug has been marked as a duplicate of bug 111441 *** 190062 2013-02-25 08:10:12 -0800 2013-02-27 04:11:11 -0800 Patch bug-108632-20130225170757.patch text/plain 1969 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDc2M2Y3YWMxOWNhZjg5NWJiZjRjNTQ3 ODUzNjZmMDdjZjI0YzFkYzQuLjAzZWJmNjVjYWUzZmQ0NGNiYjg0MzFmNDUwZDg5ODE3NDM3NGY5 ZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTMtMDItMjUgIFNpbW9uIEhhdXNtYW5uICA8c2lt b24uaGF1c21hbm5AZGlnaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjEzNzk5NCk6IEl0 IG1hZGUgSlNDIHRlc3RzIGhhbmcgYW5kIGxheW91dCB0ZXN0cyBmYWlsIG9uIEFSTSBUaHVtYjIg LyBMaW51eAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA4NjMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SXQgYXBwZWFycyB0aGF0IG1wcm90ZWN0KCkgaXMgdmVyeSBzbG93IG9uIEFSTS9MaW51eCwgc28g ZGlzYWJsZSB0aGUKKyAgICAgICAgYXBwcm9hY2ggb2YgdW5yZXNlcnZlZCBtYXBwaW5ncyB0aGVy ZSBhbmQgZmFsbCBiYWNrIHRvIG92ZXJjb21pdHRpbmcKKyAgICAgICAgbWVtb3J5LCBiYXNlZCBv biBVbGkgU2NobGFjaHRlcidzIHJlY29tbWVuZGF0aW9uLgorCisgICAgICAgICogd3RmL09TQWxs b2NhdG9yUG9zaXguY3BwOgorICAgICAgICAoV1RGOjpPU0FsbG9jYXRvcjo6cmVzZXJ2ZVVuY29t bWl0dGVkKToKKyAgICAgICAgKFdURjo6T1NBbGxvY2F0b3I6OmRlY29tbWl0KToKKwogMjAxMy0w Mi0yMCAgUm9nZXIgRm9uZyAgPHJvZ2VyX2ZvbmdAYXBwbGUuY29tPgogCiAgICAgICAgIEdldCBW UzIwMTAgU29sdXRpb24gQiZJIHJlYWR5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvT1NB bGxvY2F0b3JQb3NpeC5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9PU0FsbG9jYXRvclBvc2l4LmNwcApp bmRleCA3YjJhNTVjNmI2YWEwNWM3MGQxOTQwZDIwMjI1MWRiZWY1MjM0ZjlkLi44NzE1YjgxYjM2 MjEyZTQ1MjI5YmUzZTQyM2NjNjQ3ZTMyNjExNzc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0 Zi9PU0FsbG9jYXRvclBvc2l4LmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9PU0FsbG9jYXRvclBv c2l4LmNwcApAQCAtNDMsNyArNDMsNyBAQCB2b2lkKiBPU0FsbG9jYXRvcjo6cmVzZXJ2ZVVuY29t bWl0dGVkKHNpemVfdCBieXRlcywgVXNhZ2UgdXNhZ2UsIGJvb2wgd3JpdGFibGUsCiAgICAgdm9p ZCogcmVzdWx0ID0gbW1hcCgwLCBieXRlcywgUFJPVF9OT05FLCBNQVBfTEFaWSB8IE1BUF9QUklW QVRFIHwgTUFQX0FOT04sIC0xLCAwKTsKICAgICBpZiAocmVzdWx0ID09IE1BUF9GQUlMRUQpCiAg ICAgICAgIENSQVNIKCk7Ci0jZWxpZiBPUyhMSU5VWCkKKyNlbGlmIE9TKExJTlVYKSAmJiAhQ1BV KEFSTSkKICAgICBVTlVTRURfUEFSQU0odXNhZ2UpOwogICAgIFVOVVNFRF9QQVJBTSh3cml0YWJs ZSk7CiAgICAgVU5VU0VEX1BBUkFNKGV4ZWN1dGFibGUpOwpAQCAtMTY1LDcgKzE2NSw3IEBAIHZv aWQgT1NBbGxvY2F0b3I6OmRlY29tbWl0KHZvaWQqIGFkZHJlc3MsIHNpemVfdCBieXRlcykKICNp ZiBPUyhRTlgpCiAgICAgLy8gVXNlIFBST1RfTk9ORSBhbmQgTUFQX0xBWlkgdG8gZGVjb21taXQg dGhlIHBhZ2VzLgogICAgIG1tYXAoYWRkcmVzcywgYnl0ZXMsIFBST1RfTk9ORSwgTUFQX0ZJWEVE IHwgTUFQX0xBWlkgfCBNQVBfUFJJVkFURSB8IE1BUF9BTk9OLCAtMSwgMCk7Ci0jZWxpZiBPUyhM SU5VWCkKKyNlbGlmIE9TKExJTlVYKSAmJiAhQ1BVKEFSTSkKICAgICBtYWR2aXNlKGFkZHJlc3Ms IGJ5dGVzLCBNQURWX0RPTlRORUVEKTsKICAgICBpZiAobXByb3RlY3QoYWRkcmVzcywgYnl0ZXMs IFBST1RfTk9ORSkpCiAgICAgICAgIENSQVNIKCk7Cg==