108621 2013-02-01 05:33:00 -0800 PatchLog process durations are increasing linearly with time (faulty data logging) 2013-02-01 07:28:53 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alancutter alancutter abarth eric webkit.review.bot oldest_to_newest 822669 0 alancutter 2013-02-01 05:33:00 -0800 http://i.imgur.com/VLpp5D6.png The Patch stopped event appears to be firing multiple times per patch for some queues. Eg. 185862 on cr-android-ews. http://queues.webkit.org/patch/185862 http://i.imgur.com/vNjr236.png It's not clear at this stage what is causing the stopped event to fire for this patch on this queue so much. Not all queues are experiencing this abnormality. The QSS loggers should be made immune to this behaviour regardless. 822674 1 186024 alancutter 2013-02-01 05:42:09 -0800 Created attachment 186024 Patch 822711 2 186024 eric 2013-02-01 06:15:33 -0800 Comment on attachment 186024 Patch LGTM. Do we need to clear old ones? 822729 3 alancutter 2013-02-01 06:57:48 -0800 (In reply to comment #2) > (From update of attachment 186024 [details]) > LGTM. Do we need to clear old ones? Thanks Eric. Once the data logging code has settled down and the kinks are worked out I considering wiping the existing log data since it's full of glitches like these. 822757 4 186024 webkit.review.bot 2013-02-01 07:28:50 -0800 Comment on attachment 186024 Patch Clearing flags on attachment: 186024 Committed r141590: <http://trac.webkit.org/changeset/141590> 822758 5 webkit.review.bot 2013-02-01 07:28:53 -0800 All reviewed patches have been landed. Closing bug. 186024 2013-02-01 05:42:09 -0800 2013-02-01 07:28:50 -0800 Patch bug-108621-20130202003852.patch text/plain 2613 alancutter U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNTY1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTZhMGJmMzY1MzI0ZjM1NTNiNzcyYjBmZDFhNWM0ZDNl MDljYTg5Mi4uZThiMjUyNDUzZmVkMzdkNzVlYjE5ZmE3NzcxMzMwNTkxYjVhMjljOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTAyLTAxICBBbGFuIEN1dHRlciAgPGFsYW5jdXR0ZXJAY2hyb21pdW0ub3JnPgor CisgICAgICAgIFBhdGNoTG9nIHByb2Nlc3MgZHVyYXRpb25zIGFyZSBpbmNyZWFzaW5nIGxpbmVh cmx5IHdpdGggdGltZSAoZmF1bHR5IGRhdGEgbG9nZ2luZykKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODYyMQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIGEgY2hlY2sgdG8gcHJldmVudCBhIHN0 b3AgZXZlbnQgZnJvbSBoYXBwZW5pbmcgdG8gdGhlIHNhbWUgcGF0Y2ggbXVsdGlwbGUgdGltZXMu CisKKyAgICAgICAgKiBRdWV1ZVN0YXR1c1NlcnZlci9sb2dnZXJzL3JlY29yZHBhdGNoZXZlbnQu cHk6CisgICAgICAgIChSZWNvcmRQYXRjaEV2ZW50LnN0b3BwZWQpOgorCiAyMDEzLTAxLTMxICBE YXZpZCBGYXJsZXIgIDxkZmFybGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBQcm92aWRlIGEgc2Vu c2libGUgZGVmYXVsdCBhcmNoaXRlY3R1cmUgd2hlbiBidWlsZGluZyBvbiBpT1MgU0RLcwpkaWZm IC0tZ2l0IGEvVG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvYXBwLnlhbWwgYi9Ub29scy9RdWV1ZVN0 YXR1c1NlcnZlci9hcHAueWFtbAppbmRleCBlYTNmN2VhMTYxNzdmYTEyZDEzZWQ1NTU0MGMyNmYz NDhkMzRlN2QxLi4wNTBjODJjNThlOGRlNGFjZjNhZmY2NzMxNmU2OWE5MzYxNThkYWUyIDEwMDY0 NAotLS0gYS9Ub29scy9RdWV1ZVN0YXR1c1NlcnZlci9hcHAueWFtbAorKysgYi9Ub29scy9RdWV1 ZVN0YXR1c1NlcnZlci9hcHAueWFtbApAQCAtMSw1ICsxLDUgQEAKIGFwcGxpY2F0aW9uOiB3ZWJr aXQtY29tbWl0LXF1ZXVlCi12ZXJzaW9uOiAxMDg0MjcgIyBCdWd6aWxsYSBidWcgSUQgb2YgbGFz dCBtYWpvciBjaGFuZ2UKK3ZlcnNpb246IDEwODYyMSAjIEJ1Z3ppbGxhIGJ1ZyBJRCBvZiBsYXN0 IG1ham9yIGNoYW5nZQogcnVudGltZTogcHl0aG9uCiBhcGlfdmVyc2lvbjogMQogCmRpZmYgLS1n aXQgYS9Ub29scy9RdWV1ZVN0YXR1c1NlcnZlci9sb2dnZXJzL3JlY29yZHBhdGNoZXZlbnQucHkg Yi9Ub29scy9RdWV1ZVN0YXR1c1NlcnZlci9sb2dnZXJzL3JlY29yZHBhdGNoZXZlbnQucHkKaW5k ZXggNGNkZGI2MDZhOWI3ODhlYmY1NzRkZDg4ZTBiNjc5YzkyMjRmMGQwNy4uMDhjNTdjZGI2ZDZm MDk4OTgzMDMwMTdiOTI1Yjg3NDNmMzM5NmQ5ZiAxMDA2NDQKLS0tIGEvVG9vbHMvUXVldWVTdGF0 dXNTZXJ2ZXIvbG9nZ2Vycy9yZWNvcmRwYXRjaGV2ZW50LnB5CisrKyBiL1Rvb2xzL1F1ZXVlU3Rh dHVzU2VydmVyL2xvZ2dlcnMvcmVjb3JkcGF0Y2hldmVudC5weQpAQCAtODUsMTUgKzg1LDE2IEBA IGNsYXNzIFJlY29yZFBhdGNoRXZlbnQob2JqZWN0KToKICAgICAgICAgICAgIFdhcm5pbmdMb2cu cmVjb3JkKCJwYXRjaGxvZyB3YWl0IGR1cmF0aW9uIG1pc3NpbmciLCAiSW4gc3RvcHBlZCBldmVu dC4iLCBhdHRhY2htZW50X2lkLCBxdWV1ZV9uYW1lLCBib3RfaWQpCiAgICAgICAgICAgICByZXR1 cm4KIAotICAgICAgICBpZiBib3RfaWQ6Ci0gICAgICAgICAgICBwYXRjaF9sb2cuYm90X2lkID0g Ym90X2lkCi0gICAgICAgIHBhdGNoX2xvZy5maW5pc2hlZCA9IFRydWUKLSAgICAgICAgcGF0Y2hf bG9nLmNhbGN1bGF0ZV9wcm9jZXNzX2R1cmF0aW9uKCkKLSAgICAgICAgcGF0Y2hfbG9nLnB1dCgp CisgICAgICAgIGlmIG5vdCBwYXRjaF9sb2cuZmluaXNoZWQ6CisgICAgICAgICAgICBpZiBib3Rf aWQ6CisgICAgICAgICAgICAgICAgcGF0Y2hfbG9nLmJvdF9pZCA9IGJvdF9pZAorICAgICAgICAg ICAgcGF0Y2hfbG9nLmZpbmlzaGVkID0gVHJ1ZQorICAgICAgICAgICAgcGF0Y2hfbG9nLmNhbGN1 bGF0ZV9wcm9jZXNzX2R1cmF0aW9uKCkKKyAgICAgICAgICAgIHBhdGNoX2xvZy5wdXQoKQogCi0g ICAgICAgIHF1ZXVlX2xvZyA9IFF1ZXVlTG9nLmdldF9jdXJyZW50KHF1ZXVlX25hbWUsIHF1ZXVl X2xvZ19kdXJhdGlvbikKLSAgICAgICAgcXVldWVfbG9nLnBhdGNoX3Byb2Nlc3NfZHVyYXRpb25z LmFwcGVuZChwYXRjaF9sb2cucHJvY2Vzc19kdXJhdGlvbikKLSAgICAgICAgcXVldWVfbG9nLnB1 dCgpCisgICAgICAgICAgICBxdWV1ZV9sb2cgPSBRdWV1ZUxvZy5nZXRfY3VycmVudChxdWV1ZV9u YW1lLCBxdWV1ZV9sb2dfZHVyYXRpb24pCisgICAgICAgICAgICBxdWV1ZV9sb2cucGF0Y2hfcHJv Y2Vzc19kdXJhdGlvbnMuYXBwZW5kKHBhdGNoX2xvZy5wcm9jZXNzX2R1cmF0aW9uKQorICAgICAg ICAgICAgcXVldWVfbG9nLnB1dCgpCiAKICAgICBAY2xhc3NtZXRob2QKICAgICBkZWYgdXBkYXRl ZChjbHMsIGF0dGFjaG1lbnRfaWQsIHF1ZXVlX25hbWUsIGJvdF9pZD1Ob25lKToK