108602 2013-02-01 02:05:08 -0800 Web Inspector: [Canvas] UI is not restored properly when deleting a live recording profile 2013-02-05 04:06:18 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 aandrey aandrey apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 822519 0 aandrey 2013-02-01 02:05:08 -0800 Repro: - start recording canvas consecutive frames - while recording, delete the profile header - observe the start button's color is still red Patch to follow. 822524 1 185985 aandrey 2013-02-01 02:11:42 -0800 Created attachment 185985 Patch 824112 2 185985 pfeldman 2013-02-04 00:25:47 -0800 Comment on attachment 185985 Patch Missing a test. 824194 3 aandrey 2013-02-04 03:31:47 -0800 (In reply to comment #2) > (From update of attachment 185985 [details]) > Missing a test. UI change, manual testing. I dont think we test these. 824203 4 185985 pfeldman 2013-02-04 03:41:26 -0800 Comment on attachment 185985 Patch At this point, I don't think proceeding with no tests at all is acceptable. We need at least some acceptance tests. 825361 5 185985 webkit.review.bot 2013-02-05 04:06:13 -0800 Comment on attachment 185985 Patch Clearing flags on attachment: 185985 Committed r141883: <http://trac.webkit.org/changeset/141883> 825362 6 webkit.review.bot 2013-02-05 04:06:18 -0800 All reviewed patches have been landed. Closing bug. 185985 2013-02-01 02:11:42 -0800 2013-02-05 04:06:13 -0800 Patch bug-108602-20130201140824.patch text/plain 4618 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmZjNzFiNjA0ZTQ4NWI5 YTAzYTYzYTA2MGVlZDRkNGQ5YTU5Y2E1Ny4uMGMwYjVkMjdlY2FkZTI3NmQ2MzBhMmE2MWJiOWZi ZjA4ZGUzNjhjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAyLTAxICBBbmRy ZXkgQWRhaWtpbiAgPGFhbmRyZXlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFtDYW52YXNdIFVJIGlzIG5vdCByZXN0b3JlZCBwcm9wZXJseSB3aGVuIGRlbGV0aW5nIGEg bGl2ZSByZWNvcmRpbmcgcHJvZmlsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTA4NjAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQ2FuY2VsIHJlY29yZGluZyBwcm9maWxlIG9mIGNhbnZhcy10eXBlIHdo ZW4gZGVsZXRpbmcgYW4gYWxpdmUgdHJhY2UgbG9nLgorICAgICAgICBEcml2ZS1ieTogcmVuYW1l IFByb2ZpbGVIZWFkZXIucmVzZXQgdG8gUHJvZmlsZUhlYWRlci5kaXNwb3NlIHNpbmNlIGl0J3Mg Y2FsbGVkIG9uIGhlYWRlcidzIGRlc3RydWN0aW9uLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zy b250LWVuZC9DYW52YXNQcm9maWxlVmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5DYW52 YXNQcm9maWxlSGVhZGVyLnByb3RvdHlwZS5kaXNwb3NlKToKKyAgICAgICAgKiBpbnNwZWN0b3Iv ZnJvbnQtZW5kL1Byb2ZpbGVzUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUHJvZmls ZUhlYWRlci5wcm90b3R5cGUuZGlzcG9zZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUHJvZmls ZXNQYW5lbC5wcm90b3R5cGUuX3Jlc2V0KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Qcm9maWxl c1BhbmVsLnByb3RvdHlwZS5fcmVtb3ZlUHJvZmlsZUhlYWRlcik6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuUHJvZmlsZXNQYW5lbC5wcm90b3R5cGUuc2V0UmVjb3JkaW5nUHJvZmlsZSk6CisKIDIw MTMtMDEtMzEgIEFuZHJleSBBZGFpa2luICA8YWFuZHJleUBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgV2ViIEluc3BlY3RvcjogW0NhbnZhc10gZHJvcCB0cmFjZSBsb2cgaW4gdGhlIGJhY2tlbmQg d2hlbiBkZWxldGluZyBwcm9maWxlIGluIGZyb250ZW5kCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NhbnZhc1Byb2ZpbGVWaWV3LmpzIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9DYW52YXNQcm9maWxlVmlldy5qcwppbmRleCA2ZGQy OTZkZTA2YjlkMjgxNGMzMjFiZmI1NTA1YjY5MjcwODI4NWE5Li5lMTdhZmVkOTY3Y2U5ZTdlNTUy ODgxNzZlODVhZmZlMDVlM2I2NmY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL0NhbnZhc1Byb2ZpbGVWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvQ2FudmFzUHJvZmlsZVZpZXcuanMKQEAgLTc2NywxMSArNzY3LDE3 IEBAIFdlYkluc3BlY3Rvci5DYW52YXNQcm9maWxlSGVhZGVyLnByb3RvdHlwZSA9IHsKIAogICAg IC8qKgogICAgICAqIEBvdmVycmlkZQorICAgICAqIEBwYXJhbSB7IVdlYkluc3BlY3Rvci5Qcm9m aWxlc1BhbmVsfSBwcm9maWxlc1BhbmVsCiAgICAgICovCi0gICAgcmVzZXQ6IGZ1bmN0aW9uKCkK KyAgICBkaXNwb3NlOiBmdW5jdGlvbihwcm9maWxlc1BhbmVsKQogICAgIHsKLSAgICAgICAgaWYg KHRoaXMuX3RyYWNlTG9nSWQpCisgICAgICAgIGlmICh0aGlzLl90cmFjZUxvZ0lkKSB7CiAgICAg ICAgICAgICBDYW52YXNBZ2VudC5kcm9wVHJhY2VMb2codGhpcy5fdHJhY2VMb2dJZCk7CisgICAg ICAgICAgICBjbGVhclRpbWVvdXQodGhpcy5fcmVxdWVzdFN0YXR1c1RpbWVyKTsKKyAgICAgICAg ICAgIGlmICh0aGlzLl9hbGl2ZSkKKyAgICAgICAgICAgICAgICBwcm9maWxlc1BhbmVsLnNldFJl Y29yZGluZ1Byb2ZpbGUoV2ViSW5zcGVjdG9yLkNhbnZhc1Byb2ZpbGVUeXBlLlR5cGVJZCwgZmFs c2UpOworICAgICAgICAgICAgdGhpcy5fYWxpdmUgPSBmYWxzZTsKKyAgICAgICAgfQogICAgIH0s CiAKICAgICAvKioKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvUHJvZmlsZXNQYW5lbC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv UHJvZmlsZXNQYW5lbC5qcwppbmRleCBlYzg5MmE2ZTA0M2RmOTAwODIzZGVlMzczNzk1YmY5MGQ0 YzQwNTk5Li4wODQ0NDJjOTU0ZWY5ZWJkM2IwYWZjODEyM2VhMDY2YTcyNDI5NmFlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVzUGFuZWwuanMK KysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Qcm9maWxlc1BhbmVsLmpz CkBAIC0xODQsNyArMTg0LDEwIEBAIFdlYkluc3BlY3Rvci5Qcm9maWxlSGVhZGVyLnByb3RvdHlw ZSA9IHsKICAgICAgICAgdGhyb3cgbmV3IEVycm9yKCJOb3QgaW1wbGVtZW50ZWQuIik7CiAgICAg fSwKIAotICAgIHJlc2V0OiBmdW5jdGlvbigpCisgICAgLyoqCisgICAgICogQHBhcmFtIHshV2Vi SW5zcGVjdG9yLlByb2ZpbGVzUGFuZWx9IHByb2ZpbGVzUGFuZWwKKyAgICAgKi8KKyAgICBkaXNw b3NlOiBmdW5jdGlvbihwcm9maWxlc1BhbmVsKQogICAgIHsKICAgICB9LAogCkBAIC00MTksNyAr NDIyLDcgQEAgV2ViSW5zcGVjdG9yLlByb2ZpbGVzUGFuZWwucHJvdG90eXBlID0gewogICAgICAg ICAgICAgICAgIGlmICgiZGlzcG9zZSIgaW4gdmlldykKICAgICAgICAgICAgICAgICAgICAgdmll dy5kaXNwb3NlKCk7CiAgICAgICAgICAgICB9Ci0gICAgICAgICAgICB0aGlzLl9wcm9maWxlc1tp XS5yZXNldCgpOworICAgICAgICAgICAgdGhpcy5fcHJvZmlsZXNbaV0uZGlzcG9zZSh0aGlzKTsK ICAgICAgICAgfQogICAgICAgICBkZWxldGUgdGhpcy52aXNpYmxlVmlldzsKIApAQCAtNjE0LDcg KzYxNyw3IEBAIFdlYkluc3BlY3Rvci5Qcm9maWxlc1BhbmVsLnByb3RvdHlwZSA9IHsKICAgICAg ICAgICAgIGlmICh0aGlzLl9wcm9maWxlc1tpXS51aWQgPT09IHByb2ZpbGUudWlkKSB7CiAgICAg ICAgICAgICAgICAgcHJvZmlsZSA9IHRoaXMuX3Byb2ZpbGVzW2ldOwogICAgICAgICAgICAgICAg IHRoaXMuX3Byb2ZpbGVzLnNwbGljZShpLCAxKTsKLSAgICAgICAgICAgICAgICBwcm9maWxlLnJl c2V0KCk7CisgICAgICAgICAgICAgICAgcHJvZmlsZS5kaXNwb3NlKHRoaXMpOwogICAgICAgICAg ICAgICAgIGJyZWFrOwogICAgICAgICAgICAgfQogICAgICAgICB9CkBAIC0xMTQxLDIxICsxMTQ0 LDE2IEBAIFdlYkluc3BlY3Rvci5Qcm9maWxlc1BhbmVsLnByb3RvdHlwZSA9IHsKICAgICB7CiAg ICAgICAgIHZhciBwcm9maWxlVHlwZU9iamVjdCA9IHRoaXMuZ2V0UHJvZmlsZVR5cGUocHJvZmls ZVR5cGUpOwogICAgICAgICBwcm9maWxlVHlwZU9iamVjdC5zZXRSZWNvcmRpbmdQcm9maWxlKGlz UHJvZmlsaW5nKTsKLSAgICAgICAgdmFyIHRlbXBvcmFyeVByb2ZpbGUgPSB0aGlzLmZpbmRUZW1w b3JhcnlQcm9maWxlKHByb2ZpbGVUeXBlKTsKLSAgICAgICAgaWYgKCEhdGVtcG9yYXJ5UHJvZmls ZSA9PT0gaXNQcm9maWxpbmcpCi0gICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIGlmICghdGVt cG9yYXJ5UHJvZmlsZSkKLSAgICAgICAgICAgIHRlbXBvcmFyeVByb2ZpbGUgPSBwcm9maWxlVHlw ZU9iamVjdC5jcmVhdGVUZW1wb3JhcnlQcm9maWxlKCk7Ci0gICAgICAgIGlmIChpc1Byb2ZpbGlu ZykKLSAgICAgICAgICAgIHRoaXMuYWRkUHJvZmlsZUhlYWRlcih0ZW1wb3JhcnlQcm9maWxlKTsK LSAgICAgICAgZWxzZQotICAgICAgICAgICAgdGhpcy5fcmVtb3ZlVGVtcG9yYXJ5UHJvZmlsZShw cm9maWxlVHlwZSk7CiAgICAgICAgIHRoaXMucmVjb3JkQnV0dG9uLnRvZ2dsZWQgPSBpc1Byb2Zp bGluZzsKICAgICAgICAgdGhpcy5yZWNvcmRCdXR0b24udGl0bGUgPSBwcm9maWxlVHlwZU9iamVj dC5idXR0b25Ub29sdGlwOwotICAgICAgICBpZiAoaXNQcm9maWxpbmcpCisgICAgICAgIGlmIChp c1Byb2ZpbGluZykgewogICAgICAgICAgICAgdGhpcy5fbGF1bmNoZXJWaWV3LnByb2ZpbGVTdGFy dGVkKCk7Ci0gICAgICAgIGVsc2UKKyAgICAgICAgICAgIGlmICghdGhpcy5maW5kVGVtcG9yYXJ5 UHJvZmlsZShwcm9maWxlVHlwZSkpCisgICAgICAgICAgICAgICAgdGhpcy5hZGRQcm9maWxlSGVh ZGVyKHByb2ZpbGVUeXBlT2JqZWN0LmNyZWF0ZVRlbXBvcmFyeVByb2ZpbGUoKSk7CisgICAgICAg IH0gZWxzZSB7CiAgICAgICAgICAgICB0aGlzLl9sYXVuY2hlclZpZXcucHJvZmlsZUZpbmlzaGVk KCk7CisgICAgICAgICAgICB0aGlzLl9yZW1vdmVUZW1wb3JhcnlQcm9maWxlKHByb2ZpbGVUeXBl KTsKKyAgICAgICAgfQogICAgIH0sCiAKICAgICB0YWtlSGVhcFNuYXBzaG90OiBmdW5jdGlvbigp Cg==