108600 2013-02-01 01:56:51 -0800 Web Inspector: [Canvas] do not store a dropped trace log in backend 2013-02-05 04:36:15 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 aandrey aandrey apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 822513 0 aandrey 2013-02-01 01:56:51 -0800 Clear memory immediately on dropping current trace log instead of waiting for the next capture command. Patch to follow. 822514 1 185983 aandrey 2013-02-01 01:58:32 -0800 Created attachment 185983 Patch 824113 2 185983 pfeldman 2013-02-04 00:26:02 -0800 Comment on attachment 185983 Patch Missing a test 824188 3 aandrey 2013-02-04 03:25:00 -0800 (In reply to comment #2) > (From update of attachment 185983 [details]) > Missing a test hm... this is quite hard to test (injected script), and IMO does not worth testing, in a sense, that the only thing that changed is nulling a pointer upon dropping a trace log. 824204 4 185983 pfeldman 2013-02-04 03:41:32 -0800 Comment on attachment 185983 Patch At this point, I don't think proceeding with no tests at all is acceptable. We need at least some acceptance tests. 825369 5 185983 webkit.review.bot 2013-02-05 04:36:12 -0800 Comment on attachment 185983 Patch Clearing flags on attachment: 185983 Committed r141884: <http://trac.webkit.org/changeset/141884> 825370 6 webkit.review.bot 2013-02-05 04:36:15 -0800 All reviewed patches have been landed. Closing bug. 185983 2013-02-01 01:58:32 -0800 2013-02-05 04:36:12 -0800 Patch bug-108600-20130201135515.patch text/plain 1968 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDQ1NDQyMTkwMDgxZTIx MWQ4ZGU1MGNkOGIzNmRkM2RlNzIwNTVlNy4uOTY5NTdkMDM3ZjFmMjczNTQ5NmExNjQ3NWViYTJh OTk1N2M5NTBmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAyLTAxICBBbmRy ZXkgQWRhaWtpbiAgPGFhbmRyZXlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFtDYW52YXNdIGRvIG5vdCBzdG9yZSBhIGRyb3BwZWQgdHJhY2UgbG9nIGluIGJhY2tlbmQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODYwMAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENsZWFyIG1l bW9yeSBpbW1lZGlhdGVseSBvbiBkcm9wcGluZyBjdXJyZW50IHRyYWNlIGxvZyBpbnN0ZWFkIG9m IHdhaXRpbmcgZm9yIHRoZSBuZXh0IGNhcHR1cmUgY29tbWFuZC4KKworICAgICAgICAqIGluc3Bl Y3Rvci9JbmplY3RlZFNjcmlwdENhbnZhc01vZHVsZVNvdXJjZS5qczoKKyAgICAgICAgKC4pOgor CiAyMDEzLTAxLTMxICBBdXJpbWFzIExpdXRpa2FzICA8YXVyaW1hc0BjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgRWRpdG9yOjptX2NvbXBvc2l0aW9uTm9kZSBub3QgdXBkYXRlZCBvbiBIVE1MSW5w dXRFbGVtZW50OjpzZXRWYWx1ZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvSW5qZWN0ZWRTY3JpcHRDYW52YXNNb2R1bGVTb3VyY2UuanMgYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRDYW52YXNNb2R1bGVTb3VyY2UuanMKaW5kZXggNWEyYjdh ZTdiNmY3Mzk3ZmNkYWVhODE0OWIyMGZjMzViMmQ3YzgyMy4uNjNkYjlkNzMyMDU3OWJiZGUwMGEx M2UwNzYyNDY3MmVjZDFjNTIxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0luamVjdGVkU2NyaXB0Q2FudmFzTW9kdWxlU291cmNlLmpzCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdENhbnZhc01vZHVsZVNvdXJjZS5qcwpAQCAtMjkwMCw2 ICsyOTAwLDE2IEBAIFJlc291cmNlVHJhY2tpbmdNYW5hZ2VyLnByb3RvdHlwZSA9IHsKICAgICAg ICAgdGhpcy5fc3RvcENhcHR1cmluZ09uRnJhbWVFbmQgPSBmYWxzZTsKICAgICB9LAogCisgICAg LyoqCisgICAgICogQHBhcmFtIHshVHJhY2VMb2d9IHRyYWNlTG9nCisgICAgICovCisgICAgZHJv cFRyYWNlTG9nOiBmdW5jdGlvbih0cmFjZUxvZykKKyAgICB7CisgICAgICAgIHRoaXMuc3RvcENh cHR1cmluZyh0cmFjZUxvZyk7CisgICAgICAgIGlmICh0aGlzLl9sYXN0VHJhY2VMb2cgPT09IHRy YWNlTG9nKQorICAgICAgICAgICAgdGhpcy5fbGFzdFRyYWNlTG9nID0gbnVsbDsKKyAgICB9LAor CiAgICAgY2FwdHVyZUZyYW1lOiBmdW5jdGlvbigpCiAgICAgewogICAgICAgICB0aGlzLl9sYXN0 VHJhY2VMb2cgPSBuZXcgVHJhY2VMb2coKTsKQEAgLTMwNDAsNyArMzA1MCw5IEBAIEluamVjdGVk Q2FudmFzTW9kdWxlLnByb3RvdHlwZSA9IHsKICAgICAgKi8KICAgICBkcm9wVHJhY2VMb2c6IGZ1 bmN0aW9uKGlkKQogICAgIHsKLSAgICAgICAgdGhpcy5zdG9wQ2FwdHVyaW5nKGlkKTsKKyAgICAg ICAgdmFyIHRyYWNlTG9nID0gdGhpcy5fdHJhY2VMb2dzW2lkXTsKKyAgICAgICAgaWYgKHRyYWNl TG9nKQorICAgICAgICAgICAgdGhpcy5fbWFuYWdlci5kcm9wVHJhY2VMb2codHJhY2VMb2cpOwog ICAgICAgICBkZWxldGUgdGhpcy5fdHJhY2VMb2dzW2lkXTsKICAgICAgICAgZGVsZXRlIHRoaXMu X3RyYWNlTG9nUGxheWVyc1tpZF07CiAgICAgfSwK