108591 2013-01-31 23:57:16 -0800 Web Inspector: [Canvas] drop trace log in the backend when deleting profile in frontend 2013-02-01 01:53:47 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 aandrey aandrey apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 822399 0 aandrey 2013-01-31 23:57:16 -0800 Send a dropTraceLog command to the backend when deleting a profile header from the sidebar. Before we were sending the command only upon deleting an existing view of a profile, so we would not sent the command if the view was not created or if a profile header was removed via context menu (the ondelete() method). Patch to follow. 822404 1 185960 aandrey 2013-01-31 23:59:49 -0800 Created attachment 185960 Patch 822508 2 185960 webkit.review.bot 2013-02-01 01:53:43 -0800 Comment on attachment 185960 Patch Clearing flags on attachment: 185960 Committed r141561: <http://trac.webkit.org/changeset/141561> 822509 3 webkit.review.bot 2013-02-01 01:53:47 -0800 All reviewed patches have been landed. Closing bug. 185960 2013-01-31 23:59:49 -0800 2013-02-01 01:53:43 -0800 Patch bug-108591-20130201115632.patch text/plain 5034 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWY5YTY0ZDlmNDljNTkx ZTY3ZmE3ODBiZWY3ZTY4MzdkNDRmMjgxZS4uYTE3YzJmN2NlNTI5OTUzMDZjODJmOWUzYWE0NDk2 NTc1NzE5OTdlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMxIEBACiAyMDEzLTAxLTMxICBBbmRy ZXkgQWRhaWtpbiAgPGFhbmRyZXlAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFtDYW52YXNdIGRyb3AgdHJhY2UgbG9nIGluIHRoZSBiYWNrZW5kIHdoZW4gZGVsZXRpbmcg cHJvZmlsZSBpbiBmcm9udGVuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTA4NTkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgU2VuZCBhIGRyb3BUcmFjZUxvZyBjb21tYW5kIHRvIHRoZSBiYWNrZW5kIHdo ZW4gZGVsZXRpbmcgYSBwcm9maWxlIGhlYWRlciBmcm9tIHRoZSBzaWRlYmFyLgorICAgICAgICBC ZWZvcmUgd2Ugd2VyZSBzZW5kaW5nIHRoZSBjb21tYW5kIG9ubHkgdXBvbiBkZWxldGluZyBhbiBl eGlzdGluZyB2aWV3IG9mIGEgcHJvZmlsZSwgc28gd2UgIHdvdWxkIG5vdAorICAgICAgICBzZW50 IHRoZSBjb21tYW5kIGlmIHRoZSB2aWV3IHdhcyBub3QgY3JlYXRlZCBvciBpZiBhIHByb2ZpbGUg aGVhZGVyIHdhcyByZW1vdmVkIHZpYSBjb250ZXh0IG1lbnUgKHRoZSBvbmRlbGV0ZSgpIG1ldGhv ZCkuCisgICAgICAgIERyaXZlLWJ5OiBmaXhlZCBhbiBvZGQgZm9ybWF0dGluZyBvZiBwcm9wZXJ0 eSBmdW5jdGlvbnMuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0NhbnZhc1Byb2Zp bGVWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNhbnZhc1Byb2ZpbGVWaWV3LnByb3Rv dHlwZS5kaXNwb3NlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5DYW52YXNQcm9maWxlSGVhZGVy LnByb3RvdHlwZS5yZXNldCk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Qcm9maWxl c1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlByb2ZpbGVIZWFkZXIucHJvdG90eXBl LnJlc2V0KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Qcm9maWxlSGVhZGVyLnByb3RvdHlwZS5s b2FkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Qcm9maWxlSGVhZGVyLnByb3RvdHlwZS5jYW5T YXZlVG9GaWxlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Qcm9maWxlSGVhZGVyLnByb3RvdHlw ZS5zYXZlVG9GaWxlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Qcm9maWxlSGVhZGVyLnByb3Rv dHlwZS5sb2FkRnJvbUZpbGUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlByb2ZpbGVIZWFkZXIu cHJvdG90eXBlLmZyb21GaWxlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Qcm9maWxlc1BhbmVs KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Qcm9maWxlc1BhbmVsLnByb3RvdHlwZS5fcmVzZXQp OgorICAgICAgICAoV2ViSW5zcGVjdG9yLlByb2ZpbGVzUGFuZWwucHJvdG90eXBlLl9yZW1vdmVQ cm9maWxlSGVhZGVyKToKKworMjAxMy0wMS0zMSAgQW5kcmV5IEFkYWlraW4gIDxhYW5kcmV5QGNo cm9taXVtLm9yZz4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBFeGNlcHRpb24gaW4gSGVhcFNu YXBzaG90Vmlldy5qcwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTA4NDU2CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvQ2FudmFzUHJvZmlsZVZpZXcuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL0NhbnZhc1Byb2ZpbGVWaWV3LmpzCmluZGV4IDc5MjU2N2Y0YTIxNTU0NzE3ZjM0YzMx MTRmYzZlOWVlYmU1YzExZjIuLjZkZDI5NmRlMDZiOWQyODE0YzMyMWJmYjU1MDViNjkyNzA4Mjg1 YTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ2FudmFz UHJvZmlsZVZpZXcuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9D YW52YXNQcm9maWxlVmlldy5qcwpAQCAtMTAzLDcgKzEwMyw2IEBAIFdlYkluc3BlY3Rvci5DYW52 YXNQcm9maWxlVmlldy5wcm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICB0aGlzLl9sb2dHcmlk Tm9kZXMgPSBbXTsKICAgICAgICAgdGhpcy5fbGlua2lmaWVyLnJlc2V0KCk7Ci0gICAgICAgIENh bnZhc0FnZW50LmRyb3BUcmFjZUxvZyh0aGlzLl90cmFjZUxvZ0lkKTsKICAgICB9LAogCiAgICAg Z2V0IHN0YXR1c0Jhckl0ZW1zKCkKQEAgLTc2Nyw2ICs3NjYsMTUgQEAgV2ViSW5zcGVjdG9yLkNh bnZhc1Byb2ZpbGVIZWFkZXIucHJvdG90eXBlID0gewogICAgIH0sCiAKICAgICAvKioKKyAgICAg KiBAb3ZlcnJpZGUKKyAgICAgKi8KKyAgICByZXNldDogZnVuY3Rpb24oKQorICAgIHsKKyAgICAg ICAgaWYgKHRoaXMuX3RyYWNlTG9nSWQpCisgICAgICAgICAgICBDYW52YXNBZ2VudC5kcm9wVHJh Y2VMb2codGhpcy5fdHJhY2VMb2dJZCk7CisgICAgfSwKKworICAgIC8qKgogICAgICAqIEBwYXJh bSB7Q2FudmFzQWdlbnQuVHJhY2VMb2c9fSB0cmFjZUxvZwogICAgICAqLwogICAgIF91cGRhdGVD YXB0dXJpbmdTdGF0dXM6IGZ1bmN0aW9uKHRyYWNlTG9nKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Qcm9maWxlc1BhbmVsLmpzIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Qcm9maWxlc1BhbmVsLmpzCmluZGV4IDBjOGMzZDFkYzJm NjMwZGRjM2NlZTI0YjFmMDk1YzA0Y2JkZWE2NGIuLmVjODkyYTZlMDQzZGY5MDA4MjNkZWUzNzM3 OTViZjkwZDRjNDA1OTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvUHJvZmlsZXNQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1Byb2ZpbGVzUGFuZWwuanMKQEAgLTE4NCwyNyArMTg0LDQ1IEBAIFdlYkluc3BlY3Rv ci5Qcm9maWxlSGVhZGVyLnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhyb3cgbmV3IEVycm9yKCJO b3QgaW1wbGVtZW50ZWQuIik7CiAgICAgfSwKIAorICAgIHJlc2V0OiBmdW5jdGlvbigpCisgICAg eworICAgIH0sCisKICAgICAvKioKICAgICAgKiBAcGFyYW0ge0Z1bmN0aW9ufSBjYWxsYmFjawog ICAgICAqLwotICAgIGxvYWQ6IGZ1bmN0aW9uKGNhbGxiYWNrKSB7IH0sCisgICAgbG9hZDogZnVu Y3Rpb24oY2FsbGJhY2spCisgICAgeworICAgIH0sCiAKICAgICAvKioKICAgICAgKiBAcmV0dXJu IHtib29sZWFufQogICAgICAqLwotICAgIGNhblNhdmVUb0ZpbGU6IGZ1bmN0aW9uKCkgeyByZXR1 cm4gZmFsc2U7IH0sCisgICAgY2FuU2F2ZVRvRmlsZTogZnVuY3Rpb24oKQorICAgIHsKKyAgICAg ICAgcmV0dXJuIGZhbHNlOworICAgIH0sCiAKLSAgICBzYXZlVG9GaWxlOiBmdW5jdGlvbigpIHsg dGhyb3cgbmV3IEVycm9yKCJOZWVkcyBpbXBsZW1lbnRlZCIpOyB9LAorICAgIHNhdmVUb0ZpbGU6 IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIHRocm93IG5ldyBFcnJvcigiTmVlZHMgaW1wbGVt ZW50ZWQiKTsKKyAgICB9LAogCiAgICAgLyoqCiAgICAgICogQHBhcmFtIHtGaWxlfSBmaWxlCiAg ICAgICovCi0gICAgbG9hZEZyb21GaWxlOiBmdW5jdGlvbihmaWxlKSB7IHRocm93IG5ldyBFcnJv cigiTmVlZHMgaW1wbGVtZW50ZWQiKTsgfSwKKyAgICBsb2FkRnJvbUZpbGU6IGZ1bmN0aW9uKGZp bGUpCisgICAgeworICAgICAgICB0aHJvdyBuZXcgRXJyb3IoIk5lZWRzIGltcGxlbWVudGVkIik7 CisgICAgfSwKIAogICAgIC8qKgogICAgICAqIEByZXR1cm4ge2Jvb2xlYW59CiAgICAgICovCi0g ICAgZnJvbUZpbGU6IGZ1bmN0aW9uKCkgeyByZXR1cm4gdGhpcy5fZnJvbUZpbGU7IH0KKyAgICBm cm9tRmlsZTogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgcmV0dXJuIHRoaXMuX2Zyb21GaWxl OworICAgIH0KIH0KIAogLyoqCkBAIC0yNjQsNiArMjgyLDcgQEAgV2ViSW5zcGVjdG9yLlByb2Zp bGVzUGFuZWwgPSBmdW5jdGlvbigpCiAgICAgdGhpcy5fcHJvZmlsZVZpZXdTdGF0dXNCYXJJdGVt c0NvbnRhaW5lciA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwogICAgIHRoaXMuX3By b2ZpbGVWaWV3U3RhdHVzQmFySXRlbXNDb250YWluZXIuY2xhc3NOYW1lID0gInN0YXR1cy1iYXIt aXRlbXMiOwogCisgICAgLyoqIEB0eXBlIHshQXJyYXkuPCFXZWJJbnNwZWN0b3IuUHJvZmlsZUhl YWRlcj59ICovCiAgICAgdGhpcy5fcHJvZmlsZXMgPSBbXTsKICAgICB0aGlzLl9wcm9maWxlckVu YWJsZWQgPSAhQ2FwYWJpbGl0aWVzLnByb2ZpbGVyQ2F1c2VzUmVjb21waWxhdGlvbjsKIApAQCAt NDAwLDYgKzQxOSw3IEBAIFdlYkluc3BlY3Rvci5Qcm9maWxlc1BhbmVsLnByb3RvdHlwZSA9IHsK ICAgICAgICAgICAgICAgICBpZiAoImRpc3Bvc2UiIGluIHZpZXcpCiAgICAgICAgICAgICAgICAg ICAgIHZpZXcuZGlzcG9zZSgpOwogICAgICAgICAgICAgfQorICAgICAgICAgICAgdGhpcy5fcHJv ZmlsZXNbaV0ucmVzZXQoKTsKICAgICAgICAgfQogICAgICAgICBkZWxldGUgdGhpcy52aXNpYmxl VmlldzsKIApAQCAtNTk0LDYgKzYxNCw3IEBAIFdlYkluc3BlY3Rvci5Qcm9maWxlc1BhbmVsLnBy b3RvdHlwZSA9IHsKICAgICAgICAgICAgIGlmICh0aGlzLl9wcm9maWxlc1tpXS51aWQgPT09IHBy b2ZpbGUudWlkKSB7CiAgICAgICAgICAgICAgICAgcHJvZmlsZSA9IHRoaXMuX3Byb2ZpbGVzW2ld OwogICAgICAgICAgICAgICAgIHRoaXMuX3Byb2ZpbGVzLnNwbGljZShpLCAxKTsKKyAgICAgICAg ICAgICAgICBwcm9maWxlLnJlc2V0KCk7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg ICAgICB9CiAgICAgICAgIH0K