<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>108583</bug_id>
          
          <creation_ts>2013-01-31 22:28:33 -0800</creation_ts>
          <short_desc>[Qt] Add MessageFlags.h in Target.pri</short_desc>
          <delta_ts>2013-02-01 00:03:44 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Jae Hyun Park">jaepark</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abecsi</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>haraken</cc>
    
    <cc>menard</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>822329</commentid>
    <comment_count>0</comment_count>
    <who name="Jae Hyun Park">jaepark</who>
    <bug_when>2013-01-31 22:28:33 -0800</bug_when>
    <thetext>MessageFlags.h is not included in Target.pri, which causes compiler warning.
Since MessageDecoder and MessageEncoder includes MessageFlags.h, it should be included in Target.pri.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>822335</commentid>
    <comment_count>1</comment_count>
      <attachid>185946</attachid>
    <who name="Jae Hyun Park">jaepark</who>
    <bug_when>2013-01-31 22:32:12 -0800</bug_when>
    <thetext>Created attachment 185946
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>822369</commentid>
    <comment_count>2</comment_count>
      <attachid>185946</attachid>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2013-01-31 23:19:16 -0800</bug_when>
    <thetext>Comment on attachment 185946
Patch

rs=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>822407</commentid>
    <comment_count>3</comment_count>
      <attachid>185946</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-02-01 00:03:40 -0800</bug_when>
    <thetext>Comment on attachment 185946
Patch

Clearing flags on attachment: 185946

Committed r141546: &lt;http://trac.webkit.org/changeset/141546&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>822408</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-02-01 00:03:44 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>185946</attachid>
            <date>2013-01-31 22:32:12 -0800</date>
            <delta_ts>2013-02-01 00:03:40 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-108583-20130131222941.patch</filename>
            <type>text/plain</type>
            <size>1296</size>
            <attacher name="Jae Hyun Park">jaepark</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDUzN2RmOGY2NWE0ZGNl
ZTkxZjBlNWZlMjJkZGNkYzA5N2E2Y2E4NS4uNTlhYzg0NGJjZDE5ZDRlODg5NzBlNjAyZTJiYTU5
YWQwNTI3YjczMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTMxICBKYWUg
SHl1biBQYXJrICA8amFlLnBhcmtAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgW1F0XSBBZGQg
TWVzc2FnZUZsYWdzLmggaW4gVGFyZ2V0LnByaQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4NTgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgU2luY2UgTWVzc2FnZURlY29kZXIgYW5kIE1lc3NhZ2VFbmNv
ZGVyIGluY2x1ZGUgTWVzc2FnZUZsYWdzLmgsIGl0CisgICAgICAgIHNob3VsZCBiZSBpbmNsdWRl
ZCBpbiBUYXJnZXQucHJpLgorCisgICAgICAgICogVGFyZ2V0LnByaToKKwogMjAxMy0wMS0zMSAg
UmFmYWVsIEJyYW5kYW8gIDxyYWZhZWwubG9ib0BvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFtR
dF1bV0syXSBBbm90aGVyIGF0dGVtcHQgdG8gZml4IGJ1aWxkIGFmdGVyIHJlY2VudCBXZWJLaXQy
IGNoYW5nZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1RhcmdldC5wcmkgYi9Tb3VyY2Uv
V2ViS2l0Mi9UYXJnZXQucHJpCmluZGV4IGZlZDU3ZDg1MmZhYTA3MTRhOGNhNTcxOGJjZjVlYzNj
Y2U2YWM2NDMuLmJjN2NjMDE3YWUyMTdhMzFkYTc4ZjcxN2Q2YjY2OGE1NWZkZmNlNjkgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1RhcmdldC5wcmkKKysrIGIvU291cmNlL1dlYktpdDIvVGFy
Z2V0LnByaQpAQCAtMjYsNiArMjYsNyBAQCBIRUFERVJTICs9IFwKICAgICBQbGF0Zm9ybS9Db3Jl
SVBDL0hhbmRsZU1lc3NhZ2UuaCBcCiAgICAgUGxhdGZvcm0vQ29yZUlQQy9NZXNzYWdlRGVjb2Rl
ci5oIFwKICAgICBQbGF0Zm9ybS9Db3JlSVBDL01lc3NhZ2VFbmNvZGVyLmggXAorICAgIFBsYXRm
b3JtL0NvcmVJUEMvTWVzc2FnZUZsYWdzLmggXAogICAgIFBsYXRmb3JtL0NvcmVJUEMvTWVzc2Fn
ZVJlY2VpdmVyLmggXAogICAgIFBsYXRmb3JtL0NvcmVJUEMvTWVzc2FnZVJlY2VpdmVyTWFwLmgg
XAogICAgIFBsYXRmb3JtL0NvcmVJUEMvTWVzc2FnZVNlbmRlci5oIFwK
</data>

          </attachment>
      

    </bug>

</bugzilla>