108582 2013-01-31 22:20:42 -0800 REGRESSION(r111639): delayed animation start can be postponed 2013-03-06 09:17:05 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 107521 1 dstockwell dstockwell alancutter dglazkov dino simon.fraser webkit.review.bot oldest_to_newest 822325 0 dstockwell 2013-01-31 22:20:42 -0800 REGRESSION(r111639): delayed animation start can be postponed 822339 1 185948 dstockwell 2013-01-31 22:37:29 -0800 Created attachment 185948 Patch 822415 2 185948 webkit.review.bot 2013-02-01 00:15:47 -0800 Comment on attachment 185948 Patch Attachment 185948 did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16302453 822555 3 alancutter 2013-02-01 02:45:24 -0800 (In reply to comment #2) > (From update of attachment 185948 [details]) > Attachment 185948 [details] did not pass cr-linux-debug-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/16302453 This reported failure was due to this change in the cr-linux-debug-ews bots: bug 108512 822556 4 185948 dstockwell 2013-02-01 02:45:58 -0800 Comment on attachment 185948 Patch cr-linux-debug failure is spurious 848916 5 185948 darin 2013-03-06 09:09:53 -0800 Comment on attachment 185948 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185948&action=review > Source/WebCore/page/animation/AnimationController.cpp:129 > + if (m_animationTimer.isActive() && (m_animationTimer.repeatInterval() || m_animationTimer.nextFireInterval() <= timeToNextService)) > + return; The use of repeat interval in this class is peculiar. I don’t understand the comment at all. It says “to reduce the overhead of starting”. 848926 6 185948 webkit.review.bot 2013-03-06 09:17:01 -0800 Comment on attachment 185948 Patch Clearing flags on attachment: 185948 Committed r144935: <http://trac.webkit.org/changeset/144935> 848927 7 webkit.review.bot 2013-03-06 09:17:05 -0800 All reviewed patches have been landed. Closing bug. 185948 2013-01-31 22:37:29 -0800 2013-03-06 09:17:01 -0800 Patch bug-108582-20130201173411.patch text/plain 7151 dstockwell U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTczYmU5ODNiNDRjNDI5 ZTAyNDBkOTg1MmI4OWJlZjNiNDIxM2IyNi4uZGZhNzY3NDViMWRhYmRiMTAwMjVkMzA5ODdmOGM3 YzMzZTIyMmNlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAxLTMxICBEb3Vn bGFzIFN0b2Nrd2VsbCAgPGRzdG9ja3dlbGxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJFR1JF U1NJT04ocjExMTYzOSk6IGRlbGF5ZWQgYW5pbWF0aW9uIHN0YXJ0IGNhbiBiZSBwb3N0cG9uZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODU4Mgor CisgICAgICAgIFF1ZXJ5IHRoZSBhbmltYXRpb24gdGltZXIgZGlyZWN0bHkgZm9yIHRoZSB0aW1l IGl0IHdpbGwgbmV4dCBmaXJlIHJhdGhlciB0aGFuCisgICAgICAgIHRyeWluZyB0byBjYWNoZSB0 aGUgaW50ZXJ2YWwuIFByZXZpb3VzIGFwcHJvYWNoIHdhcyBpbmNvcnJlY3QgLS0gYXMgdGltZSBh ZHZhbmNlZAorICAgICAgICBpdCB3YXMgcG9zc2libGUgZm9yIHRoZSBpbnRlcnZhbCB0byBqdW1w IGJleW9uZCB0aGUgbmV4dCBzZXJ2aWNlIHRpbWUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogYW5pbWF0aW9ucy9hbmltYXRpb24tZGVsYXkt Y2hhbmdlZC5odG1sCisKKyAgICAgICAgKiBwYWdlL2FuaW1hdGlvbi9BbmltYXRpb25Db250cm9s bGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFuaW1hdGlvbkNvbnRyb2xsZXJQcml2YXRlOjpB bmltYXRpb25Db250cm9sbGVyUHJpdmF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpBbmltYXRpb25D b250cm9sbGVyUHJpdmF0ZTo6dXBkYXRlQW5pbWF0aW9uVGltZXJGb3JSZW5kZXJlcik6CisgICAg ICAgIChXZWJDb3JlOjpBbmltYXRpb25Db250cm9sbGVyUHJpdmF0ZTo6dXBkYXRlQW5pbWF0aW9u VGltZXIpOgorICAgICAgICAqIHBhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkNvbnRyb2xsZXJQcml2 YXRlLmg6CisgICAgICAgIChBbmltYXRpb25Db250cm9sbGVyUHJpdmF0ZSk6IFJlbW92ZSBtX3By ZXZpb3VzVGltZVRvTmV4dFNlcnZpY2UKKwogMjAxMy0wMS0zMCAgRG91Z2xhcyBTdG9ja3dlbGwg IDxkc3RvY2t3ZWxsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZW1vdmUgdW5uZWNlc3Nhcnkg c2V0QW5pbWF0aW5nKCkgbWV0aG9kCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2Fu aW1hdGlvbi9BbmltYXRpb25Db250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvYW5p bWF0aW9uL0FuaW1hdGlvbkNvbnRyb2xsZXIuY3BwCmluZGV4IGY5N2M5MmI2YWU4NTI2MzVjYTUw NjE4ZWU1YmI5ZjkwOTY0OWJlZjcuLjBkYjIzZjM2ODU5YzQyZWNhZDU4OGIwMmZkMDE5MGJiYzQw OTdiMWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0FuaW1hdGlv bkNvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0FuaW1h dGlvbkNvbnRyb2xsZXIuY3BwCkBAIC01OCw3ICs1OCw2IEBAIEFuaW1hdGlvbkNvbnRyb2xsZXJQ cml2YXRlOjpBbmltYXRpb25Db250cm9sbGVyUHJpdmF0ZShGcmFtZSogZnJhbWUpCiAgICAgLCBt X2FuaW1hdGlvbnNXYWl0aW5nRm9yU3R5bGUoKQogICAgICwgbV9hbmltYXRpb25zV2FpdGluZ0Zv clN0YXJ0VGltZVJlc3BvbnNlKCkKICAgICAsIG1fd2FpdGluZ0ZvckFzeW5jU3RhcnROb3RpZmlj YXRpb24oZmFsc2UpCi0gICAgLCBtX3ByZXZpb3VzVGltZVRvTmV4dFNlcnZpY2UoMCkKIHsKIH0K IApAQCAtMTI2LDE0ICsxMjUsOSBAQCB2b2lkIEFuaW1hdGlvbkNvbnRyb2xsZXJQcml2YXRlOjp1 cGRhdGVBbmltYXRpb25UaW1lckZvclJlbmRlcmVyKFJlbmRlck9iamVjdCogcgogICAgIGlmICgh Y29tcEFuaW0tPnN1c3BlbmRlZCgpICYmIGNvbXBBbmltLT5oYXNBbmltYXRpb25zKCkpCiAgICAg ICAgIHRpbWVUb05leHRTZXJ2aWNlID0gY29tcEFuaW0tPnRpbWVUb05leHRTZXJ2aWNlKCk7CiAK LSAgICBpZiAobV9hbmltYXRpb25UaW1lci5pc0FjdGl2ZSgpKSB7Ci0gICAgICAgIGlmIChtX3By ZXZpb3VzVGltZVRvTmV4dFNlcnZpY2UgPCB0aW1lVG9OZXh0U2VydmljZSkKLSAgICAgICAgICAg IHJldHVybjsKLQotICAgICAgICBtX2FuaW1hdGlvblRpbWVyLnN0b3AoKTsKLSAgICB9CisgICAg aWYgKG1fYW5pbWF0aW9uVGltZXIuaXNBY3RpdmUoKSAmJiAobV9hbmltYXRpb25UaW1lci5yZXBl YXRJbnRlcnZhbCgpIHx8IG1fYW5pbWF0aW9uVGltZXIubmV4dEZpcmVJbnRlcnZhbCgpIDw9IHRp bWVUb05leHRTZXJ2aWNlKSkKKyAgICAgICAgcmV0dXJuOwogCi0gICAgbV9wcmV2aW91c1RpbWVU b05leHRTZXJ2aWNlID0gdGltZVRvTmV4dFNlcnZpY2U7CiAgICAgbV9hbmltYXRpb25UaW1lci5z dGFydE9uZVNob3QodGltZVRvTmV4dFNlcnZpY2UpOwogfQogCkBAIC0xNDUsOCArMTM5LDYgQEAg dm9pZCBBbmltYXRpb25Db250cm9sbGVyUHJpdmF0ZTo6dXBkYXRlQW5pbWF0aW9uVGltZXIoU2V0 Q2hhbmdlZCBjYWxsU2V0Q2hhbmdlZC8KICAgICBpZiAoIXRpbWVUb05leHRTZXJ2aWNlKSB7CiAg ICAgICAgIGlmICghbV9hbmltYXRpb25UaW1lci5pc0FjdGl2ZSgpIHx8IG1fYW5pbWF0aW9uVGlt ZXIucmVwZWF0SW50ZXJ2YWwoKSA9PSAwKQogICAgICAgICAgICAgbV9hbmltYXRpb25UaW1lci5z dGFydFJlcGVhdGluZyhjQW5pbWF0aW9uVGltZXJEZWxheSk7Ci0KLSAgICAgICAgbV9wcmV2aW91 c1RpbWVUb05leHRTZXJ2aWNlID0gdGltZVRvTmV4dFNlcnZpY2U7CiAgICAgICAgIHJldHVybjsK ICAgICB9CiAKQEAgLTE1OCw5ICsxNTAsNiBAQCB2b2lkIEFuaW1hdGlvbkNvbnRyb2xsZXJQcml2 YXRlOjp1cGRhdGVBbmltYXRpb25UaW1lcihTZXRDaGFuZ2VkIGNhbGxTZXRDaGFuZ2VkLwogICAg IH0KIAogICAgIC8vIE90aGVyd2lzZSwgd2Ugd2FudCB0byBzdGFydCBhIG9uZS1zaG90IHRpbWVy IHNvIHdlIGdldCBoZXJlIGFnYWluCi0gICAgaWYgKG1fYW5pbWF0aW9uVGltZXIuaXNBY3RpdmUo KSkKLSAgICAgICAgbV9hbmltYXRpb25UaW1lci5zdG9wKCk7Ci0gICAgbV9wcmV2aW91c1RpbWVU b05leHRTZXJ2aWNlID0gdGltZVRvTmV4dFNlcnZpY2U7CiAgICAgbV9hbmltYXRpb25UaW1lci5z dGFydE9uZVNob3QodGltZVRvTmV4dFNlcnZpY2UpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9BbmltYXRpb25Db250cm9sbGVyUHJpdmF0ZS5oIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9hbmltYXRpb24vQW5pbWF0aW9uQ29udHJvbGxlclByaXZhdGUuaApp bmRleCAwN2FmYjc0ZDBhMTAzZDE0YTQ4N2YxZjY3NzI1MmNlNmM5ZDM5MmI4Li42Yzk2MGU0NTUy ODA4MmU5ZDhhNDU5NmYwNGZkM2VjZjI2NGRmM2Q2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL2FuaW1hdGlvbi9BbmltYXRpb25Db250cm9sbGVyUHJpdmF0ZS5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkNvbnRyb2xsZXJQcml2YXRlLmgKQEAg LTEzOSw3ICsxMzksNiBAQCBwcml2YXRlOgogICAgIFdhaXRpbmdBbmltYXRpb25zU2V0IG1fYW5p bWF0aW9uc1dhaXRpbmdGb3JTdHlsZTsKICAgICBXYWl0aW5nQW5pbWF0aW9uc1NldCBtX2FuaW1h dGlvbnNXYWl0aW5nRm9yU3RhcnRUaW1lUmVzcG9uc2U7CiAgICAgYm9vbCBtX3dhaXRpbmdGb3JB c3luY1N0YXJ0Tm90aWZpY2F0aW9uOwotICAgIGRvdWJsZSBtX3ByZXZpb3VzVGltZVRvTmV4dFNl cnZpY2U7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOTM4Y2Y0MmE4NzNi ODdiMTQyOGExNDA2MjNkYmJlZTIzMmEzNjE5My4uNjJiMzc1MDRlYWY5YzkyZGM1ZWFiNDNhMzQw Mzk0ZjE3YmUzMjBjMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAxLTMxICBEb3VnbGFz IFN0b2Nrd2VsbCAgPGRzdG9ja3dlbGxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJFR1JFU1NJ T04ocjExMTYzOSk6IGRlbGF5ZWQgYW5pbWF0aW9uIHN0YXJ0IGNhbiBiZSBwb3N0cG9uZWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODU4MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYW5pbWF0aW9u cy9hbmltYXRpb24tZGVsYXktY2hhbmdlZC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IGFuaW1hdGlvbnMvYW5pbWF0aW9uLWRlbGF5LWNoYW5nZWQuaHRtbDogQWRkZWQuCisKIDIwMTMt MDEtMzAgIFBoaWxpcCBSb2dlcnMgIDxwZHJAZ29vZ2xlLmNvbT4KIAogICAgICAgICAgVXBkYXRl IHN2Zy96b29tIHRlc3QgZXhwZWN0YXRpb25zIGFmdGVyIHIxNDEzMDMKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2FuaW1hdGlvbnMvYW5pbWF0aW9uLWRlbGF5LWNoYW5nZWQtZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9hbmltYXRpb24tZGVsYXktY2hhbmdlZC1leHBlY3Rl ZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uNWNjZmZmMDQwNmMzZGQ3YjE4MmM1ZmI5M2I3MzM3MGNlZTlmZjhl ZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2FuaW1hdGlvbnMvYW5pbWF0aW9uLWRl bGF5LWNoYW5nZWQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNSBAQAorc3RhcnRzIGFmdGVyIDFz CitzdGFydHMgYWZ0ZXIgMS41cworUEFTUyAtICJsZWZ0IiBwcm9wZXJ0eSBmb3IgImJveDEiIGVs ZW1lbnQgYXQgMXMgc2F3IHNvbWV0aGluZyBjbG9zZSB0bzogMjAwCitQQVNTIC0gImxlZnQiIHBy b3BlcnR5IGZvciAiYm94MiIgZWxlbWVudCBhdCAxcyBzYXcgc29tZXRoaW5nIGNsb3NlIHRvOiAx MDAKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9hbmltYXRpb24tZGVsYXkt Y2hhbmdlZC5odG1sIGIvTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9hbmltYXRpb24tZGVsYXktY2hh bmdlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjYwNjVkOGUzMDJhMWE1NDY0NTkxYTU3ZjE0Y2Q4OWYzNDNi Y2EwOTYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9hbmltYXRpb25zL2FuaW1hdGlv bi1kZWxheS1jaGFuZ2VkLmh0bWwKQEAgLTAsMCArMSw2NyBAQAorPCFkb2N0eXBlIGh0bWw+Cis8 aHRtbCBsYW5nPSJlbiI+Cis8aGVhZD4KKyAgPHN0eWxlPgorICAgIGJvZHkgeworICAgICAgbWFy Z2luOiAwOworICAgIH0KKworICAgICNib3gxLCAjYm94MiB7CisgICAgICBwb3NpdGlvbjogcmVs YXRpdmU7CisgICAgICBoZWlnaHQ6IDI1cHg7CisgICAgICB3aWR0aDogMTAwcHg7CisgICAgICBt YXJnaW46IDVweDsKKyAgICAgIGJhY2tncm91bmQ6IGxpZ2h0c3RlZWxibHVlOworICAgIH0KKwor ICAgIC5tb3ZlMSB7CisgICAgICAtd2Via2l0LWFuaW1hdGlvbi1uYW1lOiBtb3ZlMTsKKyAgICAg IC13ZWJraXQtYW5pbWF0aW9uLWRlbGF5OiAxczsKKyAgICAgIC13ZWJraXQtYW5pbWF0aW9uLWR1 cmF0aW9uOiAxczsKKyAgICAgIC13ZWJraXQtYW5pbWF0aW9uLXRpbWluZy1mdW5jdGlvbjogbGlu ZWFyOworICAgIH0KKworICAgIEAtd2Via2l0LWtleWZyYW1lcyBtb3ZlMSB7CisgICAgICBmcm9t IHsgbGVmdDogMHB4OyB9CisgICAgICB0byB7IGxlZnQ6IDIwMHB4OyB9CisgICAgfQorCisgICAg Lm1vdmUyIHsKKyAgICAgIC13ZWJraXQtYW5pbWF0aW9uLW5hbWU6IG1vdmUyOworICAgICAgLXdl YmtpdC1hbmltYXRpb24tZGVsYXk6IDFzOworICAgICAgLXdlYmtpdC1hbmltYXRpb24tZHVyYXRp b246IDFzOworICAgICAgLXdlYmtpdC1hbmltYXRpb24tdGltaW5nLWZ1bmN0aW9uOiBsaW5lYXI7 CisgICAgfQorCisgICAgQC13ZWJraXQta2V5ZnJhbWVzIG1vdmUyIHsKKyAgICAgIGZyb20geyBs ZWZ0OiAwcHg7IH0KKyAgICAgIHRvIHsgbGVmdDogMjAwcHg7IH0KKyAgICB9CisgIDwvc3R5bGU+ CisgIDxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvYW5pbWF0aW9uLXRlc3QtaGVscGVycy5qcyI+PC9z Y3JpcHQ+CisgIDxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgICB0 ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKKyAgICB9CisgICAgd2luZG93Lm9ubG9hZCA9IGZ1 bmN0aW9uKCkgeworICAgICAgZG9jdW1lbnQucXVlcnlTZWxlY3RvcignI2JveDEnKS5jbGFzc0xp c3QuYWRkKCdtb3ZlMScpOworICAgICAgLy8gU3RhcnQgdGhlIGFuaW1hdGlvbiBvbiBib3gyIGFm dGVyIDUwMG1zCisgICAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgeyBkb2N1bWVudC5xdWVyeVNl bGVjdG9yKCcjYm94MicpLmNsYXNzTGlzdC5hZGQoJ21vdmUyJyk7IH0sIDUwMCk7CisKKyAgICAg IGNvbnN0IGV4cGVjdGVkVmFsdWVzID0gWworICAgICAgICAvLyBbYW5pbWF0aW9uLW5hbWUsIHRp bWUsIGVsZW1lbnQtaWQsIHByb3BlcnR5LCBleHBlY3RlZC12YWx1ZSwgdG9sZXJhbmNlXQorICAg ICAgICBbbnVsbCwgMS4wLCAiYm94MSIsICJsZWZ0IiwgIDIwMCwgMTBdLAorICAgICAgICBbbnVs bCwgMS4wLCAiYm94MiIsICJsZWZ0IiwgIDEwMCwgMTBdLAorICAgICAgXTsKKworICAgICAgcnVu QW5pbWF0aW9uVGVzdChleHBlY3RlZFZhbHVlcyk7CisgICAgfQorICA8L3NjcmlwdD4KKzwvaGVh ZD4KKzxib2R5PgorPGRpdiBpZD0iYm94MSI+c3RhcnRzIGFmdGVyIDFzPC9kaXY+Cis8ZGl2IGlk PSJib3gyIj5zdGFydHMgYWZ0ZXIgMS41czwvZGl2PgorPGRpdiBpZD0icmVzdWx0Ij48L2Rpdj4K KzwvZGl2PgorPC9ib2R5PgorPC9odG1sPgo=