108578 2013-01-31 21:42:39 -0800 [CPP,GObject,ObjC] Add 'static' skip to CodeGenerator{CPP,GObject,ObjC}.pm 2013-02-01 00:46:01 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 nbarth webkit-unassigned abarth haraken japhet ojan.autocc webkit.review.bot oldest_to_newest 822309 0 nbarth 2013-01-31 21:42:39 -0800 Legacy code generators do not support static attributes. Fix by adding a test to skip static types. This allows us to not use macros like "#if defined(TESTING_JS) || defined(TESTING_V8)" in IDL files. Concretely it's just adding a suitable check to the SkipAttribute functions, and then removing macros from the test IDL file. 822373 1 185953 nbarth 2013-01-31 23:24:50 -0800 Created attachment 185953 Patch V. simple fix -- just check $attribute->isStatic This lets us remove macros from TestObj.idl and also TestSupplemental.idl 822377 2 185953 haraken 2013-01-31 23:28:10 -0800 Comment on attachment 185953 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185953&action=review > Source/WebCore/ChangeLog:8 > + Since legacy code generators (CodeGenerator{CPP,GObject,ObjC}.pm) Don't call them legacy. Their implementations are just behind. 822378 3 nbarth 2013-01-31 23:30:33 -0800 (In reply to comment #2) > (From update of attachment 185953 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185953&action=review > > > Source/WebCore/ChangeLog:8 > > + Since legacy code generators (CodeGenerator{CPP,GObject,ObjC}.pm) > > Don't call them legacy. Their implementations are just behind. Oops, sorry! Is there a proper name, like "lagging code generators", or should I just call them something like "CPP/GObject/ObjC"? 822379 4 haraken 2013-01-31 23:31:40 -0800 (In reply to comment #3) > or should I just call them something like "CPP/GObject/ObjC"? You can just say CPP/GObject/ObjC. We shouldn't break these bindings just like we shouldn't break JSC/V8. 822380 5 nbarth 2013-01-31 23:32:47 -0800 (In reply to comment #4) > (In reply to comment #3) > > or should I just call them something like "CPP/GObject/ObjC"? > > You can just say CPP/GObject/ObjC. We shouldn't break these bindings just like we shouldn't break JSC/V8. Ok, will do. 822386 6 185956 nbarth 2013-01-31 23:38:03 -0800 Created attachment 185956 ChangeLog wording fix Fix wording re: CPP/GObject/ObjC in ChangeLog 822387 7 185956 haraken 2013-01-31 23:38:38 -0800 Comment on attachment 185956 ChangeLog wording fix LGTM 822444 8 185956 webkit.review.bot 2013-02-01 00:45:57 -0800 Comment on attachment 185956 ChangeLog wording fix Clearing flags on attachment: 185956 Committed r141551: <http://trac.webkit.org/changeset/141551> 822445 9 webkit.review.bot 2013-02-01 00:46:01 -0800 All reviewed patches have been landed. Closing bug. 185953 2013-01-31 23:24:50 -0800 2013-01-31 23:38:00 -0800 Patch bug-108578-20130201162133.patch text/plain 5121 nbarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmYxYWI4Zjg5NmJlNTlh ZDIxM2FhZTgxMGE5MDZlNWJmMDIzNTJlNC4uYTUyOWM4NmIwNTE0NjcxYWZjOTY2MTQ2MGVjNmM0 Y2Y1ZjNmZmFhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI5IEBACiAyMDEzLTAxLTMxICBOaWxz IEJhcnRoICA8bmJhcnRoQGdvb2dsZS5jb20+CiAKKyAgICAgICAgW0NQUCxHT2JqZWN0LE9iakNd IEFkZCAnc3RhdGljJyBza2lwIHRvIENvZGVHZW5lcmF0b3J7Q1BQLEdPYmplY3QsT2JqQ30ucG0K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODU3OAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIGxl Z2FjeSBjb2RlIGdlbmVyYXRvcnMgKENvZGVHZW5lcmF0b3J7Q1BQLEdPYmplY3QsT2JqQ30ucG0p CisgICAgICAgIGRvIG5vdCBzdXBwb3J0IHN0YXRpYyBhdHRyaWJ1dGVzLCBhZGQgdGVzdCB0byBz a2lwIHRoZXNlLgorICAgICAgICBUaGlzIGxldHMgdXMgcmVtb3ZlICNpZiBtYWNybyBmcm9tIHN0 YXRpYyBpbiB0ZXN0IGZpbGVzIGFuZCBub3QgbmVlZAorICAgICAgICB0aGVzZSBpbiBmdXR1cmUu CisKKyAgICAgICAgVGVzdDogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Rlc3RPYmouaWRsIChydW4t YmluZGluZ3MtdGVzdCkKKyAgICAgICAgVGVzdDogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Rlc3RT dXBwbGVtZW50YWwuaWRsIChydW4tYmluZGluZ3MtdGVzdCkKKworICAgICAgICAqIGJpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvckNQUC5wbToKKyAgICAgICAgKFNraXBBdHRyaWJ1dGUpOgor ICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG06CisgICAg ICAgIChTa2lwQXR0cmlidXRlKToKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5l cmF0b3JPYmpDLnBtOgorICAgICAgICAoU2tpcEF0dHJpYnV0ZSk6CisgICAgICAgICogYmluZGlu Z3Mvc2NyaXB0cy90ZXN0L1Rlc3RPYmouaWRsOgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMv dGVzdC9UZXN0U3VwcGxlbWVudGFsLmlkbDoKKworMjAxMy0wMS0zMSAgTmlscyBCYXJ0aCAgPG5i YXJ0aEBnb29nbGUuY29tPgorCiAgICAgICAgIFtDUFAsR09iamVjdCxPYmpDXSBBZGQgJ2VudW0n IHNraXAgdG8gQ29kZUdlbmVyYXRvcntDUFAsR09iamVjdCxPYmpDfS5wbQogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4NTY1CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckNQUC5wbSBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckNQUC5wbQppbmRleCBh MGU4YzgxODE1NTNkZDZkMmY0MzE0N2YyMGVkMjkwMzgzNWRmYTNmLi5kNzFmMzYwMDU4ZDBhMDQx Y2QzYTIzNmU0NzY0OTE3YmM4ODZjMjUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JDUFAucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yQ1BQLnBtCkBAIC0yMDUsNyArMjA1LDcgQEAgc3Vi IFNraXBBdHRyaWJ1dGUKICAgICAgICAgICAgICAgICBvciAkYXR0cmlidXRlLT5zaWduYXR1cmUt PmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0b21HZXR0ZXIifTsKIAogICAgIHJldHVybiAxIGlm ICR0eXBlID1+IC9Db25zdHJ1Y3RvciQvOwotCisgICAgcmV0dXJuIDEgaWYgJGF0dHJpYnV0ZS0+ aXNTdGF0aWM7CiAgICAgcmV0dXJuIDEgaWYgJGNvZGVHZW5lcmF0b3ItPklzVHlwZWRBcnJheVR5 cGUoJHR5cGUpOwogCiAgICAgaWYgKCRjb2RlR2VuZXJhdG9yLT5HZXRBcnJheVR5cGUoJHR5cGUp KSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5l cmF0b3JHT2JqZWN0LnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9yR09iamVjdC5wbQppbmRleCAzMWI4NTM2NzQzZTRkNDM1YmQ2ZGI4YjdlZDEyYjYzZGU2 ZDU4N2RkLi41M2IzZWFkYTMyOWZmZmRhYjQ5MGU5ZjExMjY0NWMwYjBjODBkOTkzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0 LnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdP YmplY3QucG0KQEAgLTE3OSw2ICsxNzksNyBAQCBzdWIgU2tpcEF0dHJpYnV0ZSB7CiAgICAgICAg IHJldHVybiAxOwogICAgIH0KIAorICAgIHJldHVybiAxIGlmICRhdHRyaWJ1dGUtPmlzU3RhdGlj OwogICAgIHJldHVybiAxIGlmICRjb2RlR2VuZXJhdG9yLT5Jc1R5cGVkQXJyYXlUeXBlKCRwcm9w VHlwZSk7CiAKICAgICAkY29kZUdlbmVyYXRvci0+QXNzZXJ0Tm90U2VxdWVuY2VUeXBlKCRwcm9w VHlwZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVH ZW5lcmF0b3JPYmpDLnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9yT2JqQy5wbQppbmRleCBhMzAwMDI3NTA2NzE1MDE3YThiYjIzZGY5MzE2ZTc1ZGM2OWUw MGQwLi5mMTQzMGQzOWNmYmY3NjE3MDg5NWQxYjBjOGU5ZTc0ZjhmMGIzNGRmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JPYmpDLnBtCisr KyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvck9iakMucG0K QEAgLTQ1Miw2ICs0NTIsNyBAQCBzdWIgU2tpcEF0dHJpYnV0ZQogICAgIHJldHVybiAxIGlmICRj b2RlR2VuZXJhdG9yLT5HZXRBcnJheVR5cGUoJHR5cGUpOwogICAgIHJldHVybiAxIGlmICRjb2Rl R2VuZXJhdG9yLT5Jc1R5cGVkQXJyYXlUeXBlKCR0eXBlKTsKICAgICByZXR1cm4gMSBpZiAkY29k ZUdlbmVyYXRvci0+SXNFbnVtVHlwZSgkdHlwZSk7CisgICAgcmV0dXJuIDEgaWYgJGF0dHJpYnV0 ZS0+aXNTdGF0aWM7CiAKICAgICAjIFRoaXMgaXMgZm9yIER5bmFtaWNzQ29tcHJlc3Nvck5vZGUu aWRsCiAgICAgaWYgKCRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+bmFtZSBlcSAicmVsZWFzZSIpIHsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9UZXN0T2Jq LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9UZXN0T2JqLmlkbApp bmRleCBiYWZhM2E1MWQ1NDU1ZGJmZGJhZmM3ZDJhNDAxMzdhNjhkZTVjYmZlLi5jMDYzMGUzNzJj ZTZkN2U0MGIxMjJkOTJjYWJhZjZkMjk2ZmZmZTQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVGVzdE9iai5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Rlc3RPYmouaWRsCkBAIC00MCwxMSArNDAsOSBAQCBlbnVt IFRlc3RFbnVtVHlwZSB7ICIiLCAiRW51bVZhbHVlMSIsICJFbnVtVmFsdWUyIiwgIkVudW1WYWx1 ZTMiIH07CiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIGxvbmcgICAgICAgICAgICByZWFkT25seUxv bmdBdHRyOwogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcgICAgICAgcmVhZE9ubHlT dHJpbmdBdHRyOwogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBUZXN0T2JqICAgICAgICAgcmVhZE9u bHlUZXN0T2JqQXR0cjsKLSNpZiBkZWZpbmVkKFRFU1RJTkdfSlMpIHx8IGRlZmluZWQoVEVTVElO R19WOCkKICAgICBzdGF0aWMgcmVhZG9ubHkgYXR0cmlidXRlIGxvbmcgICAgIHN0YXRpY1JlYWRP bmx5TG9uZ0F0dHI7CiAgICAgc3RhdGljIGF0dHJpYnV0ZSBET01TdHJpbmcgICAgICAgICBzdGF0 aWNTdHJpbmdBdHRyOwogICAgIHN0YXRpYyByZWFkb25seSBhdHRyaWJ1dGUgVGVzdFN1Yk9iakNv bnN0cnVjdG9yIFRlc3RTdWJPYmo7Ci0jZW5kaWYKICAgICBhdHRyaWJ1dGUgVGVzdEVudW1UeXBl ICAgICAgICAgICAgIGVudW1BdHRyOwogICAgIGF0dHJpYnV0ZSBzaG9ydCAgICAgICAgICAgICAg ICAgICAgc2hvcnRBdHRyOwogICAgIGF0dHJpYnV0ZSB1bnNpZ25lZCBzaG9ydCAgICAgICAgICAg dW5zaWduZWRTaG9ydEF0dHI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL3Rlc3QvVGVzdFN1cHBsZW1lbnRhbC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9zY3JpcHRzL3Rlc3QvVGVzdFN1cHBsZW1lbnRhbC5pZGwKaW5kZXggMWVkMzBkZDViMDFjYzY3 ZDkxNzc5MjBiYzU0NjkwMDQ2MDk2NTNkNS4uZDg4YTZjYzUzYjE0Y2NiZjU0M2UzMmVkOWYzMmZm MTFiN2MxOWQzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90 ZXN0L1Rlc3RTdXBwbGVtZW50YWwuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Nj cmlwdHMvdGVzdC9UZXN0U3VwcGxlbWVudGFsLmlkbApAQCAtMzIsMTAgKzMyLDggQEAKICAgICBD b25kaXRpb25hbD1Db25kaXRpb24xMXxDb25kaXRpb24xMiwKICAgICBTdXBwbGVtZW50YWw9VGVz dEludGVyZmFjZQogXSBpbnRlcmZhY2UgVGVzdFN1cHBsZW1lbnRhbCB7Ci0jaWYgZGVmaW5lZChU RVNUSU5HX0pTKSB8fCBkZWZpbmVkKFRFU1RJTkdfVjgpCiAgICAgc3RhdGljIHJlYWRvbmx5IGF0 dHJpYnV0ZSBsb25nIHN1cHBsZW1lbnRhbFN0YXRpY1JlYWRPbmx5QXR0cjsKICAgICBzdGF0aWMg YXR0cmlidXRlIERPTVN0cmluZyBzdXBwbGVtZW50YWxTdGF0aWNBdHRyOwotI2VuZGlmCiAgICAg cmVhZG9ubHkgYXR0cmlidXRlIERPTVN0cmluZyBzdXBwbGVtZW50YWxTdHIxOwogICAgIGF0dHJp YnV0ZSBET01TdHJpbmcgc3VwcGxlbWVudGFsU3RyMjsKICAgICBbQ3VzdG9tR2V0dGVyLCBDdXN0 b21TZXR0ZXJdIGF0dHJpYnV0ZSBET01TdHJpbmcgc3VwcGxlbWVudGFsU3RyMzsK 185956 2013-01-31 23:38:03 -0800 2013-02-01 00:45:57 -0800 ChangeLog wording fix bug-108578-20130201163446.patch text/plain 5131 nbarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmYxYWI4Zjg5NmJlNTlh ZDIxM2FhZTgxMGE5MDZlNWJmMDIzNTJlNC4uOWVjNWQyODcwZGYwY2RiYjE1NjNjODQzMDQ1ZTdk NDU3YjdlMzJkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI5IEBACiAyMDEzLTAxLTMxICBOaWxz IEJhcnRoICA8bmJhcnRoQGdvb2dsZS5jb20+CiAKKyAgICAgICAgW0NQUCxHT2JqZWN0LE9iakNd IEFkZCAnc3RhdGljJyBza2lwIHRvIENvZGVHZW5lcmF0b3J7Q1BQLEdPYmplY3QsT2JqQ30ucG0K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODU3OAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIENQ UC9HT2JqZWN0L09iakMgY29kZSBnZW5lcmF0b3JzIChDb2RlR2VuZXJhdG9ye0NQUCxHT2JqZWN0 LE9iakN9LnBtKQorICAgICAgICBkbyBub3Qgc3VwcG9ydCBzdGF0aWMgYXR0cmlidXRlcywgYWRk IHRlc3QgdG8gc2tpcCB0aGVzZS4KKyAgICAgICAgVGhpcyBsZXRzIHVzIHJlbW92ZSAjaWYgbWFj cm8gZnJvbSBzdGF0aWMgaW4gdGVzdCBmaWxlcyBhbmQgbm90IG5lZWQKKyAgICAgICAgdGhlc2Ug aW4gZnV0dXJlLgorCisgICAgICAgIFRlc3Q6IGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9UZXN0T2Jq LmlkbCAocnVuLWJpbmRpbmdzLXRlc3QpCisgICAgICAgIFRlc3Q6IGJpbmRpbmdzL3NjcmlwdHMv dGVzdC9UZXN0U3VwcGxlbWVudGFsLmlkbCAocnVuLWJpbmRpbmdzLXRlc3QpCisKKyAgICAgICAg KiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JDUFAucG06CisgICAgICAgIChTa2lwQXR0 cmlidXRlKToKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0 LnBtOgorICAgICAgICAoU2tpcEF0dHJpYnV0ZSk6CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9yT2JqQy5wbToKKyAgICAgICAgKFNraXBBdHRyaWJ1dGUpOgorICAgICAg ICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9UZXN0T2JqLmlkbDoKKyAgICAgICAgKiBiaW5kaW5n cy9zY3JpcHRzL3Rlc3QvVGVzdFN1cHBsZW1lbnRhbC5pZGw6CisKKzIwMTMtMDEtMzEgIE5pbHMg QmFydGggIDxuYmFydGhAZ29vZ2xlLmNvbT4KKwogICAgICAgICBbQ1BQLEdPYmplY3QsT2JqQ10g QWRkICdlbnVtJyBza2lwIHRvIENvZGVHZW5lcmF0b3J7Q1BQLEdPYmplY3QsT2JqQ30ucG0KICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODU2NQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JD UFAucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JDUFAu cG0KaW5kZXggYTBlOGM4MTgxNTUzZGQ2ZDJmNDMxNDdmMjBlZDI5MDM4MzVkZmEzZi4uZDcxZjM2 MDA1OGQwYTA0MWNkM2EyMzZlNDc2NDkxN2JjODg2YzI1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yQ1BQLnBtCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckNQUC5wbQpAQCAtMjA1LDcgKzIw NSw3IEBAIHN1YiBTa2lwQXR0cmlidXRlCiAgICAgICAgICAgICAgICAgb3IgJGF0dHJpYnV0ZS0+ c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ3VzdG9tR2V0dGVyIn07CiAKICAgICBy ZXR1cm4gMSBpZiAkdHlwZSA9fiAvQ29uc3RydWN0b3IkLzsKLQorICAgIHJldHVybiAxIGlmICRh dHRyaWJ1dGUtPmlzU3RhdGljOwogICAgIHJldHVybiAxIGlmICRjb2RlR2VuZXJhdG9yLT5Jc1R5 cGVkQXJyYXlUeXBlKCR0eXBlKTsKIAogICAgIGlmICgkY29kZUdlbmVyYXRvci0+R2V0QXJyYXlU eXBlKCR0eXBlKSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0KaW5kZXggMzFiODUzNjc0M2U0ZDQzNWJkNmRiOGI3 ZWQxMmI2M2RlNmQ1ODdkZC4uNTNiM2VhZGEzMjlmZmZkYWI0OTBlOWYxMTI2NDVjMGIwYzgwZDk5 MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJh dG9yR09iamVjdC5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVH ZW5lcmF0b3JHT2JqZWN0LnBtCkBAIC0xNzksNiArMTc5LDcgQEAgc3ViIFNraXBBdHRyaWJ1dGUg ewogICAgICAgICByZXR1cm4gMTsKICAgICB9CiAKKyAgICByZXR1cm4gMSBpZiAkYXR0cmlidXRl LT5pc1N0YXRpYzsKICAgICByZXR1cm4gMSBpZiAkY29kZUdlbmVyYXRvci0+SXNUeXBlZEFycmF5 VHlwZSgkcHJvcFR5cGUpOwogCiAgICAgJGNvZGVHZW5lcmF0b3ItPkFzc2VydE5vdFNlcXVlbmNl VHlwZSgkcHJvcFR5cGUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy9Db2RlR2VuZXJhdG9yT2JqQy5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvQ29kZUdlbmVyYXRvck9iakMucG0KaW5kZXggYTMwMDAyNzUwNjcxNTAxN2E4YmIyM2RmOTMx NmU3NWRjNjllMDBkMC4uZjE0MzBkMzljZmJmNzYxNzA4OTVkMWIwYzhlOWU3NGY4ZjBiMzRkZiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9y T2JqQy5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0 b3JPYmpDLnBtCkBAIC00NTIsNiArNDUyLDcgQEAgc3ViIFNraXBBdHRyaWJ1dGUKICAgICByZXR1 cm4gMSBpZiAkY29kZUdlbmVyYXRvci0+R2V0QXJyYXlUeXBlKCR0eXBlKTsKICAgICByZXR1cm4g MSBpZiAkY29kZUdlbmVyYXRvci0+SXNUeXBlZEFycmF5VHlwZSgkdHlwZSk7CiAgICAgcmV0dXJu IDEgaWYgJGNvZGVHZW5lcmF0b3ItPklzRW51bVR5cGUoJHR5cGUpOworICAgIHJldHVybiAxIGlm ICRhdHRyaWJ1dGUtPmlzU3RhdGljOwogCiAgICAgIyBUaGlzIGlzIGZvciBEeW5hbWljc0NvbXBy ZXNzb3JOb2RlLmlkbAogICAgIGlmICgkYXR0cmlidXRlLT5zaWduYXR1cmUtPm5hbWUgZXEgInJl bGVhc2UiKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rl c3QvVGVzdE9iai5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVGVz dE9iai5pZGwKaW5kZXggYmFmYTNhNTFkNTQ1NWRiZmRiYWZjN2QyYTQwMTM3YTY4ZGU1Y2JmZS4u YzA2MzBlMzcyY2U2ZDdlNDBiMTIyZDkyY2FiYWY2ZDI5NmZmZmU0OCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Rlc3RPYmouaWRsCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9UZXN0T2JqLmlkbApAQCAtNDAsMTEgKzQw LDkgQEAgZW51bSBUZXN0RW51bVR5cGUgeyAiIiwgIkVudW1WYWx1ZTEiLCAiRW51bVZhbHVlMiIs ICJFbnVtVmFsdWUzIiB9OwogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBsb25nICAgICAgICAgICAg cmVhZE9ubHlMb25nQXR0cjsKICAgICByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3RyaW5nICAgICAg IHJlYWRPbmx5U3RyaW5nQXR0cjsKICAgICByZWFkb25seSBhdHRyaWJ1dGUgVGVzdE9iaiAgICAg ICAgIHJlYWRPbmx5VGVzdE9iakF0dHI7Ci0jaWYgZGVmaW5lZChURVNUSU5HX0pTKSB8fCBkZWZp bmVkKFRFU1RJTkdfVjgpCiAgICAgc3RhdGljIHJlYWRvbmx5IGF0dHJpYnV0ZSBsb25nICAgICBz dGF0aWNSZWFkT25seUxvbmdBdHRyOwogICAgIHN0YXRpYyBhdHRyaWJ1dGUgRE9NU3RyaW5nICAg ICAgICAgc3RhdGljU3RyaW5nQXR0cjsKICAgICBzdGF0aWMgcmVhZG9ubHkgYXR0cmlidXRlIFRl c3RTdWJPYmpDb25zdHJ1Y3RvciBUZXN0U3ViT2JqOwotI2VuZGlmCiAgICAgYXR0cmlidXRlIFRl c3RFbnVtVHlwZSAgICAgICAgICAgICBlbnVtQXR0cjsKICAgICBhdHRyaWJ1dGUgc2hvcnQgICAg ICAgICAgICAgICAgICAgIHNob3J0QXR0cjsKICAgICBhdHRyaWJ1dGUgdW5zaWduZWQgc2hvcnQg ICAgICAgICAgIHVuc2lnbmVkU2hvcnRBdHRyOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Rlc3RTdXBwbGVtZW50YWwuaWRsIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Rlc3RTdXBwbGVtZW50YWwuaWRsCmluZGV4IDFlZDMw ZGQ1YjAxY2M2N2Q5MTc3OTIwYmM1NDY5MDA0NjA5NjUzZDUuLmQ4OGE2Y2M1M2IxNGNjYmY1NDNl MzJlZDlmMzJmZjExYjdjMTlkM2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvdGVzdC9UZXN0U3VwcGxlbWVudGFsLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL3Rlc3QvVGVzdFN1cHBsZW1lbnRhbC5pZGwKQEAgLTMyLDEwICszMiw4 IEBACiAgICAgQ29uZGl0aW9uYWw9Q29uZGl0aW9uMTF8Q29uZGl0aW9uMTIsCiAgICAgU3VwcGxl bWVudGFsPVRlc3RJbnRlcmZhY2UKIF0gaW50ZXJmYWNlIFRlc3RTdXBwbGVtZW50YWwgewotI2lm IGRlZmluZWQoVEVTVElOR19KUykgfHwgZGVmaW5lZChURVNUSU5HX1Y4KQogICAgIHN0YXRpYyBy ZWFkb25seSBhdHRyaWJ1dGUgbG9uZyBzdXBwbGVtZW50YWxTdGF0aWNSZWFkT25seUF0dHI7CiAg ICAgc3RhdGljIGF0dHJpYnV0ZSBET01TdHJpbmcgc3VwcGxlbWVudGFsU3RhdGljQXR0cjsKLSNl bmRpZgogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcgc3VwcGxlbWVudGFsU3RyMTsK ICAgICBhdHRyaWJ1dGUgRE9NU3RyaW5nIHN1cHBsZW1lbnRhbFN0cjI7CiAgICAgW0N1c3RvbUdl dHRlciwgQ3VzdG9tU2V0dGVyXSBhdHRyaWJ1dGUgRE9NU3RyaW5nIHN1cHBsZW1lbnRhbFN0cjM7 Cg==