108575 2013-01-31 21:27:14 -0800 Web Inspector: Use String.prototype.startsWith instead of String.prototype.indexOf when possible 2013-02-01 00:21:12 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 vsevik vsevik apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 822296 0 vsevik 2013-01-31 21:27:14 -0800 It is faster and more readable. Patch to follow 822308 1 185939 vsevik 2013-01-31 21:41:33 -0800 Created attachment 185939 Patch 822420 2 185939 webkit.review.bot 2013-02-01 00:21:09 -0800 Comment on attachment 185939 Patch Clearing flags on attachment: 185939 Committed r141547: <http://trac.webkit.org/changeset/141547> 822421 3 webkit.review.bot 2013-02-01 00:21:12 -0800 All reviewed patches have been landed. Closing bug. 185939 2013-01-31 21:41:33 -0800 2013-02-01 00:21:09 -0800 Patch bug-108575-20130201093816.patch text/plain 7478 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzhlNjYyNWUwM2Q4YThm YjAxOGY5MzZhM2Y2NjZlNzBkZDQxOWI1MC4uZDQzN2RkMWVlZTMzOTUxYzE4MGM3MzBlYjMxOTBj OWI3OTI0ZDA4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAxLTMxICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFVzZSBTdHJpbmcucHJvdG90eXBlLnN0YXJ0c1dpdGggaW5zdGVhZCBvZiBTdHJpbmcucHJv dG90eXBlLmluZGV4T2Ygd2hlbiBwb3NzaWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4NTc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0ZpbGVNYXBwaW5nLmpz OgorICAgICAgICAoV2ViSW5zcGVjdG9yLkZpbGVNYXBwaW5nLnByb3RvdHlwZS5fZW50cnlNYXRj aGVzVVJMKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5GaWxlTWFwcGluZy5wcm90b3R5cGUudXJs Rm9yVVJJKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0ZpbGVTeXN0ZW1NYXBwaW5n LmpzOgorICAgICAgICAoZ2V0IFdlYkluc3BlY3Rvci5GaWxlU3lzdGVtTWFwcGluZ0ltcGwucHJv dG90eXBlLmZpbGVGb3JVUkkpOgorICAgICAgICAoZ2V0IFdlYkluc3BlY3Rvci5GaWxlU3lzdGVt TWFwcGluZ0ltcGwucHJvdG90eXBlLnVyaUZvclBhdGgpOgorCiAyMDEzLTAxLTMxICBLZW50IFRh bXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZWZhY3RvcmluZzogUmVtb3Zl IHRoZSBkZWZhdWx0IGFyZ3VtZW50IHZhbHVlIGZvciBOb2RlOjpzZXRGb2N1cwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9GaWxlTWFwcGluZy5qcyBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRmlsZU1hcHBpbmcuanMKaW5kZXggYjM0 N2NmNzc3MjVkMmM5MDU2ZTRjMDcxNzA4Y2M4MWVkNjcyZTgwMy4uNDVhZWE3ZjQ2ZjU0ZDYwZmU1 MzNhNjcxMGIxMDY2NmQzYTc5ODU4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9GaWxlTWFwcGluZy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL0ZpbGVNYXBwaW5nLmpzCkBAIC00OSw3ICs0OSw3IEBAIFdlYkluc3BlY3Rv ci5GaWxlTWFwcGluZy5wcm90b3R5cGUgPSB7CiAgICAgICovCiAgICAgX2VudHJ5TWF0Y2hlc1VS TDogZnVuY3Rpb24oZW50cnksIHVybCkKICAgICB7Ci0gICAgICAgIHJldHVybiB1cmwuaW5kZXhP ZihlbnRyeS51cmxQcmVmaXgpID09PSAwOworICAgICAgICByZXR1cm4gdXJsLnN0YXJ0c1dpdGgo ZW50cnkudXJsUHJlZml4KTsKICAgICB9LAogICAgIAogICAgIC8qKgpAQCAtMTA0LDcgKzEwNCw3 IEBAIFdlYkluc3BlY3Rvci5GaWxlTWFwcGluZy5wcm90b3R5cGUgPSB7CiAgICAgICAgIGZvciAo dmFyIGkgPSAwOyBpIDwgdGhpcy5fZW50cmllcy5sZW5ndGg7ICsraSkgewogICAgICAgICAgICAg dmFyIGVudHJ5ID0gdGhpcy5fZW50cmllc1tpXTsKICAgICAgICAgICAgIHZhciB1cmlQcmVmaXgg PSB0aGlzLl9lbnRyeVVSSVByZWZpeChlbnRyeSk7Ci0gICAgICAgICAgICBpZiAodXJpUHJlZml4 ICYmIHVyaS5pbmRleE9mKHVyaVByZWZpeCkgPT09IDApCisgICAgICAgICAgICBpZiAodXJpUHJl Zml4ICYmIHVyaS5zdGFydHNXaXRoKHVyaVByZWZpeCkpCiAgICAgICAgICAgICAgICAgcmV0dXJu IGVudHJ5LnVybFByZWZpeCArIHVyaS5zdWJzdHJpbmcodXJpUHJlZml4Lmxlbmd0aCk7CiAgICAg ICAgIH0KICAgICAgICAgcmV0dXJuICIiOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9GaWxlU3lzdGVtTWFwcGluZy5qcyBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvRmlsZVN5c3RlbU1hcHBpbmcuanMKaW5kZXggM2IxMWU1MDJkNDFi MmVhZjFmOGJmOGVhODQxOTYyNDA3NDliZDc3OS4uZjFkZGJiZTkzZmEwMTVmMzUwMDlhNDliMmU4 NTZiMTEyMTE0YzY0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9GaWxlU3lzdGVtTWFwcGluZy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0ZpbGVTeXN0ZW1NYXBwaW5nLmpzCkBAIC0xNjQsNyArMTY0LDcgQEAgV2ViSW5z cGVjdG9yLkZpbGVTeXN0ZW1NYXBwaW5nSW1wbC5wcm90b3R5cGUgPSB7CiAgICAgewogICAgICAg ICBmb3IgKHZhciBmaWxlU3lzdGVtUGF0aCBpbiB0aGlzLl9tYXBwZWROYW1lcykgewogICAgICAg ICAgICAgdmFyIHVyaVByZWZpeCA9IHRoaXMuX3VyaVByZWZpeEZvck1hcHBlZE5hbWUodGhpcy5f bWFwcGVkTmFtZXNbZmlsZVN5c3RlbVBhdGhdKTsKLSAgICAgICAgICAgIGlmICh1cmkuaW5kZXhP Zih1cmlQcmVmaXgpID09PSAwKQorICAgICAgICAgICAgaWYgKHVyaS5zdGFydHNXaXRoKHVyaVBy ZWZpeCkpCiAgICAgICAgICAgICAgICAgcmV0dXJuIG5ldyBXZWJJbnNwZWN0b3IuRmlsZVN5c3Rl bU1hcHBpbmcuRmlsZURlc2NyaXB0b3IoZmlsZVN5c3RlbVBhdGgsICIvIiArIHVyaS5zdWJzdHJp bmcodXJpUHJlZml4Lmxlbmd0aCkpOwogICAgICAgICB9CiAgICAgICAgIHJldHVybiBudWxsOwpA QCAtMTg3LDcgKzE4Nyw3IEBAIFdlYkluc3BlY3Rvci5GaWxlU3lzdGVtTWFwcGluZ0ltcGwucHJv dG90eXBlID0gewogICAgIHVyaUZvclBhdGg6IGZ1bmN0aW9uKHBhdGgpCiAgICAgewogICAgICAg ICBmb3IgKHZhciBmaWxlU3lzdGVtUGF0aCBpbiB0aGlzLl9tYXBwZWROYW1lcykgewotICAgICAg ICAgICAgaWYgKHBhdGguaW5kZXhPZihmaWxlU3lzdGVtUGF0aCkgPT09IDApIHsKKyAgICAgICAg ICAgIGlmIChwYXRoLnN0YXJ0c1dpdGgoZmlsZVN5c3RlbVBhdGgpKSB7CiAgICAgICAgICAgICAg ICAgdmFyIHVyaVByZWZpeCA9IHRoaXMuX3VyaVByZWZpeEZvck1hcHBlZE5hbWUodGhpcy5fbWFw cGVkTmFtZXNbZmlsZVN5c3RlbVBhdGhdKTsKICAgICAgICAgICAgICAgICB2YXIgc3ViUGF0aCA9 IHBhdGguc3Vic3RyaW5nKGZpbGVTeXN0ZW1QYXRoLmxlbmd0aCk7CiAgICAgICAgICAgICAgICAg aWYgKHN1YlBhdGgubGVuZ3RoID09PSAwKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDJjYmJhNjEzMzFiNGE2NDhmMzNiOTUw YTI3ODA1NmNhNzEyMjUwNTEuLjk0Yzc0OTM1ZGExNGIwMWZkNzY0YTg5Mzg5MGE2Njg2ZGJmMmE5 NDggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMy0wMS0zMSAgVnNldm9sb2QgVmxhc292ICA8 dnNldmlrQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBVc2UgU3RyaW5n LnByb3RvdHlwZS5zdGFydHNXaXRoIGluc3RlYWQgb2YgU3RyaW5nLnByb3RvdHlwZS5pbmRleE9m IHdoZW4gcG9zc2libGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwODU3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogaHR0cC90ZXN0cy9pbnNwZWN0b3IvY29uc29sZS1jZC1jb21wbGV0aW9ucy5odG1s OgorICAgICAgICAqIGh0dHAvdGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUtY2QuaHRtbDoKKyAgICAg ICAgKiBodHRwL3Rlc3RzL2luc3BlY3Rvci9pbmRleGVkZGIvaW5kZXhlZGRiLXRlc3QuanM6Cisg ICAgICAgIChpbml0aWFsaXplX0luZGV4ZWREQlRlc3QuSW5zcGVjdG9yVGVzdC5faW5zdGFsbElu ZGV4ZWREQlNuaWZmZXIuY29uc29sZU1lc3NhZ2VPdmVycmlkZSk6CisgICAgICAgIChpbml0aWFs aXplX0luZGV4ZWREQlRlc3QuSW5zcGVjdG9yVGVzdC5faW5zdGFsbEluZGV4ZWREQlNuaWZmZXIp OgorICAgICAgICAqIGluc3BlY3Rvci9uZXR3b3JrLXN0YXR1cy1ub24taHR0cC5odG1sOgorCiAy MDEzLTAxLTMxICBIYWppbWUgTW9ycml0YSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KIAogICAgICAg ICBbQ2hyb21pdW1dIFVucmV2aWV3ZWQsIHJlYmFzZWxpbmluZyBleHBlY3RhdGlvbnMuCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9jb25zb2xlLWNkLWNvbXBs ZXRpb25zLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9jb25zb2xlLWNk LWNvbXBsZXRpb25zLmh0bWwKaW5kZXggNTQ0YTk2MjkyZDcyODU4MGQ2Nzk0OTM4NGU0OTIzMGVh NmNkNjUwNi4uYzUxNGNhYTgzODA1NjM4NjMxOTM5MTUyNWVjYmU0NWQ5MzIyYTgxNyAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvY29uc29sZS1jZC1jb21wbGV0 aW9ucy5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUt Y2QtY29tcGxldGlvbnMuaHRtbApAQCAtMTAsNyArMTAsNyBAQCBmdW5jdGlvbiB0ZXN0KCkKICAg ICB2YXIgc2VsZWN0b3IgPSBXZWJJbnNwZWN0b3IuY29uc29sZVZpZXcuX2ZyYW1lU2VsZWN0b3Iu X3NlbGVjdEVsZW1lbnQ7CiAgICAgdmFyIG9wdGlvbiA9IHNlbGVjdG9yLmZpcnN0Q2hpbGQ7CiAg ICAgd2hpbGUgKG9wdGlvbikgewotICAgICAgICBpZiAob3B0aW9uLnRleHRDb250ZW50ICYmIG9w dGlvbi50ZXh0Q29udGVudC5pbmRleE9mKCJteUlGcmFtZSIpID09PSAwKQorICAgICAgICBpZiAo b3B0aW9uLnRleHRDb250ZW50ICYmIG9wdGlvbi50ZXh0Q29udGVudC5zdGFydHNXaXRoKCJteUlG cmFtZSIpKQogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIG9wdGlvbiA9IG9wdGlvbi5uZXh0 U2libGluZzsKICAgICB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3Bl Y3Rvci9jb25zb2xlLWNkLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9j b25zb2xlLWNkLmh0bWwKaW5kZXggMThiODZlYTRlYzZmYmY4N2Y0MjNjOTI0Yjk1MzdjYzdiNmZm ZmMwOS4uMjQ4MGZjYWNhNmJmOGY4YmM5MTVjNmZkYmYwODExYzE4ZjA3OGM1MCAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvY29uc29sZS1jZC5odG1sCisrKyBi L0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUtY2QuaHRtbApAQCAtMTEs NyArMTEsNyBAQCBmdW5jdGlvbiB0ZXN0KCkKICAgICB2YXIgc2VsZWN0b3IgPSBXZWJJbnNwZWN0 b3IuY29uc29sZVZpZXcuX2ZyYW1lU2VsZWN0b3IuX3NlbGVjdEVsZW1lbnQ7CiAgICAgdmFyIG9w dGlvbiA9IHNlbGVjdG9yLmZpcnN0Q2hpbGQ7CiAgICAgd2hpbGUgKG9wdGlvbikgewotICAgICAg ICBpZiAob3B0aW9uLnRleHRDb250ZW50ICYmIG9wdGlvbi50ZXh0Q29udGVudC5pbmRleE9mKCJt eUlGcmFtZSIpID09PSAwKQorICAgICAgICBpZiAob3B0aW9uLnRleHRDb250ZW50ICYmIG9wdGlv bi50ZXh0Q29udGVudC5zdGFydHNXaXRoKCJteUlGcmFtZSIpKQogICAgICAgICAgICAgYnJlYWs7 CiAgICAgICAgIG9wdGlvbiA9IG9wdGlvbi5uZXh0U2libGluZzsKICAgICB9CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9pbmRleGVkZGIvaW5kZXhlZGRiLXRl c3QuanMgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9pbmRleGVkZGIvaW5kZXhl ZGRiLXRlc3QuanMKaW5kZXggOWMzMTk2ZWFmZDIwMDA5OWE2NDA4YzAyZGYwZjdjOGRmMDQ1NzNh ZC4uOGFhNjc5NjMxYjJhZTExOGY5NjcxMWQwZjg1YzYzMjVmOTNkYWU1MSAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvaW5kZXhlZGRiL2luZGV4ZWRkYi10ZXN0 LmpzCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2luZGV4ZWRkYi9pbmRl eGVkZGItdGVzdC5qcwpAQCAtNTMsNyArNTMsNyBAQCBJbnNwZWN0b3JUZXN0Ll9pbnN0YWxsSW5k ZXhlZERCU25pZmZlciA9IGZ1bmN0aW9uKCkKICAgICBmdW5jdGlvbiBjb25zb2xlTWVzc2FnZU92 ZXJyaWRlKG1zZykKICAgICB7CiAgICAgICAgIHZhciB0ZXh0ID0gbXNnLl9tZXNzYWdlVGV4dDsK LSAgICAgICAgaWYgKHRleHQuaW5kZXhPZihjYWxsYmFja0lkUHJlZml4KSAhPT0gMCkgeworICAg ICAgICBpZiAoIXRleHQuc3RhcnRzV2l0aChjYWxsYmFja0lkUHJlZml4KSkgewogICAgICAgICAg ICAgSW5zcGVjdG9yVGVzdC5hZGRDb25zb2xlU25pZmZlcihjb25zb2xlTWVzc2FnZU92ZXJyaWRl LCBmYWxzZSk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2luc3BlY3Rvci9uZXR3b3JrLXN0YXR1cy1ub24taHR0cC5odG1sIGIvTGF5b3V0 VGVzdHMvaW5zcGVjdG9yL25ldHdvcmstc3RhdHVzLW5vbi1odHRwLmh0bWwKaW5kZXggMTEyY2Fi MWM1YzllOTFhNGQzMTYxMDkxMjc3NmRjYjE5MTVhMDBjZS4uZDRhOGUzMTIxNWUzZTQ0YWY3NjEw YzU2OGRiMGYwMmU4NmFjNWRjMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL25l dHdvcmstc3RhdHVzLW5vbi1odHRwLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL25l dHdvcmstc3RhdHVzLW5vbi1odHRwLmh0bWwKQEAgLTIxLDcgKzIxLDcgQEAgZnVuY3Rpb24gdGVz dCgpIHsKICAgICAgICAgICAgICAgICB2YXIgc3RhdHVzID0gZG9jdW1lbnQuZXZhbHVhdGUoImFu Y2VzdG9yOjp0ci90ZFtwb3NpdGlvbigpPTNdIiwgdXJscy5zbmFwc2hvdEl0ZW0oaSksIG51bGws IFhQYXRoUmVzdWx0LlNUUklOR19UWVBFLCBudWxsKTsKICAgICAgICAgICAgICAgICB2YXIgb3V0 cHV0U3RhdHVzID0gc3RhdHVzLnN0cmluZ1ZhbHVlOwogICAgICAgICAgICAgICAgIC8vIFRydW5j YXRlIHRoZSBzdGF0dXMgc3RyaW5nIG9uIGZhaWx1cmUsIHNpbmNlIHRoZSBkZXNjcmlwdGlvbiBm b2xsb3dpbmcgIihmYWlsZWQpIiBpcyBwbGF0Zm9ybS1kZXBlbmRlbnQuCi0gICAgICAgICAgICAg ICAgaWYgKG91dHB1dFN0YXR1cy5pbmRleE9mKCIoZmFpbGVkKSIpID09IDApCisgICAgICAgICAg ICAgICAgaWYgKG91dHB1dFN0YXR1cy5zdGFydHNXaXRoKCIoZmFpbGVkKSIpKQogICAgICAgICAg ICAgICAgICAgICBvdXRwdXRTdGF0dXMgPSAiKGZhaWxlZCkiOwogICAgICAgICAgICAgICAgIG91 dHB1dFN0cmluZ3MucHVzaCh1cmxGcmFnbWVudCArICI6ICIgKyBvdXRwdXRTdGF0dXMpOwogICAg ICAgICAgICAgfQo=