108569 2013-01-31 20:44:05 -0800 PrettyPatch/prettify.rb doesn't specify a load path for PrettyPatch.rb, & hard-codes the system ruby 2013-02-01 14:47:53 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 0 ndevries webkit-unassigned dglazkov joepeck webkit.review.bot oldest_to_newest 822271 0 ndevries 2013-01-31 20:44:05 -0800 You should be able to run prettify.rb from any working directory, and it shouldn't hard-code the system ruby path. 822278 1 185926 ndevries 2013-01-31 20:56:26 -0800 Created attachment 185926 Adds the directory containing prettify.rb to the $LOAD_PATH, and uses `env` to determine the ruby executable to use. 822282 2 185926 joepeck 2013-01-31 21:02:59 -0800 Comment on attachment 185926 Adds the directory containing prettify.rb to the $LOAD_PATH, and uses `env` to determine the ruby executable to use. View in context: https://bugs.webkit.org/attachment.cgi?id=185926&action=review > Websites/bugs.webkit.org/PrettyPatch/prettify.rb:7 > +#$LOAD_PATH << Pathname.new(__FILE__).dirname.realpath.to_s This looks commented out. Otherwise this looks good to me. 822289 3 185931 ndevries 2013-01-31 21:08:38 -0800 Created attachment 185931 Patch without the commented out $LOAD_PATH push. 822324 4 185931 webkit.review.bot 2013-01-31 22:20:07 -0800 Comment on attachment 185931 Patch without the commented out $LOAD_PATH push. Attachment 185931 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16296320 New failing tests: fast/forms/datalist/update-range-with-datalist.html fast/layers/no-clipping-overflow-hidden-added-after-transform.html inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html fast/loader/text-document-wrapping.html fast/loader/javascript-url-in-object.html fast/layers/no-clipping-overflow-hidden-added-after-transition.html fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html 823226 5 185931 joepeck 2013-02-01 13:49:49 -0800 Comment on attachment 185931 Patch without the commented out $LOAD_PATH push. r=me, test failures are unrelated 823292 6 185931 webkit.review.bot 2013-02-01 14:47:49 -0800 Comment on attachment 185931 Patch without the commented out $LOAD_PATH push. Clearing flags on attachment: 185931 Committed r141646: <http://trac.webkit.org/changeset/141646> 823293 7 webkit.review.bot 2013-02-01 14:47:53 -0800 All reviewed patches have been landed. Closing bug. 185926 2013-01-31 20:56:26 -0800 2013-01-31 21:08:38 -0800 Adds the directory containing prettify.rb to the $LOAD_PATH, and uses `env` to determine the ruby executable to use. 0001-Allow-prettify.rb-to-be-run-from-any-directory-and-d.patch text/plain 1754 ndevries RnJvbSA3OTYxZWZmMTczNDY3YzUxYWJiMDZkODBmNzdiYjk2MDQxZDdkNTkzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOYXRoYW4gZGUgVnJpZXMgPG5kZXZyaWVzQGFwcGxlLmNvbT4K RGF0ZTogVGh1LCAzMSBKYW4gMjAxMyAyMDo0NzowOCAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIEFs bG93IHByZXR0aWZ5LnJiIHRvIGJlIHJ1biBmcm9tIGFueSBkaXJlY3RvcnksIGFuZCBkb24ndAog aGFyZC1jb2RlIHRoZSBzeXN0ZW0gcnVieSBwYXRoCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTA4NTY5CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiogUHJl dHR5UGF0Y2gvcHJldHRpZnkucmI6Ci0tLQogV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5n ZUxvZyAgICAgICAgICAgICAgIHwgOSArKysrKysrKysKIFdlYnNpdGVzL2J1Z3Mud2Via2l0Lm9y Zy9QcmV0dHlQYXRjaC9wcmV0dGlmeS5yYiB8IDggKysrKysrLS0KIDIgZmlsZXMgY2hhbmdlZCwg MTUgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9i dWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5n ZUxvZwppbmRleCBkN2QyZGIwLi4yMzEzOGZjIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9idWdzLndl YmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMy0wMS0zMSAgTmF0aGFuIGRlIFZyaWVzICA8bmRldnJp ZXNAYXBwbGUuY29tPgorCisgICAgICAgIEFsbG93IHByZXR0aWZ5LnJiIHRvIGJlIHJ1biBmcm9t IGFueSBkaXJlY3RvcnksIGFuZCBkb24ndCBoYXJkLWNvZGUgdGhlIHN5c3RlbSBydWJ5IHBhdGgK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODU2OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogUHJldHR5 UGF0Y2gvcHJldHRpZnkucmI6CisKIDIwMTMtMDEtMDMgIEphbWVzIFJvYmluc29uICA8amFtZXNy QGNocm9taXVtLm9yZz4KIAogICAgICAgICBBdm9pZCBtaXhlZCBjb250ZW50IHdoZW4gZXhwYW5k aW5nIGNvbnRleHQgaW4gY29kZSByZXZpZXcgdG9vbApkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvYnVn cy53ZWJraXQub3JnL1ByZXR0eVBhdGNoL3ByZXR0aWZ5LnJiIGIvV2Vic2l0ZXMvYnVncy53ZWJr aXQub3JnL1ByZXR0eVBhdGNoL3ByZXR0aWZ5LnJiCmluZGV4IDA3ZDQxZmUuLmMxNWUzZmMgMTAw NzU1Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9QcmV0dHlQYXRjaC9wcmV0dGlmeS5y YgorKysgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvUHJldHR5UGF0Y2gvcHJldHRpZnkucmIK QEAgLTEsOSArMSwxMyBAQAotIyEvdXNyL2Jpbi9ydWJ5CisjIS91c3IvYmluL2VudiBydWJ5CiAK LXJlcXVpcmUgJ1ByZXR0eVBhdGNoJwogcmVxdWlyZSAnb3B0cGFyc2UnCityZXF1aXJlICdwYXRo bmFtZScKIHJlcXVpcmUgJ3dlYnJpY2svaHRtbHV0aWxzJwogCisjJExPQURfUEFUSCA8PCBQYXRo bmFtZS5uZXcoX19GSUxFX18pLmRpcm5hbWUucmVhbHBhdGgudG9fcworCityZXF1aXJlICdQcmV0 dHlQYXRjaCcKKwogQkFDS1RSQUNFX1NFUEFSQVRPUiA9ICJcblx0ZnJvbSAiCiAKIG9wdGlvbnMg PSB7IDpodG1sX2V4Y2VwdGlvbnMgPT4gZmFsc2UgfQotLSAKMS43LjEyCgo= 185931 2013-01-31 21:08:38 -0800 2013-02-01 14:47:49 -0800 Patch without the commented out $LOAD_PATH push. 0001-Allow-prettify.rb-to-be-run-from-any-directory-and-d.patch text/plain 1753 ndevries RnJvbSA2NjBmMjM0OWRlNzM3ZmZkYjAxYThkZDAwNWE4MDNmZjBkMzMwMzU4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOYXRoYW4gZGUgVnJpZXMgPG5kZXZyaWVzQGFwcGxlLmNvbT4K RGF0ZTogVGh1LCAzMSBKYW4gMjAxMyAyMDo0NzowOCAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIEFs bG93IHByZXR0aWZ5LnJiIHRvIGJlIHJ1biBmcm9tIGFueSBkaXJlY3RvcnksIGFuZCBkb24ndAog aGFyZC1jb2RlIHRoZSBzeXN0ZW0gcnVieSBwYXRoCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTA4NTY5CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiogUHJl dHR5UGF0Y2gvcHJldHRpZnkucmI6Ci0tLQogV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5n ZUxvZyAgICAgICAgICAgICAgIHwgOSArKysrKysrKysKIFdlYnNpdGVzL2J1Z3Mud2Via2l0Lm9y Zy9QcmV0dHlQYXRjaC9wcmV0dGlmeS5yYiB8IDggKysrKysrLS0KIDIgZmlsZXMgY2hhbmdlZCwg MTUgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9i dWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5n ZUxvZwppbmRleCBkN2QyZGIwLi4yMzEzOGZjIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9idWdzLndl YmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMy0wMS0zMSAgTmF0aGFuIGRlIFZyaWVzICA8bmRldnJp ZXNAYXBwbGUuY29tPgorCisgICAgICAgIEFsbG93IHByZXR0aWZ5LnJiIHRvIGJlIHJ1biBmcm9t IGFueSBkaXJlY3RvcnksIGFuZCBkb24ndCBoYXJkLWNvZGUgdGhlIHN5c3RlbSBydWJ5IHBhdGgK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODU2OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogUHJldHR5 UGF0Y2gvcHJldHRpZnkucmI6CisKIDIwMTMtMDEtMDMgIEphbWVzIFJvYmluc29uICA8amFtZXNy QGNocm9taXVtLm9yZz4KIAogICAgICAgICBBdm9pZCBtaXhlZCBjb250ZW50IHdoZW4gZXhwYW5k aW5nIGNvbnRleHQgaW4gY29kZSByZXZpZXcgdG9vbApkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvYnVn cy53ZWJraXQub3JnL1ByZXR0eVBhdGNoL3ByZXR0aWZ5LnJiIGIvV2Vic2l0ZXMvYnVncy53ZWJr aXQub3JnL1ByZXR0eVBhdGNoL3ByZXR0aWZ5LnJiCmluZGV4IDA3ZDQxZmUuLmE5YzIxMWYgMTAw NzU1Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9QcmV0dHlQYXRjaC9wcmV0dGlmeS5y YgorKysgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvUHJldHR5UGF0Y2gvcHJldHRpZnkucmIK QEAgLTEsOSArMSwxMyBAQAotIyEvdXNyL2Jpbi9ydWJ5CisjIS91c3IvYmluL2VudiBydWJ5CiAK LXJlcXVpcmUgJ1ByZXR0eVBhdGNoJwogcmVxdWlyZSAnb3B0cGFyc2UnCityZXF1aXJlICdwYXRo bmFtZScKIHJlcXVpcmUgJ3dlYnJpY2svaHRtbHV0aWxzJwogCiskTE9BRF9QQVRIIDw8IFBhdGhu YW1lLm5ldyhfX0ZJTEVfXykuZGlybmFtZS5yZWFscGF0aC50b19zCisKK3JlcXVpcmUgJ1ByZXR0 eVBhdGNoJworCiBCQUNLVFJBQ0VfU0VQQVJBVE9SID0gIlxuXHRmcm9tICIKIAogb3B0aW9ucyA9 IHsgOmh0bWxfZXhjZXB0aW9ucyA9PiBmYWxzZSB9Ci0tIAoxLjcuMTIKCg==