108520 2013-01-31 13:54:08 -0800 Assertion failure in WebResourceLoadScheduler::remove when loading .webarchives 2013-01-31 15:15:17 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson oldest_to_newest 821917 0 beidson 2013-01-31 13:54:08 -0800 Assertion failure in WebResourceLoadScheduler::remove when loading .webarchives > 1 com.apple.WebKit2 0x10e86760d WebKit::WebResourceLoadScheduler::remove(WebCore::ResourceLoader*) + 0x1bd (WebResourceLoadScheduler.cpp:150) 2 com.apple.WebCore 0x111e7ce18 WebCore::ResourceLoader::releaseResources() + 0x108 (ResourceLoader.cpp:97) 3 com.apple.WebCore 0x1120d0db4 WebCore::SubresourceLoader::releaseResources() + 0x124 (SubresourceLoader.cpp:325) 4 com.apple.WebCore 0x111e7e019 WebCore::ResourceLoader::didFinishLoading(double) + 0x49 (ResourceLoader.cpp:318) 5 com.apple.WebCore 0x1120d0924 WebCore::SubresourceLoader::didFinishLoading(double) + 0x254 (SubresourceLoader.cpp:277) 6 com.apple.WebCore 0x110d25193 WebCore::DocumentLoader::substituteResourceDeliveryTimerFired(WebCore::Timer<WebCore::DocumentLoader>*) + 0x363 (DocumentLoader.cpp:658) 7 com.apple.WebCore 0x110d33c03 WebCore::Timer<WebCore::DocumentLoader>::fired() + 0x73 (Timer.h:106) 8 com.apple.WebCore 0x11226a62b WebCore::ThreadTimers::sharedTimerFiredInternal() + 0x12b (ThreadTimers.cpp:119) 9 com.apple.WebCore 0x11226a3b9 WebCore::ThreadTimers::sharedTimerFired() + 0x19 (ThreadTimers.cpp:94) 10 com.apple.WebCore 0x111f8a9f3 WebCore::timerFired(__CFRunLoopTimer*, void*) + 0x43 (SharedTimerMac.mm:167) Archive ResourceLoaders - even if they aren't going to be scheduled or loaded remotely - should still be added to the scheduler's loader set, for proper accounting. In radar as <rdar://problem/12888145> 821933 1 185858 beidson 2013-01-31 14:05:02 -0800 Created attachment 185858 Patch v1 822016 2 beidson 2013-01-31 15:15:17 -0800 http://trac.webkit.org/changeset/141493 185858 2013-01-31 14:05:02 -0800 2013-01-31 14:06:38 -0800 Patch v1 patch text/plain 2269 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5YmYxODI4Li43YjUzYTc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYg QEAKIDIwMTMtMDEtMzEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCisgICAg ICAgIEFzc2VydGlvbiBmYWlsdXJlIGluIFdlYlJlc291cmNlTG9hZFNjaGVkdWxlcjo6cmVtb3Zl IHdoZW4gbG9hZGluZyAud2ViYXJjaGl2ZXMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEyODg4 MTQ1PiBhbmQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODUyMAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJv Y2Vzcy9OZXR3b3JrL1dlYlJlc291cmNlTG9hZFNjaGVkdWxlci5jcHA6CisgICAgICAgIChXZWJL aXQ6OldlYlJlc291cmNlTG9hZFNjaGVkdWxlcjo6c2NoZWR1bGVMb2FkKTogRXZlbiBpZiBpdCBp c24ndCB0byBiZSBzY2hlZHVsZWQgd2l0aCB0aGUKKyAgICAgICAgICBOZXR3b3JrUHJvY2Vzcywg c3RpbGwgYWRkIHRoaXMgUmVzb3VyY2VMb2FkZXIgdG8gdGhlIHNjaGVkdWxlcidzIHJlY29yZHMu CisKKzIwMTMtMDEtMzEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCiAgICAg ICAgIExhY2sgb2YgYSBsb2cgbGV2ZWwgc3RyaW5nIHNob3VsZCBub3Qgb2JsaXRlcmF0ZSBjb21w aWxlZCBpbiBsb2dnaW5nIGNoYW5uZWwgc3RhdGUuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg1MDIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJlc291cmNlTG9hZFNjaGVkdWxlci5jcHAgYi9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmNw cAppbmRleCBjZTVlOGU1Li42ZmRhODg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmNwcApA QCAtODcsMTQgKzg3LDE3IEBAIHZvaWQgV2ViUmVzb3VyY2VMb2FkU2NoZWR1bGVyOjpzY2hlZHVs ZUxvYWQoUmVzb3VyY2VMb2FkZXIqIHJlc291cmNlTG9hZGVyLCBSZXNvCiAgICAgQVNTRVJUKHBy aW9yaXR5ICE9IFJlc291cmNlTG9hZFByaW9yaXR5VW5yZXNvbHZlZCk7CiAgICAgcHJpb3JpdHkg PSBSZXNvdXJjZUxvYWRQcmlvcml0eUhpZ2hlc3Q7CiAKKyAgICBSZXNvdXJjZUxvYWRJZGVudGlm aWVyIGlkZW50aWZpZXIgPSByZXNvdXJjZUxvYWRlci0+aWRlbnRpZmllcigpOworICAgIEFTU0VS VChpZGVudGlmaWVyKTsKKwogICAgIC8vIElmIHRoZXJlJ3MgYSB3ZWIgYXJjaGl2ZSByZXNvdXJj ZSBmb3IgdGhpcyBVUkwsIHdlIGRvbid0IG5lZWQgdG8gc2NoZWR1bGUgdGhlIGxvYWQgc2luY2Ug aXQgd2lsbCBuZXZlciB0b3VjaCB0aGUgbmV0d29yay4KICAgICBpZiAocmVzb3VyY2VMb2FkZXIt PmRvY3VtZW50TG9hZGVyKCktPmFyY2hpdmVSZXNvdXJjZUZvclVSTChyZXNvdXJjZUxvYWRlci0+ cmVxdWVzdCgpLnVybCgpKSkgeworICAgICAgICBtX3dlYlJlc291cmNlTG9hZGVycy5zZXQoaWRl bnRpZmllciwgV2ViUmVzb3VyY2VMb2FkZXI6OmNyZWF0ZShyZXNvdXJjZUxvYWRlcikpOwogICAg ICAgICBzdGFydFJlc291cmNlTG9hZGVyKHJlc291cmNlTG9hZGVyKTsKKwogICAgICAgICByZXR1 cm47CiAgICAgfQogCi0gICAgUmVzb3VyY2VMb2FkSWRlbnRpZmllciBpZGVudGlmaWVyID0gcmVz b3VyY2VMb2FkZXItPmlkZW50aWZpZXIoKTsKLSAgICBBU1NFUlQoaWRlbnRpZmllcik7CiAgICAg CiAgICAgQ29udGVudFNuaWZmaW5nUG9saWN5IGNvbnRlbnRTbmlmZmluZ1BvbGljeSA9IHJlc291 cmNlTG9hZGVyLT5zaG91bGRTbmlmZkNvbnRlbnQoKSA/IFNuaWZmQ29udGVudCA6IERvTm90U25p ZmZDb250ZW50OwogICAgIFN0b3JlZENyZWRlbnRpYWxzIGFsbG93U3RvcmVkQ3JlZGVudGlhbHMg PSByZXNvdXJjZUxvYWRlci0+c2hvdWxkVXNlQ3JlZGVudGlhbFN0b3JhZ2UoKSA/IEFsbG93U3Rv cmVkQ3JlZGVudGlhbHMgOiBEb05vdEFsbG93U3RvcmVkQ3JlZGVudGlhbHM7Cg==