108511 2013-01-31 12:23:33 -0800 [Chromium] Spelling should ignore punctuation 2013-02-01 15:05:38 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106815 0 rouslan+webkit webkit-unassigned groby rniwa rouslan+webkit tony webkit.review.bot oldest_to_newest 821822 0 rouslan+webkit 2013-01-31 12:23:33 -0800 Punctuation marks should be treated as whitespace: spelling should ignore them. To test manually, type 'wellcome!', select 'wellcome!', and context-click on the selection. The test succeeds when the context menu has spell check suggestions. 823061 1 186092 rouslan+webkit 2013-02-01 11:45:15 -0800 Created attachment 186092 Patch 823101 2 186092 tony 2013-02-01 12:06:55 -0800 Comment on attachment 186092 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186092&action=review > Source/WebKit/chromium/src/ContextMenuClientImpl.cpp:147 > +// Returns true for whitespace and punctuation characters. Returns false for every other type of character. Remove this comment. > Source/WebKit/chromium/src/ContextMenuClientImpl.cpp:150 > + return WTF::Unicode::isSeparatorSpace(c) || WTF::Unicode::isPunct(c); The old code did WTF::Unicode::direction(c) == WTF::Unicode::WhiteSpaceNeutral instead of WTF::Unicode::isSeparatorSpace(c). Is this difference intentional? Maybe we should #include <wtf/text/StringImpl.h> and use isSpaceOrNewline(c) || WTF::Unicode::isPunct(c) to be more like the old code? 823187 3 186121 rouslan+webkit 2013-02-01 13:20:54 -0800 Created attachment 186121 Patch 823195 4 rouslan+webkit 2013-02-01 13:24:06 -0800 (In reply to comment #2) > (From update of attachment 186092 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=186092&action=review > > > Source/WebKit/chromium/src/ContextMenuClientImpl.cpp:147 > > +// Returns true for whitespace and punctuation characters. Returns false for every other type of character. > > Remove this comment. Removed. What are the guidelines for function comments? > > Source/WebKit/chromium/src/ContextMenuClientImpl.cpp:150 > > + return WTF::Unicode::isSeparatorSpace(c) || WTF::Unicode::isPunct(c); > > The old code did WTF::Unicode::direction(c) == WTF::Unicode::WhiteSpaceNeutral instead of WTF::Unicode::isSeparatorSpace(c). Is this difference intentional? Maybe we should #include <wtf/text/StringImpl.h> and use isSpaceOrNewline(c) || WTF::Unicode::isPunct(c) to be more like the old code? The difference is not intentional. I switched to "isSpaceOrNewLine(c) || WTF::Unicode::isPunct(c)" as you suggested. I did not need to include StringImpl.h. 823286 5 186121 tony 2013-02-01 14:42:14 -0800 Comment on attachment 186121 Patch Most functions don't have comments in WebKit. Instead, we try to use descriptive function names. 823318 6 186121 webkit.review.bot 2013-02-01 15:05:33 -0800 Comment on attachment 186121 Patch Clearing flags on attachment: 186121 Committed r141650: <http://trac.webkit.org/changeset/141650> 823319 7 webkit.review.bot 2013-02-01 15:05:38 -0800 All reviewed patches have been landed. Closing bug. 186092 2013-02-01 11:45:15 -0800 2013-02-01 13:20:52 -0800 Patch bug-108511-20130201114157.patch text/plain 4196 rouslan+webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDk0MTU4ODBkY2FkNzc3NzIyNjUxNTg5ZDJkMTg0YmI5ZDBkYzA1ODguLjJhMGYxNWRkNTllOTgz YWMyNDgzMDlhZjcyMDhlMjE0OTBkM2ZjMjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTMtMDItMDEgIFJvdXNsYW4gU29sb21ha2hpbiAgPHJvdXNsYW5A Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gSWdub3JlIHB1bmN0dWF0aW9uIGlu IHNwZWxsY2hlY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwODUxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6Oklz V2hpdGVTcGFjZU9yUHVuY3R1YXRpb24pOiBBZGRlZCB1dGlsaXR5IGZ1bmN0aW9uIHRvIGRldGVj dCB3aGl0ZXNwYWNlIG9yIHB1bmN0dWF0aW9uLgorICAgICAgICAoV2ViS2l0OjpzZWxlY3RNaXNz cGVsbGluZ0FzeW5jKTogSWdub3JlIHB1bmN0dWF0aW9uIHdoZW4gc2VsZWN0aW5nIHRoZSBtaXNz cGVsbGluZy4KKwogMjAxMy0wMi0wMSAgTmljbyBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgW2Nocm9taXVtXSBCdWlsZCB3ZWJraXQgd2l0aCBlbmFibGVfd2ViX2ludGVu dHMgc2V0IHRvIDAuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Db250 ZXh0TWVudUNsaWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ29udGV4 dE1lbnVDbGllbnRJbXBsLmNwcAppbmRleCA2YzBiNWNlMmZmOGZhMzg1OGQyODQxNjI2NGIyNWJl YTRiNzIyNGMxLi5mMDY2OWU0MGI2MWE2NTExYmZiYTk5YjdkZjlkMTc4ZjYzZTM5MTM1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRleHRNZW51Q2xpZW50SW1w bC5jcHAKQEAgLTE0NCw2ICsxNDQsMTIgQEAgc3RhdGljIFN0cmluZyBzZWxlY3RNaXNzcGVsbGVk V29yZChjb25zdCBDb250ZXh0TWVudSogZGVmYXVsdE1lbnUsIEZyYW1lKiBzZWxlY3QKICAgICBy ZXR1cm4gbWlzc3BlbGxlZFdvcmQ7CiB9CiAKKy8vIFJldHVybnMgdHJ1ZSBmb3Igd2hpdGVzcGFj ZSBhbmQgcHVuY3R1YXRpb24gY2hhcmFjdGVycy4gUmV0dXJucyBmYWxzZSBmb3IgZXZlcnkgb3Ro ZXIgdHlwZSBvZiBjaGFyYWN0ZXIuCitzdGF0aWMgYm9vbCBJc1doaXRlU3BhY2VPclB1bmN0dWF0 aW9uKFVDaGFyIGMpCit7CisgICAgcmV0dXJuIFdURjo6VW5pY29kZTo6aXNTZXBhcmF0b3JTcGFj ZShjKSB8fCBXVEY6OlVuaWNvZGU6OmlzUHVuY3QoYyk7Cit9CisKIHN0YXRpYyBTdHJpbmcgc2Vs ZWN0TWlzc3BlbGxpbmdBc3luYyhGcmFtZSogc2VsZWN0ZWRGcmFtZSwgVmVjdG9yPERvY3VtZW50 TWFya2VyKj4mIG1hcmtlcnMpCiB7CiAgICAgVmlzaWJsZVNlbGVjdGlvbiBzZWxlY3Rpb24gPSBz ZWxlY3RlZEZyYW1lLT5zZWxlY3Rpb24oKS0+c2VsZWN0aW9uKCk7CkBAIC0xNjYsNyArMTcyLDcg QEAgc3RhdGljIFN0cmluZyBzZWxlY3RNaXNzcGVsbGluZ0FzeW5jKEZyYW1lKiBzZWxlY3RlZEZy YW1lLCBWZWN0b3I8RG9jdW1lbnRNYXJrZXIKICAgICAgICAgc2VsZWN0aW9uUmFuZ2UgPSBzZWxl Y3Rpb24udG9Ob3JtYWxpemVkUmFuZ2UoKTsKICAgICB9CiAKLSAgICBpZiAobWFya2VyUmFuZ2Ut PnRleHQoKS5zdHJpcFdoaXRlU3BhY2UoKSAhPSBzZWxlY3Rpb25SYW5nZS0+dGV4dCgpLnN0cmlw V2hpdGVTcGFjZSgpKQorICAgIGlmIChtYXJrZXJSYW5nZS0+dGV4dCgpLnN0cmlwV2hpdGVTcGFj ZSgmSXNXaGl0ZVNwYWNlT3JQdW5jdHVhdGlvbikgIT0gc2VsZWN0aW9uUmFuZ2UtPnRleHQoKS5z dHJpcFdoaXRlU3BhY2UoJklzV2hpdGVTcGFjZU9yUHVuY3R1YXRpb24pKQogICAgICAgICByZXR1 cm4gU3RyaW5nKCk7CiAKICAgICByZXR1cm4gbWFya2VyUmFuZ2UtPnRleHQoKTsKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA3 MjVkZjc0NDVkNTczOTEzMzUzZjgwMTU3ZTMzMWI5MTIzODY3YWVmLi5iMjcwYTgxN2IwYjlkYTdk ZGZhZDI2NjUyNzM5NzUzNmRkMTc2MjI1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMDIt MDEgIFJvdXNsYW4gU29sb21ha2hpbiAgPHJvdXNsYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAg IFtDaHJvbWl1bV0gRXhwZWN0IHNwZWxsY2hlY2sgdG8gaWdub3JlIHB1bmN0dWF0aW9uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg1MTEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2No cm9taXVtL1Rlc3RFeHBlY3RhdGlvbnM6IEV4cGVjdCBzcGVsbGNoZWNrIHRvIGlnbm9yZSBwdW5j dHVhdGlvbi4KKwogMjAxMy0wMi0wMSAgSnVsaWVuIENoYWZmcmFpeCAgPGpjaGFmZnJhaXhAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBbQ1NTIEdyaWQgTGF5b3V0XSBjb21wdXRlUHJlZmVycmVkTG9n aWNhbFdpZHRocyBkb2Vzbid0IGhhbmRsZSBtaW5tYXggdHJhY2tzCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9ucwppbmRleCAzZTMyNjM2M2MzMmE1OWQ5 YzQ0YTg3NzMwMTg5OWVhZTUzZTY4ZjhjLi42NDJjYjhiNjM4NzA3MzgyOTNjOGZmN2JmMjVmZTli NWI2MDFlNjRmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0 RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBl Y3RhdGlvbnMKQEAgLTQzMzgsMTEgKzQzMzgsNiBAQCB3ZWJraXQub3JnL2IvMTA3OTUzIGluc3Bl Y3Rvci1wcm90b2NvbC9kZWJ1Z2dlci10ZXJtaW5hdGUtZGVkaWNhdGVkLXdvcmtlci13aGlsZQog d2Via2l0Lm9yZy9iLzEwODI4NiBwbGF0Zm9ybS9jaHJvbWl1bS92aXJ0dWFsL3NvZnR3YXJlY29t cG9zaXRpbmcvZ2VvbWV0cnkvZml4ZWQtcG9zaXRpb24tY29tcG9zaXRlZC1wYWdlLXNjYWxlLWRv d24uaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzEwODI4NiBwbGF0Zm9y bS9jaHJvbWl1bS92aXJ0dWFsL3NvZnR3YXJlY29tcG9zaXRpbmcvZ2VvbWV0cnkvZml4ZWQtcG9z aXRpb24taWZyYW1lLWNvbXBvc2l0ZWQtcGFnZS1zY2FsZS1kb3duLmh0bWwgWyBJbWFnZU9ubHlG YWlsdXJlIF0KIAotIyBTcGVsbGNoZWNrZXIgYmVoYXZpb3IgdGVzdHMuCi13ZWJraXQub3JnL2Iv MTA4MzcwIGVkaXRpbmcvc3BlbGxpbmcvc3BlbGxpbmctZG91YmxlLWNsaWNrZWQtd29yZC13aXRo LXVuZGVyc2NvcmVzLmh0bWwgWyBGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xMDgzNzAgZWRpdGlu Zy9zcGVsbGluZy9zcGVsbGluZy13aXRoLXB1bmN0dWF0aW9uLXNlbGVjdGlvbi5odG1sIFsgRmFp bHVyZSBdCi13ZWJraXQub3JnL2IvMTA4MzcwIGVkaXRpbmcvc3BlbGxpbmcvc3BlbGxpbmctd2l0 aC11bmRlcnNjb3JlLXNlbGVjdGlvbi5odG1sIFsgRmFpbHVyZSBdCi0KIHdlYmtpdC5vcmcvYi8x MDg0MjQgbWVkaWEvdmlkZW8tZXJyb3ItZG9lcy1ub3QtZXhpc3QuaHRtbCBbIEZhaWx1cmUgQ3Jh c2ggXQogd2Via2l0Lm9yZy9iLzEwODU2NiBwbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L2Zvcm1zL2Nh bGVuZGFyLXBpY2tlci9jYWxlbmRhci1waWNrZXIta2V5LW9wZXJhdGlvbnMuaHRtbCBbIEZhaWx1 cmUgXQogd2Via2l0Lm9yZy9iLzEwODU5NCBbIERlYnVnIF0gdGFibGVzL3RhYmxlLXNlY3Rpb24t b3ZlcmZsb3ctY2xpcC1jcmFzaC5odG1sIFsgQ3Jhc2ggXQo= 186121 2013-02-01 13:20:54 -0800 2013-02-01 15:05:33 -0800 Patch bug-108511-20130201131736.patch text/plain 4059 rouslan+webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDk0MTU4ODBkY2FkNzc3NzIyNjUxNTg5ZDJkMTg0YmI5ZDBkYzA1ODguLjJhMGYxNWRkNTllOTgz YWMyNDgzMDlhZjcyMDhlMjE0OTBkM2ZjMjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTMtMDItMDEgIFJvdXNsYW4gU29sb21ha2hpbiAgPHJvdXNsYW5A Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gSWdub3JlIHB1bmN0dWF0aW9uIGlu IHNwZWxsY2hlY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwODUxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6Oklz V2hpdGVTcGFjZU9yUHVuY3R1YXRpb24pOiBBZGRlZCB1dGlsaXR5IGZ1bmN0aW9uIHRvIGRldGVj dCB3aGl0ZXNwYWNlIG9yIHB1bmN0dWF0aW9uLgorICAgICAgICAoV2ViS2l0OjpzZWxlY3RNaXNz cGVsbGluZ0FzeW5jKTogSWdub3JlIHB1bmN0dWF0aW9uIHdoZW4gc2VsZWN0aW5nIHRoZSBtaXNz cGVsbGluZy4KKwogMjAxMy0wMi0wMSAgTmljbyBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgW2Nocm9taXVtXSBCdWlsZCB3ZWJraXQgd2l0aCBlbmFibGVfd2ViX2ludGVu dHMgc2V0IHRvIDAuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Db250 ZXh0TWVudUNsaWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ29udGV4 dE1lbnVDbGllbnRJbXBsLmNwcAppbmRleCA2YzBiNWNlMmZmOGZhMzg1OGQyODQxNjI2NGIyNWJl YTRiNzIyNGMxLi5kMzY1YmRlYmZjZjFmNWYxZDgyMzI5NGRmZDY0NTkyODQzMDJhMjEwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRleHRNZW51Q2xpZW50SW1w bC5jcHAKQEAgLTE0NCw2ICsxNDQsMTEgQEAgc3RhdGljIFN0cmluZyBzZWxlY3RNaXNzcGVsbGVk V29yZChjb25zdCBDb250ZXh0TWVudSogZGVmYXVsdE1lbnUsIEZyYW1lKiBzZWxlY3QKICAgICBy ZXR1cm4gbWlzc3BlbGxlZFdvcmQ7CiB9CiAKK3N0YXRpYyBib29sIElzV2hpdGVTcGFjZU9yUHVu Y3R1YXRpb24oVUNoYXIgYykKK3sKKyAgICByZXR1cm4gaXNTcGFjZU9yTmV3bGluZShjKSB8fCBX VEY6OlVuaWNvZGU6OmlzUHVuY3QoYyk7Cit9CisKIHN0YXRpYyBTdHJpbmcgc2VsZWN0TWlzc3Bl bGxpbmdBc3luYyhGcmFtZSogc2VsZWN0ZWRGcmFtZSwgVmVjdG9yPERvY3VtZW50TWFya2VyKj4m IG1hcmtlcnMpCiB7CiAgICAgVmlzaWJsZVNlbGVjdGlvbiBzZWxlY3Rpb24gPSBzZWxlY3RlZEZy YW1lLT5zZWxlY3Rpb24oKS0+c2VsZWN0aW9uKCk7CkBAIC0xNjYsNyArMTcxLDcgQEAgc3RhdGlj IFN0cmluZyBzZWxlY3RNaXNzcGVsbGluZ0FzeW5jKEZyYW1lKiBzZWxlY3RlZEZyYW1lLCBWZWN0 b3I8RG9jdW1lbnRNYXJrZXIKICAgICAgICAgc2VsZWN0aW9uUmFuZ2UgPSBzZWxlY3Rpb24udG9O b3JtYWxpemVkUmFuZ2UoKTsKICAgICB9CiAKLSAgICBpZiAobWFya2VyUmFuZ2UtPnRleHQoKS5z dHJpcFdoaXRlU3BhY2UoKSAhPSBzZWxlY3Rpb25SYW5nZS0+dGV4dCgpLnN0cmlwV2hpdGVTcGFj ZSgpKQorICAgIGlmIChtYXJrZXJSYW5nZS0+dGV4dCgpLnN0cmlwV2hpdGVTcGFjZSgmSXNXaGl0 ZVNwYWNlT3JQdW5jdHVhdGlvbikgIT0gc2VsZWN0aW9uUmFuZ2UtPnRleHQoKS5zdHJpcFdoaXRl U3BhY2UoJklzV2hpdGVTcGFjZU9yUHVuY3R1YXRpb24pKQogICAgICAgICByZXR1cm4gU3RyaW5n KCk7CiAKICAgICByZXR1cm4gbWFya2VyUmFuZ2UtPnRleHQoKTsKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAzYzI4ZjI3ZTQ0 YTNmNTFlNDExMGYxODk1MjgzNjAwNGI3Y2JmZmVjLi4xZTQwOTMxY2EwNmEwMDJkNzNhNDc4OTVh ZWM3ZDJkZjNjNzdiNTcwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMDItMDEgIFJvdXNs YW4gU29sb21ha2hpbiAgPHJvdXNsYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1 bV0gRXhwZWN0IHNwZWxsY2hlY2sgdG8gaWdub3JlIHB1bmN0dWF0aW9uCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg1MTEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1Rl c3RFeHBlY3RhdGlvbnM6IEV4cGVjdCBzcGVsbGNoZWNrIHRvIGlnbm9yZSBwdW5jdHVhdGlvbi4K KwogMjAxMy0wMi0wMSAgUm9nZXIgRm9uZyAgPHJvZ2VyX2ZvbmdAYXBwbGUuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQuIFNraXAgbW9yZSB0ZXN0IGluIHByZXBhcmF0aW9uIGZvciBXaW4gRVdT IGJvdHMgKHJvdW5kIDIpLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21p dW0vVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RF eHBlY3RhdGlvbnMKaW5kZXggNGEyZjBiNDhhZjMyOGRlYjFhM2E0ZWRjZWIyNGI2ODJjZWU5Mjlj My4uYzM0ZGQwY2Y2OTE1OThjN2ZiMjA2NmNmNTQyNDA5ZjhhMTIyZDk3NCAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCkBAIC00MzM5LDExICs0 MzM5LDYgQEAgd2Via2l0Lm9yZy9iLzEwNzk1MyBpbnNwZWN0b3ItcHJvdG9jb2wvZGVidWdnZXIt dGVybWluYXRlLWRlZGljYXRlZC13b3JrZXItd2hpbGUKIHdlYmtpdC5vcmcvYi8xMDgyODYgcGxh dGZvcm0vY2hyb21pdW0vdmlydHVhbC9zb2Z0d2FyZWNvbXBvc2l0aW5nL2dlb21ldHJ5L2ZpeGVk LXBvc2l0aW9uLWNvbXBvc2l0ZWQtcGFnZS1zY2FsZS1kb3duLmh0bWwgWyBJbWFnZU9ubHlGYWls dXJlIF0KIHdlYmtpdC5vcmcvYi8xMDgyODYgcGxhdGZvcm0vY2hyb21pdW0vdmlydHVhbC9zb2Z0 d2FyZWNvbXBvc2l0aW5nL2dlb21ldHJ5L2ZpeGVkLXBvc2l0aW9uLWlmcmFtZS1jb21wb3NpdGVk LXBhZ2Utc2NhbGUtZG93bi5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiAKLSMgU3BlbGxjaGVj a2VyIGJlaGF2aW9yIHRlc3RzLgotd2Via2l0Lm9yZy9iLzEwODM3MCBlZGl0aW5nL3NwZWxsaW5n L3NwZWxsaW5nLWRvdWJsZS1jbGlja2VkLXdvcmQtd2l0aC11bmRlcnNjb3Jlcy5odG1sIFsgRmFp bHVyZSBdCi13ZWJraXQub3JnL2IvMTA4MzcwIGVkaXRpbmcvc3BlbGxpbmcvc3BlbGxpbmctd2l0 aC1wdW5jdHVhdGlvbi1zZWxlY3Rpb24uaHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzEw ODM3MCBlZGl0aW5nL3NwZWxsaW5nL3NwZWxsaW5nLXdpdGgtdW5kZXJzY29yZS1zZWxlY3Rpb24u aHRtbCBbIEZhaWx1cmUgXQotCiB3ZWJraXQub3JnL2IvMTA4NDI0IG1lZGlhL3ZpZGVvLWVycm9y LWRvZXMtbm90LWV4aXN0Lmh0bWwgWyBGYWlsdXJlIENyYXNoIF0KIHdlYmtpdC5vcmcvYi8xMDg1 NjYgcGxhdGZvcm0vY2hyb21pdW0vZmFzdC9mb3Jtcy9jYWxlbmRhci1waWNrZXIvY2FsZW5kYXIt cGlja2VyLWtleS1vcGVyYXRpb25zLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xMDg1 OTQgWyBEZWJ1ZyBdIHRhYmxlcy90YWJsZS1zZWN0aW9uLW92ZXJmbG93LWNsaXAtY3Jhc2guaHRt bCBbIENyYXNoIF0K