108504 2013-01-31 11:02:12 -0800 HRTFElevation segfault if a null AudioBus is returned by loadPlatformResource 2013-02-01 11:01:51 -0800 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jesus jesus crogers eric.carlson feature-media-reviews kbr pnormand webkit.review.bot oldest_to_newest 821691 0 jesus 2013-01-31 11:02:12 -0800 In static AudioBus* getConcatenatedImpulseResponsesForSubject(const String& subjectName), there is no check for a null concatenatedImpulseResponses after: OwnPtr<AudioBus> concatenatedImpulseResponses = AudioBus::loadPlatformResource(subjectName.utf8().data(), ResponseSampleRate); Patch is coming. 821721 1 185820 jesus 2013-01-31 11:11:39 -0800 Created attachment 185820 Patch 822447 2 pnormand 2013-02-01 00:47:21 -0800 LGTM, Chris what do you think? 822948 3 185820 kbr 2013-02-01 10:44:32 -0800 Comment on attachment 185820 Patch Looks OK to me. 822982 4 185820 webkit.review.bot 2013-02-01 11:01:47 -0800 Comment on attachment 185820 Patch Clearing flags on attachment: 185820 Committed r141611: <http://trac.webkit.org/changeset/141611> 822983 5 webkit.review.bot 2013-02-01 11:01:51 -0800 All reviewed patches have been landed. Closing bug. 185820 2013-01-31 11:11:39 -0800 2013-02-01 11:01:46 -0800 Patch bug-108504-20130131160628.patch text/plain 1920 jesus U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzI4YTMxNjk5OTQyYzQ0 ZmExYzZkNjg0OGRhODNkZDQ0YTZhOWRlYi4uMDJhMzc0MDlmNDA1NWY0YjRlZjY4OTI1ZWQ3YjVj NGE1NzY0ZGM4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAxLTMxICBKZXN1 cyBTYW5jaGV6LVBhbGVuY2lhICA8amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4KKworICAg ICAgICBIUlRGRWxldmF0aW9uIHNlZ2ZhdWx0IGlmIGEgbnVsbCBBdWRpb0J1cyBpcyByZXR1cm5l ZCBieSBsb2FkUGxhdGZvcm1SZXNvdXJjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA4NTA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRml4ZWQgYSBzZWdmYXVsdCBieSBjaGVja2luZyBpZiB0aGUgcmV0 dXJuZWQgQXVkaW9CdXMgaXMgbnVsbCBvciBub3QuCisgICAgICAgIElmIGl0IGlzLCB3ZSBzaG91 bGQgZWFybHkgcmV0dXJuIGluIHRoZSBzYW1lIHdheSBpdCB3YXMgYmVpbmcgZG9uZSBhbHJlYWR5 CisgICAgICAgIGluIEhSVEZFbGV2YXRpb246OmNhbGN1bGF0ZUtlcm5lbHNGb3JBemltdXRoRWxl dmF0aW9uKCk7CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBjb3ZlcmVkIGJ5IGV4aXN0aW5nIHRl c3RzLgorCisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vSFJURkVsZXZhdGlvbi5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpnZXRDb25jYXRlbmF0ZWRJbXB1bHNlUmVzcG9uc2VzRm9yU3ViamVjdCk6 CisKIDIwMTMtMDEtMzAgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAg IERhdGFiYXNlQ29udGV4dCBuZWVkcyB0byBvdXRsaXZlIHRoZSBTY3JpcHRFeGVjdXRpb25Db250 ZXh0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vSFJURkVsZXZh dGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9IUlRGRWxldmF0aW9uLmNw cAppbmRleCA4MzNiOWJjMmRjMzM1YmYyYzY5Y2M3NGFhNWI1NGI5ZTZlY2ViMDJiLi4xMmYzMTkx OGZjYTI0Njk4ZGE5Mjc4MjUxNGQ2NDE2OGZlNGIyZDFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9hdWRpby9IUlRGRWxldmF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9hdWRpby9IUlRGRWxldmF0aW9uLmNwcApAQCAtNzgsNiArNzgsMTAgQEAgc3Rh dGljIEF1ZGlvQnVzKiBnZXRDb25jYXRlbmF0ZWRJbXB1bHNlUmVzcG9uc2VzRm9yU3ViamVjdChj b25zdCBTdHJpbmcmIHN1YmplY3QKICAgICBBdWRpb0J1c01hcDo6aXRlcmF0b3IgaXRlcmF0b3Ig PSBhdWRpb0J1c01hcC5maW5kKHN1YmplY3ROYW1lKTsKICAgICBpZiAoaXRlcmF0b3IgPT0gYXVk aW9CdXNNYXAuZW5kKCkpIHsKICAgICAgICAgT3duUHRyPEF1ZGlvQnVzPiBjb25jYXRlbmF0ZWRJ bXB1bHNlUmVzcG9uc2VzID0gQXVkaW9CdXM6OmxvYWRQbGF0Zm9ybVJlc291cmNlKHN1YmplY3RO YW1lLnV0ZjgoKS5kYXRhKCksIFJlc3BvbnNlU2FtcGxlUmF0ZSk7CisgICAgICAgIEFTU0VSVChj b25jYXRlbmF0ZWRJbXB1bHNlUmVzcG9uc2VzKTsKKyAgICAgICAgaWYgKCFjb25jYXRlbmF0ZWRJ bXB1bHNlUmVzcG9uc2VzKQorICAgICAgICAgICAgcmV0dXJuIDA7CisKICAgICAgICAgYnVzID0g Y29uY2F0ZW5hdGVkSW1wdWxzZVJlc3BvbnNlcy5sZWFrUHRyKCk7CiAgICAgICAgIGF1ZGlvQnVz TWFwLnNldChzdWJqZWN0TmFtZSwgYnVzKTsKICAgICB9IGVsc2UK