108502 2013-01-31 10:57:14 -0800 Lack of a log level string should not obliterate compiled in logging channel state 2013-01-31 11:09:41 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 beidson beidson oldest_to_newest 821683 0 beidson 2013-01-31 10:57:14 -0800 Lack of a log level string should not obliterate compiled in logging channel state 821688 1 185814 beidson 2013-01-31 10:58:40 -0800 Created attachment 185814 Patch v1 821692 2 185814 ap 2013-01-31 11:02:38 -0800 Comment on attachment 185814 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=185814&action=review rs=me if you do this consistently everywhere, not just in WebKit2. WebCore already has this behavior, so this leaves us with WebKit1. But WebCore's code looks different, so you can consider replacing one of the versions with a copy/paste. > Source/WebKit2/ChangeLog:9 > + (WebKit::initializeLogChannel): If there's no log level string, level the channel state alone. Autocorrection: leave. 821714 3 beidson 2013-01-31 11:09:41 -0800 http://trac.webkit.org/changeset/141447 185814 2013-01-31 10:58:40 -0800 2013-01-31 11:02:38 -0800 Patch v1 patch text/plain 1614 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiNjlhZTdhLi4zOWE5YTM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTMtMDEtMzEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIExhY2sgb2YgYSBsb2cgbGV2ZWwgc3RyaW5nIHNob3VsZCBub3Qgb2JsaXRlcmF0ZSBjb21w aWxlZCBpbiBsb2dnaW5nIGNoYW5uZWwgc3RhdGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg1MDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFBsYXRmb3JtL21hYy9Mb2dnaW5nLm1hYy5tbToKKyAg ICAgICAgKFdlYktpdDo6aW5pdGlhbGl6ZUxvZ0NoYW5uZWwpOiBJZiB0aGVyZSdzIG5vIGxvZyBs ZXZlbCBzdHJpbmcsIGxldmVsIHRoZSBjaGFubmVsIHN0YXRlIGFsb25lLgorCiAyMDEzLTAxLTMx ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQGRpZ2lhLmNvbT4KIAogICAgICAgICBV bnJldmlld2VkIHRyaXZpYWwgYnVpbGQgZml4OiBBZGQgbWlzc2luZyB2aXJ0dWFsIGRlc3RydWN0 b3IgdG8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL21hYy9Mb2dnaW5nLm1h Yy5tbSBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL21hYy9Mb2dnaW5nLm1hYy5tbQppbmRleCA2 ZTQ1ODI4Li4xOGNkZjYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9tYWMv TG9nZ2luZy5tYWMubW0KKysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vbWFjL0xvZ2dpbmcu bWFjLm1tCkBAIC0zMiwxMSArMzIsMTMgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiAKIHZvaWQgaW5p dGlhbGl6ZUxvZ0NoYW5uZWwoV1RGTG9nQ2hhbm5lbCogY2hhbm5lbCkKIHsKLSAgICBjaGFubmVs LT5zdGF0ZSA9IFdURkxvZ0NoYW5uZWxPZmY7CisgICAgLy8gSWYgdGhlcmUgaXMgbm8gbG9nIGxl dmVsIHN0cmluZyBmcm9tIHRoZSB1c2VyIGRlZmF1bHRzIHRoZW4gZG9uJ3QgY2hhbmdlIHRoZSBs b2dnaW5nIGNoYW5uZWwgYXQgYWxsLgogICAgIE5TU3RyaW5nICpsb2dMZXZlbFN0cmluZyA9IFtb TlNVc2VyRGVmYXVsdHMgc3RhbmRhcmRVc2VyRGVmYXVsdHNdIG9iamVjdEZvcktleTpbTlNTdHJp bmcgc3RyaW5nV2l0aFVURjhTdHJpbmc6Y2hhbm5lbC0+ZGVmYXVsdE5hbWVdXTsKICAgICBpZiAo IWxvZ0xldmVsU3RyaW5nKQogICAgICAgICByZXR1cm47Ci0gICAgICAgIAorCisgICAgY2hhbm5l bC0+c3RhdGUgPSBXVEZMb2dDaGFubmVsT2ZmOworCiAgICAgdW5zaWduZWQgbG9nTGV2ZWw7CiAg ICAgaWYgKCFbW05TU2Nhbm5lciBzY2FubmVyV2l0aFN0cmluZzpsb2dMZXZlbFN0cmluZ10gc2Nh bkhleEludDombG9nTGV2ZWxdKQogICAgICAgICBOU0xvZyhAInVuYWJsZSB0byBwYXJzZSBoZXgg dmFsdWUgZm9yICVzICglQCksIGxvZ2dpbmcgaXMgb2ZmIiwgY2hhbm5lbC0+ZGVmYXVsdE5hbWUs IGxvZ0xldmVsU3RyaW5nKTsK