108479 2013-01-31 07:07:46 -0800 [Skia] Argument to HarfBuzzShaper::offsetForPosition unnecessarily truncated 2013-02-04 10:23:04 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 d-r d-r eae krit leviw tony webkit.review.bot oldest_to_newest 821500 0 d-r 2013-01-31 07:07:46 -0800 There's legacy code in FontHarfBuzz.cpp that unnecessarily truncates the argument to an integer, that's not necessary any more since the signature of the called function had been changed a while ago. 824316 1 186367 d-r 2013-02-04 06:45:26 -0800 Created attachment 186367 Patch 824438 2 eae 2013-02-04 09:24:49 -0800 Is this affecting SVG at all (as per the comment)? 824486 3 186407 d-r 2013-02-04 10:00:52 -0800 Created attachment 186407 Selection inaccuracy with viewbox scaling (In reply to comment #2) > Is this affecting SVG at all (as per the comment)? I think so - if you look at the attached test case you see that text selection is broken/inaccurate in the first inline svg image which uses 100x viewport scaling. My patch is not the full solution to this issue. I found this while experimenting to find a test case. But it will probably be a necessary step to solve this completely. 824517 4 186367 webkit.review.bot 2013-02-04 10:23:01 -0800 Comment on attachment 186367 Patch Clearing flags on attachment: 186367 Committed r141778: <http://trac.webkit.org/changeset/141778> 824518 5 webkit.review.bot 2013-02-04 10:23:04 -0800 All reviewed patches have been landed. Closing bug. 186367 2013-02-04 06:45:26 -0800 2013-02-04 10:23:00 -0800 Patch bug-108479-20130204164204.patch text/plain 2161 d-r U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmNmOGNlMjM2ZGY3N2Y3 MTc2YTY0YWVhMGJhMzI2OWY1YjM0ZjgxNi4uNGMzZTNjNWVkNWQ2ODY5YTQ0ZDNkMzIxY2E2MDcw MDI0OWQ0OTc3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTA0ICBEb21p bmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CisKKyAgICAgICAg W1NraWFdIEFyZ3VtZW50IHRvIEhhcmZCdXp6U2hhcGVyOjpvZmZzZXRGb3JQb3NpdGlvbiB1bm5l Y2Vzc2FyaWx5IHRydW5jYXRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTA4NDc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUmVtb3ZlIGEgRklYTUUgdGhhdCBpbnRlbmRlZCB0byBzb2x2ZSB0aGUgdmFs dWUgdHJ1bmNhdGlvbi4KKyAgICAgICAgU2hvdWxkIHBvc2l0aXZlbHkgYWZmZWN0IFNWRyB0ZXh0 IHBvc2l0aW9uaW5nLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgcGFydGlhbGx5IGNvdmVyZWQg YnkgbWFudWFsIHRlc3QKKyAgICAgICAgTWFudWFsVGVzdHMvaGFyZmJ1enotbW91c2Utc2VsZWN0 aW9uLWNyYXNoLmh0bWwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9G b250SGFyZkJ1enouY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udDo6b2Zmc2V0Rm9yUG9zaXRp b25Gb3JDb21wbGV4VGV4dCk6CisKIDIwMTMtMDItMDQgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2Vx QGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBzeW5jIGxpc3Qgb2YgY29u c29sZSBBUEkgbWV0aG9kcyB0byB0aGF0IHVzZWQgYnkgYXV0by1jb21wbGV0ZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovRm9udEhhcmZCdXp6 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L0ZvbnRIYXJm QnV6ei5jcHAKaW5kZXggZWI3MDllMzIxODM1NzFiYTc0YzRlMGZlNDhkMWQzOTRmYmFkYzQyOC4u NTEzYzhkOWM1OGUyN2I1ZGJmYmM2M2Q5YjdiNTIwMTYzOTRlNmZkYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovRm9udEhhcmZCdXp6LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9Gb250SGFyZkJ1 enouY3BwCkBAIC0yMDIsMTQgKzIwMiwxMCBAQCBmbG9hdCBGb250OjpmbG9hdFdpZHRoRm9yQ29t cGxleFRleHQoY29uc3QgVGV4dFJ1biYgcnVuLCBIYXNoU2V0PGNvbnN0IFNpbXBsZUZvbgogaW50 IEZvbnQ6Om9mZnNldEZvclBvc2l0aW9uRm9yQ29tcGxleFRleHQoY29uc3QgVGV4dFJ1biYgcnVu LCBmbG9hdCB4RmxvYXQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBib29sIGluY2x1ZGVQYXJ0aWFsR2x5cGhzKSBjb25zdAogewotICAgIC8vIEZJWE1FOiBUaGlz IHRydW5jYXRpb24gaXMgbm90IGEgcHJvYmxlbSBmb3IgSFRNTCwgYnV0IG9ubHkgYWZmZWN0cyBT VkcsIHdoaWNoIHBhc3NlcyBmbG9hdGluZy1wb2ludCBudW1iZXJzCi0gICAgLy8gdG8gRm9udDo6 b2Zmc2V0Rm9yUG9zaXRpb24oKS4gQnVnIGh0dHA6Ly93ZWJraXQub3JnL2IvNDA2NzMgdHJhY2tz IGZpeGluZyB0aGlzIHByb2JsZW0uCi0gICAgaW50IHRhcmdldFggPSBzdGF0aWNfY2FzdDxpbnQ+ KHhGbG9hdCk7Ci0KICAgICBIYXJmQnV6elNoYXBlciBzaGFwZXIodGhpcywgcnVuKTsKICAgICBp ZiAoIXNoYXBlci5zaGFwZSgpKQogICAgICAgICByZXR1cm4gMDsKLSAgICByZXR1cm4gc2hhcGVy Lm9mZnNldEZvclBvc2l0aW9uKHRhcmdldFgpOworICAgIHJldHVybiBzaGFwZXIub2Zmc2V0Rm9y UG9zaXRpb24oeEZsb2F0KTsKIH0KIAogLy8gUmV0dXJuIHRoZSByZWN0YW5nbGUgZm9yIHNlbGVj dGluZyB0aGUgZ2l2ZW4gcmFuZ2Ugb2YgY29kZS1wb2ludHMgaW4gdGhlIFRleHRSdW4uCg== 186407 2013-02-04 10:00:52 -0800 2013-02-04 10:00:52 -0800 Selection inaccuracy with viewbox scaling viewbox2.html text/html 332 d-r PCFET0NUWVBFIGh0bWw+Cjxib2R5Pgo8c3ZnIHdpZHRoPSI1MDBweCIgaGVpZ2h0PSI1MDBweCIg dmlld0JveD0iMCAwIDUgNSI+CiAgPHRleHQgeD0iMC4yNSIgeT0iMi41IiBmb250LXNpemU9IjAu NXB4IiBmb250LWZhbWlseT0iVmVyZGFuYSIgPgogICAgVHJ5IHNlbGVjdGluZyB0ZXh0LgogIDwv dGV4dD4KPC9zdmc+Cjxzdmcgd2lkdGg9IjUwMHB4IiBoZWlnaHQ9IjUwMHB4Ij4KICA8dGV4dCB4 PSIyNSIgeT0iMjUwIiBmb250LXNpemU9IjUwcHgiIGZvbnQtZmFtaWx5PSJWZXJkYW5hIiA+CiAg ICBUcnkgc2VsZWN0aW5nIHRleHQuCiAgPC90ZXh0Pgo8L3N2Zz4KPC9ib2R5Pgo=