108468 2013-01-31 05:22:10 -0800 Web Inspector: [Profiles] show launcher view upon deleting last profile type's header 2013-01-31 05:44:19 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 aandrey aandrey apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 821423 0 aandrey 2013-01-31 05:22:10 -0800 We should show launcher view and hide profile type sidebar section upon deleting last profile type's header from the sidebar. Right now we only show launcher view upon deleting the last profile header (of any profile type). Patch to follow. 821426 1 185759 aandrey 2013-01-31 05:23:09 -0800 Created attachment 185759 Patch 821431 2 185759 yurys 2013-01-31 05:29:10 -0800 Comment on attachment 185759 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185759&action=review > Source/WebCore/inspector/front-end/ProfilesPanel.js:612 > + if (!sidebarParent.children.length) { Doesn't sidebarParent.children include section headers? 821436 3 aandrey 2013-01-31 05:37:25 -0800 (In reply to comment #2) > (From update of attachment 185759 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185759&action=review > > > Source/WebCore/inspector/front-end/ProfilesPanel.js:612 > > + if (!sidebarParent.children.length) { > > Doesn't sidebarParent.children include section headers? Looks like it includes only WebInspector.ProfileSidebarTreeElement elements. 821441 4 185759 webkit.review.bot 2013-01-31 05:44:15 -0800 Comment on attachment 185759 Patch Clearing flags on attachment: 185759 Committed r141409: <http://trac.webkit.org/changeset/141409> 821443 5 webkit.review.bot 2013-01-31 05:44:19 -0800 All reviewed patches have been landed. Closing bug. 185759 2013-01-31 05:23:09 -0800 2013-01-31 05:44:15 -0800 Patch bug-108468-20130131171952.patch text/plain 1845 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWM2Zjk5MjIzYjhlMWVj OWMzMTc3Y2NmY2JkZjMzN2Q3MTRmMmM3ZC4uMmNmMjYxOGRiMjY4MDQ3NWM2NmUyMjJiMzNlYzRk NDMwNDY2MzZlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTMxICBBbmRy ZXkgQWRhaWtpbiAgPGFhbmRyZXlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFtQcm9maWxlc10gc2hvdyBsYXVuY2hlciB2aWV3IHVwb24gZGVsZXRpbmcgbGFzdCBwcm9m aWxlIHR5cGUncyBoZWFkZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwODQ2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdlIHNob3VsZCBzaG93IGxhdW5jaGVyIHZpZXcgYW5kIGhpZGUgcHJvZmlsZSB0 eXBlIHNpZGViYXIgc2VjdGlvbiB1cG9uIGRlbGV0aW5nIGxhc3QgcHJvZmlsZSB0eXBlJ3MgaGVh ZGVyIGZyb20gdGhlIHNpZGViYXIuCisgICAgICAgIFJpZ2h0IG5vdyB3ZSBvbmx5IHNob3cgbGF1 bmNoZXIgdmlldyB1cG9uIGRlbGV0aW5nIHRoZSBsYXN0IHByb2ZpbGUgaGVhZGVyIChvZiBhbnkg cHJvZmlsZSB0eXBlKS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZXNQ YW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Qcm9maWxlc1BhbmVsLnByb3RvdHlwZS5f cmVtb3ZlUHJvZmlsZUhlYWRlcik6CisKIDIwMTMtMDEtMzAgIFBhdmVsIEZlbGRtYW4gIDxwZmVs ZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogbWlncmF0ZSBmaWxl IHNlbGVjdGlvbiBkaWFsb2cgdG8gdGhlIHZpZXdwb3J0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Qcm9maWxlc1BhbmVsLmpzIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Qcm9maWxlc1BhbmVsLmpzCmluZGV4IDcyOTI5YjIwOTA1 NGNhNmE1ZmUzMTg3ZmJmMDRjYTBhNGMxMTE2NTUuLjk2OGE4ZjFlY2ZmOWEyYTdjM2M0ZmVmMTU3 YzljYTk0ZWVlMTc3M2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvUHJvZmlsZXNQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1Byb2ZpbGVzUGFuZWwuanMKQEAgLTYwOSw4ICs2MDksMTEgQEAgV2ViSW5zcGVjdG9y LlByb2ZpbGVzUGFuZWwucHJvdG90eXBlID0gewogCiAgICAgICAgIC8vIE5vIG90aGVyIGl0ZW0g d2lsbCBiZSBzZWxlY3RlZCBpZiB0aGVyZSBhcmVuJ3QgYW55IG90aGVyIHByb2ZpbGVzLCBzbwog ICAgICAgICAvLyBtYWtlIHN1cmUgdGhhdCB2aWV3IGdldHMgY2xlYXJlZCB3aGVuIHRoZSBsYXN0 IHByb2ZpbGUgaXMgcmVtb3ZlZC4KLSAgICAgICAgaWYgKCF0aGlzLl9wcm9maWxlcy5sZW5ndGgp Ci0gICAgICAgICAgICB0aGlzLmNsb3NlVmlzaWJsZVZpZXcoKTsKKyAgICAgICAgaWYgKCFzaWRl YmFyUGFyZW50LmNoaWxkcmVuLmxlbmd0aCkgeworICAgICAgICAgICAgdGhpcy5wcm9maWxlc0l0 ZW1UcmVlRWxlbWVudC5zZWxlY3QoKTsKKyAgICAgICAgICAgIHRoaXMuX3Nob3dMYXVuY2hlclZp ZXcoKTsKKyAgICAgICAgICAgIHNpZGViYXJQYXJlbnQuaGlkZGVuID0gdHJ1ZTsKKyAgICAgICAg fQogICAgIH0sCiAKICAgICAvKioK