10846 2006-09-13 14:14:50 -0700 exceptions from XHTML/SVG <script> tags don't show the right line numbers 2006-09-19 02:42:01 -0700 1 1 1 Unclassified WebKit XML 420+ Mac OS X 10.4 RESOLVED FIXED SVGHitList P3 Normal --- 1 eric eric ddkilzer oldest_to_newest 55446 0 eric 2006-09-13 14:14:50 -0700 exceptions from XHTML/SVG <script> tags don't show the right line numbers This is why: XMLTokenizer::endElementNs() contains a: m_view->frame()->executeScript(0, scriptCode); call, notice how it fails to pass the correct base line number. Compare that with the HTML tokenizer, which correctly passes the line number. We'll have to steal the line number out of: m_context->input->line when we hit a <script> start tag, and then use that when we actually execute the script. It shouldn't be too hard. We might just consider adding a m_startLineNumber member into HTMLScriptElement and SVGScriptElement for simplicity of both tokenizers/parsers. Adding to the SVG hitlist as this makes SVGs very hard to debug in Safari. 55450 1 10547 eric 2006-09-13 14:56:21 -0700 Created attachment 10547 Improves the situation This "fixes" the bug. Now line numbers seem to be off-by-one in the other direction. I'm not sure why. I could just change the line to m_scriptStartLine - 1, but I'm not sure that's "right". 55452 2 ddkilzer 2006-09-13 15:26:24 -0700 (In reply to comment #1) > Created an attachment (id=10547) [edit] > Improves the situation > > This "fixes" the bug. With just a ChangeLog entry? :) 55454 3 eric 2006-09-13 15:37:26 -0700 (In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=10547) [edit] > > Improves the situation > > > > This "fixes" the bug. > > With just a ChangeLog entry? :) > You under-estimate the power of the ChangeLog! Sometimes willing a bug gone is enough. :) In this case however, a code change would help. Too bad I tossed the patch thinking it was already safely part of bugzilla. :( 55455 4 10549 eric 2006-09-13 15:38:47 -0700 Created attachment 10549 The fix (now with 100% more code!) 55901 5 10549 hyatt 2006-09-19 02:34:49 -0700 Comment on attachment 10549 The fix (now with 100% more code!) r=me 55903 6 eric 2006-09-19 02:42:01 -0700 Drosera works much better now for xhtml/svg. :) Landed as r16447. 10547 2006-09-13 14:56:21 -0700 2006-09-13 15:38:47 -0700 Improves the situation line-fix.patch text/plain 665 eric SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2MzQ2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDYtMDkt MTMgIEVyaWMgU2VpZGVsICA8ZXJpY0Blc2VpZGVsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeGNlcHRpb25zIHRocm93biBmcm9tIDxzY3Jp cHQ+IHRhZ3MgaW4gWEhUTUwvU1ZHIGRvY3Mgc2hvdyB0aGUgd3JvbmcgbGluZSBudW1iZXJzCisg ICAgICAgIGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4 NDYKKworICAgICAgICAqIGRvbS9YTUxUb2tlbml6ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 WE1MVG9rZW5pemVyOjpYTUxUb2tlbml6ZXIpOgorICAgICAgICAoV2ViQ29yZTo6WE1MVG9rZW5p emVyOjpzdGFydEVsZW1lbnROcyk6CisgICAgICAgIChXZWJDb3JlOjpYTUxUb2tlbml6ZXI6OmVu ZEVsZW1lbnROcyk6CisKIDIwMDYtMDktMTMgIE1vcmdhbkwgIDxtb3JsbW9yQHlhaG9vLmNvbT4K IAogICAgICAgICBSZXZpZXdlZC9sYW5kZWQgYnkgYXJvYmVuLgo= 10549 2006-09-13 15:38:47 -0700 2006-09-19 02:34:49 -0700 The fix (now with 100% more code!) line-fix.patch text/plain 3291 eric SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2MzQ3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDYtMDkt MTMgIEVyaWMgU2VpZGVsICA8ZXJpY0Blc2VpZGVsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeGNlcHRpb25zIHRocm93biBmcm9tIDxzY3Jp cHQ+IHRhZ3MgaW4gWEhUTUwvU1ZHIGRvY3Mgc2hvdyB0aGUgd3JvbmcgbGluZSBudW1iZXJzCisg ICAgICAgIGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4 NDYKKworICAgICAgICAqIGRvbS9YTUxUb2tlbml6ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 WE1MVG9rZW5pemVyOjpYTUxUb2tlbml6ZXIpOgorICAgICAgICAoV2ViQ29yZTo6WE1MVG9rZW5p emVyOjpzdGFydEVsZW1lbnROcyk6CisgICAgICAgIChXZWJDb3JlOjpYTUxUb2tlbml6ZXI6OmVu ZEVsZW1lbnROcyk6CisKIDIwMDYtMDktMTMgIE5pa29sYXMgWmltbWVybWFubiAgPHppbW1lcm1h bm5Aa2RlLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBlc2VpZGVsLiAgTGFuZGVkIGJ5IGVz ZWlkZWwuCkluZGV4OiBXZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCShyZXZpc2lvbiAxNjM0NikK KysrIFdlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagkod29ya2luZyBjb3B5KQpAQCAt ODU3MCw3ICs4NTcwLDYgQEAKIAkJMDg2N0Q2OTBGRTg0MDI4RkMwMkFBQzA3IC8qIFByb2plY3Qg b2JqZWN0ICovID0gewogCQkJaXNhID0gUEJYUHJvamVjdDsKIAkJCWJ1aWxkQ29uZmlndXJhdGlv bkxpc3QgPSAxNDlDMjg0MzA4OTAyQjExMDA4QTlFRkMgLyogQnVpbGQgY29uZmlndXJhdGlvbiBs aXN0IGZvciBQQlhQcm9qZWN0ICJXZWJDb3JlIiAqLzsKLQkJCWNvbXBhdGliaWxpdHlWZXJzaW9u ID0gIlhjb2RlIDIuNCI7CiAJCQloYXNTY2FubmVkRm9yRW5jb2RpbmdzID0gMTsKIAkJCWtub3du UmVnaW9ucyA9ICgKIAkJCQlFbmdsaXNoLApAQCAtODU4NSw3ICs4NTg0LDYgQEAKIAkJCXByb2R1 Y3RSZWZHcm91cCA9IDAzNDc2OERGRkYzOEE1MDQxMURCOUM4QiAvKiBQcm9kdWN0cyAqLzsKIAkJ CXByb2plY3REaXJQYXRoID0gIiI7CiAJCQlwcm9qZWN0Um9vdCA9ICIiOwotCQkJc2hvdWxkQ2hl Y2tDb21wYXRpYmlsaXR5ID0gMTsKIAkJCXRhcmdldHMgPSAoCiAJCQkJOTNGMTk4QTUwODI0NUU1 OTAwMUU5QUJDIC8qIFdlYkNvcmUgKi8sCiAJCQkJREQwNDFGQkUwOUQ5RERCRTAwMTBBRjJBIC8q IERlcml2ZWQgU291cmNlcyAqLywKSW5kZXg6IGRvbS9YTUxUb2tlbml6ZXIuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIGRvbS9YTUxUb2tlbml6ZXIuY3BwCShyZXZpc2lvbiAxNjM0NikKKysrIGRvbS9YTUxU b2tlbml6ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDMsNiArMTQzLDcgQEAgcHJpdmF0ZToK IAogICAgIENhY2hlZFNjcmlwdCAqbV9wZW5kaW5nU2NyaXB0OwogICAgIFJlZlB0cjxFbGVtZW50 PiBtX3NjcmlwdEVsZW1lbnQ7CisgICAgaW50IG1fc2NyaXB0U3RhcnRMaW5lOwogICAgIAogICAg IGJvb2wgbV9wYXJzaW5nRnJhZ21lbnQ7CiAgICAgU3RyaW5nIG1fZGVmYXVsdE5hbWVzcGFjZVVS STsKQEAgLTUzNyw2ICs1MzgsNyBAQCBYTUxUb2tlbml6ZXI6OlhNTFRva2VuaXplcihEb2N1bWVu dCAqX2RvCiAgICAgLCBtX2xhc3RFcnJvckxpbmUoMCkKICAgICAsIG1fbGFzdEVycm9yQ29sdW1u KDApCiAgICAgLCBtX3BlbmRpbmdTY3JpcHQoMCkKKyAgICAsIG1fc2NyaXB0U3RhcnRMaW5lKDAp CiAgICAgLCBtX3BhcnNpbmdGcmFnbWVudChmYWxzZSkKICAgICAsIG1fcGVuZGluZ0NhbGxiYWNr cyhuZXcgUGVuZGluZ0NhbGxiYWNrcykKIHsKQEAgLTU1OSw2ICs1NjEsNyBAQCBYTUxUb2tlbml6 ZXI6OlhNTFRva2VuaXplcihEb2N1bWVudEZyYWdtCiAgICAgLCBtX2xhc3RFcnJvckxpbmUoMCkK ICAgICAsIG1fbGFzdEVycm9yQ29sdW1uKDApCiAgICAgLCBtX3BlbmRpbmdTY3JpcHQoMCkKKyAg ICAsIG1fc2NyaXB0U3RhcnRMaW5lKDApCiAgICAgLCBtX3BhcnNpbmdGcmFnbWVudCh0cnVlKQog ICAgICwgbV9wZW5kaW5nQ2FsbGJhY2tzKG5ldyBQZW5kaW5nQ2FsbGJhY2tzKQogewpAQCAtNzY0 LDcgKzc2NywxMCBAQCB2b2lkIFhNTFRva2VuaXplcjo6c3RhcnRFbGVtZW50TnMoY29uc3QgCiAK ICAgICBpZiAobmV3RWxlbWVudC0+aGFzVGFnTmFtZShzY3JpcHRUYWcpKQogICAgICAgICBzdGF0 aWNfY2FzdDxIVE1MU2NyaXB0RWxlbWVudCAqPihuZXdFbGVtZW50LmdldCgpKS0+c2V0Q3JlYXRl ZEJ5UGFyc2VyKHRydWUpOwotCisgICAgCisgICAgaWYgKG5ld0VsZW1lbnQtPmhhc1RhZ05hbWUo SFRNTE5hbWVzOjpzY3JpcHRUYWcpIHx8IG5ld0VsZW1lbnQtPmhhc1RhZ05hbWUoU1ZHTmFtZXM6 OnNjcmlwdFRhZykpCisgICAgICAgIG1fc2NyaXB0U3RhcnRMaW5lID0gbGluZU51bWJlcigpOwor ICAgIAogICAgIGlmICghbV9jdXJyZW50Tm9kZS0+YWRkQ2hpbGQobmV3RWxlbWVudC5nZXQoKSkp IHsKICAgICAgICAgc3RvcFBhcnNpbmcoKTsKICAgICAgICAgcmV0dXJuOwpAQCAtODM0LDcgKzg0 MCw3IEBAIHZvaWQgWE1MVG9rZW5pemVyOjplbmRFbGVtZW50TnMoKQogICAgICAgICAgICAgICAg IGlmIChjaGlsZC0+aXNUZXh0Tm9kZSgpIHx8IGNoaWxkLT5ub2RlVHlwZSgpID09IE5vZGU6OkNE QVRBX1NFQ1RJT05fTk9ERSkKICAgICAgICAgICAgICAgICAgICAgc2NyaXB0Q29kZSArPSBzdGF0 aWNfY2FzdDxDaGFyYWN0ZXJEYXRhKj4oY2hpbGQpLT5kYXRhKCk7CiAgICAgICAgICAgICB9Ci0g ICAgICAgICAgICBtX3ZpZXctPmZyYW1lKCktPmV4ZWN1dGVTY3JpcHQoMCwgc2NyaXB0Q29kZSk7 CisgICAgICAgICAgICBtX3ZpZXctPmZyYW1lKCktPmV4ZWN1dGVTY3JpcHQobV9kb2MtPlVSTCgp LCBtX3NjcmlwdFN0YXJ0TGluZSAtIDEsIDAsIHNjcmlwdENvZGUpOwogICAgICAgICB9CiAgICAg ICAgIAogICAgICAgICBtX3JlcXVlc3RpbmdTY3JpcHQgPSBmYWxzZTsK