108459 2013-01-31 04:24:58 -0800 [WK2][Notifications] Missing early return in populateCopyOfNotificationPermissions 2013-02-11 11:55:05 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 csaavedra webkit-unassigned ap jonlee webkit.review.bot oldest_to_newest 821374 0 csaavedra 2013-01-31 04:24:58 -0800 [WK2][Notifications] Missing early return in populateCopyOfNotificationPermissions 821376 1 185746 csaavedra 2013-01-31 04:28:40 -0800 Created attachment 185746 Patch 821378 2 csaavedra 2013-01-31 04:30:26 -0800 Jon, could you please have a look at this? I found it while implementing a dummy provider for the GTK+ port. Thank you! 823032 3 185746 jonlee 2013-02-01 11:31:05 -0800 Comment on attachment 185746 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185746&action=review > Source/WebKit2/UIProcess/Notifications/WebNotificationManagerProxy.cpp:96 > + if (!knownPermissions) Wouldn't it be more appropriate to move this check before we clear out the permissions? If the client wishes to clear out the permissions, they should provide an empty dictionary instead. 827159 4 187019 csaavedra 2013-02-07 01:17:21 -0800 Created attachment 187019 Patch 827526 5 jonlee 2013-02-07 08:08:00 -0800 Unofficial r=me. 829613 6 csaavedra 2013-02-11 06:04:19 -0800 Who to ping to get this reviewed? 829946 7 jonlee 2013-02-11 11:33:31 -0800 Alexey, would you mind r+'ing the patch? It looks good to me. 829961 8 187019 webkit.review.bot 2013-02-11 11:55:01 -0800 Comment on attachment 187019 Patch Clearing flags on attachment: 187019 Committed r142493: <http://trac.webkit.org/changeset/142493> 829962 9 webkit.review.bot 2013-02-11 11:55:05 -0800 All reviewed patches have been landed. Closing bug. 185746 2013-01-31 04:28:40 -0800 2013-02-07 01:17:15 -0800 Patch bug-108459-20130131142523.patch text/plain 1843 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwOTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjI5MzM2MjNjODVkZDNh NzZkNWIyMGE4N2YwNzc5YTVhMGFmYzMwYS4uZjEyNDk2YWJmZTZiN2ZkM2YwNDA5ZTA5ZDY0NjU2 ZjQxMTUwZTM4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTMxICBDbGF1 ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dLMl1bTm90 aWZpY2F0aW9uc10gTWlzc2luZyBlYXJseSByZXR1cm4gaW4gcG9wdWxhdGVDb3B5T2ZOb3RpZmlj YXRpb25QZXJtaXNzaW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTA4NDU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvTm90aWZpY2F0aW9ucy9XZWJOb3RpZmljYXRpb25NYW5hZ2Vy UHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJOb3RpZmljYXRpb25NYW5hZ2VyUHJveHk6 OnBvcHVsYXRlQ29weU9mTm90aWZpY2F0aW9uUGVybWlzc2lvbnMpOgorICAgICAgICBQcm92aWRl cnMgbWlnaHQgcmV0dXJuIDAgYW5kIHdlIHdpbGwgZW5kIHVwIHdpdGggYSBudWxsLXBvaW50ZXIg ZGVyZWZlcmVuY2UuCisgICAgICAgIEVhcmx5IGNoZWNrIGFnYWluc3QgdGhpcy4KKwogMjAxMy0w MS0yOCAgUmVuYXRhIEhvZG92YW4gIDxyZW5pQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XVtX aW5dW1dLMl0gQnVpbGQgZml4IGFmdGVyIHIxNDA5NTcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvTm90aWZpY2F0aW9ucy9XZWJOb3RpZmljYXRpb25NYW5hZ2VyUHJveHku Y3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL05vdGlmaWNhdGlvbnMvV2ViTm90aWZpY2F0 aW9uTWFuYWdlclByb3h5LmNwcAppbmRleCA0MmU0NWNkMWEwZTYxYzExODdlNTIwYmZkYzZlODg1 YmY1NDY3ZWNiLi5jMWY5YmQ1N2M2MGI1NDg1ZDgyNjdmYWFhYjk1MmFkNjkyOWMyODJiIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTm90aWZpY2F0aW9ucy9XZWJOb3RpZmlj YXRpb25NYW5hZ2VyUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Ob3Rp ZmljYXRpb25zL1dlYk5vdGlmaWNhdGlvbk1hbmFnZXJQcm94eS5jcHAKQEAgLTkwLDcgKzkwLDEy IEBAIHZvaWQgV2ViTm90aWZpY2F0aW9uTWFuYWdlclByb3h5OjpkZXJlZldlYkNvbnRleHRTdXBw bGVtZW50KCkKIHZvaWQgV2ViTm90aWZpY2F0aW9uTWFuYWdlclByb3h5Ojpwb3B1bGF0ZUNvcHlP Zk5vdGlmaWNhdGlvblBlcm1pc3Npb25zKEhhc2hNYXA8U3RyaW5nLCBib29sPiYgcGVybWlzc2lv bnMpCiB7CiAgICAgUmVmUHRyPEltbXV0YWJsZURpY3Rpb25hcnk+IGtub3duUGVybWlzc2lvbnMg PSBtX3Byb3ZpZGVyLm5vdGlmaWNhdGlvblBlcm1pc3Npb25zKCk7CisKICAgICBwZXJtaXNzaW9u cy5jbGVhcigpOworCisgICAgaWYgKCFrbm93blBlcm1pc3Npb25zKQorICAgICAgICByZXR1cm47 CisKICAgICBSZWZQdHI8SW1tdXRhYmxlQXJyYXk+IGtub3duT3JpZ2lucyA9IGtub3duUGVybWlz c2lvbnMtPmtleXMoKTsKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGtub3duT3JpZ2lucy0+ c2l6ZSgpOyArK2kpIHsKICAgICAgICAgV2ViU3RyaW5nKiBvcmlnaW4gPSBrbm93bk9yaWdpbnMt PmF0PFdlYlN0cmluZz4oaSk7Cg== 187019 2013-02-07 01:17:21 -0800 2013-02-11 11:55:01 -0800 Patch bug-108459-20130207111356.patch text/plain 1780 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwOTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjI5MzM2MjNjODVkZDNh NzZkNWIyMGE4N2YwNzc5YTVhMGFmYzMwYS4uZjEyNDk2YWJmZTZiN2ZkM2YwNDA5ZTA5ZDY0NjU2 ZjQxMTUwZTM4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTMxICBDbGF1 ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dLMl1bTm90 aWZpY2F0aW9uc10gTWlzc2luZyBlYXJseSByZXR1cm4gaW4gcG9wdWxhdGVDb3B5T2ZOb3RpZmlj YXRpb25QZXJtaXNzaW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTA4NDU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvTm90aWZpY2F0aW9ucy9XZWJOb3RpZmljYXRpb25NYW5hZ2Vy UHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJOb3RpZmljYXRpb25NYW5hZ2VyUHJveHk6 OnBvcHVsYXRlQ29weU9mTm90aWZpY2F0aW9uUGVybWlzc2lvbnMpOgorICAgICAgICBQcm92aWRl cnMgbWlnaHQgcmV0dXJuIDAgYW5kIHdlIHdpbGwgZW5kIHVwIHdpdGggYSBudWxsLXBvaW50ZXIg ZGVyZWZlcmVuY2UuCisgICAgICAgIEVhcmx5IGNoZWNrIGFnYWluc3QgdGhpcy4KKwogMjAxMy0w MS0yOCAgUmVuYXRhIEhvZG92YW4gIDxyZW5pQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XVtX aW5dW1dLMl0gQnVpbGQgZml4IGFmdGVyIHIxNDA5NTcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvTm90aWZpY2F0aW9ucy9XZWJOb3RpZmljYXRpb25NYW5hZ2VyUHJveHku Y3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL05vdGlmaWNhdGlvbnMvV2ViTm90aWZpY2F0 aW9uTWFuYWdlclByb3h5LmNwcAppbmRleCA0MmU0NWNkMWEwZTYxYzExODdlNTIwYmZkYzZlODg1 YmY1NDY3ZWNiLi44MzdiMzYxZDZjMjU2NzI4NTlkZWMwNWEyYTFmY2I5NDc4YjI1YWJmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTm90aWZpY2F0aW9ucy9XZWJOb3RpZmlj YXRpb25NYW5hZ2VyUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Ob3Rp ZmljYXRpb25zL1dlYk5vdGlmaWNhdGlvbk1hbmFnZXJQcm94eS5jcHAKQEAgLTkwLDYgKzkwLDEw IEBAIHZvaWQgV2ViTm90aWZpY2F0aW9uTWFuYWdlclByb3h5OjpkZXJlZldlYkNvbnRleHRTdXBw bGVtZW50KCkKIHZvaWQgV2ViTm90aWZpY2F0aW9uTWFuYWdlclByb3h5Ojpwb3B1bGF0ZUNvcHlP Zk5vdGlmaWNhdGlvblBlcm1pc3Npb25zKEhhc2hNYXA8U3RyaW5nLCBib29sPiYgcGVybWlzc2lv bnMpCiB7CiAgICAgUmVmUHRyPEltbXV0YWJsZURpY3Rpb25hcnk+IGtub3duUGVybWlzc2lvbnMg PSBtX3Byb3ZpZGVyLm5vdGlmaWNhdGlvblBlcm1pc3Npb25zKCk7CisKKyAgICBpZiAoIWtub3du UGVybWlzc2lvbnMpCisgICAgICAgIHJldHVybjsKKwogICAgIHBlcm1pc3Npb25zLmNsZWFyKCk7 CiAgICAgUmVmUHRyPEltbXV0YWJsZUFycmF5PiBrbm93bk9yaWdpbnMgPSBrbm93blBlcm1pc3Np b25zLT5rZXlzKCk7CiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBrbm93bk9yaWdpbnMtPnNp emUoKTsgKytpKSB7Cg==