108456 2013-01-31 04:10:01 -0800 Web Inspector: Exception in HeapSnapshotView.js 2013-01-31 06:17:05 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 aandrey aandrey apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 821359 0 aandrey 2013-01-31 04:10:01 -0800 Patch to follow. Repro: - Go to Profiles panel and take a Heap Snapshot - Remove the snapshot profile header from the sidebar via context menu - Run another profile, e.g. Capture Canvas Frame - Observe the exception below: Uncaught TypeError: Cannot call method 'fromFile' of undefined InspectorBackend.js:186 InspectorBackendClass.dispatch InspectorBackend.js:186 InspectorFrontendAPI.dispatchMessage InspectorFrontendAPI.js:198 Stack trace: WebInspector.HeapSnapshotView._updateFilterOptions (HeapSnapshotView.js:724) WebInspector.Object.dispatchEventToListeners (Object.js:101) WebInspector.ProfilesPanel.addProfileHeader (ProfilesPanel.js:580) WebInspector.CanvasProfileType._didStartCapturingFrame (CanvasProfileView.js:496) InspectorBackendClass.dispatch (InspectorBackend.js:186) InspectorFrontendAPI.dispatchMessage (InspectorFrontendAPI.js:198) 821361 1 185742 aandrey 2013-01-31 04:11:17 -0800 Created attachment 185742 Patch 821366 2 185742 yurys 2013-01-31 04:15:32 -0800 Comment on attachment 185742 Patch We should check that the profile being added is a heap snapshot and ignore all other notifications. 821377 3 185747 aandrey 2013-01-31 04:28:46 -0800 Created attachment 185747 Patch 821380 4 185747 yurys 2013-01-31 04:34:36 -0800 Comment on attachment 185747 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185747&action=review > Source/WebCore/inspector/front-end/HeapSnapshotView.js:741 > + if (!event.data || event.data.type !== WebInspector.HeapSnapshotProfileType.TypeId) This one will not work for native snapshots with type WebInspector.NativeSnapshotProfileType.TypeId which reuses the same view so we should probably save profile type from the |profile| argument to HeapSnapshotView and compare with it here. 821411 5 185754 aandrey 2013-01-31 05:11:00 -0800 Created attachment 185754 Patch 821471 6 185754 webkit.review.bot 2013-01-31 06:17:02 -0800 Comment on attachment 185754 Patch Clearing flags on attachment: 185754 Committed r141415: <http://trac.webkit.org/changeset/141415> 821472 7 webkit.review.bot 2013-01-31 06:17:05 -0800 All reviewed patches have been landed. Closing bug. 185742 2013-01-31 04:11:17 -0800 2013-01-31 04:28:43 -0800 Patch bug-108456-20130131160801.patch text/plain 1869 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWM2Zjk5MjIzYjhlMWVj OWMzMTc3Y2NmY2JkZjMzN2Q3MTRmMmM3ZC4uMzQ1NWVjZTEzNTRmZmM1ZDIzZjU5NzUwNjBjODM5 MjczYzhjMzc2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTMxICBBbmRy ZXkgQWRhaWtpbiAgPGFhbmRyZXlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEV4Y2VwdGlvbiBpbiBIZWFwU25hcHNob3RWaWV3LmpzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg0NTYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhpbmcgZXhjZXB0aW9uIGluIEhlYXBTbmFw c2hvdFZpZXcuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdFZp ZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90Vmlldy5wcm90b3R5cGUu X3VwZGF0ZUJhc2VPcHRpb25zKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RW aWV3LnByb3RvdHlwZS5fdXBkYXRlRmlsdGVyT3B0aW9ucyk6CisKIDIwMTMtMDEtMzAgIFBhdmVs IEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogbWlncmF0ZSBmaWxlIHNlbGVjdGlvbiBkaWFsb2cgdG8gdGhlIHZpZXdwb3J0LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3RWaWV3 LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3RWaWV3 LmpzCmluZGV4IDE0ZGFkMWE4MDFkYjJlNzBiNGUwNzlmN2I2YzhiOWY1ZDZlOWVjNWEuLmI1MzQz ZjI4ZmI0ZmQwZGU3YzJlM2IyZGE0Mzg2NmExNjE5YzE4MzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90Vmlldy5qcworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdFZpZXcuanMKQEAgLTY5 MCw2ICs2OTAsOCBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90Vmlldy5wcm90b3R5cGUgPSB7 CiAgICAgX3VwZGF0ZUJhc2VPcHRpb25zOiBmdW5jdGlvbigpCiAgICAgewogICAgICAgICB2YXIg bGlzdCA9IHRoaXMuX3Byb2ZpbGVzKCk7CisgICAgICAgIGlmICghbGlzdC5sZW5ndGgpCisgICAg ICAgICAgICByZXR1cm47CiAgICAgICAgIC8vIFdlJ3JlIGFzc3VtaW5nIHRoYXQgc25hcHNob3Rz IGNhbiBvbmx5IGJlIGFkZGVkLgogICAgICAgICBpZiAodGhpcy5iYXNlU2VsZWN0RWxlbWVudC5s ZW5ndGggPT09IGxpc3QubGVuZ3RoKQogICAgICAgICAgICAgcmV0dXJuOwpAQCAtNzA3LDYgKzcw OSw4IEBAIFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RWaWV3LnByb3RvdHlwZSA9IHsKICAgICBf dXBkYXRlRmlsdGVyT3B0aW9uczogZnVuY3Rpb24oKQogICAgIHsKICAgICAgICAgdmFyIGxpc3Qg PSB0aGlzLl9wcm9maWxlcygpOworICAgICAgICBpZiAoIWxpc3QubGVuZ3RoKQorICAgICAgICAg ICAgcmV0dXJuOwogICAgICAgICAvLyBXZSdyZSBhc3N1bWluZyB0aGF0IHNuYXBzaG90cyBjYW4g b25seSBiZSBhZGRlZC4KICAgICAgICAgaWYgKHRoaXMuZmlsdGVyU2VsZWN0RWxlbWVudC5sZW5n dGggLSAxID09PSBsaXN0Lmxlbmd0aCkKICAgICAgICAgICAgIHJldHVybjsK 185747 2013-01-31 04:28:46 -0800 2013-01-31 05:10:57 -0800 Patch bug-108456-20130131162530.patch text/plain 2155 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWM2Zjk5MjIzYjhlMWVj OWMzMTc3Y2NmY2JkZjMzN2Q3MTRmMmM3ZC4uYzc1ZTcxNzUzZDFmYTAyYmFmOGYwNzllOTI0M2Ez YWZkOGVlNjgxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTMxICBBbmRy ZXkgQWRhaWtpbiAgPGFhbmRyZXlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEV4Y2VwdGlvbiBpbiBIZWFwU25hcHNob3RWaWV3LmpzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg0NTYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMaXN0ZW4gInByb2ZpbGUgYWRkZWQiIGV2ZW50 cyBpbiB0aGUgSGVhcFNuYXBzaG90VmlldyB0YXJnZXRlZCBvbmx5IHRvIHRoZSBIZWFwIFNuYXBz aG90IHR5cGUuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdFZp ZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90Vmlldy5wcm90b3R5cGUu X29uUHJvZmlsZUhlYWRlckFkZGVkKToKKwogMjAxMy0wMS0zMCAgUGF2ZWwgRmVsZG1hbiAgPHBm ZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBtaWdyYXRlIGZp bGUgc2VsZWN0aW9uIGRpYWxvZyB0byB0aGUgdmlld3BvcnQuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdFZpZXcuanMgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdFZpZXcuanMKaW5kZXggMTRk YWQxYTgwMWRiMmU3MGI0ZTA3OWY3YjZjOGI5ZjVkNmU5ZWM1YS4uMWY0ODkyZTgzZDQ2MTRmODU1 NGU4NWM2ZWVlMWZiODY0MDlhNDhiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3RWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90Vmlldy5qcwpAQCAtNDAsOCArNDAsNyBAQCBX ZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90VmlldyA9IGZ1bmN0aW9uKHBhcmVudCwgcHJvZmlsZSkK ICAgICB0aGlzLmVsZW1lbnQuYWRkU3R5bGVDbGFzcygiaGVhcC1zbmFwc2hvdC12aWV3Iik7CiAK ICAgICB0aGlzLnBhcmVudCA9IHBhcmVudDsKLSAgICB0aGlzLnBhcmVudC5hZGRFdmVudExpc3Rl bmVyKCJwcm9maWxlIGFkZGVkIiwgdGhpcy5fdXBkYXRlQmFzZU9wdGlvbnMsIHRoaXMpOwotICAg IHRoaXMucGFyZW50LmFkZEV2ZW50TGlzdGVuZXIoInByb2ZpbGUgYWRkZWQiLCB0aGlzLl91cGRh dGVGaWx0ZXJPcHRpb25zLCB0aGlzKTsKKyAgICB0aGlzLnBhcmVudC5hZGRFdmVudExpc3RlbmVy KCJwcm9maWxlIGFkZGVkIiwgdGhpcy5fb25Qcm9maWxlSGVhZGVyQWRkZWQsIHRoaXMpOwogCiAg ICAgdGhpcy52aWV3c0NvbnRhaW5lciA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwog ICAgIHRoaXMudmlld3NDb250YWluZXIuYWRkU3R5bGVDbGFzcygidmlld3MtY29udGFpbmVyIik7 CkBAIC03MzQsNiArNzMzLDE3IEBAIFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RWaWV3LnByb3Rv dHlwZSA9IHsKICAgICAgICAgfQogICAgIH0sCiAKKyAgICAvKioKKyAgICAgKiBAcGFyYW0ge1dl Ykluc3BlY3Rvci5FdmVudH0gZXZlbnQKKyAgICAgKi8KKyAgICBfb25Qcm9maWxlSGVhZGVyQWRk ZWQ6IGZ1bmN0aW9uKGV2ZW50KQorICAgIHsKKyAgICAgICAgaWYgKCFldmVudC5kYXRhIHx8IGV2 ZW50LmRhdGEudHlwZSAhPT0gV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdFByb2ZpbGVUeXBlLlR5 cGVJZCkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgdGhpcy5fdXBkYXRlQmFzZU9wdGlv bnMoKTsKKyAgICAgICAgdGhpcy5fdXBkYXRlRmlsdGVyT3B0aW9ucygpOworICAgIH0sCisKICAg ICBfX3Byb3RvX186IFdlYkluc3BlY3Rvci5WaWV3LnByb3RvdHlwZQogfQogCg== 185754 2013-01-31 05:11:00 -0800 2013-01-31 06:17:01 -0800 Patch bug-108456-20130131170744.patch text/plain 2667 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWM2Zjk5MjIzYjhlMWVj OWMzMTc3Y2NmY2JkZjMzN2Q3MTRmMmM3ZC4uYzc1ZTcxNzUzZDFmYTAyYmFmOGYwNzllOTI0M2Ez YWZkOGVlNjgxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTMxICBBbmRy ZXkgQWRhaWtpbiAgPGFhbmRyZXlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEV4Y2VwdGlvbiBpbiBIZWFwU25hcHNob3RWaWV3LmpzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg0NTYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMaXN0ZW4gInByb2ZpbGUgYWRkZWQiIGV2ZW50 cyBpbiB0aGUgSGVhcFNuYXBzaG90VmlldyB0YXJnZXRlZCBvbmx5IHRvIHRoZSBIZWFwIFNuYXBz aG90IHR5cGUuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdFZp ZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90Vmlldy5wcm90b3R5cGUu X29uUHJvZmlsZUhlYWRlckFkZGVkKToKKwogMjAxMy0wMS0zMCAgUGF2ZWwgRmVsZG1hbiAgPHBm ZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBtaWdyYXRlIGZp bGUgc2VsZWN0aW9uIGRpYWxvZyB0byB0aGUgdmlld3BvcnQuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdFZpZXcuanMgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdFZpZXcuanMKaW5kZXggMTRk YWQxYTgwMWRiMmU3MGI0ZTA3OWY3YjZjOGI5ZjVkNmU5ZWM1YS4uYmEwYjk0ZjJjM2ZhZjRhMTNl ZmVlYzIyNjYxNDY0NjFkNWQ4ZTBjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3RWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90Vmlldy5qcwpAQCAtMzIsNiArMzIsNyBAQAog ICogQGNvbnN0cnVjdG9yCiAgKiBAZXh0ZW5kcyB7V2ViSW5zcGVjdG9yLlZpZXd9CiAgKiBAcGFy YW0ge1dlYkluc3BlY3Rvci5Qcm9maWxlc1BhbmVsfSBwYXJlbnQKKyAqIEBwYXJhbSB7V2ViSW5z cGVjdG9yLkhlYXBQcm9maWxlSGVhZGVyfSBwcm9maWxlCiAgKi8KIFdlYkluc3BlY3Rvci5IZWFw U25hcHNob3RWaWV3ID0gZnVuY3Rpb24ocGFyZW50LCBwcm9maWxlKQogewpAQCAtNDAsOCArNDEs NyBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90VmlldyA9IGZ1bmN0aW9uKHBhcmVudCwgcHJv ZmlsZSkKICAgICB0aGlzLmVsZW1lbnQuYWRkU3R5bGVDbGFzcygiaGVhcC1zbmFwc2hvdC12aWV3 Iik7CiAKICAgICB0aGlzLnBhcmVudCA9IHBhcmVudDsKLSAgICB0aGlzLnBhcmVudC5hZGRFdmVu dExpc3RlbmVyKCJwcm9maWxlIGFkZGVkIiwgdGhpcy5fdXBkYXRlQmFzZU9wdGlvbnMsIHRoaXMp OwotICAgIHRoaXMucGFyZW50LmFkZEV2ZW50TGlzdGVuZXIoInByb2ZpbGUgYWRkZWQiLCB0aGlz Ll91cGRhdGVGaWx0ZXJPcHRpb25zLCB0aGlzKTsKKyAgICB0aGlzLnBhcmVudC5hZGRFdmVudExp c3RlbmVyKCJwcm9maWxlIGFkZGVkIiwgdGhpcy5fb25Qcm9maWxlSGVhZGVyQWRkZWQsIHRoaXMp OwogCiAgICAgdGhpcy52aWV3c0NvbnRhaW5lciA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRp diIpOwogICAgIHRoaXMudmlld3NDb250YWluZXIuYWRkU3R5bGVDbGFzcygidmlld3MtY29udGFp bmVyIik7CkBAIC0xMjAsNiArMTIwLDcgQEAgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdFZpZXcg PSBmdW5jdGlvbihwYXJlbnQsIHByb2ZpbGUpCiAgICAgfQogCiAgICAgdGhpcy5fcHJvZmlsZVVp ZCA9IHByb2ZpbGUudWlkOworICAgIHRoaXMuX3Byb2ZpbGVUeXBlSWQgPSBwcm9maWxlLnByb2Zp bGVUeXBlKCkuaWQ7CiAKICAgICB0aGlzLmJhc2VTZWxlY3RFbGVtZW50ID0gZG9jdW1lbnQuY3Jl YXRlRWxlbWVudCgic2VsZWN0Iik7CiAgICAgdGhpcy5iYXNlU2VsZWN0RWxlbWVudC5jbGFzc05h bWUgPSAic3RhdHVzLWJhci1pdGVtIjsKQEAgLTczNCw2ICs3MzUsMTcgQEAgV2ViSW5zcGVjdG9y LkhlYXBTbmFwc2hvdFZpZXcucHJvdG90eXBlID0gewogICAgICAgICB9CiAgICAgfSwKIAorICAg IC8qKgorICAgICAqIEBwYXJhbSB7V2ViSW5zcGVjdG9yLkV2ZW50fSBldmVudAorICAgICAqLwor ICAgIF9vblByb2ZpbGVIZWFkZXJBZGRlZDogZnVuY3Rpb24oZXZlbnQpCisgICAgeworICAgICAg ICBpZiAoIWV2ZW50LmRhdGEgfHwgZXZlbnQuZGF0YS50eXBlICE9PSB0aGlzLl9wcm9maWxlVHlw ZUlkKQorICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB0aGlzLl91cGRhdGVCYXNlT3B0aW9u cygpOworICAgICAgICB0aGlzLl91cGRhdGVGaWx0ZXJPcHRpb25zKCk7CisgICAgfSwKKwogICAg IF9fcHJvdG9fXzogV2ViSW5zcGVjdG9yLlZpZXcucHJvdG90eXBlCiB9CiAK